From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vaibhav Hiremath Subject: [PATCH 2/4] mfd: 88pm800: use irq_mode to configure interrupt status reg clear method Date: Sat, 30 May 2015 03:49:20 +0530 Message-ID: <1432937962-4537-3-git-send-email-vaibhav.hiremath@linaro.org> References: <1432937962-4537-1-git-send-email-vaibhav.hiremath@linaro.org> Return-path: In-Reply-To: <1432937962-4537-1-git-send-email-vaibhav.hiremath@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: linux-arm-kernel@lists.infradead.org Cc: robh+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, sameo@linux.intel.com, lee.jones@linaro.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, Vaibhav Hiremath , zhaoy List-Id: devicetree@vger.kernel.org >>From the spec, bit 1 of reg 0xe (page 0): IN_CLEAR_MODE controls the method of clearing interrupt status register of 88pm800; 0: clear on read 1: clear on write Signed-off-by: zhaoy Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c | 4 +++- include/linux/mfd/88pm80x.h | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c index 06ee058..8ea4467 100644 --- a/drivers/mfd/88pm800.c +++ b/drivers/mfd/88pm800.c @@ -391,7 +391,8 @@ static int device_irq_init_800(struct pm80x_chip *chip) PM800_WAKEUP2_INV_INT | PM800_WAKEUP2_INT_CLEAR | PM800_WAKEUP2_INT_MASK; - data = PM800_WAKEUP2_INT_CLEAR; + data = (chip->irq_mode) ? + PM800_WAKEUP2_INT_WRITE_CLEAR : PM800_WAKEUP2_INT_READ_CLEAR; ret = regmap_update_bits(map, PM800_WAKEUP2, mask, data); if (ret < 0) @@ -514,6 +515,7 @@ static int device_800_init(struct pm80x_chip *chip, } chip->regmap_irq_chip = &pm800_irq_chip; + chip->irq_mode = pdata->irq_mode; ret = device_irq_init_800(chip); if (ret < 0) { diff --git a/include/linux/mfd/88pm80x.h b/include/linux/mfd/88pm80x.h index 97cb283..6ed6c16 100644 --- a/include/linux/mfd/88pm80x.h +++ b/include/linux/mfd/88pm80x.h @@ -77,6 +77,8 @@ enum { #define PM800_WAKEUP2 (0x0E) #define PM800_WAKEUP2_INV_INT (1 << 0) #define PM800_WAKEUP2_INT_CLEAR (1 << 1) +#define PM800_WAKEUP2_INT_READ_CLEAR (0 << 1) +#define PM800_WAKEUP2_INT_WRITE_CLEAR (1 << 1) #define PM800_WAKEUP2_INT_MASK (1 << 2) #define PM800_POWER_UP_LOG (0x10) -- 1.9.1