From: Bastien Nocera <hadess@hadess.net>
To: Irina Tirdea <irina.tirdea@intel.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Octavian Purdila <octavian.purdila@intel.com>
Subject: Re: [PATCH v2 4/8] input: goodix: reset device at init
Date: Tue, 09 Jun 2015 17:53:02 +0200 [thread overview]
Message-ID: <1433865182.5707.7.camel@hadess.net> (raw)
In-Reply-To: <1433864084.5707.4.camel@hadess.net>
On Tue, 2015-06-09 at 17:34 +0200, Bastien Nocera wrote:
> On Mon, 2015-06-08 at 17:37 +0300, Irina Tirdea wrote:
> > After power on, it is recommended that the driver resets the
> > device.
> > The reset procedure timing is described in the datasheet and is
> > used
> > at device init (before writing device configuration) and
> > for power management. It is a sequence of setting the interrupt
> > and reset pins high/low at specific timing intervals. This
> > procedure
> > also includes setting the slave address to the one specified in the
> > ACPI/device tree.
>
> This breaks the touchscreen on my Onda v975w:
> [ 239.732858] Goodix-TS i2c-GDIX1001:00: ID 9271, version: 1020
> [ 239.732977] Goodix-TS i2c-GDIX1001:00: Failed to get reset GPIO:
> -16
> [ 239.736071] Goodix-TS: probe of i2c-GDIX1001:00 failed with error
> -16
>
> This is the DSDT for that device:
> https://bugzilla.kernel.org/attachment.cgi?id=149331
(Note that this means that I haven't been able to test any following
patches in that series than 4/8).
next prev parent reply other threads:[~2015-06-09 15:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 14:37 [PATCH v2 0/8] Goodix touchscreen enhancements Irina Tirdea
[not found] ` <1433774273-23103-1-git-send-email-irina.tirdea-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-06-08 14:37 ` [PATCH v2 1/8] input: goodix: fix alignment issues Irina Tirdea
2015-06-08 14:37 ` [PATCH v2 4/8] input: goodix: reset device at init Irina Tirdea
2015-06-09 15:34 ` Bastien Nocera
2015-06-09 15:53 ` Bastien Nocera [this message]
2015-06-23 13:23 ` Tirdea, Irina
2015-06-23 14:12 ` Bastien Nocera
2015-06-23 14:50 ` Octavian Purdila
2015-06-29 16:04 ` Tirdea, Irina
2015-06-09 17:57 ` Dmitry Torokhov
2015-06-23 13:20 ` Tirdea, Irina
2015-06-08 14:37 ` [PATCH v2 6/8] input: goodix: add power management support Irina Tirdea
2015-06-09 18:15 ` Dmitry Torokhov
2015-06-23 13:28 ` Tirdea, Irina
2015-06-08 14:37 ` [PATCH v2 2/8] input: goodix: fix variable length array warning Irina Tirdea
2015-06-09 15:35 ` Bastien Nocera
2015-06-08 14:37 ` [PATCH v2 3/8] input: goodix: export id and version read from device Irina Tirdea
2015-06-09 15:36 ` Bastien Nocera
2015-06-08 14:37 ` [PATCH v2 5/8] input: goodix: write configuration data to device Irina Tirdea
[not found] ` <1433774273-23103-6-git-send-email-irina.tirdea-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-06-09 18:14 ` Dmitry Torokhov
2015-06-23 13:27 ` Tirdea, Irina
[not found] ` <1F3AC3675D538145B1661F571FE1805F2F06166E-pww93C2UFcwu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-06-23 18:59 ` Dmitry Torokhov
2015-06-29 16:01 ` Tirdea, Irina
2015-06-08 14:37 ` [PATCH v2 7/8] input: goodix: use goodix_i2c_write_u8 instead of i2c_master_send Irina Tirdea
2015-06-08 14:37 ` [PATCH v2 8/8] input: goodix: add support for ESD Irina Tirdea
2015-06-09 18:17 ` [PATCH v2 0/8] Goodix touchscreen enhancements Dmitry Torokhov
2015-06-23 13:18 ` Tirdea, Irina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433865182.5707.7.camel@hadess.net \
--to=hadess@hadess.net \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=irina.tirdea@intel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=octavian.purdila@intel.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).