From: Johan Hovold <johan@kernel.org>
To: Tony Lindgren <tony@atomide.com>
Cc: "Matthijs van Duin" <matthijsvanduin@gmail.com>,
robertcnelson@gmail.com, "Felipe Balbi" <balbi@ti.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Johan Hovold" <johan@kernel.org>
Subject: [PATCH] Revert "ARM: dts: am335x-boneblack: disable RTC-only sleep"
Date: Thu, 11 Jun 2015 16:18:38 +0200 [thread overview]
Message-ID: <1434032318-3557-1-git-send-email-johan@kernel.org> (raw)
In-Reply-To: <20150601200137.GC30984@atomide.com>
This reverts commit 3d76be5b933e2a66d85a2f7444e68e99e8a48ad4.
The latest revision of Beaglebone Black does not support RTC-only mode.
To avoid potential hardware damage, RTC-only mode was disabled by
default by commit 7a6cb0abe1aa ("ARM: dts: am335x-boneblack: disable
RTC-only sleep to avoid hardware damage").
Unfortunately, an incorrect fix had already been applied, which instead
of just disabling RTC-only mode, prevents the Beaglebone from powering
down at all.
Revert this patch to fix the power-off regression.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
The offending patch was incorrectly applied after Matthijs initial fix
was posted and before the final fix (which only added some comments) was
applied.
Note that the final version of the fix 7a6cb0abe1aa ("ARM: dts:
am335x-boneblack: disable RTC-only sleep to avoid hardware damage")
indicates that it should be backported to 3.12 even though RTC-only mode
was first enabled in 3.19.
Johan
arch/arm/boot/dts/am335x-boneblack.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/am335x-boneblack.dts b/arch/arm/boot/dts/am335x-boneblack.dts
index 901739fcb85a..5c42d259fa68 100644
--- a/arch/arm/boot/dts/am335x-boneblack.dts
+++ b/arch/arm/boot/dts/am335x-boneblack.dts
@@ -80,3 +80,7 @@
status = "okay";
};
};
+
+&rtc {
+ system-power-controller;
+};
--
2.3.6
next prev parent reply other threads:[~2015-06-11 14:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 15:38 [PATCH] ARM: dts: am335x-boneblack: disable RTC-only sleep Robert Nelson
2015-05-20 16:47 ` Tony Lindgren
2015-06-01 0:20 ` Matthijs van Duin
2015-06-01 2:18 ` Robert Nelson
2015-06-01 5:14 ` Matthijs van Duin
2015-06-01 17:23 ` Tony Lindgren
2015-06-01 19:33 ` Matthijs van Duin
[not found] ` <20150601193328.GA27640-2pNSKKP3PSK44ywRPIzf9A@public.gmane.org>
2015-06-01 20:01 ` Tony Lindgren
2015-06-11 14:18 ` Johan Hovold [this message]
[not found] ` <1434032318-3557-1-git-send-email-johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-07-06 12:16 ` [PATCH] Revert "ARM: dts: am335x-boneblack: disable RTC-only sleep" Tony Lindgren
2015-06-01 17:12 ` [PATCH] ARM: dts: am335x-boneblack: disable RTC-only sleep Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434032318-3557-1-git-send-email-johan@kernel.org \
--to=johan@kernel.org \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=matthijsvanduin@gmail.com \
--cc=robertcnelson@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).