devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Yuantian.Tang@freescale.com
Cc: b07421@freescale.com, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Chenhui Zhao <chenhui.zhao@freescale.com>
Subject: Re: [PATCH v2] powerpc/rcpm: add RCPM driver
Date: Fri, 12 Jun 2015 10:57:42 +0200	[thread overview]
Message-ID: <1434099462.2271.149.camel@x220> (raw)
In-Reply-To: <1434004357-2294-1-git-send-email-Yuantian.Tang@freescale.com>

Just a nit.

On Thu, 2015-06-11 at 14:32 +0800, Yuantian.Tang@freescale.com wrote:
> --- /dev/null
> +++ b/arch/powerpc/sysdev/fsl_rcpm.c

> +int fsl_rcpm_init(void)

This is used only through early_initcall(). I took the cargo cult
approach of looking at the other uses of early_initcall() in
arch/powerpc/. That approach tells me this function could be static and
marked as __init. Would that work here too?

> +{
> +	[...]
> +}
> +
> +/* need to call this before SMP init */
> +early_initcall(fsl_rcpm_init);

Thanks,

Paul Bolle

  reply	other threads:[~2015-06-12  8:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-11  6:32 [PATCH v2] powerpc/rcpm: add RCPM driver Yuantian.Tang
2015-06-12  8:57 ` Paul Bolle [this message]
2015-06-12  9:10   ` Yuantian Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434099462.2271.149.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=Yuantian.Tang@freescale.com \
    --cc=b07421@freescale.com \
    --cc=chenhui.zhao@freescale.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).