From mboxrd@z Thu Jan 1 00:00:00 1970 From: Koro Chen Subject: Re: [PATCH 2/3] ASoC: mediatek: Add machine driver for MAX98090 codec Date: Mon, 15 Jun 2015 10:31:45 +0800 Message-ID: <1434335505.14980.13.camel@mtksdaap41> References: <1433946276-25969-1-git-send-email-koro.chen@mediatek.com> <1433946276-25969-3-git-send-email-koro.chen@mediatek.com> <20150612131325.GA1921@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150612131325.GA1921-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, perex-/Fr2/VpizcU@public.gmane.org, tiwai-l3A5Bk7waGM@public.gmane.org, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, 2015-06-12 at 14:13 +0100, Mark Brown wrote: > On Wed, Jun 10, 2015 at 10:24:35PM +0800, Koro Chen wrote: > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/mt8173-max98090.txt > > @@ -0,0 +1,17 @@ > > +MT8173 with MAX98090 CODEC > > + > > +Required properties: > > +- compatible : "mediatek,mt8173-max98090" > > +- mediatek,audio-codec: the phandle of the MAX98090 audio codec > > +- dvdd-supply : the phandle of regulator to supply 1.2V > > +- avdd-supply : the phandle of regulator to supply 1.8V > > Why are these supplies part of the machine driver? > These are for the codec as you said. I think I should remove all these supplies as well as codes in machine drivers, since now the regulators are configured during the board's bootloader stage. > > +config SND_SOC_MT8173_MAX98090 > > + bool "ASoC Audio driver for MT8173 with MAX98090 codec" > > Why bool? > This should be tristate as Paul mentioned before. I will fix it. > > + codec_node = of_parse_phandle(pdev->dev.of_node, > > + "mediatek,audio-codec", 0); > > + if (!codec_node) { > > + dev_err(&pdev->dev, > > + "Property 'audio-codec' missing or invalid\n"); > > + } else { > > Isn't this a fatal error? > Thank you and yes it should be fatal, I will fix it. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html