devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Li Jun <jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
	balbi-l0cyMroinI0@public.gmane.org,
	peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	macpaul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	rogerq-l0cyMroinI0@public.gmane.org,
	Li Jun <jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Subject: [PATCH v4 09/23] usb: chipidea: update ci_otg_is_fsm_mode conditions
Date: Wed, 17 Jun 2015 13:43:41 +0800	[thread overview]
Message-ID: <1434519835-27745-10-git-send-email-jun.li@freescale.com> (raw)
In-Reply-To: <1434519835-27745-1-git-send-email-jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

After introduce usb otg properties, update ci_otg_is_fsm_mode conditions
to be depending on both usb hardware properties and usb driver config,
also resolve a compile issue in debug.c after the API change.

Signed-off-by: Li Jun <jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
 drivers/usb/chipidea/ci.h    | 5 ++++-
 drivers/usb/chipidea/debug.c | 1 +
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/chipidea/ci.h b/drivers/usb/chipidea/ci.h
index 6d6200e..f243f0b 100644
--- a/drivers/usb/chipidea/ci.h
+++ b/drivers/usb/chipidea/ci.h
@@ -406,8 +406,11 @@ static inline u32 hw_test_and_write(struct ci_hdrc *ci, enum ci_hw_regs reg,
 static inline bool ci_otg_is_fsm_mode(struct ci_hdrc *ci)
 {
 #ifdef CONFIG_USB_OTG_FSM
+	struct usb_otg_caps *otg_caps = &ci->platdata->ci_otg_caps;
+
 	return ci->is_otg && ci->roles[CI_ROLE_HOST] &&
-					ci->roles[CI_ROLE_GADGET];
+		ci->roles[CI_ROLE_GADGET] && (otg_caps->srp_support ||
+		otg_caps->hnp_support || otg_caps->adp_support);
 #else
 	return false;
 #endif
diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c
index 5b7061a..3869c6d 100644
--- a/drivers/usb/chipidea/debug.c
+++ b/drivers/usb/chipidea/debug.c
@@ -10,6 +10,7 @@
 #include <linux/usb/phy.h>
 #include <linux/usb/otg.h>
 #include <linux/usb/otg-fsm.h>
+#include <linux/usb/chipidea.h>
 
 #include "ci.h"
 #include "udc.h"
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-06-17  5:43 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-17  5:43 [PATCH v4 00/23] usb gadget update for OTG 2.0 Li Jun
     [not found] ` <1434519835-27745-1-git-send-email-jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-06-17  5:43   ` [PATCH v4 01/23] usb: add usb_otg20_descriptor for OTG 2.0 and above Li Jun
2015-06-17  5:43   ` [PATCH v4 02/23] usb: add USB_OTG_ADP definition Li Jun
2015-06-17  5:43   ` [PATCH v4 03/23] usb: otg: add usb_otg_caps structure for otg capabilities Li Jun
     [not found]     ` <1434519835-27745-4-git-send-email-jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-06-17  8:25       ` Roger Quadros
2015-06-17  5:43   ` [PATCH v4 04/23] usb: add usb_otg_caps to usb_gadget structure Li Jun
     [not found]     ` <1434519835-27745-5-git-send-email-jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-06-17  8:29       ` Roger Quadros
2015-06-17  8:50         ` Li Jun
2015-06-17  8:53         ` Roger Quadros
2015-06-17  5:43   ` [PATCH v4 05/23] usb: gadget: composite: add USB_DT_OTG request handling Li Jun
2015-06-17  5:43   ` [PATCH v4 06/23] doc: dt-binding: usb: add otg related properties Li Jun
     [not found]     ` <1434519835-27745-7-git-send-email-jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-06-17  8:30       ` Roger Quadros
2015-06-17  5:43   ` [PATCH v4 07/23] usb: common: add API to get usb otg features from device tree Li Jun
     [not found]     ` <1434519835-27745-8-git-send-email-jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-06-17  8:45       ` Roger Quadros
2015-06-17  9:19         ` Li Jun
2015-06-17  5:43   ` [PATCH v4 08/23] usb: chipidea: set usb gadeget's otg capabilities Li Jun
2015-06-17  5:43   ` Li Jun [this message]
2015-06-17  5:43   ` [PATCH v4 10/23] usb: gadget: add usb otg descriptor allocate and init interface Li Jun
     [not found]     ` <1434519835-27745-11-git-send-email-jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-06-17  8:51       ` Roger Quadros
2015-06-17  5:43   ` [PATCH v4 11/23] usb: gadget: configfs: allocate and init otg descriptor by otg capabilities Li Jun
     [not found]     ` <1434519835-27745-12-git-send-email-jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-06-17  9:01       ` Roger Quadros
2015-06-17  5:43   ` [PATCH v4 12/23] usb: gadget: ether: " Li Jun
     [not found]     ` <1434519835-27745-13-git-send-email-jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-06-17  9:03       ` Roger Quadros
2015-06-17  9:53         ` Li Jun
2015-06-17  5:43   ` [PATCH v4 13/23] usb: gadget: acm_ms: " Li Jun
     [not found]     ` <1434519835-27745-14-git-send-email-jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-06-17  9:11       ` Roger Quadros
2015-06-17  5:43   ` [PATCH v4 14/23] usb: gadget: audio: " Li Jun
2015-06-17  5:43   ` [PATCH v4 15/23] usb: gadget: cdc2: " Li Jun
2015-06-17  5:43   ` [PATCH v4 16/23] usb: gadget: g_ffs: " Li Jun
2015-06-17  5:43   ` [PATCH v4 17/23] usb: gadget: hid: " Li Jun
2015-06-17  5:43   ` [PATCH v4 18/23] usb: gadget: mass_storage: " Li Jun
2015-06-17  5:43   ` [PATCH v4 19/23] usb: gadget: multi: " Li Jun
2015-06-17  5:43   ` [PATCH v4 20/23] usb: gadget: ncm: " Li Jun
2015-06-17  5:43   ` [PATCH v4 21/23] usb: gadget: printer: " Li Jun
2015-06-17  5:43   ` [PATCH v4 22/23] usb: gadget: serial: " Li Jun
2015-06-17  5:43   ` [PATCH v4 23/23] usb: gadget: zero: " Li Jun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434519835-27745-10-git-send-email-jun.li@freescale.com \
    --to=jun.li-kzfg59tc24xl57midrcfdg@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=macpaul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
    --cc=peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=rogerq-l0cyMroinI0@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).