devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Li Jun <jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
	balbi-l0cyMroinI0@public.gmane.org,
	peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	macpaul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	rogerq-l0cyMroinI0@public.gmane.org,
	Li Jun <jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Subject: [PATCH v4 11/23] usb: gadget: configfs: allocate and init otg descriptor by otg capabilities
Date: Wed, 17 Jun 2015 13:43:43 +0800	[thread overview]
Message-ID: <1434519835-27745-12-git-send-email-jun.li@freescale.com> (raw)
In-Reply-To: <1434519835-27745-1-git-send-email-jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

Allocate and initialize usb otg descriptor according to gadget otg
capabilities, add it for each usb configurations, free it while
composite unbind. If otg capability is not defined, keep its otg
descriptor unchanged.

Signed-off-by: Li Jun <jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
 drivers/usb/gadget/configfs.c | 29 ++++++++++++++++++++---------
 1 file changed, 20 insertions(+), 9 deletions(-)

diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
index 0495c94..c7b62ef 100644
--- a/drivers/usb/gadget/configfs.c
+++ b/drivers/usb/gadget/configfs.c
@@ -41,6 +41,8 @@ int check_user_usb_string(const char *name,
 #define MAX_NAME_LEN	40
 #define MAX_USB_STRING_LANGS 2
 
+static const struct usb_descriptor_header *otg_desc[2];
+
 struct gadget_info {
 	struct config_group group;
 	struct config_group functions_group;
@@ -55,9 +57,6 @@ struct gadget_info {
 	struct list_head available_func;
 
 	const char *udc_name;
-#ifdef CONFIG_USB_OTG
-	struct usb_otg_descriptor otg;
-#endif
 	struct usb_composite_driver composite;
 	struct usb_composite_dev cdev;
 	bool use_os_desc;
@@ -1376,6 +1375,19 @@ static int configfs_composite_bind(struct usb_gadget *gadget,
 		memcpy(cdev->qw_sign, gi->qw_sign, OS_STRING_QW_SIGN_LEN);
 	}
 
+	if (gadget_is_otg(gadget) && !otg_desc[0]) {
+		struct usb_descriptor_header *usb_desc;
+
+		usb_desc = usb_otg_descriptor_alloc(gadget);
+		if (!usb_desc) {
+			ret = -ENOMEM;
+			goto err_comp_cleanup;
+		}
+		usb_otg_descriptor_init(gadget, usb_desc);
+		otg_desc[0] = usb_desc;
+		otg_desc[1] = NULL;
+	}
+
 	/* Go through all configs, attach all functions */
 	list_for_each_entry(c, &gi->cdev.configs, list) {
 		struct config_usb_cfg *cfg;
@@ -1383,6 +1395,9 @@ static int configfs_composite_bind(struct usb_gadget *gadget,
 		struct usb_function *tmp;
 		struct gadget_config_name *cn;
 
+		if (gadget_is_otg(gadget))
+			c->descriptors = otg_desc;
+
 		cfg = container_of(c, struct config_usb_cfg, c);
 		if (!list_empty(&cfg->string_list)) {
 			i = 0;
@@ -1437,6 +1452,8 @@ static void configfs_composite_unbind(struct usb_gadget *gadget)
 	cdev = get_gadget_data(gadget);
 	gi = container_of(cdev, struct gadget_info, cdev);
 
+	kfree(otg_desc[0]);
+	otg_desc[0] = NULL;
 	purge_configs_funcs(gi);
 	composite_dev_cleanup(cdev);
 	usb_ep_autoconfig_reset(cdev->gadget);
@@ -1510,12 +1527,6 @@ static struct config_group *gadgets_make(
 	if (!gi->composite.gadget_driver.function)
 		goto err;
 
-#ifdef CONFIG_USB_OTG
-	gi->otg.bLength = sizeof(struct usb_otg_descriptor);
-	gi->otg.bDescriptorType = USB_DT_OTG;
-	gi->otg.bmAttributes = USB_OTG_SRP | USB_OTG_HNP;
-#endif

  parent reply	other threads:[~2015-06-17  5:43 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-17  5:43 [PATCH v4 00/23] usb gadget update for OTG 2.0 Li Jun
     [not found] ` <1434519835-27745-1-git-send-email-jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-06-17  5:43   ` [PATCH v4 01/23] usb: add usb_otg20_descriptor for OTG 2.0 and above Li Jun
2015-06-17  5:43   ` [PATCH v4 02/23] usb: add USB_OTG_ADP definition Li Jun
2015-06-17  5:43   ` [PATCH v4 03/23] usb: otg: add usb_otg_caps structure for otg capabilities Li Jun
     [not found]     ` <1434519835-27745-4-git-send-email-jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-06-17  8:25       ` Roger Quadros
2015-06-17  5:43   ` [PATCH v4 04/23] usb: add usb_otg_caps to usb_gadget structure Li Jun
     [not found]     ` <1434519835-27745-5-git-send-email-jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-06-17  8:29       ` Roger Quadros
2015-06-17  8:50         ` Li Jun
2015-06-17  8:53         ` Roger Quadros
2015-06-17  5:43   ` [PATCH v4 05/23] usb: gadget: composite: add USB_DT_OTG request handling Li Jun
2015-06-17  5:43   ` [PATCH v4 06/23] doc: dt-binding: usb: add otg related properties Li Jun
     [not found]     ` <1434519835-27745-7-git-send-email-jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-06-17  8:30       ` Roger Quadros
2015-06-17  5:43   ` [PATCH v4 07/23] usb: common: add API to get usb otg features from device tree Li Jun
     [not found]     ` <1434519835-27745-8-git-send-email-jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-06-17  8:45       ` Roger Quadros
2015-06-17  9:19         ` Li Jun
2015-06-17  5:43   ` [PATCH v4 08/23] usb: chipidea: set usb gadeget's otg capabilities Li Jun
2015-06-17  5:43   ` [PATCH v4 09/23] usb: chipidea: update ci_otg_is_fsm_mode conditions Li Jun
2015-06-17  5:43   ` [PATCH v4 10/23] usb: gadget: add usb otg descriptor allocate and init interface Li Jun
     [not found]     ` <1434519835-27745-11-git-send-email-jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-06-17  8:51       ` Roger Quadros
2015-06-17  5:43   ` Li Jun [this message]
     [not found]     ` <1434519835-27745-12-git-send-email-jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-06-17  9:01       ` [PATCH v4 11/23] usb: gadget: configfs: allocate and init otg descriptor by otg capabilities Roger Quadros
2015-06-17  5:43   ` [PATCH v4 12/23] usb: gadget: ether: " Li Jun
     [not found]     ` <1434519835-27745-13-git-send-email-jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-06-17  9:03       ` Roger Quadros
2015-06-17  9:53         ` Li Jun
2015-06-17  5:43   ` [PATCH v4 13/23] usb: gadget: acm_ms: " Li Jun
     [not found]     ` <1434519835-27745-14-git-send-email-jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-06-17  9:11       ` Roger Quadros
2015-06-17  5:43   ` [PATCH v4 14/23] usb: gadget: audio: " Li Jun
2015-06-17  5:43   ` [PATCH v4 15/23] usb: gadget: cdc2: " Li Jun
2015-06-17  5:43   ` [PATCH v4 16/23] usb: gadget: g_ffs: " Li Jun
2015-06-17  5:43   ` [PATCH v4 17/23] usb: gadget: hid: " Li Jun
2015-06-17  5:43   ` [PATCH v4 18/23] usb: gadget: mass_storage: " Li Jun
2015-06-17  5:43   ` [PATCH v4 19/23] usb: gadget: multi: " Li Jun
2015-06-17  5:43   ` [PATCH v4 20/23] usb: gadget: ncm: " Li Jun
2015-06-17  5:43   ` [PATCH v4 21/23] usb: gadget: printer: " Li Jun
2015-06-17  5:43   ` [PATCH v4 22/23] usb: gadget: serial: " Li Jun
2015-06-17  5:43   ` [PATCH v4 23/23] usb: gadget: zero: " Li Jun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434519835-27745-12-git-send-email-jun.li@freescale.com \
    --to=jun.li-kzfg59tc24xl57midrcfdg@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=macpaul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
    --cc=peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=rogerq-l0cyMroinI0@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).