From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Bolle Subject: Re: [PATCHv5 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox. Date: Thu, 25 Jun 2015 09:31:31 +0200 Message-ID: <1435217491.16792.5.camel@tiscali.nl> References: <1435082402-29239-1-git-send-email-moritz.fischer@ettus.com> <1435082402-29239-3-git-send-email-moritz.fischer@ettus.com> <1435178205.4528.77.camel@tiscali.nl> <558BA5D4.8060903@xilinx.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <558BA5D4.8060903-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Michal Simek , Moritz Fischer , jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org, jingoohan1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, 2015-06-25 at 08:55 +0200, Michal Simek wrote: > On 06/24/2015 10:36 PM, Paul Bolle wrote: > > On Tue, 2015-06-23 at 11:00 -0700, Moritz Fischer wrote: > > > +MODULE_ALIAS("platform:xilinx-mailbox"); > > > > So I think this MODULE_ALIAS() is only useful if, in short, there's > > a corresponding platform_device created. Ie, a platform_device with > > a name "xilinx-mailbox" that will fire of a "MODALIAS=platform:xili > > nx-mailbox" when it's created. > > > > I couldn't spot such a platform_device. Provided git grep didn't > > let me down here: what breaks if this line is dropped? > > IRC you don't need to have this platform_device in the kernel > present. Only one thing which should be check is that this driver can > be used as platform device driver. > > The only one problematic part is devm_clk_get() and this should be > checked if you can use this as platform driver. From the first look > it looks like that this will break it. > > Anyway if Moritz is able to use this a platform driver he can keep > this line there. If not, it should be removed. But, assuming this works as a platform driver, where does the "xilinx -mailbox" platform device originate? Paul Bolle PS Evolution 3.16 is nearly unbearable in its handling of replies to plain text messages. Doe anyone know how to make it handle them sensibly? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html