From: Vaibhav Hiremath <vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
yizhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org,
Vaibhav Hiremath
<vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: [PATCH-V5 2/4] mfd: 88pm800: Remove unnecessary protection around pdata
Date: Mon, 29 Jun 2015 21:01:15 +0530 [thread overview]
Message-ID: <1435591877-18214-3-git-send-email-vaibhav.hiremath@linaro.org> (raw)
In-Reply-To: <1435591877-18214-1-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
With addition of proper checks in place in pm800_probe function,
which makes sure that pdata would never become NULL.
So remove all unnecessary protection around pdata in whole
driver code.
Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
drivers/mfd/88pm800.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c
index 40fd014..d495737 100644
--- a/drivers/mfd/88pm800.c
+++ b/drivers/mfd/88pm800.c
@@ -302,7 +302,7 @@ static int device_gpadc_init(struct pm80x_chip *chip,
mask = (PM800_GPADC_GP_BIAS_EN0 | PM800_GPADC_GP_BIAS_EN1 |
PM800_GPADC_GP_BIAS_EN2 | PM800_GPADC_GP_BIAS_EN3);
- if (pdata && (pdata->batt_det == 0))
+ if (pdata->batt_det == 0)
data = (PM800_GPADC_GP_BIAS_EN0 | PM800_GPADC_GP_BIAS_EN1 |
PM800_GPADC_GP_BIAS_EN2 | PM800_GPADC_GP_BIAS_EN3);
else
@@ -342,11 +342,9 @@ static int device_rtc_init(struct pm80x_chip *chip,
{
int ret;
- if (pdata) {
- rtc_devs[0].platform_data = pdata->rtc;
- rtc_devs[0].pdata_size =
- pdata->rtc ? sizeof(struct pm80x_rtc_pdata) : 0;
- }
+ rtc_devs[0].platform_data = pdata->rtc;
+ rtc_devs[0].pdata_size = pdata->rtc ? sizeof(struct pm80x_rtc_pdata) : 0;
+
ret = mfd_add_devices(chip->dev, 0, &rtc_devs[0],
ARRAY_SIZE(rtc_devs), NULL, 0, NULL);
if (ret) {
@@ -503,7 +501,7 @@ static int device_800_init(struct pm80x_chip *chip,
goto out;
}
if (val & PM800_ALARM_WAKEUP) {
- if (pdata && pdata->rtc)
+ if (pdata->rtc)
pdata->rtc->rtc_wakeup = 1;
}
@@ -602,7 +600,7 @@ static int pm800_probe(struct i2c_client *client,
goto err_device_init;
}
- if (pdata && pdata->plat_config)
+ if (pdata->plat_config)
pdata->plat_config(chip, pdata);
return 0;
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-06-29 15:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 15:31 [PATCH-V5 0/4] mfd: 88pm800: Add Device tree support Vaibhav Hiremath
2015-06-29 15:31 ` [PATCH-V5 1/4] mfd: 88pm800: Add device " Vaibhav Hiremath
[not found] ` <1435591877-18214-2-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-06-30 0:32 ` Krzysztof Kozlowski
2015-07-07 7:30 ` Lee Jones
[not found] ` <1435591877-18214-1-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-06-29 15:31 ` Vaibhav Hiremath [this message]
[not found] ` <1435591877-18214-3-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-06-30 0:34 ` [PATCH-V5 2/4] mfd: 88pm800: Remove unnecessary protection around pdata Krzysztof Kozlowski
2015-07-07 7:30 ` Lee Jones
2015-06-29 15:31 ` [PATCH-V5 3/4] mfd: 88pm800: Set default interrupt clear method Vaibhav Hiremath
[not found] ` <1435591877-18214-4-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-06-30 0:29 ` Krzysztof Kozlowski
2015-07-07 7:29 ` Lee Jones
2015-07-07 9:53 ` Vaibhav Hiremath
[not found] ` <559BA1AE.9050006-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-07-07 10:40 ` Lee Jones
2015-07-07 10:51 ` Vaibhav Hiremath
2015-07-07 11:12 ` Lee Jones
2015-07-07 11:18 ` Vaibhav Hiremath
[not found] ` <559BB58E.9010406-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-07-07 11:25 ` Vaibhav Hiremath
[not found] ` <559BB727.2070106-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-07-07 12:54 ` Lee Jones
2015-07-07 14:47 ` Vaibhav Hiremath
2015-07-07 14:57 ` Lee Jones
2015-07-08 12:22 ` Vaibhav Hiremath
2015-06-29 15:31 ` [PATCH-V5 4/4] mfd: devicetree: bindings: Add new 88pm800 mfd binding Vaibhav Hiremath
[not found] ` <1435591877-18214-5-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-06-30 0:30 ` Krzysztof Kozłowski
2015-07-01 7:43 ` Lee Jones
2015-07-01 8:00 ` Krzysztof Kozłowski
2015-06-30 0:31 ` Krzysztof Kozlowski
[not found] ` <CAJKOXPdyDRPiEwKd_MLq6rkhuWxxqqageUweMk-p69RXfH2hJA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-30 5:40 ` Vaibhav Hiremath
2015-07-07 7:31 ` Lee Jones
2015-07-01 16:10 ` Rob Herring
2015-07-01 16:21 ` Vaibhav Hiremath
[not found] ` <5594137D.6070106-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-07-01 17:17 ` Rob Herring
[not found] ` <CAL_JsqKgxPK3oBJifAn9-S8pB8Ew7JRmi9cJE4qO1b=aRC4N+w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-01 17:24 ` Vaibhav Hiremath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435591877-18214-3-git-send-email-vaibhav.hiremath@linaro.org \
--to=vaibhav.hiremath-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=yizhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).