devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Ludovic Desroches <ludovic.desroches@atmel.com>,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Cc: ulf.hansson@linaro.org, nicolas.ferre@atmel.com,
	alexandre.belloni@free-electrons.com
Subject: Re: [PATCH 2/3] mmc: sdhci-of-at91: introduce driver for the Atmel SDMMC
Date: Sat, 04 Jul 2015 10:30:28 +0200	[thread overview]
Message-ID: <1435998628.20057.26.camel@tiscali.nl> (raw)
In-Reply-To: <1435933037-12889-3-git-send-email-ludovic.desroches@atmel.com>

A nit only: a license mismatch.

On vr, 2015-07-03 at 16:17 +0200, Ludovic Desroches wrote:
> --- /dev/null
> +++ b/drivers/mmc/host/sdhci-of-at91.c
> 
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or (at
> + * your option) any later version.

This states the license is GPL v2 or later.

> +MODULE_LICENSE("GPL v2");

And, according to include/linux/module.h, this states the license is
(only) GPL v2. So I think that either the comment at the top of this
file or the ident used in MODULE_LICENSE() needs to change.

Thanks,


Paul Bolle

  reply	other threads:[~2015-07-04  8:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-03 14:17 [PATCH 0/3] introduce driver for the Atmel SDMMC Ludovic Desroches
     [not found] ` <1435933037-12889-1-git-send-email-ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-07-03 14:17   ` [PATCH 1/3] mmc: sdhci: switch from programmable clock mode to divided one if needed Ludovic Desroches
2015-07-03 14:17   ` [PATCH 2/3] mmc: sdhci-of-at91: introduce driver for the Atmel SDMMC Ludovic Desroches
2015-07-04  8:30     ` Paul Bolle [this message]
2015-07-06  7:33       ` Ludovic Desroches
2015-07-04 20:06     ` Arnd Bergmann
2015-07-06  7:33       ` Ludovic Desroches
2015-07-03 14:17 ` [PATCH 3/3] MAINTAINERS: add entry for Atmel sdhci-of-at91 driver Ludovic Desroches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435998628.20057.26.camel@tiscali.nl \
    --to=pebolle@tiscali.nl \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ludovic.desroches@atmel.com \
    --cc=nicolas.ferre@atmel.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).