[PATCH 1/2] powerpc/85xx: Add binding for SCFG

[PATCH 1/2] powerpc/85xx: Add binding for SCFG

[Dongsheng Wang]

From: Wang Dongsheng <dongsheng.wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

SCFG provides SoC specific configuration and status registers for
the chip. Add this for powerpc platform.

Signed-off-by: Wang Dongsheng <dongsheng.wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

diff --git a/Documentation/devicetree/bindings/powerpc/fsl/board.txt b/Documentation/devicetree/bindings/powerpc/fsl/board.txt
index cff38bd..55604fe 100644
--- a/Documentation/devicetree/bindings/powerpc/fsl/board.txt
+++ b/Documentation/devicetree/bindings/powerpc/fsl/board.txt
@@ -3,6 +3,25 @@ Freescale Reference Board Bindings
 This document describes device tree bindings for various devices that
 exist on some Freescale reference boards.
 
+* Supplement configuration unit (SCFG)
+
+SCFG is the supplemental configuration unit, that provides SoC specific
+configuration and status registers for the chip. Such as getting PEX port
+status.
+
+Required properties:
+
+- compatible: should be "fsl,<board>-scfg"
+- reg: should contain base address and length of SCFG memory-mapped
+registers
+
+Example:
+
+	scfg: global-utilities@fc000 {
+		compatible = "fsl,t1040-scfg";
+		reg = <0xfc000 0x1000>;
+	};
+
 * Board Control and Status (BCSR)
 
 Required properties:
-- 
2.1.0.27.g96db324

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] powerpc/mpc85xx:Add SCFG device tree support of T104x

[Dongsheng Wang]

From: Wang Dongsheng <dongsheng.wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

Signed-off-by: Wang Dongsheng <dongsheng.wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

diff --git a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
index 9e9f7e2..9770d02 100644
--- a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
@@ -484,6 +484,11 @@
 		reg	   = <0xea000 0x4000>;
 	};
 
+	scfg: global-utilities@fc000 {
+		compatible = "fsl,t1040-scfg";
+		reg = <0xfc000 0x1000>;
+	};
+
 /include/ "elo3-dma-0.dtsi"
 /include/ "elo3-dma-1.dtsi"
 /include/ "qoriq-espi-0.dtsi"
-- 
2.1.0.27.g96db324

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] powerpc/85xx: Add binding for SCFG

[Scott Wood]

On Tue, 2015-07-07 at 17:47 +0800, Dongsheng Wang wrote:
> From: Wang Dongsheng <dongsheng.wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> 
> SCFG provides SoC specific configuration and status registers for
> the chip. Add this for powerpc platform.
> 
> Signed-off-by: Wang Dongsheng <dongsheng.wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> 
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/board.txt 
> b/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> index cff38bd..55604fe 100644
> --- a/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> @@ -3,6 +3,25 @@ Freescale Reference Board Bindings
>  This document describes device tree bindings for various devices that
>  exist on some Freescale reference boards.
>  
> +* Supplement configuration unit (SCFG)
> +
> +SCFG is the supplemental configuration unit, that provides SoC specific
> +configuration and status registers for the chip. Such as getting PEX port
> +status.
> +
> +Required properties:
> +
> +- compatible: should be "fsl,<board>-scfg"

fsl,<chip>-scfg

> +- reg: should contain base address and length of SCFG memory-mapped
> +registers
> +
> +Example:
> +
> +     scfg:  global-utilities@fc000{
> +             compatible = "fsl,t1040-scfg";
> +             reg = <0xfc000 0x1000>;
> +     };
> +

I don't think board.txt is the right place for this, since it's part of the 
SoC, not the board.  Put it in its own file.

-Scott

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/2] powerpc/85xx: Add binding for SCFG

[Wang Dongsheng]

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Wednesday, July 08, 2015 3:50 AM
> To: Wang Dongsheng-B40534
> Cc: robh+dt@kernel.org; ijc+devicetree@hellion.org.uk; galak@codeaurora.org;
> Jain Priyanka-B32167; devicetree@vger.kernel.org
> Subject: Re: [PATCH 1/2] powerpc/85xx: Add binding for SCFG
> 
> On Tue, 2015-07-07 at 17:47 +0800, Dongsheng Wang wrote:
> > From: Wang Dongsheng <dongsheng.wang@freescale.com>
> >
> > SCFG provides SoC specific configuration and status registers for the
> > chip. Add this for powerpc platform.
> >
> > Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com>
> >
> > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> > b/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> > index cff38bd..55604fe 100644
> > --- a/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> > +++ b/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> > @@ -3,6 +3,25 @@ Freescale Reference Board Bindings  This document
> > describes device tree bindings for various devices that  exist on some
> > Freescale reference boards.
> >
> > +* Supplement configuration unit (SCFG)
> > +
> > +SCFG is the supplemental configuration unit, that provides SoC
> > +specific configuration and status registers for the chip. Such as
> > +getting PEX port status.
> > +
> > +Required properties:
> > +
> > +- compatible: should be "fsl,<board>-scfg"
> 
> fsl,<chip>-scfg

Thanks.

> > +- reg: should contain base address and length of SCFG memory-mapped
> > +registers
> > +
> > +Example:
> > +
> > +     scfg:  global-utilities@fc000{
> > +             compatible = "fsl,t1040-scfg";
> > +             reg = <0xfc000 0x1000>;
> > +     };
> > +
> 
> I don't think board.txt is the right place for this, since it's part of the SoC,
> not the board.  Put it in its own file.

OK, will put it in Documentation/devicetree/bindings/powerpc/fsl/scfg.txt.

Regards,
-Dongsheng