devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
To: linux-arm-kernel@lists.infradead.org
Cc: devicetree@vger.kernel.org, k.kozlowski@samsung.com,
	sameo@linux.intel.com, linux-kernel@vger.kernel.org,
	Vaibhav Hiremath <vaibhav.hiremath@linaro.org>,
	robh+dt@kernel.org, lee.jones@linaro.org
Subject: [PATCH 4/6] mfd: 88pm800: Enable 32KHZ XO low jitter clock out
Date: Thu,  9 Jul 2015 17:17:09 +0530	[thread overview]
Message-ID: <1436442431-3471-5-git-send-email-vaibhav.hiremath@linaro.org> (raw)
In-Reply-To: <1436442431-3471-1-git-send-email-vaibhav.hiremath@linaro.org>

88PM800/860 device supports output of 32KHz low jitter XO clock
out on
 - CLK32K3 - for 88pm800
 - CLK32K2 - for 88pm860

Both devices share same register bit-field to configure this.

This patch adds support to enable this clock out, using DT property
"marvell,88pm800-32khz-xolj-out-en"

Since this configuration is controlled through DT property, it is
safe to put it as common code.

Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
---
 drivers/mfd/88pm800.c       | 13 +++++++++++++
 include/linux/mfd/88pm80x.h |  1 +
 2 files changed, 14 insertions(+)

diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c
index 80a1bc1..8930fd8 100644
--- a/drivers/mfd/88pm800.c
+++ b/drivers/mfd/88pm800.c
@@ -526,6 +526,19 @@ static int pm800_init_config(struct pm80x_chip *chip, struct device_node *np)
 	int ret;
 	unsigned int val;
 
+	/* Enable 32Khz-out-3 low jitter XO_LJ = 1 in pm800
+	 * Enable 32Khz-out-2 low jitter XO_LJ = 1 in pm860
+	 * they are the same bit
+	 */
+	if (of_property_read_bool(np, "marvell,88pm800-32khz-xolj-out-en")) {
+		ret = regmap_update_bits(chip->regmap,
+					PM800_LOW_POWER2,
+					PM800_XO_LJ_OUT_EN,
+					PM800_XO_LJ_OUT_EN);
+		if (ret)
+			goto error;
+	}
+
 	switch (chip->type) {
 	case CHIP_PM800:
 	case CHIP_PM805:
diff --git a/include/linux/mfd/88pm80x.h b/include/linux/mfd/88pm80x.h
index 2ef62af..fb916f1 100644
--- a/include/linux/mfd/88pm80x.h
+++ b/include/linux/mfd/88pm80x.h
@@ -88,6 +88,7 @@ enum {
 /* Referance and low power registers */
 #define PM800_LOW_POWER1		(0x20)
 #define PM800_LOW_POWER2		(0x21)
+#define PM800_XO_LJ_OUT_EN		BIT(5)
 
 #define PM800_LOW_POWER_CONFIG3		(0x22)
 #define PM800_LDOBK_FREEZE		BIT(7)
-- 
1.9.1

  parent reply	other threads:[~2015-07-09 11:47 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-09 11:47 [PATCH 0/6] mfd: 88pm800: Add 88pm860 device support Vaibhav Hiremath
     [not found] ` <1436442431-3471-1-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-07-09 11:47   ` [PATCH 1/6] mfd: 88pm80x: Add 88pm860 chip type support Vaibhav Hiremath
     [not found]     ` <1436442431-3471-2-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-07-11  6:54       ` Krzysztof Kozlowski
2015-07-09 11:47   ` [PATCH 2/6] mfd: 88pm800: Add init time initial configuration support Vaibhav Hiremath
     [not found]     ` <1436442431-3471-3-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-07-11  6:53       ` Krzysztof Kozlowski
     [not found]         ` <55A0BD78.8050005-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-07-13  7:10           ` Vaibhav Hiremath
2015-07-09 11:47   ` [PATCH 3/6] mfd: devicetree: bindings: 88pm800: Add DT property for 32KHz output enable Vaibhav Hiremath
     [not found]     ` <1436442431-3471-4-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-07-11  7:11       ` Krzysztof Kozlowski
2015-07-13  7:24         ` Vaibhav Hiremath
     [not found]           ` <55A367BE.6040103-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-07-13  7:31             ` Krzysztof Kozlowski
     [not found]               ` <55A36939.7070607-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-07-13  7:38                 ` Vaibhav Hiremath
     [not found]                   ` <55A36AE6.5070802-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-07-13  7:44                     ` Krzysztof Kozlowski
2015-07-09 12:04   ` [PATCH 0/6] mfd: 88pm800: Add 88pm860 device support Krzysztof Kozlowski
2015-07-09 12:44     ` Vaibhav Hiremath
     [not found]       ` <559E6C9A.8090004-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-07-09 12:53         ` Vaibhav Hiremath
2015-07-09 13:28           ` Krzysztof Kozlowski
     [not found]             ` <CAJKOXPeF6N_=FhBYOYTTxnGgU8GcTrbqthPNU=bXBfo7Db0Lkg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-10 12:03               ` Vaibhav Hiremath
2015-07-11  6:46                 ` Krzysztof Kozlowski
2015-07-09 11:47 ` Vaibhav Hiremath [this message]
2015-07-09 11:47 ` [PATCH 5/6] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable Vaibhav Hiremath
     [not found]   ` <1436442431-3471-6-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-07-11  7:16     ` Krzysztof Kozlowski
     [not found]       ` <55A0C2CB.6060209-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-07-13  7:50         ` Vaibhav Hiremath
2015-07-13  8:10           ` Krzysztof Kozlowski
     [not found]             ` <55A3725B.2040801-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-07-13 14:27               ` Vaibhav Hiremath
2015-07-09 11:47 ` [PATCH 6/6] mfd: 88pm800: Add support for configuration of dual phase on BUCK1 Vaibhav Hiremath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436442431-3471-5-git-send-email-vaibhav.hiremath@linaro.org \
    --to=vaibhav.hiremath@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=k.kozlowski@samsung.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).