devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Jianwei Wang <jianwei.wang@freescale.com>
Cc: devicetree@vger.kernel.org,
	Xiubo Li <lixiubo@cmss.chinamobile.com>,
	daniel.vetter@ffwll.ch, Alison Wang <b18965@freescale.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	scottwood@freescale.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 1/4] drm/layerscape: Add Freescale DCU DRM driver
Date: Sat, 11 Jul 2015 15:15:43 +0200	[thread overview]
Message-ID: <1436620543.2679.13.camel@tiscali.nl> (raw)
In-Reply-To: <1436527063-44762-1-git-send-email-jianwei.wang@freescale.com>

A question and a nit follow.

On vr, 2015-07-10 at 19:17 +0800, Jianwei Wang wrote:
> --- /dev/null
> +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c

> +MODULE_ALIAS("platform:fsl-dcu-drm");

Question: this appears to be only useful if there's a corresponding
struct platform_device. That is, a platform_device with a "fsl-dcu-drm"
.name. It will fire off a "MODALIAS=platform:fsl-dcu-drm" uevent when
it's created.

I couldn't find this corresponding platform_device. Does it exist? Or is
this alias needed for some other reason?

> --- /dev/null
> +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h

> +#define DRIVER_NAME			"fsl-dcu-drm"

Nit: I don't think DRIVER_NAME is actually used anywhere.

Thanks,


Paul Bolle
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2015-07-11 13:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-10 11:17 [PATCH v7 1/4] drm/layerscape: Add Freescale DCU DRM driver Jianwei Wang
2015-07-10 11:17 ` [PATCH v7 2/4] drm/panel: simple: Add support for NEC NL4827HC19-05B 480x272 panel Jianwei Wang
2015-07-10 11:17 ` [PATCH v7 3/4] arm/dts/ls1021a: Add DCU dts node Jianwei Wang
2015-07-10 11:17 ` [PATCH v7 4/4] arm/dts/ls1021a: Add a TFT LCD panel " Jianwei Wang
2015-07-10 17:02 ` [PATCH v7 1/4] drm/layerscape: Add Freescale DCU DRM driver Daniel Vetter
2015-07-11 13:15 ` Paul Bolle [this message]
2015-07-13  3:58   ` Wang J.W.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436620543.2679.13.camel@tiscali.nl \
    --to=pebolle@tiscali.nl \
    --cc=b18965@freescale.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jianwei.wang@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lixiubo@cmss.chinamobile.com \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).