Re: [PATCH 3/5] [media] tc358743: support probe from device tree

[Philipp Zabel <p.zabel@pengutronix.de>]

Am Dienstag, den 14.07.2015, 12:15 +0200 schrieb Hans Verkuil:
[...]
> As you said, it's not public and without the formulas there is nothing you
> can do but hardcode it.
> 
> If I understand this correctly these values depend on the link frequency,
> so the DT should contain the link frequency and the driver can hardcode the
> values based on that. Which means that if someone needs to support a new
> link frequency the driver needs to be extended for that frequency.
> 
> As long as Toshiba keeps the formulas under NDA there isn't much else you can
> do.

Ok.

[...]
> >>>  	/* platform data */
> >>> -	if (!pdata) {
> >>> -		v4l_err(client, "No platform data!\n");
> >>> -		return -ENODEV;
> >>> +	if (pdata) {
> >>> +		state->pdata = *pdata;
> >>> +	} else {
> >>> +		err = tc358743_probe_of(state);
> >>> +		if (err == -ENODEV)
> >>> +			v4l_err(client, "No platform data!\n");
> >>
> >> I'd replace this with "No device tree data!" or something like that.
> > 
> > I'll do that, thank you.

On second thought, I'll keep it as is. The tc358743_probe_of function
prints its own error messages. In the platform data case it returns
-ENODEV, so that'd still be the correct message, then.

regards
Philipp