[PATCH] drivers/of/fdt.c: replace pr_warning by pr

devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH] drivers/of/fdt.c: replace pr_warning by pr_warn
@ 2015-07-21  8:01 Wang Long
  2015-07-24 19:00 ` Rob Herring
  0 siblings, 1 reply; 5+ messages in thread
From: Wang Long @ 2015-07-21  8:01 UTC (permalink / raw)
  To: grant.likely, robh+dt
  Cc: devicetree, linux-kernel, peifeiyue, wanglong, long.wanglong

Update the last pr_warning callsite in drivers/of.

Signed-off-by: Wang Long <long.wanglong@huawei.com>
---
 drivers/of/fdt.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index 0749656..e1f61b8 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -425,7 +425,7 @@ static void __unflatten_device_tree(const void *blob,
 	start = 0;
 	unflatten_dt_node(blob, mem, &start, NULL, mynodes, 0, false);
 	if (be32_to_cpup(mem + size) != 0xdeadbeef)
-		pr_warning("End of tree marker overwritten: %08x\n",
+		pr_warn("End of tree marker overwritten: %08x\n",
 			   be32_to_cpup(mem + size));
 
 	pr_debug(" <- unflatten_device_tree()\n");
@@ -985,24 +985,24 @@ void __init __weak early_init_dt_add_memory_arch(u64 base, u64 size)
 	size &= PAGE_MASK;
 
 	if (base > MAX_PHYS_ADDR) {
-		pr_warning("Ignoring memory block 0x%llx - 0x%llx\n",
+		pr_warn("Ignoring memory block 0x%llx - 0x%llx\n",
 				base, base + size);
 		return;
 	}
 
 	if (base + size - 1 > MAX_PHYS_ADDR) {
-		pr_warning("Ignoring memory range 0x%llx - 0x%llx\n",
+		pr_warn("Ignoring memory range 0x%llx - 0x%llx\n",
 				((u64)MAX_PHYS_ADDR) + 1, base + size);
 		size = MAX_PHYS_ADDR - base + 1;
 	}
 
 	if (base + size < phys_offset) {
-		pr_warning("Ignoring memory block 0x%llx - 0x%llx\n",
+		pr_warn("Ignoring memory block 0x%llx - 0x%llx\n",
 			   base, base + size);
 		return;
 	}
 	if (base < phys_offset) {
-		pr_warning("Ignoring memory range 0x%llx - 0x%llx\n",
+		pr_warn("Ignoring memory range 0x%llx - 0x%llx\n",
 			   base, phys_offset);
 		size -= phys_offset - base;
 		base = phys_offset;
-- 
1.8.3.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] drivers/of/fdt.c: replace pr_warning by pr_warn
  2015-07-21  8:01 [PATCH] drivers/of/fdt.c: replace pr_warning by pr_warn Wang Long
@ 2015-07-24 19:00 ` Rob Herring
  2015-07-25  0:57   ` long.wanglong
  0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2015-07-24 19:00 UTC (permalink / raw)
  To: Wang Long
  Cc: Grant Likely, Rob Herring, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, peifeiyue, wanglong

On Tue, Jul 21, 2015 at 3:01 AM, Wang Long <long.wanglong@huawei.com> wrote:
> Update the last pr_warning callsite in drivers/of.

That is obvious in the diff, but can you tell me why?

Rob

> Signed-off-by: Wang Long <long.wanglong@huawei.com>
> ---
>  drivers/of/fdt.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index 0749656..e1f61b8 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -425,7 +425,7 @@ static void __unflatten_device_tree(const void *blob,
>         start = 0;
>         unflatten_dt_node(blob, mem, &start, NULL, mynodes, 0, false);
>         if (be32_to_cpup(mem + size) != 0xdeadbeef)
> -               pr_warning("End of tree marker overwritten: %08x\n",
> +               pr_warn("End of tree marker overwritten: %08x\n",
>                            be32_to_cpup(mem + size));
>
>         pr_debug(" <- unflatten_device_tree()\n");
> @@ -985,24 +985,24 @@ void __init __weak early_init_dt_add_memory_arch(u64 base, u64 size)
>         size &= PAGE_MASK;
>
>         if (base > MAX_PHYS_ADDR) {
> -               pr_warning("Ignoring memory block 0x%llx - 0x%llx\n",
> +               pr_warn("Ignoring memory block 0x%llx - 0x%llx\n",
>                                 base, base + size);
>                 return;
>         }
>
>         if (base + size - 1 > MAX_PHYS_ADDR) {
> -               pr_warning("Ignoring memory range 0x%llx - 0x%llx\n",
> +               pr_warn("Ignoring memory range 0x%llx - 0x%llx\n",
>                                 ((u64)MAX_PHYS_ADDR) + 1, base + size);
>                 size = MAX_PHYS_ADDR - base + 1;
>         }
>
>         if (base + size < phys_offset) {
> -               pr_warning("Ignoring memory block 0x%llx - 0x%llx\n",
> +               pr_warn("Ignoring memory block 0x%llx - 0x%llx\n",
>                            base, base + size);
>                 return;
>         }
>         if (base < phys_offset) {
> -               pr_warning("Ignoring memory range 0x%llx - 0x%llx\n",
> +               pr_warn("Ignoring memory range 0x%llx - 0x%llx\n",
>                            base, phys_offset);
>                 size -= phys_offset - base;
>                 base = phys_offset;
> --
> 1.8.3.4
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] drivers/of/fdt.c: replace pr_warning by pr_warn
  2015-07-24 19:00 ` Rob Herring
@ 2015-07-25  0:57   ` long.wanglong
       [not found]     ` <55B2DEE2.8080509-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
  0 siblings, 1 reply; 5+ messages in thread
From: long.wanglong @ 2015-07-25  0:57 UTC (permalink / raw)
  To: Rob Herring
  Cc: Grant Likely, Rob Herring, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, peifeiyue, wanglong

On 2015/7/25 3:00, Rob Herring wrote:
> On Tue, Jul 21, 2015 at 3:01 AM, Wang Long <long.wanglong@huawei.com> wrote:
>> Update the last pr_warning callsite in drivers/of.
> 
> That is obvious in the diff, but can you tell me why?

Hi Rob,

When we use script "./scripts/checkpatch.pl" to check a patch, using pr_warning
will produce WARNING:

	WARNING: Prefer pr_warn(... to pr_warning(...
	#22: FILE: drivers/of/fdt.c:428:
	+		pr_warning("End of tree marker overwritten: %08x\n",

So,we should convert pr_warning to pr_warn.


Best Regards
Wang Long


> 
> Rob
> 
>> Signed-off-by: Wang Long <long.wanglong@huawei.com>
>> ---
>>  drivers/of/fdt.c | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
>> index 0749656..e1f61b8 100644
>> --- a/drivers/of/fdt.c
>> +++ b/drivers/of/fdt.c
>> @@ -425,7 +425,7 @@ static void __unflatten_device_tree(const void *blob,
>>         start = 0;
>>         unflatten_dt_node(blob, mem, &start, NULL, mynodes, 0, false);
>>         if (be32_to_cpup(mem + size) != 0xdeadbeef)
>> -               pr_warning("End of tree marker overwritten: %08x\n",
>> +               pr_warn("End of tree marker overwritten: %08x\n",
>>                            be32_to_cpup(mem + size));
>>
>>         pr_debug(" <- unflatten_device_tree()\n");
>> @@ -985,24 +985,24 @@ void __init __weak early_init_dt_add_memory_arch(u64 base, u64 size)
>>         size &= PAGE_MASK;
>>
>>         if (base > MAX_PHYS_ADDR) {
>> -               pr_warning("Ignoring memory block 0x%llx - 0x%llx\n",
>> +               pr_warn("Ignoring memory block 0x%llx - 0x%llx\n",
>>                                 base, base + size);
>>                 return;
>>         }
>>
>>         if (base + size - 1 > MAX_PHYS_ADDR) {
>> -               pr_warning("Ignoring memory range 0x%llx - 0x%llx\n",
>> +               pr_warn("Ignoring memory range 0x%llx - 0x%llx\n",
>>                                 ((u64)MAX_PHYS_ADDR) + 1, base + size);
>>                 size = MAX_PHYS_ADDR - base + 1;
>>         }
>>
>>         if (base + size < phys_offset) {
>> -               pr_warning("Ignoring memory block 0x%llx - 0x%llx\n",
>> +               pr_warn("Ignoring memory block 0x%llx - 0x%llx\n",
>>                            base, base + size);
>>                 return;
>>         }
>>         if (base < phys_offset) {
>> -               pr_warning("Ignoring memory range 0x%llx - 0x%llx\n",
>> +               pr_warn("Ignoring memory range 0x%llx - 0x%llx\n",
>>                            base, phys_offset);
>>                 size -= phys_offset - base;
>>                 base = phys_offset;
>> --
>> 1.8.3.4
>>
> 
> .
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

[parent not found: <55B2DEE2.8080509-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>]

* Re: [PATCH] drivers/of/fdt.c: replace pr_warning by pr_warn
       [not found]     ` <55B2DEE2.8080509-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
@ 2015-07-26 20:39       ` Rob Herring
  2015-07-27  1:47         ` long.wanglong
  0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2015-07-26 20:39 UTC (permalink / raw)
  To: long.wanglong
  Cc: Grant Likely, Rob Herring,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	peifeiyue-hv44wF8Li93QT0dZR+AlfA, wanglong-m92B/FuLcaEcWVvVuXF20w

On Fri, Jul 24, 2015 at 7:57 PM, long.wanglong <long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> wrote:
> On 2015/7/25 3:00, Rob Herring wrote:
>> On Tue, Jul 21, 2015 at 3:01 AM, Wang Long <long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> wrote:
>>> Update the last pr_warning callsite in drivers/of.
>>
>> That is obvious in the diff, but can you tell me why?
>
> Hi Rob,
>
> When we use script "./scripts/checkpatch.pl" to check a patch, using pr_warning
> will produce WARNING:
>
>         WARNING: Prefer pr_warn(... to pr_warning(...
>         #22: FILE: drivers/of/fdt.c:428:
>         +               pr_warning("End of tree marker overwritten: %08x\n",
>
> So,we should convert pr_warning to pr_warn.

Okay, but don't explain to me. Explain this in the commit message.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] drivers/of/fdt.c: replace pr_warning by pr_warn
  2015-07-26 20:39       ` Rob Herring
@ 2015-07-27  1:47         ` long.wanglong
  0 siblings, 0 replies; 5+ messages in thread
From: long.wanglong @ 2015-07-27  1:47 UTC (permalink / raw)
  To: Rob Herring
  Cc: Grant Likely, Rob Herring, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, peifeiyue, wanglong

On 2015/7/27 4:39, Rob Herring wrote:
> On Fri, Jul 24, 2015 at 7:57 PM, long.wanglong <long.wanglong@huawei.com> wrote:
>> On 2015/7/25 3:00, Rob Herring wrote:
>>> On Tue, Jul 21, 2015 at 3:01 AM, Wang Long <long.wanglong@huawei.com> wrote:
>>>> Update the last pr_warning callsite in drivers/of.
>>>
>>> That is obvious in the diff, but can you tell me why?
>>
>> Hi Rob,
>>
>> When we use script "./scripts/checkpatch.pl" to check a patch, using pr_warning
>> will produce WARNING:
>>
>>         WARNING: Prefer pr_warn(... to pr_warning(...
>>         #22: FILE: drivers/of/fdt.c:428:
>>         +               pr_warning("End of tree marker overwritten: %08x\n",
>>
>> So,we should convert pr_warning to pr_warn.
> 
> Okay, but don't explain to me. Explain this in the commit message.
> 
> Rob
> 
> 

OK, i will send another patch and explain this in the commit message.

Wang Long

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-07-27  1:47 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-21  8:01 [PATCH] drivers/of/fdt.c: replace pr_warning by pr_warn Wang Long
2015-07-24 19:00 ` Rob Herring
2015-07-25  0:57   ` long.wanglong
     [not found]     ` <55B2DEE2.8080509-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-07-26 20:39       ` Rob Herring
2015-07-27  1:47         ` long.wanglong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).