From: Haibo Chen <haibo.chen@freescale.com>
To: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
shawnguo@kernel.org, kernel@pengutronix.de,
linux@arm.linux.org.uk, ulf.hansson@linaro.org,
aisheng.dong@freescale.com
Cc: fabio.estevam@freescale.com, devicetree@vger.kernel.org,
haibo.chen@freescale.com, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, johan.derycke@barco.com,
b29396@freescale.com, linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/6] mmc: sdhci-esdhc-imx: add tuning-step seting support
Date: Wed, 29 Jul 2015 17:03:53 +0800 [thread overview]
Message-ID: <1438160637-28061-3-git-send-email-haibo.chen@freescale.com> (raw)
In-Reply-To: <1438160637-28061-1-git-send-email-haibo.chen@freescale.com>
tuning-step is the delay cell steps in tuning procedure. The default value
of tuning-step is 1. For imx6 series usdhc, tuning procedure can be passed
when the tuning-step value is 1. But imx7d usdhc need the tuning-step value
as 2, otherwise it can't pass the tuning procedure.
So this patch add the tuning-step setting in driver, so that user can set
the tuning-step value in dts.
Signed-off-by: Haibo Chen <haibo.chen@freescale.com>
---
drivers/mmc/host/sdhci-esdhc-imx.c | 9 +++++++++
include/linux/platform_data/mmc-esdhc-imx.h | 1 +
2 files changed, 10 insertions(+)
diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index b441eed..158f93b 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -75,6 +75,7 @@
#define ESDHC_STD_TUNING_EN (1 << 24)
/* NOTE: the minimum valid tuning start tap for mx6sl is 1 */
#define ESDHC_TUNING_START_TAP 0x1
+#define ESDHC_TUNING_STEP_SHIFT 16
/* pinctrl state */
#define ESDHC_PINCTRL_STATE_100MHZ "state_100mhz"
@@ -472,6 +473,7 @@ static void esdhc_writew_le(struct sdhci_host *host, u16 val, int reg)
} else if (imx_data->socdata->flags & ESDHC_FLAG_STD_TUNING) {
u32 v = readl(host->ioaddr + SDHCI_ACMD12_ERR);
u32 m = readl(host->ioaddr + ESDHC_MIX_CTRL);
+ u32 tuning_ctrl;
if (val & SDHCI_CTRL_TUNED_CLK) {
v |= ESDHC_MIX_CTRL_SMPCLK_SEL;
} else {
@@ -482,6 +484,11 @@ static void esdhc_writew_le(struct sdhci_host *host, u16 val, int reg)
if (val & SDHCI_CTRL_EXEC_TUNING) {
v |= ESDHC_MIX_CTRL_EXE_TUNE;
m |= ESDHC_MIX_CTRL_FBCLK_SEL;
+ tuning_ctrl = readl(host->ioaddr + ESDHC_TUNING_CTRL);
+ tuning_ctrl |= ESDHC_STD_TUNING_EN | ESDHC_TUNING_START_TAP;
+ if (imx_data->boarddata.tuning_step)
+ tuning_ctrl |= imx_data->boarddata.tuning_step << ESDHC_TUNING_STEP_SHIFT;
+ writel(tuning_ctrl, host->ioaddr + ESDHC_TUNING_CTRL);
} else {
v &= ~ESDHC_MIX_CTRL_EXE_TUNE;
}
@@ -949,6 +956,8 @@ sdhci_esdhc_imx_probe_dt(struct platform_device *pdev,
if (gpio_is_valid(boarddata->wp_gpio))
boarddata->wp_type = ESDHC_WP_GPIO;
+ of_property_read_u32(np, "fsl,tuning-step", &boarddata->tuning_step);
+
if (of_find_property(np, "no-1-8-v", NULL))
boarddata->support_vsel = false;
else
diff --git a/include/linux/platform_data/mmc-esdhc-imx.h b/include/linux/platform_data/mmc-esdhc-imx.h
index e1571ef..95ccab3 100644
--- a/include/linux/platform_data/mmc-esdhc-imx.h
+++ b/include/linux/platform_data/mmc-esdhc-imx.h
@@ -45,5 +45,6 @@ struct esdhc_platform_data {
int max_bus_width;
bool support_vsel;
unsigned int delay_line;
+ unsigned int tuning_step; /* The delay cell steps in tuning procedure */
};
#endif /* __ASM_ARCH_IMX_ESDHC_H */
--
1.9.1
next prev parent reply other threads:[~2015-07-29 9:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 9:03 [PATCH v3 0/6] mmc: imx: a few fixes and new feature Haibo Chen
2015-07-29 9:03 ` [PATCH v3 1/6] mmc: sdhci-esdhc-imx: add imx7d support and support HS400 Haibo Chen
2015-07-31 14:15 ` Dong Aisheng
2015-08-02 8:59 ` Chen Bough
2015-08-03 12:09 ` Dong Aisheng
2015-08-05 7:39 ` Chen Bough
2015-08-05 7:53 ` Dong Aisheng
2015-08-04 3:25 ` Dong Aisheng
2015-07-29 9:03 ` Haibo Chen [this message]
2015-07-30 16:25 ` [PATCH v3 2/6] mmc: sdhci-esdhc-imx: add tuning-step seting support Jan Lübbe
2015-07-31 4:41 ` Dong Aisheng
2015-07-29 9:03 ` [PATCH v3 3/6] ARM: dts: imx7d-sdb: add eMMC5.0 support Haibo Chen
2015-07-31 14:46 ` Dong Aisheng
2015-07-29 9:03 ` [PATCH v3 4/6] mmc: sdhci-esdhc-imx: add compatible string in bingding doc Haibo Chen
[not found] ` <1438160637-28061-5-git-send-email-haibo.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-07-31 14:43 ` Dong Aisheng
2015-08-02 9:02 ` Chen Bough
2015-07-29 9:03 ` [PATCH v3 5/6] mmc: sdhci-esdhc-imx: config watermark level and burst length Haibo Chen
2015-07-31 14:51 ` Dong Aisheng
2015-07-31 15:13 ` Russell King - ARM Linux
[not found] ` <20150731151345.GX7557-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2015-08-03 10:14 ` Dong Aisheng
2015-07-31 14:55 ` Dong Aisheng
2015-07-29 9:03 ` [PATCH v3 6/6] mmc: sdhci-esdhc-imx: set back the burst_length_enable bit to 1 Haibo Chen
[not found] ` <1438160637-28061-7-git-send-email-haibo.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-07-31 14:57 ` Dong Aisheng
2015-08-03 1:08 ` Chen Bough
2015-08-03 12:12 ` Dong Aisheng
2015-07-29 9:10 ` [PATCH v3 0/6] mmc: imx: a few fixes and new feature Dong Aisheng
[not found] ` <20150729091027.GC16916-KgLukfWpBlCctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2015-07-30 9:44 ` Holger Schurig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438160637-28061-3-git-send-email-haibo.chen@freescale.com \
--to=haibo.chen@freescale.com \
--cc=aisheng.dong@freescale.com \
--cc=b29396@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=johan.derycke@barco.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).