devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Haibo Chen <haibo.chen@freescale.com>
To: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	shawnguo@kernel.org, kernel@pengutronix.de,
	linux@arm.linux.org.uk, ulf.hansson@linaro.org,
	aisheng.dong@freescale.com
Cc: johan.derycke@barco.com, mkl@pengutronix.de,
	haibo.chen@freescale.com, fabio.estevam@freescale.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org
Subject: [PATCH v6 5/6] mmc: sdhci-esdhc-imx: set back the burst_length_enable bit to 1
Date: Tue, 11 Aug 2015 19:38:30 +0800	[thread overview]
Message-ID: <1439293111-21077-6-git-send-email-haibo.chen@freescale.com> (raw)
In-Reply-To: <1439293111-21077-1-git-send-email-haibo.chen@freescale.com>

Currently we find that if a usdhc is choosed to boot system, then ROM
code will set the burst length enable bit of this usdhc as 0.

This will make performance drop a lot if this usdhc's burst length is
configed. So this patch set back the burst_length_enable bit as 1,
which is the default value, and means burst length is enabled for INCR.

Signed-off-by: Haibo Chen <haibo.chen@freescale.com>
---
 drivers/mmc/host/sdhci-esdhc-imx.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index 298551d..ac8ec01 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -32,6 +32,7 @@
 #include "sdhci-esdhc.h"
 
 #define	ESDHC_CTRL_D3CD			0x08
+#define ESDHC_BURST_LEN_EN_INCR		(1 << 27)
 /* VENDOR SPEC register */
 #define ESDHC_VENDOR_SPEC		0xc0
 #define  ESDHC_VENDOR_SPEC_SDIO_QUIRK	(1 << 1)
@@ -1163,6 +1164,21 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev)
 		host->quirks2 |= SDHCI_QUIRK2_PRESET_VALUE_BROKEN;
 		host->mmc->caps |= MMC_CAP_1_8V_DDR;
 
+		/*
+		 * ROM code will change the bit burst_length_enable setting
+		 * to zero if this usdhc is choosed to boot system. Change
+		 * it back here, otherwise it will impact the performance a
+		 * lot. This bit is used to enable/disable the burst length
+		 * for the external AHB2AXI bridge, it's usefully especially
+		 * for INCR transfer because without burst length indicator,
+		 * the AHB2AXI bridge does not know the burst length in
+		 * advance. And without burst length indicator, AHB INCR
+		 * transfer can only be converted to singles on the AXI side.
+		 */
+		writel(readl(host->ioaddr + SDHCI_HOST_CONTROL)
+			| ESDHC_BURST_LEN_EN_INCR,
+			host->ioaddr + SDHCI_HOST_CONTROL);
+
 		if (!(imx_data->socdata->flags & ESDHC_FLAG_HS200))
 			host->quirks2 |= SDHCI_QUIRK2_BROKEN_HS200;
 
-- 
1.9.1

  parent reply	other threads:[~2015-08-11 11:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11 11:38 [PATCH v6 0/6] mmc: imx: a few fixes and new feature Haibo Chen
2015-08-11 11:38 ` [PATCH v6 1/6] mmc: sdhci-esdhc-imx: add imx7d support and support HS400 Haibo Chen
2015-08-11 11:38 ` [PATCH v6 2/6] mmc: sdhci-esdhc-imx: add tuning-step setting support Haibo Chen
2015-08-11 11:38 ` [PATCH v6 3/6] mmc: sdhci-esdhc-imx: add imx7d support in bingding doc Haibo Chen
2015-08-11 11:38 ` [PATCH v6 4/6] ARM: dts: imx7d-sdb: add eMMC5.0 support Haibo Chen
     [not found]   ` <1439293111-21077-5-git-send-email-haibo.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-09-06  7:35     ` Shawn Guo
2015-08-11 11:38 ` Haibo Chen [this message]
     [not found] ` <1439293111-21077-1-git-send-email-haibo.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-08-11 11:38   ` [PATCH v6 6/6] mmc: sdhci-esdhc-imx: change default watermark level and burst length Haibo Chen
2015-08-13  8:58 ` [PATCH v6 0/6] mmc: imx: a few fixes and new feature Dong Aisheng
2015-08-25  3:34   ` Haibo Chen
2015-08-25 12:06 ` Ulf Hansson
2015-08-28  6:53   ` Chen Bough

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439293111-21077-6-git-send-email-haibo.chen@freescale.com \
    --to=haibo.chen@freescale.com \
    --cc=aisheng.dong@freescale.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@freescale.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=johan.derycke@barco.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=mkl@pengutronix.de \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).