From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27A7EC433EF for ; Mon, 14 Mar 2022 07:36:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231923AbiCNHha (ORCPT ); Mon, 14 Mar 2022 03:37:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236717AbiCNHh3 (ORCPT ); Mon, 14 Mar 2022 03:37:29 -0400 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0869E40E62 for ; Mon, 14 Mar 2022 00:36:19 -0700 (PDT) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 706633F4BE for ; Mon, 14 Mar 2022 07:36:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1647243378; bh=iAtSOaeLKxQsN9oiK9IKSKgSGPin9K0zGNTzo54gjLk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ejJ1McrfEU8hBrkyg9HYVguxj9Ylx7vnA1gvJSacWKkxNcaMpB3+GGVONaJg6ZiJd SsdzFwrRTf/skmDfOtZ0p6M+7Gg3ZOVW3jLqnttFuy6bLZE4jj/We1x1GheOwUC9KI lCB3UXDfpdHMBMD5h/mpSGO8JwJRbm8Um4rf13cl03rkQIlySUYmM1n40DMdbhewkc 3Hq24WAxYGV4OO3sLM0+tMFzv2njr2YEeEJQzNcLOyCt516n5SPLGTMwHO3Si7NkkV 0Wfu39dfl+KmyrYdruN7wtTXHCO2QalQOS9R8UsYkpz9XkZUpAmFtJeOp6Cfby2+zI s7hbpw1ls5T3g== Received: by mail-ed1-f70.google.com with SMTP id b9-20020aa7d489000000b0041669cd2cbfso8170586edr.16 for ; Mon, 14 Mar 2022 00:36:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=iAtSOaeLKxQsN9oiK9IKSKgSGPin9K0zGNTzo54gjLk=; b=SWf5xm1wHgG3s5sx8eB38fvyJx1l0N/+ZAFQNOALdWKWmFytnnMqD5/UcmBwpZQntz YWL5AsE4GYaspMlbwZgWX/V/mXvl7DTR3tWQpwyHaBWVvV39srFF1GiiNLcRXxU4G6vg 49TZPbZ1j+VfKhEIeZXy0Mb/i6/FN58mZgf9Y+nuJNHOg6n0uXYIdyAKIE5BpmpTbdIN BEwbirpf3ij24rPhirYY/gU+3GWuoAD1pARZW7qrBGjtH1TDQDiuOtjLfFsXkHtXHqFp yO9OnYtBcsO0uAe8qeOaybpNLKuBFsFmlysK2oO1l4Wk6BXgzmy4ztvGN/UVHXKh6En5 Zebg== X-Gm-Message-State: AOAM5328yvfcydB2meaXCsVABYBY+TbxxKj/m9joaMD0fhBZD7siq2vG Jes98rzAPtKjCDj0RqfXX1epNDNoeyEKYdd5zE8yoaaB3OrYh3+qSUwMh0Tua7w3HhXe/+OSrNh YRfyluSE87O5kygv5hrP1nuAdGOQGHxPabtYg6QU= X-Received: by 2002:a17:907:1614:b0:6db:e3f7:2cb4 with SMTP id hb20-20020a170907161400b006dbe3f72cb4mr255447ejc.435.1647243377975; Mon, 14 Mar 2022 00:36:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJycCN76EHq9M0eAQGZvA10vpA52jlIoM5/wMGxfvQsd+ClzDaAgk2gAPmK0IIzzn0h6WBnHrQ== X-Received: by 2002:a17:907:1614:b0:6db:e3f7:2cb4 with SMTP id hb20-20020a170907161400b006dbe3f72cb4mr255415ejc.435.1647243377741; Mon, 14 Mar 2022 00:36:17 -0700 (PDT) Received: from [192.168.0.152] (xdsl-188-155-174-239.adslplus.ch. [188.155.174.239]) by smtp.googlemail.com with ESMTPSA id z21-20020a1709063a1500b006da6436819dsm6448816eje.173.2022.03.14.00.36.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Mar 2022 00:36:17 -0700 (PDT) Message-ID: <143db512-0223-1553-c141-2dc24a23c430@canonical.com> Date: Mon, 14 Mar 2022 08:36:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 3/3] EDAC: nuvoton: Add NPCM memory controller driver Content-Language: en-US To: Medad Young Cc: rric@kernel.org, james.morse@arm.com, tony.luck@intel.com, mchehab@kernel.org, bp@alien8.de, robh+dt@kernel.org, Benjamin Fair , Nancy Yuen , Patrick Venture , KWLIU@nuvoton.com, YSCHU@nuvoton.com, JJLIU0@nuvoton.com, KFTING , avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, ctcchien@nuvoton.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, openbmc@lists.ozlabs.org References: <20220311014245.4612-1-ctcchien@nuvoton.com> <20220311014245.4612-4-ctcchien@nuvoton.com> <1f5e1e49-4ab0-5e06-fa8f-2a11b0fd1df9@canonical.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/03/2022 06:32, Medad Young wrote: > Krzysztof Kozlowski 於 2022年3月11日 > 週五 下午5:15寫道： >> >> On 11/03/2022 02:42, Medad CChien wrote: >>> Add support for Nuvoton NPCM SoC. >>> >>> Signed-off-by: Medad CChien >>> --- >>> drivers/edac/Kconfig | 9 + >>> drivers/edac/Makefile | 1 + >>> drivers/edac/npcm_edac.c | 714 +++++++++++++++++++++++++++++++++++++++ >>> 3 files changed, 724 insertions(+) >>> create mode 100644 drivers/edac/npcm_edac.c >>> >>> diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig >>> index 58ab63642e72..757e1d160640 100644 >>> --- a/drivers/edac/Kconfig >>> +++ b/drivers/edac/Kconfig >>> @@ -539,4 +539,13 @@ config EDAC_DMC520 >>> Support for error detection and correction on the >>> SoCs with ARM DMC-520 DRAM controller. >>> >>> +config EDAC_NPCM >>> + tristate "Nuvoton NPCM DDR Memory Controller" >>> + depends on ARCH_NPCM >> >> || COMPILE_TEST >> (and test if it compiles) >> >> (...) >> >>> + >>> +MODULE_DEVICE_TABLE(of, npcm_edac_of_match); >>> + >>> +static int npcm_edac_mc_probe(struct platform_device *pdev) >>> +{ >>> + const struct npcm_edac_platform_data *npcm_chip; >>> + struct device *dev = &pdev->dev; >>> + struct edac_mc_layer layers[1]; >>> + const struct of_device_id *id; >>> + struct priv_data *priv_data; >>> + struct mem_ctl_info *mci; >>> + struct resource *res; >>> + void __iomem *reg; >>> + int ret = -ENODEV; >>> + int irq; >>> + >>> + id = of_match_device(npcm_edac_of_match, &pdev->dev); >>> + if (!id) >>> + return -ENODEV; >> >> Why do you need it? How such case is even possible? > this driver is used for two nuvoton SOCs, one is NPCM845 and the other > is NPCM750 Yes and how NULL can happen for OF-only driver? Unless I missed something and this is not an OF-only driver? Do you allow any other matching methods? Best regards, Krzysztof