devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/5] ARM: dts: exynos5420: add support for hdmi subsystem
@ 2013-06-20  5:41 Rahul Sharma
  2013-06-20  5:41 ` [PATCH 1/5] ARM: dts: exynos5420: add i2c device nodes Rahul Sharma
                   ` (5 more replies)
  0 siblings, 6 replies; 13+ messages in thread
From: Rahul Sharma @ 2013-06-20  5:41 UTC (permalink / raw)
  To: linux-samsung-soc, devicetree-discuss
  Cc: kgene.kim, sw0312.kim, inki.dae, seanpaul, l.stach, tomasz.figa,
	rob.herring, s.nawrocki, grant.likely, joshi, r.sh.open,
	Rahul Sharma

Add dt nodes and clocks for hdmi subsystem. It also add pinctrl
node for hdmi hpd gpio and update binding documents.

This patch is based on v3.11-next/soc-exynos5420-pinctrl branch
at http://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git

device tree binding document for hdmi compatible type is update at
http://www.spinics.net/lists/dri-devel/msg39987.html

Andrew Bresticker (1):
  ARM: dts: exynos5420: add i2c device nodes

Rahul Sharma (4):
  ARM: dts: exynos5420: add dt nodes for hdmi subsystem
  ARM: dts: exynos5420: add clocks for hdmi subsystem
  ARM: dts: exynos5420: add hdmi hpd gpio pinctrl node
  ARM: dts: update binding documentation for hdmi subsystem

 .../devicetree/bindings/video/exynos_hdmi.txt      |   17 ++++-
 .../devicetree/bindings/video/exynos_mixer.txt     |    4 ++
 arch/arm/boot/dts/exynos5420-pinctrl.dtsi          |    7 ++
 arch/arm/boot/dts/exynos5420-smdk5420.dts          |   17 +++++
 arch/arm/boot/dts/exynos5420.dtsi                  |   74 ++++++++++++++++++++
 5 files changed, 116 insertions(+), 3 deletions(-)

-- 
1.7.10.4

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH 1/5] ARM: dts: exynos5420: add i2c device nodes
  2013-06-20  5:41 [PATCH 0/5] ARM: dts: exynos5420: add support for hdmi subsystem Rahul Sharma
@ 2013-06-20  5:41 ` Rahul Sharma
  2013-06-20  6:13   ` Chander Kashyap
  2013-06-20  5:41 ` [PATCH 2/5] ARM: dts: exynos5420: add dt nodes for hdmi subsystem Rahul Sharma
                   ` (4 subsequent siblings)
  5 siblings, 1 reply; 13+ messages in thread
From: Rahul Sharma @ 2013-06-20  5:41 UTC (permalink / raw)
  To: linux-samsung-soc, devicetree-discuss
  Cc: kgene.kim, sw0312.kim, inki.dae, seanpaul, l.stach, tomasz.figa,
	rob.herring, s.nawrocki, grant.likely, joshi, r.sh.open,
	Andrew Bresticker, Rahul Sharma

From: Andrew Bresticker <abrestic@chromium.org>

This adds device-tree nodes for the i2c busses on Exynos
5420 platforms.

Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5420.dtsi |   56 +++++++++++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 8c54c4b..b0ec047 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -24,6 +24,10 @@
 		pinctrl2 = &pinctrl_2;
 		pinctrl3 = &pinctrl_3;
 		pinctrl4 = &pinctrl_4;
+		i2c0 = &i2c_0;
+		i2c1 = &i2c_1;
+		i2c2 = &i2c_2;
+		i2c3 = &i2c_3;
 	};
 
 	cpus {
@@ -145,4 +149,56 @@
 		clocks = <&clock 260>, <&clock 131>;
 		clock-names = "uart", "clk_uart_baud0";
 	};
+
+	i2c_0: i2c@12C60000 {
+		compatible = "samsung,s3c2440-i2c";
+		reg = <0x12C60000 0x100>;
+		interrupts = <0 56 0>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c0_bus>;
+		clocks = <&clock 261>;
+		clock-names = "i2c";
+		status = "disabled";
+	};
+
+	i2c_1: i2c@12C70000 {
+		compatible = "samsung,s3c2440-i2c";
+		reg = <0x12C70000 0x100>;
+		interrupts = <0 57 0>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c1_bus>;
+		clocks = <&clock 262>;
+		clock-names = "i2c";
+		status = "disabled";
+	};
+
+	i2c_2: i2c@12C80000 {
+		compatible = "samsung,s3c2440-i2c";
+		reg = <0x12C80000 0x100>;
+		interrupts = <0 58 0>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c2_bus>;
+		clocks = <&clock 263>;
+		clock-names = "i2c";
+		status = "disabled";
+	};
+
+	i2c_3: i2c@12C90000 {
+		compatible = "samsung,s3c2440-i2c";
+		reg = <0x12C90000 0x100>;
+		interrupts = <0 59 0>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c3_bus>;
+		clocks = <&clock 264>;
+		clock-names = "i2c";
+		status = "disabled";
+	};
 };
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 2/5] ARM: dts: exynos5420: add dt nodes for hdmi subsystem
  2013-06-20  5:41 [PATCH 0/5] ARM: dts: exynos5420: add support for hdmi subsystem Rahul Sharma
  2013-06-20  5:41 ` [PATCH 1/5] ARM: dts: exynos5420: add i2c device nodes Rahul Sharma
@ 2013-06-20  5:41 ` Rahul Sharma
       [not found]   ` <1371706911-27016-3-git-send-email-rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
  2013-06-20  5:41 ` [PATCH 3/5] ARM: dts: exynos5420: add clocks " Rahul Sharma
                   ` (3 subsequent siblings)
  5 siblings, 1 reply; 13+ messages in thread
From: Rahul Sharma @ 2013-06-20  5:41 UTC (permalink / raw)
  To: linux-samsung-soc, devicetree-discuss
  Cc: kgene.kim, sw0312.kim, inki.dae, seanpaul, l.stach, tomasz.figa,
	rob.herring, s.nawrocki, grant.likely, joshi, r.sh.open,
	Rahul Sharma

Add hdmi, mixer, ddc device tree nodes for Exynos 5420 SoC.

Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5420-smdk5420.dts |   15 +++++++++++++++
 arch/arm/boot/dts/exynos5420.dtsi         |   12 ++++++++++++
 2 files changed, 27 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index 08607df..b3721bd 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -30,4 +30,19 @@
 			clock-frequency = <24000000>;
 		};
 	};
+
+	hdmi {
+		hpd-gpio = <&gpx3 7 0>;
+	};
+
+	i2c_2: i2c@12C80000 {
+		samsung,i2c-sda-delay = <100>;
+		samsung,i2c-max-bus-freq = <66000>;
+		status = "okay";
+
+		hdmiddc@50 {
+			compatible = "samsung,exynos4210-hdmiddc";
+			reg = <0x50>;
+		};
+	};
 };
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index b0ec047..45aadf9 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -201,4 +201,16 @@
 		clock-names = "i2c";
 		status = "disabled";
 	};
+
+	hdmi {
+		compatible = "samsung,exynos4212-hdmi";
+		reg = <0x14530000 0x70000>;
+		interrupts = <0 95 0>;
+	};
+
+	mixer: mixer@14450000 {
+		compatible = "samsung,exynos5420-mixer";
+		reg = <0x14450000 0x10000>;
+		interrupts = <0 94 0>;
+	};
 };
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 3/5] ARM: dts: exynos5420: add clocks for hdmi subsystem
  2013-06-20  5:41 [PATCH 0/5] ARM: dts: exynos5420: add support for hdmi subsystem Rahul Sharma
  2013-06-20  5:41 ` [PATCH 1/5] ARM: dts: exynos5420: add i2c device nodes Rahul Sharma
  2013-06-20  5:41 ` [PATCH 2/5] ARM: dts: exynos5420: add dt nodes for hdmi subsystem Rahul Sharma
@ 2013-06-20  5:41 ` Rahul Sharma
  2013-06-20  5:41 ` [PATCH 4/5] ARM: dts: exynos5420: add hdmi hpd gpio pinctrl node Rahul Sharma
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 13+ messages in thread
From: Rahul Sharma @ 2013-06-20  5:41 UTC (permalink / raw)
  To: linux-samsung-soc, devicetree-discuss
  Cc: kgene.kim, sw0312.kim, inki.dae, seanpaul, l.stach, tomasz.figa,
	rob.herring, s.nawrocki, grant.likely, joshi, r.sh.open,
	Rahul Sharma

Add clocks for hdmi and mixer for exynos5420 SoC.

Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5420.dtsi |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 45aadf9..60685a2 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -206,11 +206,17 @@
 		compatible = "samsung,exynos4212-hdmi";
 		reg = <0x14530000 0x70000>;
 		interrupts = <0 95 0>;
+		clocks = <&clock 413>, <&clock 143>, <&clock 144>,
+			<&clock 158>, <&clock 1024>;
+		clock-names = "hdmi", "sclk_hdmi", "sclk_pixel",
+			"sclk_hdmiphy", "mout_hdmi";
 	};
 
 	mixer: mixer@14450000 {
 		compatible = "samsung,exynos5420-mixer";
 		reg = <0x14450000 0x10000>;
 		interrupts = <0 94 0>;
+		clocks = <&clock 431>, <&clock 143>;
+		clock-names = "mixer", "sclk_hdmi";
 	};
 };
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 4/5] ARM: dts: exynos5420: add hdmi hpd gpio pinctrl node
  2013-06-20  5:41 [PATCH 0/5] ARM: dts: exynos5420: add support for hdmi subsystem Rahul Sharma
                   ` (2 preceding siblings ...)
  2013-06-20  5:41 ` [PATCH 3/5] ARM: dts: exynos5420: add clocks " Rahul Sharma
@ 2013-06-20  5:41 ` Rahul Sharma
  2013-06-20  7:09   ` Tomasz Figa
  2013-06-20  5:41 ` [PATCH 5/5] ARM: dts: update binding documentation for hdmi subsystem Rahul Sharma
  2013-06-20  6:15 ` [PATCH 0/5] ARM: dts: exynos5420: add support " Chander Kashyap
  5 siblings, 1 reply; 13+ messages in thread
From: Rahul Sharma @ 2013-06-20  5:41 UTC (permalink / raw)
  To: linux-samsung-soc, devicetree-discuss
  Cc: kgene.kim, sw0312.kim, inki.dae, seanpaul, l.stach, tomasz.figa,
	rob.herring, s.nawrocki, grant.likely, joshi, r.sh.open,
	Rahul Sharma

Add pinctrl node for hdmi-hpd gpio pin to exynos5420
device tree files.

Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5420-pinctrl.dtsi |    7 +++++++
 arch/arm/boot/dts/exynos5420-smdk5420.dts |    2 ++
 2 files changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
index 5848c42..5706ad9 100644
--- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
@@ -59,6 +59,13 @@
 			interrupt-controller;
 			#interrupt-cells = <2>;
 		};
+
+		hdmi_hpd_irq: hdmi-hpd-irq {
+		        samsung,pins = "gpx3-7";
+			samsung,pin-function = <0>;
+			samsung,pin-pud = <1>;
+			samsung,pin-drv = <0>;
+		};
 	};
 
 	pinctrl@13410000 {
diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index b3721bd..2d6c74f 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -33,6 +33,8 @@
 
 	hdmi {
 		hpd-gpio = <&gpx3 7 0>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&hdmi_hpd_irq>;
 	};
 
 	i2c_2: i2c@12C80000 {
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 5/5] ARM: dts: update binding documentation for hdmi subsystem
  2013-06-20  5:41 [PATCH 0/5] ARM: dts: exynos5420: add support for hdmi subsystem Rahul Sharma
                   ` (3 preceding siblings ...)
  2013-06-20  5:41 ` [PATCH 4/5] ARM: dts: exynos5420: add hdmi hpd gpio pinctrl node Rahul Sharma
@ 2013-06-20  5:41 ` Rahul Sharma
  2013-06-20  6:37   ` Sachin Kamat
  2013-06-20  6:15 ` [PATCH 0/5] ARM: dts: exynos5420: add support " Chander Kashyap
  5 siblings, 1 reply; 13+ messages in thread
From: Rahul Sharma @ 2013-06-20  5:41 UTC (permalink / raw)
  To: linux-samsung-soc, devicetree-discuss
  Cc: kgene.kim, sw0312.kim, inki.dae, seanpaul, l.stach, tomasz.figa,
	rob.herring, s.nawrocki, grant.likely, joshi, r.sh.open,
	Rahul Sharma

Adding information about clocks to mixer and hdmi dt
nodes. Also removed the updated fields for hpd property.

Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
---
 .../devicetree/bindings/video/exynos_hdmi.txt         |   17 ++++++++++++++---
 .../devicetree/bindings/video/exynos_mixer.txt        |    4 ++++
 2 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/video/exynos_hdmi.txt b/Documentation/devicetree/bindings/video/exynos_hdmi.txt
index 589edee..5dca3af 100644
--- a/Documentation/devicetree/bindings/video/exynos_hdmi.txt
+++ b/Documentation/devicetree/bindings/video/exynos_hdmi.txt
@@ -8,9 +8,20 @@ Required properties:
 - hpd-gpio: following information about the hotplug gpio pin.
 	a) phandle of the gpio controller node.
 	b) pin number within the gpio controller.
-	c) pin function mode.
-	d) optional flags and pull up/down.
-	e) drive strength.
+	c) optional flags and pull up/down.
+- clocks: list of clock IDs from SoC clock driver.
+	a) hdmi: It is required for gate operation on aclk_200_disp1 clock
+		which clocks the display1 block.
+	b) sclk_hdmi: It is required for gate operation on sclk_hdmi clock
+		which clocks hdmi IP.
+	c) sclk_pixel: Parent for mux mout_hdmi.
+	d) sclk_hdmiphy: Parent for mux mout_hdmi.
+	e) mout_hdmi: It is required by the driver to switch between the 2
+		parents i.e. sclk_pixel and sclk_hdmiphy. If hdmiphy is stable
+		after configuration, parent is set to sclk_hdmiphy else
+		sclk_pixel.
+- clock-names: aliases as per driver requirements for above clock IDs:
+	"hdmi", "sclk_hdmi", "sclk_pixel", "sclk_hdmiphy" and "mout_hdmi".
 
 Example:
 
diff --git a/Documentation/devicetree/bindings/video/exynos_mixer.txt b/Documentation/devicetree/bindings/video/exynos_mixer.txt
index 9b2ea03..54790a2 100644
--- a/Documentation/devicetree/bindings/video/exynos_mixer.txt
+++ b/Documentation/devicetree/bindings/video/exynos_mixer.txt
@@ -5,6 +5,10 @@ Required properties:
 - reg: physical base address of the mixer and length of memory mapped
 	region.
 - interrupts: interrupt number to the cpu.
+- clocks: list of clock IDs from SoC clock driver.
+	a) mixer: It is required for gate operation on aclk_200_disp1 clock
+		which clocks the display1 block.
+	b) sclk_hdmi: Parent for mux mout_mixer.
 
 Example:
 
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH 1/5] ARM: dts: exynos5420: add i2c device nodes
  2013-06-20  5:41 ` [PATCH 1/5] ARM: dts: exynos5420: add i2c device nodes Rahul Sharma
@ 2013-06-20  6:13   ` Chander Kashyap
  0 siblings, 0 replies; 13+ messages in thread
From: Chander Kashyap @ 2013-06-20  6:13 UTC (permalink / raw)
  To: Rahul Sharma
  Cc: linux-samsung-soc@vger.kernel.org, devicetree-discuss,
	kgene.kim@samsung.com, sw0312.kim, inki.dae, seanpaul, l.stach,
	Tomasz Figa, Rob Herring, s.nawrocki@samsung.com, Grant Likely,
	joshi, r.sh.open, Andrew Bresticker

On 20 June 2013 11:11, Rahul Sharma <rahul.sharma@samsung.com> wrote:
> From: Andrew Bresticker <abrestic@chromium.org>
>
> This adds device-tree nodes for the i2c busses on Exynos
> 5420 platforms.
>
> Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5420.dtsi |   56 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 56 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index 8c54c4b..b0ec047 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -24,6 +24,10 @@
>                 pinctrl2 = &pinctrl_2;
>                 pinctrl3 = &pinctrl_3;
>                 pinctrl4 = &pinctrl_4;
> +               i2c0 = &i2c_0;
> +               i2c1 = &i2c_1;
> +               i2c2 = &i2c_2;
> +               i2c3 = &i2c_3;
>         };
>
>         cpus {
> @@ -145,4 +149,56 @@
>                 clocks = <&clock 260>, <&clock 131>;
>                 clock-names = "uart", "clk_uart_baud0";
>         };
> +
> +       i2c_0: i2c@12C60000 {
> +               compatible = "samsung,s3c2440-i2c";
> +               reg = <0x12C60000 0x100>;
> +               interrupts = <0 56 0>;
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&i2c0_bus>;
> +               clocks = <&clock 261>;
> +               clock-names = "i2c";
> +               status = "disabled";
> +       };
Please move the common properties of exynos5250 and exynos5420 to exynos5.dtsi.
> +
> +       i2c_1: i2c@12C70000 {
> +               compatible = "samsung,s3c2440-i2c";
> +               reg = <0x12C70000 0x100>;
> +               interrupts = <0 57 0>;
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&i2c1_bus>;
> +               clocks = <&clock 262>;
> +               clock-names = "i2c";
> +               status = "disabled";
> +       };
> +
> +       i2c_2: i2c@12C80000 {
> +               compatible = "samsung,s3c2440-i2c";
> +               reg = <0x12C80000 0x100>;
> +               interrupts = <0 58 0>;
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&i2c2_bus>;
> +               clocks = <&clock 263>;
> +               clock-names = "i2c";
> +               status = "disabled";
> +       };
> +
> +       i2c_3: i2c@12C90000 {
> +               compatible = "samsung,s3c2440-i2c";
> +               reg = <0x12C90000 0x100>;
> +               interrupts = <0 59 0>;
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&i2c3_bus>;
> +               clocks = <&clock 264>;
> +               clock-names = "i2c";
> +               status = "disabled";
> +       };
>  };
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



--
with warm regards,
Chander Kashyap

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 0/5] ARM: dts: exynos5420: add support for hdmi subsystem
  2013-06-20  5:41 [PATCH 0/5] ARM: dts: exynos5420: add support for hdmi subsystem Rahul Sharma
                   ` (4 preceding siblings ...)
  2013-06-20  5:41 ` [PATCH 5/5] ARM: dts: update binding documentation for hdmi subsystem Rahul Sharma
@ 2013-06-20  6:15 ` Chander Kashyap
  2013-06-20  6:45   ` Rahul Sharma
  5 siblings, 1 reply; 13+ messages in thread
From: Chander Kashyap @ 2013-06-20  6:15 UTC (permalink / raw)
  To: Rahul Sharma
  Cc: linux-samsung-soc@vger.kernel.org, devicetree-discuss,
	kgene.kim@samsung.com, sw0312.kim, inki.dae, seanpaul, l.stach,
	Tomasz Figa, Rob Herring, s.nawrocki@samsung.com, Grant Likely,
	joshi, r.sh.open

On 20 June 2013 11:11, Rahul Sharma <rahul.sharma@samsung.com> wrote:
> Add dt nodes and clocks for hdmi subsystem. It also add pinctrl
> node for hdmi hpd gpio and update binding documents.
>
> This patch is based on v3.11-next/soc-exynos5420-pinctrl branch
> at http://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git
>
> device tree binding document for hdmi compatible type is update at
> http://www.spinics.net/lists/dri-devel/msg39987.html
>
> Andrew Bresticker (1):
>   ARM: dts: exynos5420: add i2c device nodes
>
> Rahul Sharma (4):
>   ARM: dts: exynos5420: add dt nodes for hdmi subsystem
>   ARM: dts: exynos5420: add clocks for hdmi subsystem
>   ARM: dts: exynos5420: add hdmi hpd gpio pinctrl node
>   ARM: dts: update binding documentation for hdmi subsystem
While populating exnos5420.dtsi, move nodes with common properties
across exynos5420 and exynos5420 to exynos5.dtsi
>
>  .../devicetree/bindings/video/exynos_hdmi.txt      |   17 ++++-
>  .../devicetree/bindings/video/exynos_mixer.txt     |    4 ++
>  arch/arm/boot/dts/exynos5420-pinctrl.dtsi          |    7 ++
>  arch/arm/boot/dts/exynos5420-smdk5420.dts          |   17 +++++
>  arch/arm/boot/dts/exynos5420.dtsi                  |   74 ++++++++++++++++++++
>  5 files changed, 116 insertions(+), 3 deletions(-)
>
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



--
with warm regards,
Chander Kashyap

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 5/5] ARM: dts: update binding documentation for hdmi subsystem
  2013-06-20  5:41 ` [PATCH 5/5] ARM: dts: update binding documentation for hdmi subsystem Rahul Sharma
@ 2013-06-20  6:37   ` Sachin Kamat
  0 siblings, 0 replies; 13+ messages in thread
From: Sachin Kamat @ 2013-06-20  6:37 UTC (permalink / raw)
  To: Rahul Sharma
  Cc: linux-samsung-soc, devicetree-discuss, kgene.kim, sw0312.kim,
	inki.dae, seanpaul, l.stach, tomasz.figa, rob.herring, s.nawrocki,
	grant.likely, joshi, r.sh.open

On 20 June 2013 11:11, Rahul Sharma <rahul.sharma@samsung.com> wrote:
> Adding information about clocks to mixer and hdmi dt
> nodes. Also removed the updated fields for hpd property.
>
> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>

Please rebase you patch on top of [1] or fold this into it.

[1] http://permalink.gmane.org/gmane.linux.drivers.devicetree/36162


> ---
>  .../devicetree/bindings/video/exynos_hdmi.txt         |   17 ++++++++++++++---
>  .../devicetree/bindings/video/exynos_mixer.txt        |    4 ++++
>  2 files changed, 18 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/video/exynos_hdmi.txt b/Documentation/devicetree/bindings/video/exynos_hdmi.txt
> index 589edee..5dca3af 100644
> --- a/Documentation/devicetree/bindings/video/exynos_hdmi.txt
> +++ b/Documentation/devicetree/bindings/video/exynos_hdmi.txt
> @@ -8,9 +8,20 @@ Required properties:
>  - hpd-gpio: following information about the hotplug gpio pin.
>         a) phandle of the gpio controller node.
>         b) pin number within the gpio controller.
> -       c) pin function mode.
> -       d) optional flags and pull up/down.
> -       e) drive strength.
> +       c) optional flags and pull up/down.
> +- clocks: list of clock IDs from SoC clock driver.
> +       a) hdmi: It is required for gate operation on aclk_200_disp1 clock
> +               which clocks the display1 block.
> +       b) sclk_hdmi: It is required for gate operation on sclk_hdmi clock
> +               which clocks hdmi IP.
> +       c) sclk_pixel: Parent for mux mout_hdmi.
> +       d) sclk_hdmiphy: Parent for mux mout_hdmi.
> +       e) mout_hdmi: It is required by the driver to switch between the 2
> +               parents i.e. sclk_pixel and sclk_hdmiphy. If hdmiphy is stable
> +               after configuration, parent is set to sclk_hdmiphy else
> +               sclk_pixel.
> +- clock-names: aliases as per driver requirements for above clock IDs:
> +       "hdmi", "sclk_hdmi", "sclk_pixel", "sclk_hdmiphy" and "mout_hdmi".
>
>  Example:
>
> diff --git a/Documentation/devicetree/bindings/video/exynos_mixer.txt b/Documentation/devicetree/bindings/video/exynos_mixer.txt
> index 9b2ea03..54790a2 100644
> --- a/Documentation/devicetree/bindings/video/exynos_mixer.txt
> +++ b/Documentation/devicetree/bindings/video/exynos_mixer.txt
> @@ -5,6 +5,10 @@ Required properties:
>  - reg: physical base address of the mixer and length of memory mapped
>         region.
>  - interrupts: interrupt number to the cpu.
> +- clocks: list of clock IDs from SoC clock driver.
> +       a) mixer: It is required for gate operation on aclk_200_disp1 clock
> +               which clocks the display1 block.
> +       b) sclk_hdmi: Parent for mux mout_mixer.
>
>  Example:
>
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
With warm regards,
Sachin

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 2/5] ARM: dts: exynos5420: add dt nodes for hdmi subsystem
       [not found]   ` <1371706911-27016-3-git-send-email-rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
@ 2013-06-20  6:38     ` Sachin Kamat
  2013-06-20  6:43       ` Rahul Sharma
  0 siblings, 1 reply; 13+ messages in thread
From: Sachin Kamat @ 2013-06-20  6:38 UTC (permalink / raw)
  To: Rahul Sharma
  Cc: kgene.kim-Sze3O3UU22JBDgjK7y7TUQ,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
	sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
	tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w,
	rob.herring-bsGFqQB8/DxBDgjK7y7TUQ, joshi-Sze3O3UU22JBDgjK7y7TUQ,
	inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
	linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
	s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ,
	grant.likely-QSEj5FYQhm4dnm+yROfE0A,
	r.sh.open-Re5JQEeQqe8AvxtiuMwx3w, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ

On 20 June 2013 11:11, Rahul Sharma <rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> Add hdmi, mixer, ddc device tree nodes for Exynos 5420 SoC.
>
> Signed-off-by: Rahul Sharma <rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
>  arch/arm/boot/dts/exynos5420-smdk5420.dts |   15 +++++++++++++++
>  arch/arm/boot/dts/exynos5420.dtsi         |   12 ++++++++++++
>  2 files changed, 27 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> index 08607df..b3721bd 100644
> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> @@ -30,4 +30,19 @@
>                         clock-frequency = <24000000>;
>                 };
>         };
> +
> +       hdmi {
> +               hpd-gpio = <&gpx3 7 0>;
> +       };
> +
> +       i2c_2: i2c@12C80000 {
> +               samsung,i2c-sda-delay = <100>;
> +               samsung,i2c-max-bus-freq = <66000>;
> +               status = "okay";
> +
> +               hdmiddc@50 {
> +                       compatible = "samsung,exynos4210-hdmiddc";
> +                       reg = <0x50>;
> +               };
> +       };
>  };
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index b0ec047..45aadf9 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -201,4 +201,16 @@
>                 clock-names = "i2c";
>                 status = "disabled";
>         };
> +
> +       hdmi {
> +               compatible = "samsung,exynos4212-hdmi";
> +               reg = <0x14530000 0x70000>;
> +               interrupts = <0 95 0>;
> +       };
> +
> +       mixer: mixer@14450000 {
> +               compatible = "samsung,exynos5420-mixer";
> +               reg = <0x14450000 0x10000>;
> +               interrupts = <0 94 0>;
> +       };

If these are the parent nodes, disable them here and enable in the board files.


-- 
With warm regards,
Sachin

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 2/5] ARM: dts: exynos5420: add dt nodes for hdmi subsystem
  2013-06-20  6:38     ` Sachin Kamat
@ 2013-06-20  6:43       ` Rahul Sharma
  0 siblings, 0 replies; 13+ messages in thread
From: Rahul Sharma @ 2013-06-20  6:43 UTC (permalink / raw)
  To: Sachin Kamat
  Cc: Rahul Sharma, linux-samsung-soc, devicetree-discuss, kgene.kim,
	sw0312.kim, inki.dae, seanpaul, l.stach, tomasz.figa, rob.herring,
	s.nawrocki, grant.likely, joshi

ok Sachin. Thanks.

On Thu, Jun 20, 2013 at 12:08 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> On 20 June 2013 11:11, Rahul Sharma <rahul.sharma@samsung.com> wrote:
>> Add hdmi, mixer, ddc device tree nodes for Exynos 5420 SoC.
>>
>> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos5420-smdk5420.dts |   15 +++++++++++++++
>>  arch/arm/boot/dts/exynos5420.dtsi         |   12 ++++++++++++
>>  2 files changed, 27 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> index 08607df..b3721bd 100644
>> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> @@ -30,4 +30,19 @@
>>                         clock-frequency = <24000000>;
>>                 };
>>         };
>> +
>> +       hdmi {
>> +               hpd-gpio = <&gpx3 7 0>;
>> +       };
>> +
>> +       i2c_2: i2c@12C80000 {
>> +               samsung,i2c-sda-delay = <100>;
>> +               samsung,i2c-max-bus-freq = <66000>;
>> +               status = "okay";
>> +
>> +               hdmiddc@50 {
>> +                       compatible = "samsung,exynos4210-hdmiddc";
>> +                       reg = <0x50>;
>> +               };
>> +       };
>>  };
>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
>> index b0ec047..45aadf9 100644
>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> @@ -201,4 +201,16 @@
>>                 clock-names = "i2c";
>>                 status = "disabled";
>>         };
>> +
>> +       hdmi {
>> +               compatible = "samsung,exynos4212-hdmi";
>> +               reg = <0x14530000 0x70000>;
>> +               interrupts = <0 95 0>;
>> +       };
>> +
>> +       mixer: mixer@14450000 {
>> +               compatible = "samsung,exynos5420-mixer";
>> +               reg = <0x14450000 0x10000>;
>> +               interrupts = <0 94 0>;
>> +       };
>
> If these are the parent nodes, disable them here and enable in the board files.
>
>
> --
> With warm regards,
> Sachin

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 0/5] ARM: dts: exynos5420: add support for hdmi subsystem
  2013-06-20  6:15 ` [PATCH 0/5] ARM: dts: exynos5420: add support " Chander Kashyap
@ 2013-06-20  6:45   ` Rahul Sharma
  0 siblings, 0 replies; 13+ messages in thread
From: Rahul Sharma @ 2013-06-20  6:45 UTC (permalink / raw)
  To: Chander Kashyap
  Cc: Rahul Sharma, linux-samsung-soc@vger.kernel.org,
	devicetree-discuss, kgene.kim@samsung.com, sw0312.kim, inki.dae,
	seanpaul, l.stach, Tomasz Figa, Rob Herring,
	s.nawrocki@samsung.com, Grant Likely, joshi

Thanks Chander,

I am posting v2 with the suggested changes.

regards,
Rahul Sharma.

On Thu, Jun 20, 2013 at 11:45 AM, Chander Kashyap
<chander.kashyap@linaro.org> wrote:
> On 20 June 2013 11:11, Rahul Sharma <rahul.sharma@samsung.com> wrote:
>> Add dt nodes and clocks for hdmi subsystem. It also add pinctrl
>> node for hdmi hpd gpio and update binding documents.
>>
>> This patch is based on v3.11-next/soc-exynos5420-pinctrl branch
>> at http://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git
>>
>> device tree binding document for hdmi compatible type is update at
>> http://www.spinics.net/lists/dri-devel/msg39987.html
>>
>> Andrew Bresticker (1):
>>   ARM: dts: exynos5420: add i2c device nodes
>>
>> Rahul Sharma (4):
>>   ARM: dts: exynos5420: add dt nodes for hdmi subsystem
>>   ARM: dts: exynos5420: add clocks for hdmi subsystem
>>   ARM: dts: exynos5420: add hdmi hpd gpio pinctrl node
>>   ARM: dts: update binding documentation for hdmi subsystem
> While populating exnos5420.dtsi, move nodes with common properties
> across exynos5420 and exynos5420 to exynos5.dtsi
>>
>>  .../devicetree/bindings/video/exynos_hdmi.txt      |   17 ++++-
>>  .../devicetree/bindings/video/exynos_mixer.txt     |    4 ++
>>  arch/arm/boot/dts/exynos5420-pinctrl.dtsi          |    7 ++
>>  arch/arm/boot/dts/exynos5420-smdk5420.dts          |   17 +++++
>>  arch/arm/boot/dts/exynos5420.dtsi                  |   74 ++++++++++++++++++++
>>  5 files changed, 116 insertions(+), 3 deletions(-)
>>
>> --
>> 1.7.10.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>
>
> --
> with warm regards,
> Chander Kashyap

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 4/5] ARM: dts: exynos5420: add hdmi hpd gpio pinctrl node
  2013-06-20  5:41 ` [PATCH 4/5] ARM: dts: exynos5420: add hdmi hpd gpio pinctrl node Rahul Sharma
@ 2013-06-20  7:09   ` Tomasz Figa
  0 siblings, 0 replies; 13+ messages in thread
From: Tomasz Figa @ 2013-06-20  7:09 UTC (permalink / raw)
  To: Rahul Sharma
  Cc: linux-samsung-soc, devicetree-discuss, kgene.kim, sw0312.kim,
	inki.dae, seanpaul, l.stach, rob.herring, s.nawrocki,
	grant.likely, joshi, r.sh.open

Hi Rahul,

On Thursday 20 of June 2013 11:11:50 Rahul Sharma wrote:
> Add pinctrl node for hdmi-hpd gpio pin to exynos5420
> device tree files.
> 
> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5420-pinctrl.dtsi |    7 +++++++
>  arch/arm/boot/dts/exynos5420-smdk5420.dts |    2 ++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi index 5848c42..5706ad9
> 100644
> --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> @@ -59,6 +59,13 @@
>  			interrupt-controller;
>  			#interrupt-cells = <2>;
>  		};
> +
> +		hdmi_hpd_irq: hdmi-hpd-irq {
> +		        samsung,pins = "gpx3-7";
> +			samsung,pin-function = <0>;
> +			samsung,pin-pud = <1>;
> +			samsung,pin-drv = <0>;
> +		};

This looks like a board-specific pinconf entry. It should be specified in 
the dts of appropriate board, in this case exynos5420-smdk5420.dts .

Best regards,
Tomasz

>  	};
> 
>  	pinctrl@13410000 {
> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts
> b/arch/arm/boot/dts/exynos5420-smdk5420.dts index b3721bd..2d6c74f
> 100644
> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> @@ -33,6 +33,8 @@
> 
>  	hdmi {
>  		hpd-gpio = <&gpx3 7 0>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&hdmi_hpd_irq>;
>  	};
> 
>  	i2c_2: i2c@12C80000 {

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2013-06-20  7:09 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-20  5:41 [PATCH 0/5] ARM: dts: exynos5420: add support for hdmi subsystem Rahul Sharma
2013-06-20  5:41 ` [PATCH 1/5] ARM: dts: exynos5420: add i2c device nodes Rahul Sharma
2013-06-20  6:13   ` Chander Kashyap
2013-06-20  5:41 ` [PATCH 2/5] ARM: dts: exynos5420: add dt nodes for hdmi subsystem Rahul Sharma
     [not found]   ` <1371706911-27016-3-git-send-email-rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-06-20  6:38     ` Sachin Kamat
2013-06-20  6:43       ` Rahul Sharma
2013-06-20  5:41 ` [PATCH 3/5] ARM: dts: exynos5420: add clocks " Rahul Sharma
2013-06-20  5:41 ` [PATCH 4/5] ARM: dts: exynos5420: add hdmi hpd gpio pinctrl node Rahul Sharma
2013-06-20  7:09   ` Tomasz Figa
2013-06-20  5:41 ` [PATCH 5/5] ARM: dts: update binding documentation for hdmi subsystem Rahul Sharma
2013-06-20  6:37   ` Sachin Kamat
2013-06-20  6:15 ` [PATCH 0/5] ARM: dts: exynos5420: add support " Chander Kashyap
2013-06-20  6:45   ` Rahul Sharma

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).