From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH v2] QEMU fw_cfg DMA interface documentation Date: Mon, 07 Sep 2015 13:08:29 +0200 Message-ID: <1441624109.27149.18.camel@redhat.com> References: <1441012133-8154-1-git-send-email-markmb@redhat.com> <1441012303-8261-1-git-send-email-markmb@redhat.com> <20150902103311.5335d469@markmb_rh> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150902103311.5335d469@markmb_rh> Sender: linux-kernel-owner@vger.kernel.org To: Marc =?ISO-8859-1?Q?Mar=ED?= Cc: Stefan Hajnoczi , linux-kernel , Drew , Kevin O'Connor , Laszlo , Arnd Bergmann , Rob Herring , Mark Rutland , Alexander Graf , devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi, > It's just simplicity. If you want to read a few times from the same > field (like in ACPI tables, read the data size and then the data), you > need a way to enable and disable the selector and manage the current > offset for that entry. This is already provided with the "old" > interface. Could be handled with a 'select' control bit. Only when set select entry and reset offset to zero. Also: would it make sense to allow an *array* of FWCfgDmaAccess structs? With a 'more' bit in control we could indicate that there are more entries. I'm not sure firmware would actually use that though ... cheers, Gerd