From: Andreas Dannenberg <dannenberg@ti.com>
To: Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Laurentiu Palcu <laurentiu.palcu@intel.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
Andreas Dannenberg <dannenberg@ti.com>
Subject: [PATCH v2 08/13] power: bq24257: Add charge type setting support
Date: Tue, 8 Sep 2015 19:12:32 -0500 [thread overview]
Message-ID: <1441757557-7266-9-git-send-email-dannenberg@ti.com> (raw)
In-Reply-To: <1441757557-7266-1-git-send-email-dannenberg@ti.com>
The bq2425x devices support charging with a configurable charge current
i_chg or a specific fixed low-current in what's called Low Charge mode.
This patch exposes access to the Low Charge mode through a POWER_
SUPPLY_PROP_CHARGE_TYPE sysfs property value of POWER_SUPPLY_CHARGE_
TYPE_TRICKLE. It also allows to completely disable charging if desired
by setting the property to POWER_SUPPLY_CHARGE_TYPE_NONE. Normal
charging with the configured i_chg current is activated through
POWER_SUPPLY_CHARGE_TYPE_FAST (default).
Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
---
drivers/power/bq24257_charger.c | 90 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 90 insertions(+)
diff --git a/drivers/power/bq24257_charger.c b/drivers/power/bq24257_charger.c
index f0d4307..886040c 100644
--- a/drivers/power/bq24257_charger.c
+++ b/drivers/power/bq24257_charger.c
@@ -265,6 +265,56 @@ enum bq24257_fault {
FAULT_INPUT_LDO_LOW,
};
+static int bq24257_get_charge_type(struct bq24257_device *bq,
+ union power_supply_propval *val)
+{
+ int ret;
+
+ ret = bq24257_field_read(bq, F_CE);
+ if (ret < 0)
+ return ret;
+
+ /* Charge Enable is active-low */
+ if (ret) {
+ val->intval = POWER_SUPPLY_CHARGE_TYPE_NONE;
+ return 0;
+ }
+
+ /* Low Charge means a fixed low-current is used instead of i_chg */
+ ret = bq24257_field_read(bq, F_LOW_CHG);
+ if (ret < 0)
+ return ret;
+
+ val->intval = ret ? POWER_SUPPLY_CHARGE_TYPE_TRICKLE :
+ POWER_SUPPLY_CHARGE_TYPE_FAST;
+
+ return 0;
+}
+
+static int bq24257_set_charge_type(struct bq24257_device *bq,
+ const union power_supply_propval *val)
+{
+ int ret;
+
+ switch (val->intval) {
+ case POWER_SUPPLY_CHARGE_TYPE_NONE:
+ return bq24257_field_write(bq, F_CE, 1);
+ case POWER_SUPPLY_CHARGE_TYPE_TRICKLE:
+ ret = bq24257_field_write(bq, F_LOW_CHG, 1);
+ break;
+ case POWER_SUPPLY_CHARGE_TYPE_FAST:
+ ret = bq24257_field_write(bq, F_LOW_CHG, 0);
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ if (ret < 0)
+ return ret;
+
+ return bq24257_field_write(bq, F_CE, 0);
+}
+
static int bq24257_power_supply_get_property(struct power_supply *psy,
enum power_supply_property psp,
union power_supply_propval *val)
@@ -290,6 +340,10 @@ static int bq24257_power_supply_get_property(struct power_supply *psy,
val->intval = POWER_SUPPLY_STATUS_UNKNOWN;
break;
+ case POWER_SUPPLY_PROP_CHARGE_TYPE:
+ ret = bq24257_get_charge_type(bq, val);
+ break;
+
case POWER_SUPPLY_PROP_MANUFACTURER:
val->strval = BQ24257_MANUFACTURER;
break;
@@ -358,6 +412,39 @@ static int bq24257_power_supply_get_property(struct power_supply *psy,
return ret;
}
+static int bq24257_power_supply_set_property(struct power_supply *psy,
+ enum power_supply_property prop,
+ const union power_supply_propval *val)
+{
+ struct bq24257_device *bq = power_supply_get_drvdata(psy);
+ int ret;
+
+ mutex_lock(&bq->lock);
+
+ switch (prop) {
+ case POWER_SUPPLY_PROP_CHARGE_TYPE:
+ ret = bq24257_set_charge_type(bq, val);
+ break;
+ default:
+ ret = -EINVAL;
+ }
+
+ mutex_unlock(&bq->lock);
+
+ return ret;
+}
+
+static int bq24257_power_supply_property_is_writeable(struct power_supply *psy,
+ enum power_supply_property psp)
+{
+ switch (psp) {
+ case POWER_SUPPLY_PROP_CHARGE_TYPE:
+ return true;
+ default:
+ return false;
+ }
+}
+
static int bq24257_get_chip_state(struct bq24257_device *bq,
struct bq24257_state *state)
{
@@ -683,6 +770,7 @@ static enum power_supply_property bq24257_power_supply_props[] = {
POWER_SUPPLY_PROP_MANUFACTURER,
POWER_SUPPLY_PROP_MODEL_NAME,
POWER_SUPPLY_PROP_STATUS,
+ POWER_SUPPLY_PROP_CHARGE_TYPE,
POWER_SUPPLY_PROP_ONLINE,
POWER_SUPPLY_PROP_HEALTH,
POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT,
@@ -702,6 +790,8 @@ static const struct power_supply_desc bq24257_power_supply_desc = {
.properties = bq24257_power_supply_props,
.num_properties = ARRAY_SIZE(bq24257_power_supply_props),
.get_property = bq24257_power_supply_get_property,
+ .set_property = bq24257_power_supply_set_property,
+ .property_is_writeable = bq24257_power_supply_property_is_writeable
};
static ssize_t bq24257_show_ovp_voltage(struct device *dev,
--
1.9.1
next prev parent reply other threads:[~2015-09-09 0:12 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 0:12 [PATCH v2 00/13] power: bq24257: Add support for bq24250/bq24251 Andreas Dannenberg
2015-09-09 0:12 ` [PATCH v2 01/13] power: bq24257: Add bit definition for temp sense enable Andreas Dannenberg
2015-09-10 12:31 ` Laurentiu Palcu
2015-09-09 0:12 ` [PATCH v2 02/13] power: bq24257: Add basic support for bq24250/bq24251 Andreas Dannenberg
2015-09-10 12:42 ` Laurentiu Palcu
2015-09-10 16:19 ` Andreas Dannenberg
2015-09-09 0:12 ` [PATCH v2 03/13] power: bq24257: Allow manual setting of input current limit Andreas Dannenberg
[not found] ` <1441757557-7266-4-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-10 12:50 ` Laurentiu Palcu
2015-09-09 0:12 ` [PATCH v2 04/13] power: bq24257: Add SW-based approach for Power Good determination Andreas Dannenberg
[not found] ` <1441757557-7266-5-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-10 12:57 ` Laurentiu Palcu
2015-09-09 0:12 ` [PATCH v2 05/13] power: bq24257: Add over voltage protection setting support Andreas Dannenberg
[not found] ` <1441757557-7266-6-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-10 13:07 ` Laurentiu Palcu
2015-09-09 0:12 ` [PATCH v2 06/13] power: bq24257: Add input DPM voltage threshold " Andreas Dannenberg
2015-09-10 13:27 ` Laurentiu Palcu
2015-09-09 0:12 ` [PATCH v2 07/13] power: bq24257: Extend scope of mutex protection Andreas Dannenberg
2015-09-10 13:43 ` Laurentiu Palcu
2015-09-10 17:05 ` Andreas Dannenberg
2015-09-09 0:12 ` Andreas Dannenberg [this message]
[not found] ` <1441757557-7266-9-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-10 13:56 ` [PATCH v2 08/13] power: bq24257: Add charge type setting support Laurentiu Palcu
2015-09-10 18:50 ` Andreas Dannenberg
2015-09-09 0:12 ` [PATCH v2 09/13] power: bq24257: Allow input current limit sysfs access Andreas Dannenberg
2015-09-10 14:06 ` Laurentiu Palcu
[not found] ` <1441757557-7266-1-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-09 0:12 ` [PATCH v2 10/13] power: bq24257: Add various device-specific sysfs properties Andreas Dannenberg
[not found] ` <1441757557-7266-11-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-10 14:13 ` Laurentiu Palcu
2015-09-10 18:53 ` Andreas Dannenberg
2015-09-09 0:12 ` [PATCH v2 11/13] power: bq24257: Add platform data based initialization Andreas Dannenberg
2015-09-10 14:40 ` Laurentiu Palcu
2015-09-10 19:49 ` Andreas Dannenberg
2015-09-09 0:12 ` [PATCH v2 13/13] dt: power: bq2425x-charger: Cover additional devices Andreas Dannenberg
2015-09-09 0:27 ` Krzysztof Kozlowski
2015-09-09 2:48 ` Andreas Dannenberg
2015-09-09 4:58 ` Krzysztof Kozlowski
2015-09-09 20:15 ` Andreas Dannenberg
2015-09-10 0:15 ` Krzysztof Kozlowski
2015-09-10 15:00 ` Laurentiu Palcu
2015-09-10 21:05 ` Andreas Dannenberg
2015-09-10 20:57 ` Andreas Dannenberg
2015-09-11 0:34 ` Krzysztof Kozlowski
2015-09-11 14:47 ` Andreas Dannenberg
2015-09-10 12:26 ` [PATCH v2 00/13] power: bq24257: Add support for bq24250/bq24251 Laurentiu Palcu
2015-09-10 21:26 ` Andreas Dannenberg
2015-09-11 8:26 ` Laurentiu Palcu
2015-09-11 15:06 ` Andreas Dannenberg
2015-09-09 0:12 ` [PATCH v2 12/13] power: bq24257: Renaming for consistency Andreas Dannenberg
2015-09-10 14:41 ` Laurentiu Palcu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441757557-7266-9-git-send-email-dannenberg@ti.com \
--to=dannenberg@ti.com \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=k.kozlowski@samsung.com \
--cc=laurentiu.palcu@intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).