[PATCH 1/2] fsl: Add binding for RCPM

[PATCH 1/2] fsl: Add binding for RCPM

[Dongsheng Wang]

From: Wang Dongsheng <dongsheng.wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

RCPM is the Run Control and Power Management module performs all
device-level tasks associated with device run control and power
management.

Add this for freescale powerpc platform and layerscape platform.

Signed-off-by: Chenhui Zhao <chenhui.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Signed-off-by: Tang Yuantian <Yuantian.Tang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Signed-off-by: Wang Dongsheng <dongsheng.wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

diff --git a/Documentation/devicetree/bindings/soc/fsl/rcpm.txt b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt
new file mode 100644
index 0000000..284070c
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt
@@ -0,0 +1,64 @@
+* Run Control and Power Management
+-------------------------------------------
+The RCPM performs all device-level tasks associated with device run control
+and power management.
+
+Required properites:
+  - reg : Offset and length of the register set of RCPM block.
+  - compatible : Sould contain a chip-specific RCPM block compatible string
+	and (if applicable) may contain a chassis-version RCPM compatible string.
+	Chip-specific strings are of the form "fsl,<chip>-rcpm", such as:
+	* "fsl,p2041-rcpm"
+	* "fsl,p3041-rcpm"
+	* "fsl,p4080-rcpm"
+	* "fsl,p5020-rcpm"
+	* "fsl,p5040-rcpm"
+	* "fsl,t4240-rcpm"
+	* "fsl,b4420-rcpm"
+	* "fsl,b4860-rcpm"
+
+	Chassis-version strings are of the form "fsl,qoriq-rcpm-<version>",
+	such as:
+	* "fsl,qoriq-rcpm-1.0": for chassis 1.0 rcpm
+	* "fsl,qoriq-rcpm-2.0": for chassis 2.0 rcpm
+	* "fsl,qoriq-rcpm-2.1": for chassis 2.1 rcpm
+
+All references to "1.0" and "2.0" refer to the QorIQ chassis version to
+which the chip complies.
+Chassis Version		Example Chips
+---------------		-------------------------------
+1.0				p4080, p5020, p5040, p2041, p3041
+2.0				t4240, b4860, b4420
+2.1				t1040, ls1021
+
+Example:
+The RCPM node for T4240:
+	rcpm: global-utilities@e2000 {
+		compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0";
+		reg = <0xe2000 0x1000>;
+	};
+
+The RCPM node for P4080:
+	rcpm: global-utilities@e2000 {
+		compatible = "fsl,qoriq-rcpm-1.0";
+		reg = <0xe2000 0x1000>;
+	};
+
+* Freescale RCPM Wakeup Source Device Tree Bindings
+-------------------------------------------
+Required rcpm-wakeup property should be added to a device node if the device
+can be used as a wakeup source.
+
+  - rcpm-wakeup: should contain a pointer to the rcpm node and the
+	corresponding bit of device in the register.
+
+Example:
+	lpuart0: serial@2950000 {
+		compatible = "fsl,ls1021a-lpuart";
+		reg = <0x0 0x2950000 0x0 0x1000>;
+		interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&sysclk>;
+		clock-names = "ipg";
+		rcpm-wakeup = <&rcpm 0x0 0x40000000>;
+		status = "disabled";
+	};
-- 
2.1.0.27.g96db324

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] arm/layerscape: add RCPM device tree support for ls1021a.

[Dongsheng Wang]

From: Wang Dongsheng <dongsheng.wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

Signed-off-by: Wang Dongsheng <dongsheng.wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index 973a496..deb1271 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -139,6 +139,7 @@
 			sdhci,auto-cmd12;
 			big-endian;
 			bus-width = <4>;
+			rcpm-wakeup = <&rcpm 0x00000080 0x0>;
 			status = "disabled";
 		};
 
@@ -186,6 +187,11 @@
 			};
 		};
 
+		rcpm: rcpm@1ee2000 {
+			compatible = "fsl,ls1021a-rcpm", "fsl,qoriq-rcpm-2.1";
+			reg = <0x0 0x1ee2000 0x0 0x10000>;
+		};
+
 		dspi0: dspi@2100000 {
 			compatible = "fsl,ls1021a-v1.0-dspi";
 			#address-cells = <1>;
@@ -287,6 +293,7 @@
 			interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&sysclk>;
 			clock-names = "ipg";
+			rcpm-wakeup = <&rcpm 0x0 0x40000000>;
 			status = "disabled";
 		};
 
-- 
2.1.0.27.g96db324

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] fsl: Add binding for RCPM

[Scott Wood]

On Wed, 2015-09-09 at 14:42 +0800, Dongsheng Wang wrote:
> From: Wang Dongsheng <dongsheng.wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> 
> RCPM is the Run Control and Power Management module performs all
> device-level tasks associated with device run control and power
> management.
> 
> Add this for freescale powerpc platform and layerscape platform.
> 
> Signed-off-by: Chenhui Zhao <chenhui.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> Signed-off-by: Tang Yuantian <Yuantian.Tang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> Signed-off-by: Wang Dongsheng <dongsheng.wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> 
> diff --git a/Documentation/devicetree/bindings/soc/fsl/rcpm.txt 
> b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> new file mode 100644
> index 0000000..284070c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> @@ -0,0 +1,64 @@
> +* Run Control and Power Management
> +-------------------------------------------
> +The RCPM performs all device-level tasks associated with device run control
> +and power management.
> +
> +Required properites:
> +  - reg : Offset and length of the register set of RCPM block.
> +  - compatible : Sould contain a chip-specific RCPM block compatible string
> +     and (if applicable) may contain a chassis-version RCPM compatible string.
> +     Chip-specific strings are of the form "fsl,<chip>-rcpm", such as:
> +     * "fsl,p2041-rcpm"
> +     * "fsl,p3041-rcpm"
> +     * "fsl,p4080-rcpm"
> +     * "fsl,p5020-rcpm"
> +     * "fsl,p5040-rcpm"
> +     * "fsl,t4240-rcpm"
> +     * "fsl,b4420-rcpm"
> +     * "fsl,b4860-rcpm"
> +
> +     Chassis-version strings are of the form "fsl,qoriq-rcpm-<version>",
> +     such as:
> +     * "fsl,qoriq-rcpm-1.0": for chassis 1.0 rcpm
> +     * "fsl,qoriq-rcpm-2.0": for chassis 2.0 rcpm
> +     * "fsl,qoriq-rcpm-2.1": for chassis 2.1 rcpm
> +
> +All references to "1.0" and "2.0" refer to the QorIQ chassis version to
> +which the chip complies.
> +Chassis Version              Example Chips
> +---------------              -------------------------------
> +1.0                          p4080, p5020, p5040, p2041, p3041
> +2.0                          t4240, b4860, b4420
> +2.1                          t1040, ls1021
> +
> +Example:
> +The RCPM node for T4240:
> +     rcpm:  global-utilities@e2000{
> +             compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0";
> +             reg = <0xe2000 0x1000>;
> +     };
> +
> +The RCPM node for P4080:
> +     rcpm:  global-utilities@e2000{
> +             compatible = "fsl,qoriq-rcpm-1.0";
> +             reg = <0xe2000 0x1000>;
> +     };

I would avoid putting the p4080 example in the binding, as we don't want to 
make it look like it's OK to leave out the specific chip compatible.

> +* Freescale RCPM Wakeup Source Device Tree Bindings
> +-------------------------------------------
> +Required rcpm-wakeup property should be added to a device node if the 
> device
> +can be used as a wakeup source.
> +
> +  - rcpm-wakeup: should contain a pointer to the rcpm node and the
> +     corresponding bit of device in the register.

The corresponding bit in *what* register?

-Scott

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/2] fsl: Add binding for RCPM

[Wang Dongsheng]

Hi Scott,

Thanks for your review.

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Thursday, September 10, 2015 3:57 AM
> To: Wang Dongsheng-B40534
> Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Jin Zhengxiong-
> R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983; Wang Huan-B18965;
> robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH 1/2] fsl: Add binding for RCPM
> 
> On Wed, 2015-09-09 at 14:42 +0800, Dongsheng Wang wrote:
> > From: Wang Dongsheng <dongsheng.wang@freescale.com>
> >
> > RCPM is the Run Control and Power Management module performs all
> > device-level tasks associated with device run control and power
> > management.
> >
> > Add this for freescale powerpc platform and layerscape platform.
> >
> > Signed-off-by: Chenhui Zhao <chenhui.zhao@freescale.com>
> > Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
> > Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com>
> >
> > diff --git a/Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> > b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> > new file mode 100644
> > index 0000000..284070c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> > @@ -0,0 +1,64 @@
> > +* Run Control and Power Management
> > +-------------------------------------------
> > +The RCPM performs all device-level tasks associated with device run control
> > +and power management.
> > +
> > +Required properites:
> > +  - reg : Offset and length of the register set of RCPM block.
> > +  - compatible : Sould contain a chip-specific RCPM block compatible string
> > +     and (if applicable) may contain a chassis-version RCPM compatible string.
> > +     Chip-specific strings are of the form "fsl,<chip>-rcpm", such as:
> > +     * "fsl,p2041-rcpm"
> > +     * "fsl,p3041-rcpm"
> > +     * "fsl,p4080-rcpm"
> > +     * "fsl,p5020-rcpm"
> > +     * "fsl,p5040-rcpm"
> > +     * "fsl,t4240-rcpm"
> > +     * "fsl,b4420-rcpm"
> > +     * "fsl,b4860-rcpm"
> > +
> > +     Chassis-version strings are of the form "fsl,qoriq-rcpm-<version>",
> > +     such as:
> > +     * "fsl,qoriq-rcpm-1.0": for chassis 1.0 rcpm
> > +     * "fsl,qoriq-rcpm-2.0": for chassis 2.0 rcpm
> > +     * "fsl,qoriq-rcpm-2.1": for chassis 2.1 rcpm
> > +
> > +All references to "1.0" and "2.0" refer to the QorIQ chassis version to
> > +which the chip complies.
> > +Chassis Version              Example Chips
> > +---------------              -------------------------------
> > +1.0                          p4080, p5020, p5040, p2041, p3041
> > +2.0                          t4240, b4860, b4420
> > +2.1                          t1040, ls1021
> > +
> > +Example:
> > +The RCPM node for T4240:
> > +     rcpm:  global-utilities@e2000{
> > +             compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0";
> > +             reg = <0xe2000 0x1000>;
> > +     };
> > +
> > +The RCPM node for P4080:
> > +     rcpm:  global-utilities@e2000{
> > +             compatible = "fsl,qoriq-rcpm-1.0";
> > +             reg = <0xe2000 0x1000>;
> > +     };
> 
> I would avoid putting the p4080 example in the binding, as we don't want to
> make it look like it's OK to leave out the specific chip compatible.
> 

Fine, I will add the specific chip compatible in this example.
compatible = "fsl,p4080-rcpm", "fsl,qoriq-rcpm-1.0";

> > +* Freescale RCPM Wakeup Source Device Tree Bindings
> > +-------------------------------------------
> > +Required rcpm-wakeup property should be added to a device node if the
> > device
> > +can be used as a wakeup source.
> > +
> > +  - rcpm-wakeup: should contain a pointer to the rcpm node and the
> > +     corresponding bit of device in the register.
> 
> The corresponding bit in *what* register?
> 

RCPM_IPPDEXPCRx register, I will add a explain to this.

Regards,
-Dongsheng
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 1/2] fsl: Add binding for RCPM

[Scott Wood]

On Wed, 2015-09-09 at 21:03 -0500, Wang Dongsheng-B40534 wrote:
> Hi Scott,
> 
> Thanks for your review.
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Thursday, September 10, 2015 3:57 AM
> > To: Wang Dongsheng-B40534
> > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; Jin 
> > Zhengxiong-
> > R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983; Wang Huan-B18965;
> > robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> > Subject: Re: [PATCH 1/2] fsl: Add binding for RCPM
> > 
> > On Wed, 2015-09-09 at 14:42 +0800, Dongsheng Wang wrote:
> > > From: Wang Dongsheng <dongsheng.wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > > 
> > > RCPM is the Run Control and Power Management module performs all
> > > device-level tasks associated with device run control and power
> > > management.
> > > 
> > > Add this for freescale powerpc platform and layerscape platform.
> > > 
> > > Signed-off-by: Chenhui Zhao <chenhui.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > > Signed-off-by: Tang Yuantian <Yuantian.Tang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > > Signed-off-by: Wang Dongsheng <dongsheng.wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > > 
> > > diff --git a/Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> > > b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> > > new file mode 100644
> > > index 0000000..284070c
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> > > @@ -0,0 +1,64 @@
> > > +* Run Control and Power Management
> > > +-------------------------------------------
> > > +The RCPM performs all device-level tasks associated with device run 
> > > control
> > > +and power management.
> > > +
> > > +Required properites:
> > > +  - reg : Offset and length of the register set of RCPM block.
> > > +  - compatible : Sould contain a chip-specific RCPM block compatible 
> > > string
> > > +     and (if applicable) may contain a chassis-version RCPM compatible 
> > > string.
> > > +     Chip-specific strings are of the form "fsl,<chip>-rcpm", such as:
> > > +     * "fsl,p2041-rcpm"
> > > +     * "fsl,p3041-rcpm"
> > > +     * "fsl,p4080-rcpm"
> > > +     * "fsl,p5020-rcpm"
> > > +     * "fsl,p5040-rcpm"
> > > +     * "fsl,t4240-rcpm"
> > > +     * "fsl,b4420-rcpm"
> > > +     * "fsl,b4860-rcpm"
> > > +
> > > +     Chassis-version strings are of the form "fsl,qoriq-rcpm-
> > > <version>",
> > > +     such as:
> > > +     * "fsl,qoriq-rcpm-1.0": for chassis 1.0 rcpm
> > > +     * "fsl,qoriq-rcpm-2.0": for chassis 2.0 rcpm
> > > +     * "fsl,qoriq-rcpm-2.1": for chassis 2.1 rcpm
> > > +
> > > +All references to "1.0" and "2.0" refer to the QorIQ chassis version to
> > > +which the chip complies.
> > > +Chassis Version              Example Chips
> > > +---------------              -------------------------------
> > > +1.0                          p4080, p5020, p5040, p2041, p3041
> > > +2.0                          t4240, b4860, b4420
> > > +2.1                          t1040, ls1021
> > > +
> > > +Example:
> > > +The RCPM node for T4240:
> > > +     rcpm:  global-utilities@e2000{
> > > +             compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0";
> > > +             reg = <0xe2000 0x1000>;
> > > +     };
> > > +
> > > +The RCPM node for P4080:
> > > +     rcpm:  global-utilities@e2000{
> > > +             compatible = "fsl,qoriq-rcpm-1.0";
> > > +             reg = <0xe2000 0x1000>;
> > > +     };
> > 
> > I would avoid putting the p4080 example in the binding, as we don't want 
> > to
> > make it look like it's OK to leave out the specific chip compatible.
> > 
> 
> Fine, I will add the specific chip compatible in this example.
> compatible = "fsl,p4080-rcpm", "fsl,qoriq-rcpm-1.0";

Just drop that example.

> > > +* Freescale RCPM Wakeup Source Device Tree Bindings
> > > +-------------------------------------------
> > > +Required rcpm-wakeup property should be added to a device node if the
> > > device
> > > +can be used as a wakeup source.
> > > +
> > > +  - rcpm-wakeup: should contain a pointer to the rcpm node and the
> > > +     corresponding bit of device in the register.
> > 
> > The corresponding bit in *what* register?
> > 
> 
> RCPM_IPPDEXPCRx register, I will add a explain to this.

How do you encode which "x" it is?

-Scott

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/2] fsl: Add binding for RCPM

[Wang Dongsheng]

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Friday, September 11, 2015 12:47 AM
> To: Wang Dongsheng-B40534
> Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Jin Zhengxiong-
> R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983; Wang Huan-B18965;
> robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH 1/2] fsl: Add binding for RCPM
> 
> On Wed, 2015-09-09 at 21:03 -0500, Wang Dongsheng-B40534 wrote:
> > Hi Scott,
> >
> > Thanks for your review.
> >
> > > -----Original Message-----
> > > From: Wood Scott-B07421
> > > Sent: Thursday, September 10, 2015 3:57 AM
> > > To: Wang Dongsheng-B40534
> > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Jin
> > > Zhengxiong-
> > > R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983; Wang Huan-B18965;
> > > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org
> > > Subject: Re: [PATCH 1/2] fsl: Add binding for RCPM
> > >
> > > On Wed, 2015-09-09 at 14:42 +0800, Dongsheng Wang wrote:
> > > > From: Wang Dongsheng <dongsheng.wang@freescale.com>
> > > >
> > > > RCPM is the Run Control and Power Management module performs all
> > > > device-level tasks associated with device run control and power
> > > > management.
> > > >
> > > > Add this for freescale powerpc platform and layerscape platform.
> > > >
> > > > Signed-off-by: Chenhui Zhao <chenhui.zhao@freescale.com>
> > > > Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
> > > > Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com>
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> > > > b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> > > > new file mode 100644
> > > > index 0000000..284070c
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> > > > @@ -0,0 +1,64 @@
> > > > +* Run Control and Power Management
> > > > +-------------------------------------------
> > > > +The RCPM performs all device-level tasks associated with device
> > > > +run
> > > > control
> > > > +and power management.
> > > > +
> > > > +Required properites:
> > > > +  - reg : Offset and length of the register set of RCPM block.
> > > > +  - compatible : Sould contain a chip-specific RCPM block
> > > > +compatible
> > > > string
> > > > +     and (if applicable) may contain a chassis-version RCPM
> > > > + compatible
> > > > string.
> > > > +     Chip-specific strings are of the form "fsl,<chip>-rcpm", such as:
> > > > +     * "fsl,p2041-rcpm"
> > > > +     * "fsl,p3041-rcpm"
> > > > +     * "fsl,p4080-rcpm"
> > > > +     * "fsl,p5020-rcpm"
> > > > +     * "fsl,p5040-rcpm"
> > > > +     * "fsl,t4240-rcpm"
> > > > +     * "fsl,b4420-rcpm"
> > > > +     * "fsl,b4860-rcpm"
> > > > +
> > > > +     Chassis-version strings are of the form "fsl,qoriq-rcpm-
> > > > <version>",
> > > > +     such as:
> > > > +     * "fsl,qoriq-rcpm-1.0": for chassis 1.0 rcpm
> > > > +     * "fsl,qoriq-rcpm-2.0": for chassis 2.0 rcpm
> > > > +     * "fsl,qoriq-rcpm-2.1": for chassis 2.1 rcpm
> > > > +
> > > > +All references to "1.0" and "2.0" refer to the QorIQ chassis
> > > > +version to which the chip complies.
> > > > +Chassis Version              Example Chips
> > > > +---------------              -------------------------------
> > > > +1.0                          p4080, p5020, p5040, p2041, p3041
> > > > +2.0                          t4240, b4860, b4420
> > > > +2.1                          t1040, ls1021
> > > > +
> > > > +Example:
> > > > +The RCPM node for T4240:
> > > > +     rcpm:  global-utilities@e2000{
> > > > +             compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0";
> > > > +             reg = <0xe2000 0x1000>;
> > > > +     };
> > > > +
> > > > +The RCPM node for P4080:
> > > > +     rcpm:  global-utilities@e2000{
> > > > +             compatible = "fsl,qoriq-rcpm-1.0";
> > > > +             reg = <0xe2000 0x1000>;
> > > > +     };
> > >
> > > I would avoid putting the p4080 example in the binding, as we don't
> > > want to make it look like it's OK to leave out the specific chip
> > > compatible.
> > >
> >
> > Fine, I will add the specific chip compatible in this example.
> > compatible = "fsl,p4080-rcpm", "fsl,qoriq-rcpm-1.0";
> 
> Just drop that example.
> 

Thanks.

> > > > +* Freescale RCPM Wakeup Source Device Tree Bindings
> > > > +-------------------------------------------
> > > > +Required rcpm-wakeup property should be added to a device node if
> > > > +the
> > > > device
> > > > +can be used as a wakeup source.
> > > > +
> > > > +  - rcpm-wakeup: should contain a pointer to the rcpm node and the
> > > > +     corresponding bit of device in the register.
> > >
> > > The corresponding bit in *what* register?
> > >
> >
> > RCPM_IPPDEXPCRx register, I will add a explain to this.
> 
> How do you encode which "x" it is?

Just means IPPDEXPCR0 IPPDEXPCR1.

"&rcpm IPPDEXPCR0 IPPDEXPCR1" will explain "what register" in this property.

Regards,
-Dongsheng
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev