From: Sjoerd Simons <sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
To: Javier Martinez Canillas
<javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org>
Cc: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Linux Kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 2/2] ARM: dts: rockchip: Add dtb for the Radxa Rock 2 Square board
Date: Mon, 14 Sep 2015 09:30:49 +0200 [thread overview]
Message-ID: <1442215849.8778.101.camel@collabora.co.uk> (raw)
In-Reply-To: <CABxcv=nRjge1qMeoXt6U6McKbv30oYUhh9C417mX0B=bt9Jg-g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Mon, 2015-09-14 at 01:00 +0200, Javier Martinez Canillas wrote:
> Hello Sjoerd,
>
> On Sat, Sep 12, 2015 at 12:36 AM, Sjoerd Simons
> <sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> wrote:
>
> [snip]
>
> > +
> > + regulators {
> > + vcc_ddr: REG1 {
> > + regulator-name = "VCC_DDR";
> > + regulator-min-microvolt =
> > <1200000>;
> > + regulator-max-microvolt =
> > <1200000>;
> > + regulator-always-on;
> > + };
> > +
> > + vcc_io: REG2 {
> > + regulator-name = "VCC_IO";
> > + regulator-min-microvolt =
> > <3300000>;
> > + regulator-max-microvolt =
> > <3300000>;
> > + regulator-always-on;
> > + };
> > +
> > + vdd_log: REG3 {
> > + regulator-name = "VDD_LOG";
> > + regulator-min-microvolt =
> > <1000000>;
> > + regulator-max-microvolt =
> > <1000000>;
> > + regulator-always-on;
> > + };
> > +
> > + vcc_20: REG4 {
> > + regulator-name = "VCC_20";
> > + regulator-min-microvolt =
> > <2000000>;
> > + regulator-max-microvolt =
> > <2000000>;
> > + regulator-always-on;
> > + };
> > +
> > + vccio_sd: REG5 {
> > + regulator-name = "VCCIO_SD";
> > + regulator-min-microvolt =
> > <3300000>;
> > + regulator-max-microvolt =
> > <3300000>;
> > + regulator-always-on;
> > + };
> > +
> > + vdd10_lcd: REG6 {
> > + regulator-name = "VDD10_LCD";
> > + regulator-min-microvolt =
> > <1000000>;
> > + regulator-max-microvolt =
> > <1000000>;
> > + regulator-always-on;
> > + };
> > +
> > + vcca_codec: REG7 {
> > + regulator-name = "VCCA_CODEC";
> > + regulator-min-microvolt =
> > <3300000>;
> > + regulator-max-microvolt =
> > <3300000>;
> > + regulator-always-on;
> > + };
> > +
> > + vcca_tp: REG8 {
> > + regulator-name = "VCCA_TP";
> > + regulator-min-microvolt =
> > <3300000>;
> > + regulator-max-microvolt =
> > <3300000>;
> > + regulator-always-on;
> > + };
> > +
> > + vccio_pmu: REG9 {
> > + regulator-name = "VCCIO_PMU";
> > + regulator-min-microvolt =
> > <3300000>;
> > + regulator-max-microvolt =
> > <3300000>;
> > + regulator-always-on;
> > + };
> > +
> > + vdd_10: REG10 {
> > + regulator-name = "VDD_10";
> > + regulator-min-microvolt =
> > <1000000>;
> > + regulator-max-microvolt =
> > <1000000>;
> > + regulator-always-on;
> > + };
> > +
> > + vcc_18: REG11 {
> > + regulator-name = "VCC_18";
> > + regulator-min-microvolt =
> > <1800000>;
> > + regulator-max-microvolt =
> > <1800000>;
> > + regulator-always-on;
> > + };
> > +
> > + vcc18_lcd: REG12 {
> > + regulator-name = "VCC18_LCD";
> > + regulator-min-microvolt =
> > <1800000>;
> > + regulator-max-microvolt =
> > <1800000>;
> > + regulator-always-on;
> > + };
>
> Should all these regulators really need to be always-on?
Ideally not all of them, turning the ones that aren't needed off is
definately on my list of things to do (together with the other
pheripherals, leds, hw. keys etc).
For the first patch i do prefer to keep them on so we can have get some
more testing with this board before fine-tuning those things (fwiw,
the rockchip evb board and others with essentially the same pmic setup
all also have them always-on)
--
Sjoerd Simons
Collabora Ltd.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-09-14 7:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 22:36 [PATCH 1/2] pinctrl: rockchip: Define GPIO banks 7 and 8 Sjoerd Simons
[not found] ` <1442011005-4828-1-git-send-email-sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2015-09-11 22:36 ` [PATCH 2/2] ARM: dts: rockchip: Add dtb for the Radxa Rock 2 Square board Sjoerd Simons
[not found] ` <1442011005-4828-2-git-send-email-sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2015-09-13 16:47 ` Heiko Stübner
2015-09-13 16:59 ` Heiko Stübner
2015-09-13 23:00 ` Javier Martinez Canillas
[not found] ` <CABxcv=nRjge1qMeoXt6U6McKbv30oYUhh9C417mX0B=bt9Jg-g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-14 7:30 ` Sjoerd Simons [this message]
[not found] ` <1442215849.8778.101.camel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2015-09-14 7:50 ` Javier Martinez Canillas
2015-09-14 8:05 ` Sjoerd Simons
[not found] ` <1442217958.8778.103.camel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2015-09-14 8:47 ` Heiko Stübner
2015-09-12 10:40 ` [PATCH 1/2] pinctrl: rockchip: Define GPIO banks 7 and 8 Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442215849.8778.101.camel@collabora.co.uk \
--to=sjoerd.simons-zgy8ohtn/8ppycu2f3hruq@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).