devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Constantine Shulyupin <const@MakeLinux.com>
To: open list <linux-kernel@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	lm-sensors@lm-sensors.org, Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>
Subject: Please suggest proper format for DT properties.
Date: Sat, 19 Sep 2015 01:36:43 +0300	[thread overview]
Message-ID: <1442615803-17766-1-git-send-email-const@MakeLinux.com> (raw)

Hi,

I am designing DT support for a hwmon chip. 
It has some sensors, each of them can be:
 - "disabled"
 - "thermal diode"
 - "thermistor"
 - "voltage"

Four possible options for DT properties format.

Option 1: Separated property for each sensor.

Example nct7802 node:

nct7802 {
	compatible = "nuvoton,nct7802";
	reg = <0x2a>;
	nuvoton,sensor1-type = "thermistor";
	nuvoton,sensor2-type = "disabled";
	nuvoton,sensor3-type = "voltage";
};

Option 2: Array of strings for all sensors.

nct7802 {
	compatible = "nuvoton,nct7802";
	reg = <0x2a>;
	nuvoton,sensors-types = "thermistor", "disabled", "voltage";
};

Option 3: Sets of 4 cells.

  Borrowed from marvell,reg-init and broadcom,c45-reg-init.

  The first cell is the page address, 
  the second a register address within the page,
  the third cell contains a mask to be ANDed with the existing register
  value, and the fourth cell is ORed with the result to yield the
  new register value. If the third cell has a value of zero,
  no read of the existing value is performed.

Example nct7802 node:

nct7802 {
	compatible = "nuvoton,nct7802";
	reg = <0x2a>;
	nct7802,reg-init =
		<0 0x21 0 0x01 > // START = 1
		<0 0x22 0x03 0x02>; // RTD1_MD = 2
};

Please suggest proper format for DT properties.

Thanks
Constantine

PS:
Datasheet: https://www.nuvoton.com/hq/products/cloud-computing/hardware-monitors/desktop-server-series/nct7802y/

             reply	other threads:[~2015-09-18 22:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18 22:36 Constantine Shulyupin [this message]
     [not found] ` <1442615803-17766-1-git-send-email-const-GkuDRZ1haSFDPfheJLI6IQ@public.gmane.org>
2015-09-21  1:51   ` Please suggest proper format for DT properties Rob Herring
2015-09-21 19:24     ` Constantine Shulyupin
     [not found]       ` <CAE7jHC-8NeHKo8x5oCPQTPTzoWmpyXxa3G2+PxJgSBxEct5ocA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-22  0:32         ` Rob Herring
2015-09-22  8:36   ` Arnd Bergmann
2015-09-22 15:08     ` Guenter Roeck
     [not found]       ` <56016EE9.1010302-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-09-22 15:17         ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442615803-17766-1-git-send-email-const@MakeLinux.com \
    --to=const@makelinux.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jdelvare@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).