From: Eric Nelson <eric@nelint.com>
To: linux-media@vger.kernel.org
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mchehab@osg.samsung.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, patrice.chotard@st.com, fabf@skynet.be,
wsa@the-dreams.de, heiko@sntech.de, devicetree@vger.kernel.org,
otavio@ossystems.com.br, Eric Nelson <eric@nelint.com>
Subject: [PATCH V2 2/2] rc: gpio-ir-recv: add timeout on idle
Date: Mon, 21 Sep 2015 12:08:44 -0700 [thread overview]
Message-ID: <1442862524-3694-3-git-send-email-eric@nelint.com> (raw)
In-Reply-To: <1442862524-3694-1-git-send-email-eric@nelint.com>
Many decoders require a trailing space (period without IR illumination)
to be delivered before completing a decode.
Since the gpio-ir-recv driver only delivers events on gpio transitions,
a single IR symbol (caused by a quick touch on an IR remote) will not
be properly decoded without the use of a timer to flush the tail end
state of the IR receiver.
This patch initializes and uses a timer and the timeout field of rcdev
to complete the stream and allow decode.
The timeout can be overridden through the use of the LIRC_SET_REC_TIMEOUT
ioctl.
Signed-off-by: Eric Nelson <eric@nelint.com>
---
drivers/media/rc/gpio-ir-recv.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/drivers/media/rc/gpio-ir-recv.c b/drivers/media/rc/gpio-ir-recv.c
index 7dbc9ca..d3b216a 100644
--- a/drivers/media/rc/gpio-ir-recv.c
+++ b/drivers/media/rc/gpio-ir-recv.c
@@ -30,6 +30,7 @@ struct gpio_rc_dev {
struct rc_dev *rcdev;
int gpio_nr;
bool active_low;
+ struct timer_list flush_timer;
};
#ifdef CONFIG_OF
@@ -93,12 +94,26 @@ static irqreturn_t gpio_ir_recv_irq(int irq, void *dev_id)
if (rc < 0)
goto err_get_value;
+ mod_timer(&gpio_dev->flush_timer,
+ jiffies + nsecs_to_jiffies(gpio_dev->rcdev->timeout));
+
ir_raw_event_handle(gpio_dev->rcdev);
err_get_value:
return IRQ_HANDLED;
}
+static void flush_timer(unsigned long arg)
+{
+ struct gpio_rc_dev *gpio_dev = (struct gpio_rc_dev *)arg;
+ DEFINE_IR_RAW_EVENT(ev);
+
+ ev.timeout = true;
+ ev.duration = gpio_dev->rcdev->timeout;
+ ir_raw_event_store(gpio_dev->rcdev, &ev);
+ ir_raw_event_handle(gpio_dev->rcdev);
+}
+
static int gpio_ir_recv_probe(struct platform_device *pdev)
{
struct gpio_rc_dev *gpio_dev;
@@ -144,6 +159,9 @@ static int gpio_ir_recv_probe(struct platform_device *pdev)
rcdev->input_id.version = 0x0100;
rcdev->dev.parent = &pdev->dev;
rcdev->driver_name = GPIO_IR_DRIVER_NAME;
+ rcdev->min_timeout = 1;
+ rcdev->timeout = IR_DEFAULT_TIMEOUT;
+ rcdev->max_timeout = 10 * IR_DEFAULT_TIMEOUT;
if (pdata->allowed_protos)
rcdev->allowed_protocols = pdata->allowed_protos;
else
@@ -154,6 +172,10 @@ static int gpio_ir_recv_probe(struct platform_device *pdev)
gpio_dev->gpio_nr = pdata->gpio_nr;
gpio_dev->active_low = pdata->active_low;
+ init_timer(&gpio_dev->flush_timer);
+ gpio_dev->flush_timer.function = flush_timer;
+ gpio_dev->flush_timer.data = (unsigned long)gpio_dev;
+
rc = gpio_request(pdata->gpio_nr, "gpio-ir-recv");
if (rc < 0)
goto err_gpio_request;
--
2.5.2
next prev parent reply other threads:[~2015-09-21 19:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 14:00 [PATCH][resend] rc: gpio-ir-recv: allow flush space on idle Eric Nelson
[not found] ` <1441980024-1944-1-git-send-email-eric-SeqgQ6RdavfQT0dZR+AlfA@public.gmane.org>
2015-09-14 10:00 ` Sean Young
2015-09-14 14:34 ` Eric Nelson
2015-09-14 14:54 ` Sean Young
2015-09-14 15:05 ` Eric Nelson
2015-09-14 15:35 ` Sean Young
2015-09-21 19:08 ` [PATCH V2 0/2] rc: Add timeout support to gpio-ir-recv Eric Nelson
2015-09-21 19:08 ` Eric Nelson
2015-09-21 19:08 ` [PATCH V2 1/2] rc-core: define a default timeout for drivers Eric Nelson
[not found] ` <1442862524-3694-2-git-send-email-eric-SeqgQ6RdavfQT0dZR+AlfA@public.gmane.org>
2015-10-03 14:25 ` Mauro Carvalho Chehab
[not found] ` <20151003112510.54fe2a25-+RedX5hVuTR+urZeOPWqwQ@public.gmane.org>
2015-10-03 14:52 ` Eric Nelson
2015-10-03 15:18 ` Eric Nelson
2015-09-21 19:08 ` Eric Nelson [this message]
2015-09-23 13:26 ` [PATCH V2 2/2] rc: gpio-ir-recv: add timeout on idle Sean Young
2015-09-23 13:52 ` Eric Nelson
[not found] ` <5602AE95.9000505-SeqgQ6RdavfQT0dZR+AlfA@public.gmane.org>
2015-09-23 14:07 ` [PATCH V3 " Eric Nelson
[not found] ` <1443017228-16499-1-git-send-email-eric-SeqgQ6RdavfQT0dZR+AlfA@public.gmane.org>
2015-09-23 14:26 ` Sean Young
2015-10-03 14:27 ` [PATCH V2 0/2] rc: Add timeout support to gpio-ir-recv Mauro Carvalho Chehab
2015-10-03 15:10 ` Eric Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442862524-3694-3-git-send-email-eric@nelint.com \
--to=eric@nelint.com \
--cc=devicetree@vger.kernel.org \
--cc=fabf@skynet.be \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@osg.samsung.com \
--cc=otavio@ossystems.com.br \
--cc=patrice.chotard@st.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).