devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] net: Fix Hisilicon Network Subsystem Support Compilation
@ 2015-09-24  9:54 huangdaode
       [not found] ` <1443088449-147241-1-git-send-email-huangdaode-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: huangdaode @ 2015-09-24  9:54 UTC (permalink / raw)
  To: davem
  Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
	catalin.marinas, will.deacon, liguozhu, Yisen.Zhuang,
	paul.gortmaker, dingtianhong, zhangfei.gao, devicetree,
	linux-kernel, linux-arm-kernel, netdev, linuxarm, salil.mehta,
	huangdaode, kenneth-lee-2012, xuwei5, lisheng011

This patch fixes the compilation error with arm allmodconfig, this error
generated due to unavailability of readq on 32-bit platform which was
found during net-next daily compilation

Signed-off-by: huangdaode <huangdaode@hisilicon.com>
Singed-off-by: yankejian <yankejian@huawei.com>
---
 drivers/net/ethernet/hisilicon/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/hisilicon/Kconfig b/drivers/net/ethernet/hisilicon/Kconfig
index 165b5a8..04d5f8f 100644
--- a/drivers/net/ethernet/hisilicon/Kconfig
+++ b/drivers/net/ethernet/hisilicon/Kconfig
@@ -41,6 +41,7 @@ config HNS_MDIO
 
 config HNS
 	tristate "Hisilicon Network Subsystem Support (Framework)"
+	depends on ARM64
 	---help---
 	  This selects the framework support for Hisilicon Network Subsystem. It
 	  is needed by any driver which provides HNS acceleration engine or make
@@ -50,6 +51,7 @@ config HNS_DSAF
 	tristate "Hisilicon HNS DSAF device Support"
 	select HNS
 	select HNS_MDIO
+	depends on ARM64
 	---help---
 	  This selects the DSAF (Distributed System Area Frabric) network
 	  acceleration engine support. The engine is used in Hisilicon hip05,
@@ -59,6 +61,7 @@ config HNS_ENET
 	tristate "Hisilicon HNS Ethernet Device Support"
 	select PHYLIB
 	select HNS
+	depends on ARM64
 	---help---
 	  This selects the general ethernet driver for HNS.  This module make
 	  use of any HNS AE driver, such as HNS_DSAF
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] net: Fix Hisilicon Network Subsystem Support Compilation
       [not found] ` <1443088449-147241-1-git-send-email-huangdaode-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
@ 2015-09-24 17:52   ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-09-24 17:52 UTC (permalink / raw)
  To: huangdaode-C8/M+/jPZTeaMJb+Lgu22Q
  Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
	mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
	galak-sgV2jX0FEOL9JmXXK+q4OQ, catalin.marinas-5wv7dgnIgG8,
	will.deacon-5wv7dgnIgG8, liguozhu-C8/M+/jPZTeaMJb+Lgu22Q,
	Yisen.Zhuang-hv44wF8Li93QT0dZR+AlfA,
	paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ,
	dingtianhong-hv44wF8Li93QT0dZR+AlfA,
	zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	netdev-u79uwXL29TY76Z2rM5mHXA, linuxarm-hv44wF8Li93QT0dZR+AlfA,
	salil.mehta-hv44wF8Li93QT0dZR+AlfA,
	kenneth-lee-2012-H32Fclmsjq1BDgjK7y7TUQ,
	xuwei5-C8/M+/jPZTeaMJb+Lgu22Q, lisheng011-hv44wF8Li93QT0dZR+AlfA

From: huangdaode <huangdaode-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
Date: Thu, 24 Sep 2015 17:54:09 +0800

> This patch fixes the compilation error with arm allmodconfig, this error
> generated due to unavailability of readq on 32-bit platform which was
> found during net-next daily compilation
> 
> Signed-off-by: huangdaode <huangdaode-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
> Singed-off-by: yankejian <yankejian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

This is not necessaily the right fix, sorry.

I'd rather this driver be available to compile on as many
configurations as possible, to increase build coverage.

There is a standard way to make readq available on 32-bit platforms
and I want you to do research into how that works and how you can thus
make your driver build even on 32-bit targets.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-09-24 17:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-24  9:54 [PATCH net-next] net: Fix Hisilicon Network Subsystem Support Compilation huangdaode
     [not found] ` <1443088449-147241-1-git-send-email-huangdaode-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
2015-09-24 17:52   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).