devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Dannenberg <dannenberg@ti.com>
To: Sebastian Reichel <sre@kernel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Laurentiu Palcu <laurentiu.palcu@intel.com>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Ramakrishna Pallala <ramakrishna.pallala@intel.com>,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-api@vger.kernel.org, Andreas Dannenberg <dannenberg@ti.com>
Subject: [PATCH v8 11/14] power: bq24257: Allow input current limit sysfs access
Date: Mon, 28 Sep 2015 17:33:59 -0500	[thread overview]
Message-ID: <1443479642-23712-12-git-send-email-dannenberg@ti.com> (raw)
In-Reply-To: <1443479642-23712-1-git-send-email-dannenberg@ti.com>

This patch allows reading and writing of the input current limit through
the power supply's input_current_limit sysfs property. This allows
userspace to see what charger was detected (if the D+/D- USB signal-
based charger type detection is enabled) and to re-configure the maximum
current drawn from the external supply at runtime based on system-level
knowledge or user input. Note that upon charger disconnection and
re-connection the limit configured through firmware becomes active again
(or the D+/D- USB signal-based charger detection will be run again).

Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
---
 drivers/power/bq24257_charger.c | 85 ++++++++++++++++++++++++++++++++++++++---
 1 file changed, 79 insertions(+), 6 deletions(-)

diff --git a/drivers/power/bq24257_charger.c b/drivers/power/bq24257_charger.c
index ebb22f3..db719bf 100644
--- a/drivers/power/bq24257_charger.c
+++ b/drivers/power/bq24257_charger.c
@@ -267,6 +267,47 @@ enum bq24257_fault {
 	FAULT_INPUT_LDO_LOW,
 };
 
+static int bq24257_get_input_current_limit(struct bq24257_device *bq,
+					   union power_supply_propval *val)
+{
+	int ret;
+
+	ret = bq24257_field_read(bq, F_IILIMIT);
+	if (ret < 0)
+		return ret;
+
+	/*
+	 * The "External ILIM" and "Production & Test" modes are not exposed
+	 * through this driver and not being covered by the lookup table.
+	 * Should such a mode have become active let's return an error rather
+	 * than exceeding the bounds of the lookup table and returning
+	 * garbage.
+	 */
+	if (ret >= BQ24257_IILIMIT_MAP_SIZE)
+		return -ENODATA;
+
+	val->intval = bq24257_iilimit_map[ret];
+
+	return 0;
+}
+
+static int bq24257_set_input_current_limit(struct bq24257_device *bq,
+					const union power_supply_propval *val)
+{
+	/*
+	 * Address the case where the user manually sets an input current limit
+	 * while the charger auto-detection mechanism is is active. In this
+	 * case we want to abort and go straight to the user-specified value.
+	 */
+	if (bq->iilimit_autoset_enable)
+		cancel_delayed_work_sync(&bq->iilimit_setup_work);
+
+	return bq24257_field_write(bq, F_IILIMIT,
+				   bq24257_find_idx(val->intval,
+						    bq24257_iilimit_map,
+						    BQ24257_IILIMIT_MAP_SIZE));
+}
+
 static int bq24257_power_supply_get_property(struct power_supply *psy,
 					     enum power_supply_property psp,
 					     union power_supply_propval *val)
@@ -351,6 +392,9 @@ static int bq24257_power_supply_get_property(struct power_supply *psy,
 		val->intval = bq24257_iterm_map[bq->init_data.iterm];
 		break;
 
+	case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT:
+		return bq24257_get_input_current_limit(bq, val);
+
 	default:
 		return -EINVAL;
 	}
@@ -358,6 +402,31 @@ static int bq24257_power_supply_get_property(struct power_supply *psy,
 	return 0;
 }
 
+static int bq24257_power_supply_set_property(struct power_supply *psy,
+					enum power_supply_property prop,
+					const union power_supply_propval *val)
+{
+	struct bq24257_device *bq = power_supply_get_drvdata(psy);
+
+	switch (prop) {
+	case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT:
+		return bq24257_set_input_current_limit(bq, val);
+	default:
+		return -EINVAL;
+	}
+}
+
+static int bq24257_power_supply_property_is_writeable(struct power_supply *psy,
+					enum power_supply_property psp)
+{
+	switch (psp) {
+	case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT:
+		return true;
+	default:
+		return false;
+	}
+}
+
 static int bq24257_get_chip_state(struct bq24257_device *bq,
 				  struct bq24257_state *state)
 {
@@ -559,13 +628,14 @@ static void bq24257_handle_state_change(struct bq24257_device *bq,
 			ret = bq24257_field_write(bq, F_DPDM_EN, 1);
 			if (ret < 0)
 				goto error;
-
-			/* reset input current limit */
-			ret = bq24257_field_write(bq, F_IILIMIT,
-						  bq->init_data.iilimit);
-			if (ret < 0)
-				goto error;
 		}
+		/*
+		 * When power is removed always return to the default input
+		 * current limit as configured during probe.
+		 */
+		ret = bq24257_field_write(bq, F_IILIMIT, bq->init_data.iilimit);
+		if (ret < 0)
+			goto error;
 	} else if (!old_state.power_good) {
 		dev_dbg(bq->dev, "Power inserted\n");
 
@@ -682,6 +752,7 @@ static enum power_supply_property bq24257_power_supply_props[] = {
 	POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE,
 	POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX,
 	POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT,
+	POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT,
 };
 
 static char *bq24257_charger_supplied_to[] = {
@@ -694,6 +765,8 @@ static const struct power_supply_desc bq24257_power_supply_desc = {
 	.properties = bq24257_power_supply_props,
 	.num_properties = ARRAY_SIZE(bq24257_power_supply_props),
 	.get_property = bq24257_power_supply_get_property,
+	.set_property = bq24257_power_supply_set_property,
+	.property_is_writeable = bq24257_power_supply_property_is_writeable,
 };
 
 static ssize_t bq24257_show_ovp_voltage(struct device *dev,
-- 
1.9.1


  parent reply	other threads:[~2015-09-28 22:33 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-28 22:33 [PATCH v8 00/14] power: bq24257: Add support for bq24250/bq24251 Andreas Dannenberg
2015-09-28 22:33 ` [PATCH v8 03/14] power: bq24257: Use managed power supply register Andreas Dannenberg
2015-09-28 22:33 ` [PATCH v8 05/14] power: bq24257: Add basic support for bq24250/bq24251 Andreas Dannenberg
     [not found] ` <1443479642-23712-1-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-28 22:33   ` [PATCH v8 01/14] dt: power: bq24257-charger: Cover additional devices Andreas Dannenberg
2015-09-28 22:33   ` [PATCH v8 02/14] power: bq24257: Streamline input current limit setup Andreas Dannenberg
2015-09-28 22:33   ` [PATCH v8 04/14] power: bq24257: Simplify bq24257_power_supply_init() Andreas Dannenberg
2015-09-28 22:33   ` [PATCH v8 06/14] power: bq24257: Add bit definition for temp sense enable Andreas Dannenberg
2015-09-28 22:33   ` [PATCH v8 07/14] power: bq24257: Allow manual setting of input current limit Andreas Dannenberg
2015-09-29  6:07     ` Krzysztof Kozlowski
2015-09-28 22:33   ` [PATCH v8 08/14] power: bq24257: Add SW-based approach for Power Good determination Andreas Dannenberg
     [not found]     ` <1443479642-23712-9-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-29  6:10       ` Krzysztof Kozlowski
2015-09-28 22:33   ` [PATCH v8 10/14] power: bq24257: Add input DPM voltage threshold setting support Andreas Dannenberg
     [not found]     ` <1443479642-23712-11-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-29  6:13       ` Krzysztof Kozlowski
2015-09-28 22:34   ` [PATCH v8 12/14] power: bq24257: Add various device-specific sysfs properties Andreas Dannenberg
2015-09-29  6:15     ` Krzysztof Kozlowski
2015-09-28 22:34   ` [PATCH v8 14/14] Documentation: power: bq24257: Document exported sysfs entries Andreas Dannenberg
     [not found]     ` <1443479642-23712-15-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-29  6:22       ` Krzysztof Kozlowski
2015-09-28 22:33 ` [PATCH v8 09/14] power: bq24257: Add over voltage protection setting support Andreas Dannenberg
     [not found]   ` <1443479642-23712-10-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-29  6:12     ` Krzysztof Kozlowski
2015-09-28 22:33 ` Andreas Dannenberg [this message]
     [not found]   ` <1443479642-23712-12-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-29  6:14     ` [PATCH v8 11/14] power: bq24257: Allow input current limit sysfs access Krzysztof Kozlowski
2015-09-28 22:34 ` [PATCH v8 13/14] power: bq24257: Add platform data based initialization Andreas Dannenberg
2015-10-01  2:58 ` [PATCH v8 00/14] power: bq24257: Add support for bq24250/bq24251 Sebastian Reichel
2015-10-01 16:53   ` Andreas Dannenberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443479642-23712-12-git-send-email-dannenberg@ti.com \
    --to=dannenberg@ti.com \
    --cc=dbaryshkov@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=k.kozlowski@samsung.com \
    --cc=laurentiu.palcu@intel.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=ramakrishna.pallala@intel.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).