* Re: [PATCH v2 07/10] dts/ls2085a: Update DTSI to add support of various peripherals [not found] <1441350322-4671-1-git-send-email-bhupesh.sharma@freescale.com> @ 2015-09-04 21:02 ` Li Yang 2015-09-05 8:37 ` Sharma Bhupesh [not found] ` <CAL_Jsq+9izV8vkrF1tK96M-VRGTMJ+GN5o=RsnCBDcnh-at5kA@mail.gmail.com> 1 sibling, 1 reply; 10+ messages in thread From: Li Yang @ 2015-09-04 21:02 UTC (permalink / raw) To: Bhupesh Sharma Cc: Arnd Bergmann, Mark Rutland, linux-arm-kernel@lists.infradead.org, marc.zyngier, linux-clk, Yangbo Lu, Shaohui Xie, Alison Wang, Catalin.Marinas, will.deacon, Scott Wood, Minghuan Lian, Liu Gang, olof, Nikhil Badola, Bhupesh SHARMA, Jaiprakash Singh, devicetree On Fri, Sep 4, 2015 at 2:05 AM, Bhupesh Sharma <bhupesh.sharma@freescale.com> wrote: > This patch updates the LS2085a DTSI (DTS Include) file to add > support for various peripherals supported by FSL LS2085a SoC, for e.g.: The title and description here are still using the old LS2085 name. > - USB 3.0 Host > - PMU > - CCN-504 > - Watchdog > - SATA > - SPI > - PCIe > - etc. > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@freescale.com> > Signed-off-by: Jaiprakash Singh <b44839@freescale.com> > Signed-off-by: Alison Wang <alison.wang@freescale.com> > Signed-off-by: Liu Gang <Gang.Liu@freescale.com> > Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com> > Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com> > Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com> > Signed-off-by: Yangbo Lu <yangbo.lu@freescale.com> > Signed-off-by: Scott Wood <scottwood@freescale.com> > --- > arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi | 469 +++++++++++++++++++++++- > 1 file changed, 459 insertions(+), 10 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi > index 333d942..5fee0a7 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi > @@ -20,11 +20,6 @@ > * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > * GNU General Public License for more details. > * > - * You should have received a copy of the GNU General Public > - * License along with this library; if not, write to the Free > - * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, > - * MA 02110-1301 USA > - * > * Or, alternatively, > * > * b) Permission is hereby granted, free of charge, to any person > @@ -71,48 +66,56 @@ > device_type = "cpu"; > compatible = "arm,cortex-a57"; > reg = <0x0 0x0>; > + clocks = <&clockgen 1 0>; > }; > > cpu@1 { > device_type = "cpu"; > compatible = "arm,cortex-a57"; > reg = <0x0 0x1>; > + clocks = <&clockgen 1 0>; > }; > > cpu@100 { > device_type = "cpu"; > compatible = "arm,cortex-a57"; > reg = <0x0 0x100>; > + clocks = <&clockgen 1 1>; > }; > > cpu@101 { > device_type = "cpu"; > compatible = "arm,cortex-a57"; > reg = <0x0 0x101>; > + clocks = <&clockgen 1 1>; > }; > > cpu@200 { > device_type = "cpu"; > compatible = "arm,cortex-a57"; > reg = <0x0 0x200>; > + clocks = <&clockgen 1 2>; > }; > > cpu@201 { > device_type = "cpu"; > compatible = "arm,cortex-a57"; > reg = <0x0 0x201>; > + clocks = <&clockgen 1 2>; > }; > > cpu@300 { > device_type = "cpu"; > compatible = "arm,cortex-a57"; > reg = <0x0 0x300>; > + clocks = <&clockgen 1 3>; > }; > > cpu@301 { > device_type = "cpu"; > compatible = "arm,cortex-a57"; > reg = <0x0 0x301>; > + clocks = <&clockgen 1 3>; > }; > }; > > @@ -122,13 +125,44 @@ > /* DRAM space - 1, size : 2 GB DRAM */ > }; > > + pmu { > + compatible = "arm,armv8-pmuv3"; > + interrupts = <1 7 0x8>; /* PMU PPI, Level low type */ > + }; > + > gic: interrupt-controller@6000000 { > compatible = "arm,gic-v3"; > reg = <0x0 0x06000000 0 0x10000>, /* GIC Dist */ > - <0x0 0x06100000 0 0x100000>; /* GICR (RD_base + SGI_base) */ > + <0x0 0x06100000 0 0x100000>, /* GICR (RD_base + SGI_base) */ > + <0x0 0x0c0c0000 0 0x2000>, /* GICC */ > + <0x0 0x0c0d0000 0 0x1000>, /* GICH */ > + <0x0 0x0c0e0000 0 0x20000>; /* GICV */ > #interrupt-cells = <3>; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > interrupt-controller; > interrupts = <1 9 0x4>; > + > + its: gic-its@6020000 { > + compatible = "arm,gic-v3-its"; > + msi-controller; > + reg = <0x0 0x6020000 0 0x20000>; > + }; > + }; > + > + clockgen: clocking@1300000 { > + compatible = "fsl,ls2080a-clockgen"; > + reg = <0 0x1300000 0 0xa0000>; > + #clock-cells = <2>; > + clocks = <&sysclk>; > + > + sysclk: sysclk { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <100000000>; > + clock-output-names = "sysclk"; > + }; > }; > > timer { > @@ -139,25 +173,440 @@ > <1 10 0x8>; /* Hypervisor PPI, active-low */ > }; > > + amba { > + compatible = "arm,amba-bus"; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + cluster1_core0_watchdog: wdt@c000000 { > + compatible = "arm,primecell"; Binding of Primecell requires a specific name for the device instead of just a "arm,primecell". > + reg = <0x0 0xc000000 0x0 0x1000>; > + interrupts = <1 12 0x8>; /* PPI, Level low type */ > + clocks = <&clockgen 4 3>; > + clock-names = "apb_pclk"; > + }; > + > + cluster1_core1_watchdog: wdt@c010000 { > + compatible = "arm,primecell"; > + reg = <0x0 0xc010000 0x0 0x1000>; > + interrupts = <1 12 0x8>; /* PPI, Level low type */ > + clocks = <&clockgen 4 3>; > + clock-names = "apb_pclk"; > + }; > + > + cluster2_core0_watchdog: wdt@c100000 { > + compatible = "arm,primecell"; > + reg = <0x0 0xc100000 0x0 0x1000>; > + interrupts = <1 12 0x8>; /* PPI, Level low type */ > + clocks = <&clockgen 4 3>; > + clock-names = "apb_pclk"; > + }; > + > + cluster2_core1_watchdog: wdt@c110000 { > + compatible = "arm,primecell"; > + reg = <0x0 0xc110000 0x0 0x1000>; > + interrupts = <1 12 0x8>; /* PPI, Level low type */ > + clocks = <&clockgen 4 3>; > + clock-names = "apb_pclk"; > + }; > + > + cluster3_core0_watchdog: wdt@c200000 { > + compatible = "arm,primecell"; > + reg = <0x0 0xc200000 0x0 0x1000>; > + interrupts = <1 12 0x8>; /* PPI, Level low type */ > + clocks = <&clockgen 4 3>; > + clock-names = "apb_pclk"; > + }; > + > + cluster3_core1_watchdog: wdt@c210000 { > + compatible = "arm,primecell"; > + reg = <0x0 0xc210000 0x0 0x1000>; > + interrupts = <1 12 0x8>; /* PPI, Level low type */ > + clocks = <&clockgen 4 3>; > + clock-names = "apb_pclk"; > + }; > + > + cluster4_core0_watchdog: wdt@c300000 { > + compatible = "arm,primecell"; > + reg = <0x0 0xc300000 0x0 0x1000>; > + interrupts = <1 12 0x8>; /* PPI, Level low type */ > + clocks = <&clockgen 4 3>; > + clock-names = "apb_pclk"; > + }; > + > + cluster4_core1_watchdog: wdt@c310000 { > + compatible = "arm,primecell"; > + reg = <0x0 0xc310000 0x0 0x1000>; > + interrupts = <1 12 0x8>; /* PPI, Level low type */ > + clocks = <&clockgen 4 3>; > + clock-names = "apb_pclk"; > + }; > + }; > + > serial0: serial@21c0500 { > device_type = "serial"; > compatible = "fsl,ns16550", "ns16550a"; > reg = <0x0 0x21c0500 0x0 0x100>; > - clock-frequency = <0>; /* Updated by bootloader */ > - interrupts = <0 32 0x1>; /* edge triggered */ > + clocks = <&clockgen 4 3>; > + interrupts = <0 32 0x4>; /* Level high type */ > }; > > serial1: serial@21c0600 { > device_type = "serial"; > compatible = "fsl,ns16550", "ns16550a"; > reg = <0x0 0x21c0600 0x0 0x100>; > - clock-frequency = <0>; /* Updated by bootloader */ > - interrupts = <0 32 0x1>; /* edge triggered */ > + clocks = <&clockgen 4 3>; > + interrupts = <0 32 0x4>; /* Level high type */ > }; > > fsl_mc: fsl-mc@80c000000 { > compatible = "fsl,qoriq-mc"; > + #stream-id-cells = <2>; > reg = <0x00000008 0x0c000000 0 0x40>, /* MC portal base */ > <0x00000000 0x08340000 0 0x40000>; /* MC control reg */ > + lpi-parent = <&its>; > + }; > + > + smmu: iommu@5000000 { > + compatible = "arm,mmu-500"; > + reg = <0 0x5000000 0 0x800000>; > + #global-interrupts = <12>; > + interrupts = <0 13 4>, /* global secure fault */ > + <0 14 4>, /* combined secure interrupt */ > + <0 15 4>, /* global non-secure fault */ > + <0 16 4>, /* combined non-secure interrupt */ > + /* performance counter interrupts 0-7 */ > + <0 211 4>, > + <0 212 4>, > + <0 213 4>, > + <0 214 4>, > + <0 215 4>, > + <0 216 4>, > + <0 217 4>, > + <0 218 4>, > + /* per context interrupt, 64 interrupts */ > + <0 146 4>, > + <0 147 4>, > + <0 148 4>, > + <0 149 4>, > + <0 150 4>, > + <0 151 4>, > + <0 152 4>, > + <0 153 4>, > + <0 154 4>, > + <0 155 4>, > + <0 156 4>, > + <0 157 4>, > + <0 158 4>, > + <0 159 4>, > + <0 160 4>, > + <0 161 4>, > + <0 162 4>, > + <0 163 4>, > + <0 164 4>, > + <0 165 4>, > + <0 166 4>, > + <0 167 4>, > + <0 168 4>, > + <0 169 4>, > + <0 170 4>, > + <0 171 4>, > + <0 172 4>, > + <0 173 4>, > + <0 174 4>, > + <0 175 4>, > + <0 176 4>, > + <0 177 4>, > + <0 178 4>, > + <0 179 4>, > + <0 180 4>, > + <0 181 4>, > + <0 182 4>, > + <0 183 4>, > + <0 184 4>, > + <0 185 4>, > + <0 186 4>, > + <0 187 4>, > + <0 188 4>, > + <0 189 4>, > + <0 190 4>, > + <0 191 4>, > + <0 192 4>, > + <0 193 4>, > + <0 194 4>, > + <0 195 4>, > + <0 196 4>, > + <0 197 4>, > + <0 198 4>, > + <0 199 4>, > + <0 200 4>, > + <0 201 4>, > + <0 202 4>, > + <0 203 4>, > + <0 204 4>, > + <0 205 4>, > + <0 206 4>, > + <0 207 4>, > + <0 208 4>, > + <0 209 4>; > + mmu-masters = <&fsl_mc 0x300 0>; Are we really only having one mmu-master? > + }; > + > + dspi: dspi@2100000 { > + compatible = "fsl,vf610-dspi"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x0 0x2100000 0x0 0x10000>; > + interrupts = <0 26 0x4>; /* Level high type */ > + tcfq-mode; Can not find this property in the binding. > + clocks = <&clockgen 4 3>; > + clock-names = "dspi"; > + spi-num-chipselects = <5>; > + bus-num = <0>; > + spi-cpol; > + spi-cpha; These two are not defined either. > + }; > + > + esdhc: esdhc@2140000 { > + compatible = "fsl,ls2080a-esdhc", "fsl,esdhc"; > + reg = <0x0 0x2140000 0x0 0x10000>; > + interrupts = <0 28 0x4>; /* Level high type */ > + clock-frequency = <0>; /* Updated by bootloader */ > + voltage-ranges = <1800 1800 3300 3300>; > + sdhci,auto-cmd12; > + little-endian; The patch for defining this property is still pending. > + bus-width = <4>; > + }; > + > + gpio0: gpio@2300000 { > + compatible = "fsl,ls2080a-gpio"; Maybe you should add a more generic compatible string here. It's not clear which driver/binding you are actually using, mpc8xxx, imx or vf610? > + reg = <0x0 0x2300000 0x0 0x10000>; > + interrupts = <0 36 0x4>; /* Level high type */ > + gpio-controller; > + #gpio-cells = <2>; > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpio1: gpio@2310000 { > + compatible = "fsl,ls2080a-gpio"; > + reg = <0x0 0x2310000 0x0 0x10000>; > + interrupts = <0 36 0x4>; /* Level high type */ > + gpio-controller; > + #gpio-cells = <2>; > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpio2: gpio@2320000 { > + compatible = "fsl,ls2080a-gpio"; > + reg = <0x0 0x2320000 0x0 0x10000>; > + interrupts = <0 37 0x4>; /* Level high type */ > + gpio-controller; > + #gpio-cells = <2>; > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpio3: gpio@2330000 { > + compatible = "fsl,ls2080a-gpio"; > + reg = <0x0 0x2330000 0x0 0x10000>; > + interrupts = <0 37 0x4>; /* Level high type */ > + gpio-controller; > + #gpio-cells = <2>; > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + i2c0: i2c@2000000 { > + compatible = "fsl,vf610-i2c"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x0 0x2000000 0x0 0x10000>; > + interrupts = <0 34 0x4>; /* Level high type */ > + clock-names = "i2c"; > + clocks = <&clockgen 4 3>; > + }; > + > + i2c1: i2c@2010000 { > + compatible = "fsl,vf610-i2c"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x0 0x2010000 0x0 0x10000>; > + interrupts = <0 34 0x4>; /* Level high type */ > + clock-names = "i2c"; > + clocks = <&clockgen 4 3>; > + }; > + > + i2c2: i2c@2020000 { > + compatible = "fsl,vf610-i2c"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x0 0x2020000 0x0 0x10000>; > + interrupts = <0 35 0x4>; /* Level high type */ > + clock-names = "i2c"; > + clocks = <&clockgen 4 3>; > + }; > + > + i2c3: i2c@2030000 { > + compatible = "fsl,vf610-i2c"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x0 0x2030000 0x0 0x10000>; > + interrupts = <0 35 0x4>; /* Level high type */ > + clock-names = "i2c"; > + clocks = <&clockgen 4 3>; > + }; > + > + ifc: ifc@2240000 { > + compatible = "fsl,ifc", "simple-bus"; > + reg = <0x0 0x2240000 0x0 0x20000>; > + interrupts = <0 21 0x4>; /* Level high type */ > + little-endian; > + #address-cells = <2>; > + #size-cells = <1>; > + > + ranges = <0 0 0x5 0x80000000 0x08000000 > + 2 0 0x5 0x30000000 0x00010000 > + 3 0 0x5 0x20000000 0x00010000>; > + }; > + > + qspi: quadspi@20c0000 { > + compatible = "fsl,vf610-qspi"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x0 0x20c0000 0x0 0x10000>, > + <0x0 0x20000000 0x0 0x10000000>; > + reg-names = "QuadSPI", "QuadSPI-memory"; > + interrupts = <0 25 0x4>; /* Level high type */ > + clocks = <&clockgen 4 3>, <&clockgen 4 3>; > + clock-names = "qspi_en", "qspi"; > + }; > + > + pcie@3400000 { > + compatible = "fsl,ls2080a-pcie", "snps,dw-pcie"; > + reg = <0x00 0x03400000 0x0 0x00100000 /* controller registers */ > + 0x10 0x00000000 0x0 0x00001000>; /* configuration space */ > + reg-names = "regs", "config"; > + interrupts = <0 108 0x4>; /* Level high type */ > + interrupt-names = "intr"; > + #address-cells = <3>; > + #size-cells = <2>; > + device_type = "pci"; > + num-lanes = <4>; > + bus-range = <0x0 0xff>; > + ranges = <0x81000000 0x0 0x00000000 0x10 0x00010000 0x0 0x00010000 /* downstream I/O */ > + 0x82000000 0x0 0x40000000 0x10 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */ > + msi-parent = <&its>; > + #interrupt-cells = <1>; > + interrupt-map-mask = <0 0 0 7>; > + interrupt-map = <0000 0 0 1 &gic 0 0 0 109 4>, > + <0000 0 0 2 &gic 0 0 0 110 4>, > + <0000 0 0 3 &gic 0 0 0 111 4>, > + <0000 0 0 4 &gic 0 0 0 112 4>; Binding shows it requires clocks and clock-names property. > + }; > + > + pcie@3500000 { > + compatible = "fsl,ls2080a-pcie", "snps,dw-pcie"; > + reg = <0x00 0x03500000 0x0 0x00100000 /* controller registers */ > + 0x12 0x00000000 0x0 0x00001000>; /* configuration space */ > + reg-names = "regs", "config"; > + interrupts = <0 113 0x4>; /* Level high type */ > + interrupt-names = "intr"; > + #address-cells = <3>; > + #size-cells = <2>; > + device_type = "pci"; > + num-lanes = <4>; > + bus-range = <0x0 0xff>; > + ranges = <0x81000000 0x0 0x00000000 0x12 0x00010000 0x0 0x00010000 /* downstream I/O */ > + 0x82000000 0x0 0x40000000 0x12 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */ > + msi-parent = <&its>; > + #interrupt-cells = <1>; > + interrupt-map-mask = <0 0 0 7>; > + interrupt-map = <0000 0 0 1 &gic 0 0 0 114 4>, > + <0000 0 0 2 &gic 0 0 0 115 4>, > + <0000 0 0 3 &gic 0 0 0 116 4>, > + <0000 0 0 4 &gic 0 0 0 117 4>; > + }; > + > + pcie@3600000 { > + compatible = "fsl,ls2080a-pcie", "snps,dw-pcie"; > + reg = <0x00 0x03600000 0x0 0x00100000 /* controller registers */ > + 0x14 0x00000000 0x0 0x00001000>; /* configuration space */ > + reg-names = "regs", "config"; > + interrupts = <0 118 0x4>; /* Level high type */ > + interrupt-names = "intr"; > + #address-cells = <3>; > + #size-cells = <2>; > + device_type = "pci"; > + num-lanes = <8>; > + bus-range = <0x0 0xff>; > + ranges = <0x81000000 0x0 0x00000000 0x14 0x00010000 0x0 0x00010000 /* downstream I/O */ > + 0x82000000 0x0 0x40000000 0x14 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */ > + msi-parent = <&its>; > + #interrupt-cells = <1>; > + interrupt-map-mask = <0 0 0 7>; > + interrupt-map = <0000 0 0 1 &gic 0 0 0 119 4>, > + <0000 0 0 2 &gic 0 0 0 120 4>, > + <0000 0 0 3 &gic 0 0 0 121 4>, > + <0000 0 0 4 &gic 0 0 0 122 4>; > + }; > + > + pcie@3700000 { > + compatible = "fsl,ls2080a-pcie", "snps,dw-pcie"; > + reg = <0x00 0x03700000 0x0 0x00100000 /* controller registers */ > + 0x16 0x00000000 0x0 0x00001000>; /* configuration space */ > + reg-names = "regs", "config"; > + interrupts = <0 123 0x4>; /* Level high type */ > + interrupt-names = "intr"; > + #address-cells = <3>; > + #size-cells = <2>; > + device_type = "pci"; > + num-lanes = <4>; > + bus-range = <0x0 0xff>; > + ranges = <0x81000000 0x0 0x00000000 0x16 0x00010000 0x0 0x00010000 /* downstream I/O */ > + 0x82000000 0x0 0x40000000 0x16 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */ > + msi-parent = <&its>; > + #interrupt-cells = <1>; > + interrupt-map-mask = <0 0 0 7>; > + interrupt-map = <0000 0 0 1 &gic 0 0 0 124 4>, > + <0000 0 0 2 &gic 0 0 0 125 4>, > + <0000 0 0 3 &gic 0 0 0 126 4>, > + <0000 0 0 4 &gic 0 0 0 127 4>; > + }; > + > + sata0: sata@3200000 { > + compatible = "fsl,ls2080a-ahci", "fsl,ls1021a-ahci"; Binding requires a more general compatible fsl,qoriq-ahci > + reg = <0x0 0x3200000 0x0 0x10000>; > + interrupts = <0 133 0x4>; /* Level high type */ > + clocks = <&clockgen 4 3>; > + }; > + > + sata1: sata@3210000 { > + compatible = "fsl,ls2080a-ahci", "fsl,ls1021a-ahci"; > + reg = <0x0 0x3210000 0x0 0x10000>; > + interrupts = <0 136 0x4>; /* Level high type */ > + clocks = <&clockgen 4 3>; > + }; > + > + usb0: usb3@3100000 { > + compatible = "snps,dwc3"; > + reg = <0x0 0x3100000 0x0 0x10000>; > + interrupts = <0 80 0x4>; /* Level high type */ > + dr_mode = "host"; dr_mode not defined in dwc3 binding. > + }; > + > + usb1: usb3@3110000 { > + compatible = "snps,dwc3"; > + reg = <0x0 0x3110000 0x0 0x10000>; > + interrupts = <0 81 0x4>; /* Level high type */ > + dr_mode = "host"; > + }; > + > + ccn@4000000 { > + compatible = "arm,ccn-504"; > + reg = <0x0 0x04000000 0x0 0x01000000>; > + interrupts = <0 12 4>; > }; > }; > -- > 1.7.9.5 > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- - Leo ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH v2 07/10] dts/ls2085a: Update DTSI to add support of various peripherals 2015-09-04 21:02 ` [PATCH v2 07/10] dts/ls2085a: Update DTSI to add support of various peripherals Li Yang @ 2015-09-05 8:37 ` Sharma Bhupesh 2015-09-06 20:57 ` Rob Herring 0 siblings, 1 reply; 10+ messages in thread From: Sharma Bhupesh @ 2015-09-05 8:37 UTC (permalink / raw) To: Li Leo, Xiaobo Xie, Liu Gang, Lian M.H., Badola Nikhil Cc: Mark Rutland, devicetree@vger.kernel.org, Shaohui Xie, Arnd Bergmann, Huan Wang, marc.zyngier@arm.com, Catalin.Marinas@arm.com, Singh Jaiprakash, will.deacon@arm.com, olof@lixom.net, Scott Wood, Bhupesh SHARMA, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lu Y.B. > From: pku.leo@gmail.com [mailto:pku.leo@gmail.com] > Sent: Saturday, September 05, 2015 2:33 AM > On Fri, Sep 4, 2015 at 2:05 AM, Bhupesh Sharma > <bhupesh.sharma@freescale.com> wrote: > > This patch updates the LS2085a DTSI (DTS Include) file to add support > > for various peripherals supported by FSL LS2085a SoC, for e.g.: > > The title and description here are still using the old LS2085 name. Ok. [snip] .. > > + amba { > > + compatible = "arm,amba-bus"; > > + #address-cells = <2>; > > + #size-cells = <2>; > > + ranges; > > + > > + cluster1_core0_watchdog: wdt@c000000 { > > + compatible = "arm,primecell"; > > Binding of Primecell requires a specific name for the device instead of > just a "arm,primecell". The sp805 driver doesn't have a compatible string like arm, sp805. You can refer to 'Documentation/devicetree/bindings/wdt' for details - there is no entry for sp805 here. Instead it relies on the 'drivers/amba/bus.c' framework to invoke the probe function of the sp805 wdt driver using the unique PRIMECELL identifiers of the sp805 wdt IP. See Appendix A of 'devicetree/usage-model.txt' for details: http://lxr.free-electrons.com/source/Documentation/devicetree/usage-model.txt#L398 > > + smmu: iommu@5000000 { > > + compatible = "arm,mmu-500"; > > + reg = <0 0x5000000 0 0x800000>; > > + #global-interrupts = <12>; > > + interrupts = <0 13 4>, /* global secure fault */ > > + <0 14 4>, /* combined secure interrupt */ > > + <0 15 4>, /* global non-secure fault */ > > + <0 16 4>, /* combined non-secure interrupt > */ > > + /* performance counter interrupts 0-7 */ > > + <0 211 4>, > > + <0 212 4>, > > + <0 213 4>, > > + <0 214 4>, > > + <0 215 4>, > > + <0 216 4>, > > + <0 217 4>, > > + <0 218 4>, > > + /* per context interrupt, 64 interrupts */ > > + <0 146 4>, > > + <0 147 4>, > > + <0 148 4>, > > + <0 149 4>, > > + <0 150 4>, > > + <0 151 4>, > > + <0 152 4>, > > + <0 153 4>, > > + <0 154 4>, > > + <0 155 4>, > > + <0 156 4>, > > + <0 157 4>, > > + <0 158 4>, > > + <0 159 4>, > > + <0 160 4>, > > + <0 161 4>, > > + <0 162 4>, > > + <0 163 4>, > > + <0 164 4>, > > + <0 165 4>, > > + <0 166 4>, > > + <0 167 4>, > > + <0 168 4>, > > + <0 169 4>, > > + <0 170 4>, > > + <0 171 4>, > > + <0 172 4>, > > + <0 173 4>, > > + <0 174 4>, > > + <0 175 4>, > > + <0 176 4>, > > + <0 177 4>, > > + <0 178 4>, > > + <0 179 4>, > > + <0 180 4>, > > + <0 181 4>, > > + <0 182 4>, > > + <0 183 4>, > > + <0 184 4>, > > + <0 185 4>, > > + <0 186 4>, > > + <0 187 4>, > > + <0 188 4>, > > + <0 189 4>, > > + <0 190 4>, > > + <0 191 4>, > > + <0 192 4>, > > + <0 193 4>, > > + <0 194 4>, > > + <0 195 4>, > > + <0 196 4>, > > + <0 197 4>, > > + <0 198 4>, > > + <0 199 4>, > > + <0 200 4>, > > + <0 201 4>, > > + <0 202 4>, > > + <0 203 4>, > > + <0 204 4>, > > + <0 205 4>, > > + <0 206 4>, > > + <0 207 4>, > > + <0 208 4>, > > + <0 209 4>; > > + mmu-masters = <&fsl_mc 0x300 0>; > > Are we really only having one mmu-master? So far only this one is tested. Later on others can be added when we have tested them with SMMU APIs as well. > > + }; > > + > > + dspi: dspi@2100000 { > > + compatible = "fsl,vf610-dspi"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <0x0 0x2100000 0x0 0x10000>; > > + interrupts = <0 26 0x4>; /* Level high type */ > > + tcfq-mode; > > Can not find this property in the binding. Xiaobo, can you please answer Leo's comment here. Thanks. > > + clocks = <&clockgen 4 3>; > > + clock-names = "dspi"; > > + spi-num-chipselects = <5>; > > + bus-num = <0>; > > + spi-cpol; > > + spi-cpha; > > These two are not defined either. Xiaobo, can you please answer Leo's comment here. Thanks. > > + }; > > + > > + esdhc: esdhc@2140000 { > > + compatible = "fsl,ls2080a-esdhc", "fsl,esdhc"; > > + reg = <0x0 0x2140000 0x0 0x10000>; > > + interrupts = <0 28 0x4>; /* Level high type */ > > + clock-frequency = <0>; /* Updated by bootloader */ > > + voltage-ranges = <1800 1800 3300 3300>; > > + sdhci,auto-cmd12; > > + little-endian; > > The patch for defining this property is still pending. Xiaobo, can you please answer Leo's comment here. Thanks. > > > + bus-width = <4>; > > + }; > > + > > + gpio0: gpio@2300000 { > > + compatible = "fsl,ls2080a-gpio"; > > Maybe you should add a more generic compatible string here. It's not > clear which driver/binding you are actually using, mpc8xxx, imx or vf610? Liu Gang, can you please answer Leo's comment here. Thanks. > > + reg = <0x0 0x2300000 0x0 0x10000>; > > + interrupts = <0 36 0x4>; /* Level high type */ > > + gpio-controller; > > + #gpio-cells = <2>; > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + }; > > + [snip] .. > > + pcie@3400000 { > > + compatible = "fsl,ls2080a-pcie", "snps,dw-pcie"; > > + reg = <0x00 0x03400000 0x0 0x00100000 /* controller > registers */ > > + 0x10 0x00000000 0x0 0x00001000>; /* > configuration space */ > > + reg-names = "regs", "config"; > > + interrupts = <0 108 0x4>; /* Level high type */ > > + interrupt-names = "intr"; > > + #address-cells = <3>; > > + #size-cells = <2>; > > + device_type = "pci"; > > + num-lanes = <4>; > > + bus-range = <0x0 0xff>; > > + ranges = <0x81000000 0x0 0x00000000 0x10 0x00010000 0x0 > 0x00010000 /* downstream I/O */ > > + 0x82000000 0x0 0x40000000 0x10 0x40000000 0x0 > 0x40000000>; /* non-prefetchable memory */ > > + msi-parent = <&its>; > > + #interrupt-cells = <1>; > > + interrupt-map-mask = <0 0 0 7>; > > + interrupt-map = <0000 0 0 1 &gic 0 0 0 109 4>, > > + <0000 0 0 2 &gic 0 0 0 110 4>, > > + <0000 0 0 3 &gic 0 0 0 111 4>, > > + <0000 0 0 4 &gic 0 0 0 112 4>; > > Binding shows it requires clocks and clock-names property. Minghuan, can you please answer Leo's comment here. Thanks. > > + }; > > + [snip] .. > > + > > + usb0: usb3@3100000 { > > + compatible = "snps,dwc3"; > > + reg = <0x0 0x3100000 0x0 0x10000>; > > + interrupts = <0 80 0x4>; /* Level high type */ > > + dr_mode = "host"; > > dr_mode not defined in dwc3 binding. Nikhil, I think you have already sent out a patch which addresses the same. Can you please update this thread with the link of the same? Thanks. [snip] .. Regards, Bhupesh ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 07/10] dts/ls2085a: Update DTSI to add support of various peripherals 2015-09-05 8:37 ` Sharma Bhupesh @ 2015-09-06 20:57 ` Rob Herring 2015-09-06 21:03 ` Sharma Bhupesh 0 siblings, 1 reply; 10+ messages in thread From: Rob Herring @ 2015-09-06 20:57 UTC (permalink / raw) To: Sharma Bhupesh Cc: Li Leo, Xiaobo Xie, Liu Gang, Lian M.H., Badola Nikhil, Mark Rutland, devicetree@vger.kernel.org, Shaohui Xie, Arnd Bergmann, Huan Wang, marc.zyngier@arm.com, Catalin.Marinas@arm.com, Singh Jaiprakash, will.deacon@arm.com, olof@lixom.net, Scott Wood, Bhupesh SHARMA, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lu Y.B. On Sat, Sep 5, 2015 at 3:37 AM, Sharma Bhupesh <bhupesh.sharma@freescale.com> wrote: >> From: pku.leo@gmail.com [mailto:pku.leo@gmail.com] >> Sent: Saturday, September 05, 2015 2:33 AM >> On Fri, Sep 4, 2015 at 2:05 AM, Bhupesh Sharma >> <bhupesh.sharma@freescale.com> wrote: >> > This patch updates the LS2085a DTSI (DTS Include) file to add support >> > for various peripherals supported by FSL LS2085a SoC, for e.g.: >> >> The title and description here are still using the old LS2085 name. > > Ok. > > [snip] .. > >> > + amba { >> > + compatible = "arm,amba-bus"; >> > + #address-cells = <2>; >> > + #size-cells = <2>; >> > + ranges; >> > + >> > + cluster1_core0_watchdog: wdt@c000000 { >> > + compatible = "arm,primecell"; >> >> Binding of Primecell requires a specific name for the device instead of >> just a "arm,primecell". > > The sp805 driver doesn't have a compatible string like arm, sp805. > You can refer to 'Documentation/devicetree/bindings/wdt' for details - there is no entry for sp805 here. Because no one wrote it yet. Please read Documentation/devicetree/bindings/arm/primecell.txt. If sp805 has no binding doc, please write one. > Instead it relies on the 'drivers/amba/bus.c' framework to invoke the probe function of the > sp805 wdt driver using the unique PRIMECELL identifiers of the sp805 wdt IP. Whether the kernel chooses to bind with the ID registers or compatible strings is up to the kernel. That is independent of the bindings. Rob ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH v2 07/10] dts/ls2085a: Update DTSI to add support of various peripherals 2015-09-06 20:57 ` Rob Herring @ 2015-09-06 21:03 ` Sharma Bhupesh 2015-09-07 20:58 ` Rob Herring 0 siblings, 1 reply; 10+ messages in thread From: Sharma Bhupesh @ 2015-09-06 21:03 UTC (permalink / raw) To: Rob Herring Cc: Mark Rutland, devicetree@vger.kernel.org, Bhupesh SHARMA, Shaohui Xie, Arnd Bergmann, Huan Wang, marc.zyngier@arm.com, Catalin.Marinas@arm.com, Singh Jaiprakash, will.deacon@arm.com, Scott Wood, Lian M.H., Liu Gang, linux-arm-kernel@lists.infradead.org, olof@lixom.net, Badola Nikhil, Li Leo, linux-clk@vger.kernel.org, Xiaobo Xie, Lu Y.B. > From: Rob Herring [mailto:robherring2@gmail.com] > Sent: Monday, September 07, 2015 2:27 AM > On Sat, Sep 5, 2015 at 3:37 AM, Sharma Bhupesh > <bhupesh.sharma@freescale.com> wrote: > >> From: pku.leo@gmail.com [mailto:pku.leo@gmail.com] > >> Sent: Saturday, September 05, 2015 2:33 AM On Fri, Sep 4, 2015 at > >> 2:05 AM, Bhupesh Sharma <bhupesh.sharma@freescale.com> wrote: > >> > This patch updates the LS2085a DTSI (DTS Include) file to add > >> > support for various peripherals supported by FSL LS2085a SoC, for > e.g.: > >> > >> The title and description here are still using the old LS2085 name. > > > > Ok. > > > > [snip] .. > > > >> > + amba { > >> > + compatible = "arm,amba-bus"; > >> > + #address-cells = <2>; > >> > + #size-cells = <2>; > >> > + ranges; > >> > + > >> > + cluster1_core0_watchdog: wdt@c000000 { > >> > + compatible = "arm,primecell"; > >> > >> Binding of Primecell requires a specific name for the device instead > >> of just a "arm,primecell". > > > > The sp805 driver doesn't have a compatible string like arm, sp805. > > You can refer to 'Documentation/devicetree/bindings/wdt' for details - > there is no entry for sp805 here. > > Because no one wrote it yet. Please read > Documentation/devicetree/bindings/arm/primecell.txt. If sp805 has no > binding doc, please write one. > > > Instead it relies on the 'drivers/amba/bus.c' framework to invoke the > > probe function of the > > sp805 wdt driver using the unique PRIMECELL identifiers of the sp805 > wdt IP. > > Whether the kernel chooses to bind with the ID registers or compatible > strings is up to the kernel. That is independent of the bindings. > Right. But wouldn't the driver require DTS awareness to handle the compatible string then. Shouldn't the DTS awareness added both in terms of bindings and driver handling? Regards, Bhupesh ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 07/10] dts/ls2085a: Update DTSI to add support of various peripherals 2015-09-06 21:03 ` Sharma Bhupesh @ 2015-09-07 20:58 ` Rob Herring 2015-09-09 3:55 ` Sharma Bhupesh 0 siblings, 1 reply; 10+ messages in thread From: Rob Herring @ 2015-09-07 20:58 UTC (permalink / raw) To: Sharma Bhupesh Cc: Li Leo, Xiaobo Xie, Liu Gang, Lian M.H., Badola Nikhil, Mark Rutland, devicetree@vger.kernel.org, Shaohui Xie, Arnd Bergmann, Huan Wang, marc.zyngier@arm.com, Catalin.Marinas@arm.com, Singh Jaiprakash, will.deacon@arm.com, olof@lixom.net, Scott Wood, Bhupesh SHARMA, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lu Y.B. On Sun, Sep 6, 2015 at 4:03 PM, Sharma Bhupesh <bhupesh.sharma@freescale.com> wrote: >> From: Rob Herring [mailto:robherring2@gmail.com] >> Sent: Monday, September 07, 2015 2:27 AM >> On Sat, Sep 5, 2015 at 3:37 AM, Sharma Bhupesh >> <bhupesh.sharma@freescale.com> wrote: >> >> From: pku.leo@gmail.com [mailto:pku.leo@gmail.com] >> >> Sent: Saturday, September 05, 2015 2:33 AM On Fri, Sep 4, 2015 at >> >> 2:05 AM, Bhupesh Sharma <bhupesh.sharma@freescale.com> wrote: >> >> > This patch updates the LS2085a DTSI (DTS Include) file to add >> >> > support for various peripherals supported by FSL LS2085a SoC, for >> e.g.: >> >> >> >> The title and description here are still using the old LS2085 name. >> > >> > Ok. >> > >> > [snip] .. >> > >> >> > + amba { >> >> > + compatible = "arm,amba-bus"; >> >> > + #address-cells = <2>; >> >> > + #size-cells = <2>; >> >> > + ranges; >> >> > + >> >> > + cluster1_core0_watchdog: wdt@c000000 { >> >> > + compatible = "arm,primecell"; >> >> >> >> Binding of Primecell requires a specific name for the device instead >> >> of just a "arm,primecell". >> > >> > The sp805 driver doesn't have a compatible string like arm, sp805. >> > You can refer to 'Documentation/devicetree/bindings/wdt' for details - >> there is no entry for sp805 here. >> >> Because no one wrote it yet. Please read >> Documentation/devicetree/bindings/arm/primecell.txt. If sp805 has no >> binding doc, please write one. >> >> > Instead it relies on the 'drivers/amba/bus.c' framework to invoke the >> > probe function of the >> > sp805 wdt driver using the unique PRIMECELL identifiers of the sp805 >> wdt IP. >> >> Whether the kernel chooses to bind with the ID registers or compatible >> strings is up to the kernel. That is independent of the bindings. >> > > Right. But wouldn't the driver require DTS awareness to handle the compatible string then. > Shouldn't the DTS awareness added both in terms of bindings and driver handling? No. The OS is free to do device enumeration however it sees fit and that could change independent of the DT. Rob > > Regards, > Bhupesh ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH v2 07/10] dts/ls2085a: Update DTSI to add support of various peripherals 2015-09-07 20:58 ` Rob Herring @ 2015-09-09 3:55 ` Sharma Bhupesh 0 siblings, 0 replies; 10+ messages in thread From: Sharma Bhupesh @ 2015-09-09 3:55 UTC (permalink / raw) To: Rob Herring Cc: Mark Rutland, devicetree@vger.kernel.org, Bhupesh SHARMA, Shaohui Xie, Arnd Bergmann, Huan Wang, marc.zyngier@arm.com, Catalin.Marinas@arm.com, Singh Jaiprakash, will.deacon@arm.com, Scott Wood, Lian M.H., Liu Gang, linux-arm-kernel@lists.infradead.org, olof@lixom.net, Badola Nikhil, Li Leo, linux-clk@vger.kernel.org, Xiaobo Xie, Lu Y.B. > From: Rob Herring [mailto:robherring2@gmail.com] > Sent: Tuesday, September 08, 2015 2:28 AM > On Sun, Sep 6, 2015 at 4:03 PM, Sharma Bhupesh > <bhupesh.sharma@freescale.com> wrote: > >> From: Rob Herring [mailto:robherring2@gmail.com] > >> Sent: Monday, September 07, 2015 2:27 AM On Sat, Sep 5, 2015 at 3:37 > >> AM, Sharma Bhupesh <bhupesh.sharma@freescale.com> wrote: > >> >> From: pku.leo@gmail.com [mailto:pku.leo@gmail.com] > >> >> Sent: Saturday, September 05, 2015 2:33 AM On Fri, Sep 4, 2015 at > >> >> 2:05 AM, Bhupesh Sharma <bhupesh.sharma@freescale.com> wrote: > >> >> > This patch updates the LS2085a DTSI (DTS Include) file to add > >> >> > support for various peripherals supported by FSL LS2085a SoC, > >> >> > for > >> e.g.: > >> >> > >> >> The title and description here are still using the old LS2085 name. > >> > > >> > Ok. > >> > > >> > [snip] .. > >> > > >> >> > + amba { > >> >> > + compatible = "arm,amba-bus"; > >> >> > + #address-cells = <2>; > >> >> > + #size-cells = <2>; > >> >> > + ranges; > >> >> > + > >> >> > + cluster1_core0_watchdog: wdt@c000000 { > >> >> > + compatible = "arm,primecell"; > >> >> > >> >> Binding of Primecell requires a specific name for the device > >> >> instead of just a "arm,primecell". > >> > > >> > The sp805 driver doesn't have a compatible string like arm, sp805. > >> > You can refer to 'Documentation/devicetree/bindings/wdt' for > >> > details - > >> there is no entry for sp805 here. > >> > >> Because no one wrote it yet. Please read > >> Documentation/devicetree/bindings/arm/primecell.txt. If sp805 has no > >> binding doc, please write one. > >> > >> > Instead it relies on the 'drivers/amba/bus.c' framework to invoke > >> > the probe function of the > >> > sp805 wdt driver using the unique PRIMECELL identifiers of the > >> > sp805 > >> wdt IP. > >> > >> Whether the kernel chooses to bind with the ID registers or > >> compatible strings is up to the kernel. That is independent of the > bindings. > >> > > > > Right. But wouldn't the driver require DTS awareness to handle the > compatible string then. > > Shouldn't the DTS awareness added both in terms of bindings and driver > handling? > > No. The OS is free to do device enumeration however it sees fit and that > could change independent of the DT. Ok. Will address this in v3 of this patchset then. Regards, Bhupesh ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <CAL_Jsq+9izV8vkrF1tK96M-VRGTMJ+GN5o=RsnCBDcnh-at5kA@mail.gmail.com>]
[parent not found: <CALRxmdC9ZzGiw6CVnVTqhH1xvA-P9s8cpYbk8DoVq7CodFS0VA@mail.gmail.com>]
[parent not found: <CY1PR0301MB0748A8F37E3FBE1922AF9D3F874C0@CY1PR0301MB0748.namprd03.prod.outlook.com>]
* Re: [PATCH v2 07/10] dts/ls2085a: Update DTSI to add support of various peripherals [not found] ` <CY1PR0301MB0748A8F37E3FBE1922AF9D3F874C0@CY1PR0301MB0748.namprd03.prod.outlook.com> @ 2015-10-01 21:42 ` Li Yang 2015-10-01 21:58 ` Scott Wood 0 siblings, 1 reply; 10+ messages in thread From: Li Yang @ 2015-10-01 21:42 UTC (permalink / raw) To: Stuart Yoder Cc: Rob Herring, Mark Rutland, Shaohui Xie, Arnd Bergmann, Huan Wang, Sharma Bhupesh, Catalin Marinas, Singh Jaiprakash, Will Deacon, Lian M.H., Scott Wood, Marc Zyngier, Liu Gang, Olof Johansson, Badola Nikhil-B46172, Bhupesh SHARMA, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lu Y.B., devicetree On Thu, Oct 1, 2015 at 3:05 PM, Stuart Yoder <stuart.yoder@freescale.com> wrote: > Hi Rob, > > Had a question about your comments on the patch below. > > You singled out 3 nodes (gic,uart,clockgen) and said "This should be under a bus node." > > What is special about those 3 nodes types? There are a bunch of other memory > mapped SoC devices as well in the DTS. > > I skimmed the dts files under arch/arm64 and it looks like most have a simple-bus > SoC node like this where SoC devices are under: > > soc { > #address-cells = <2>; > #size-cells = <2>; > compatible = "simple-bus"; > ranges; > > Is that what you are looking for-- for all SoC devices? I think the key is to have the soc node and have all the on-chip devices defined underneath it. I read the following from the booting-without-of.txt document: f) the /soc<SOCname> node This node is used to represent a system-on-a-chip (SoC) and must be present if the processor is a SoC. The top-level soc node contains information that is global to all devices on the SoC. The node name should contain a unit address for the SoC, which is the base address of the memory-mapped register set for the SoC. The name of an SoC node should start with "soc", and the remainder of the name should represent the part number for the soc. For example, the MPC8540's soc node would be called "soc8540". A lot of device trees didn't follow the soc<SOCname> naming scheme and just used "soc" as the node name. I am not sure if we want to enforce the naming in the future or update the document to make it more relax. Regards, Leo ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 07/10] dts/ls2085a: Update DTSI to add support of various peripherals 2015-10-01 21:42 ` Li Yang @ 2015-10-01 21:58 ` Scott Wood 2015-10-01 22:41 ` Li Yang 0 siblings, 1 reply; 10+ messages in thread From: Scott Wood @ 2015-10-01 21:58 UTC (permalink / raw) To: Li Yang Cc: Mark Rutland, devicetree, Shaohui Xie, Arnd Bergmann, Huan Wang, Sharma Bhupesh, Catalin Marinas, Olof Johansson, Singh Jaiprakash, Stuart Yoder, Will Deacon, Lian M.H., Liu Gang, Rob Herring, Marc Zyngier, Badola Nikhil-B46172, Bhupesh SHARMA, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lu Y.B. On Thu, 2015-10-01 at 16:42 -0500, Li Yang wrote: > On Thu, Oct 1, 2015 at 3:05 PM, Stuart Yoder <stuart.yoder@freescale.com> > wrote: > > Hi Rob, > > > > Had a question about your comments on the patch below. > > > > You singled out 3 nodes (gic,uart,clockgen) and said "This should be > > under a bus node." > > > > What is special about those 3 nodes types? There are a bunch of other > > memory > > mapped SoC devices as well in the DTS. > > > > I skimmed the dts files under arch/arm64 and it looks like most have a > > simple-bus > > SoC node like this where SoC devices are under: > > > > soc { > > #address-cells = <2>; > > #size-cells = <2>; > > compatible = "simple-bus"; > > ranges; > > > > Is that what you are looking for-- for all SoC devices? > > I think the key is to have the soc node and have all the on-chip > devices defined underneath it. > > I read the following from the booting-without-of.txt document: > > f) the /soc<SOCname> node > > This node is used to represent a system-on-a-chip (SoC) and must be > present if the processor is a SoC. The top-level soc node contains > information that is global to all devices on the SoC. The node name > should contain a unit address for the SoC, which is the base address > of the memory-mapped register set for the SoC. The name of an SoC > node should start with "soc", and the remainder of the name should > represent the part number for the soc. For example, the MPC8540's > soc node would be called "soc8540". > > A lot of device trees didn't follow the soc<SOCname> naming scheme and > just used "soc" as the node name. I am not sure if we want to enforce > the naming in the future or update the document to make it more relax. Update the document. Having the SoC name in the node name was a pain, which is why we don't do it anymore. Ideally, this text should be moved into a binding for Freescale PPC/LS SoCs. It really doesn't have the broad applicability that this historical document suggests, and even on our SoCs it doesn't represent the entire SoC. It represents CCSR/IMMR. -Scott ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 07/10] dts/ls2085a: Update DTSI to add support of various peripherals 2015-10-01 21:58 ` Scott Wood @ 2015-10-01 22:41 ` Li Yang 2015-10-01 23:18 ` Scott Wood 0 siblings, 1 reply; 10+ messages in thread From: Li Yang @ 2015-10-01 22:41 UTC (permalink / raw) To: Scott Wood Cc: Mark Rutland, devicetree, Shaohui Xie, Arnd Bergmann, Huan Wang, Sharma Bhupesh, Catalin Marinas, Olof Johansson, Singh Jaiprakash, Stuart Yoder, Will Deacon, Lian M.H., Liu Gang, Rob Herring, Marc Zyngier, Badola Nikhil-B46172, Bhupesh SHARMA, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lu Y.B. On Thu, Oct 1, 2015 at 4:58 PM, Scott Wood <scottwood@freescale.com> wrote: > On Thu, 2015-10-01 at 16:42 -0500, Li Yang wrote: >> On Thu, Oct 1, 2015 at 3:05 PM, Stuart Yoder <stuart.yoder@freescale.com> >> wrote: >> > Hi Rob, >> > >> > Had a question about your comments on the patch below. >> > >> > You singled out 3 nodes (gic,uart,clockgen) and said "This should be >> > under a bus node." >> > >> > What is special about those 3 nodes types? There are a bunch of other >> > memory >> > mapped SoC devices as well in the DTS. >> > >> > I skimmed the dts files under arch/arm64 and it looks like most have a >> > simple-bus >> > SoC node like this where SoC devices are under: >> > >> > soc { >> > #address-cells = <2>; >> > #size-cells = <2>; >> > compatible = "simple-bus"; >> > ranges; >> > >> > Is that what you are looking for-- for all SoC devices? >> >> I think the key is to have the soc node and have all the on-chip >> devices defined underneath it. >> >> I read the following from the booting-without-of.txt document: >> >> f) the /soc<SOCname> node >> >> This node is used to represent a system-on-a-chip (SoC) and must be >> present if the processor is a SoC. The top-level soc node contains >> information that is global to all devices on the SoC. The node name >> should contain a unit address for the SoC, which is the base address >> of the memory-mapped register set for the SoC. The name of an SoC >> node should start with "soc", and the remainder of the name should >> represent the part number for the soc. For example, the MPC8540's >> soc node would be called "soc8540". >> >> A lot of device trees didn't follow the soc<SOCname> naming scheme and >> just used "soc" as the node name. I am not sure if we want to enforce >> the naming in the future or update the document to make it more relax. > > Update the document. Having the SoC name in the node name was a pain, which > is why we don't do it anymore. Ideally, this text should be moved into a > binding for Freescale PPC/LS SoCs. It really doesn't have the broad > applicability that this historical document suggests, and even on our SoCs it > doesn't represent the entire SoC. It represents CCSR/IMMR. Having the soc node to represent the CCSR space is a Freescale specific thing. But using the soc node to be the parent for all the on-chip devices seems to be a good practice for all device trees. I do think we should maintain a standard for the top level nodes of a device tree. Regards, Leo ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 07/10] dts/ls2085a: Update DTSI to add support of various peripherals 2015-10-01 22:41 ` Li Yang @ 2015-10-01 23:18 ` Scott Wood 0 siblings, 0 replies; 10+ messages in thread From: Scott Wood @ 2015-10-01 23:18 UTC (permalink / raw) To: Li Yang Cc: Mark Rutland, devicetree, Shaohui Xie, Arnd Bergmann, Huan Wang, Sharma Bhupesh, Catalin Marinas, Singh Jaiprakash, Stuart Yoder, Will Deacon, Lian M.H., Liu Gang, Rob Herring, Marc Zyngier, Olof Johansson, Badola Nikhil-B46172, Bhupesh SHARMA, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lu Y.B. On Thu, 2015-10-01 at 17:41 -0500, Li Yang wrote: > On Thu, Oct 1, 2015 at 4:58 PM, Scott Wood <scottwood@freescale.com> wrote: > > On Thu, 2015-10-01 at 16:42 -0500, Li Yang wrote: > > > On Thu, Oct 1, 2015 at 3:05 PM, Stuart Yoder <stuart.yoder@freescale.com> > > > > > > wrote: > > > > Hi Rob, > > > > > > > > Had a question about your comments on the patch below. > > > > > > > > You singled out 3 nodes (gic,uart,clockgen) and said "This should be > > > > under a bus node." > > > > > > > > What is special about those 3 nodes types? There are a bunch of other > > > > memory > > > > mapped SoC devices as well in the DTS. > > > > > > > > I skimmed the dts files under arch/arm64 and it looks like most have a > > > > simple-bus > > > > SoC node like this where SoC devices are under: > > > > > > > > soc { > > > > #address-cells = <2>; > > > > #size-cells = <2>; > > > > compatible = "simple-bus"; > > > > ranges; > > > > > > > > Is that what you are looking for-- for all SoC devices? > > > > > > I think the key is to have the soc node and have all the on-chip > > > devices defined underneath it. > > > > > > I read the following from the booting-without-of.txt document: > > > > > > f) the /soc<SOCname> node > > > > > > This node is used to represent a system-on-a-chip (SoC) and must be > > > present if the processor is a SoC. The top-level soc node contains > > > information that is global to all devices on the SoC. The node name > > > should contain a unit address for the SoC, which is the base address > > > of the memory-mapped register set for the SoC. The name of an SoC > > > node should start with "soc", and the remainder of the name should > > > represent the part number for the soc. For example, the MPC8540's > > > soc node would be called "soc8540". > > > > > > A lot of device trees didn't follow the soc<SOCname> naming scheme and > > > just used "soc" as the node name. I am not sure if we want to enforce > > > the naming in the future or update the document to make it more relax. > > > > Update the document. Having the SoC name in the node name was a pain, > > which > > is why we don't do it anymore. Ideally, this text should be moved into a > > binding for Freescale PPC/LS SoCs. It really doesn't have the broad > > applicability that this historical document suggests, and even on our > > SoCs it > > doesn't represent the entire SoC. It represents CCSR/IMMR. > > Having the soc node to represent the CCSR space is a Freescale > specific thing. But using the soc node to be the parent for all the > on-chip devices seems to be a good practice for all device trees. I > do think we should maintain a standard for the top level nodes of a > device tree. But it doesn't represent all on-chip devices. E.g. DPAA portals don't go under it, because they're not part of CCSR. DCSR doesn't go under it, etc. If the definition doesn't even work for our own SoCs, how are we going to force it on everyone else's? -Scott ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-10-01 23:18 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1441350322-4671-1-git-send-email-bhupesh.sharma@freescale.com>
2015-09-04 21:02 ` [PATCH v2 07/10] dts/ls2085a: Update DTSI to add support of various peripherals Li Yang
2015-09-05 8:37 ` Sharma Bhupesh
2015-09-06 20:57 ` Rob Herring
2015-09-06 21:03 ` Sharma Bhupesh
2015-09-07 20:58 ` Rob Herring
2015-09-09 3:55 ` Sharma Bhupesh
[not found] ` <CAL_Jsq+9izV8vkrF1tK96M-VRGTMJ+GN5o=RsnCBDcnh-at5kA@mail.gmail.com>
[not found] ` <CALRxmdC9ZzGiw6CVnVTqhH1xvA-P9s8cpYbk8DoVq7CodFS0VA@mail.gmail.com>
[not found] ` <CY1PR0301MB0748A8F37E3FBE1922AF9D3F874C0@CY1PR0301MB0748.namprd03.prod.outlook.com>
2015-10-01 21:42 ` Li Yang
2015-10-01 21:58 ` Scott Wood
2015-10-01 22:41 ` Li Yang
2015-10-01 23:18 ` Scott Wood
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).