From mboxrd@z Thu Jan 1 00:00:00 1970 From: bayi.cheng Subject: Re: [PATCH v4 3/3] arm64: dts: mt8173: Add nor flash node Date: Wed, 14 Oct 2015 21:59:29 +0800 Message-ID: <1444831169.4832.3.camel@mhfsdcap03> References: <1444729160-26433-1-git-send-email-bayi.cheng@mediatek.com> <1444729160-26433-4-git-send-email-bayi.cheng@mediatek.com> <561D1642.3070105@cogentembedded.com> <561E36ED.7090103@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Daniel Kurtz Cc: Mark Rutland , "open list:OPEN FIRMWARE AND..." , Sergei Shtylyov , srv_heupstream , Ian Campbell , Sascha Hauer , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Rob Herring , Pawel Moll , linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Kumar Gala , Matthias Brugger , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Brian Norris , David Woodhouse , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Wed, 2015-10-14 at 19:26 +0800, Daniel Kurtz wrote: > Sergei, > > On Wed, Oct 14, 2015 at 7:05 PM, Sergei Shtylyov > wrote: > > Hello. > > > > On 10/14/2015 4:07 AM, Daniel Kurtz wrote: > > > >>>> Add Mediatek nor flash node > >>>> > >>>> Signed-off-by: Bayi Cheng > >>>> --- > >>>> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 15 +++++++++++++++ > >>>> 1 file changed, 15 insertions(+) > >>>> > >>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > >>>> b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > >>>> index d18ee42..385c2e4 100644 > >>>> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > >>>> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > >>>> @@ -365,6 +365,21 @@ > >>>> status = "disabled"; > >>>> }; > >>>> > >>>> + nor_flash: spi@1100d000 { > >>> > >>> > >>> I don't think this is a good label name for a SPI controller. > >> > >> > >> You think "spi" is not a good name for SPI controller? > >> Or you mean the label "nor_flash"? > > > > > > I think I said clearly: "label". :-) > > > >> Would you prefer: > >> > >> spi_nor_flash: spi@1100d000 > > > > > > I'd prefer the "_nor_flash" part to be dropped, to be used for the real > > flash device (if needed) which is a sub-node of this node. > > The dedicated nor_flash spi bus cannot just be labeled 'spi', as that > would conflict with the general purpose 'spi' bus. Instead, it is > given a unique label that can be used as a phandle elsewhere (e.g., in > a board file, to enable the bus). The name "spi_nor_flash" makes it > clear that this spi bus is only for use for accessing the nor_flash. > > Bayi: Actually, this reminds me. I'd prefer if the bus node was > disabled by default, and only enabled by boards as required. So, the > node should include: > status = "disabled"; > > -Dan Hi, Dan & Sergei, Thanks for your advice, and I will add "status = "disable"" to the node in the next patch.Thanks~ Bayi