devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: CK Hu <ck.hu@mediatek.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	"; Pawel Moll" <pawel.moll@arm.com>,
	Kumar Gala <galak@codeaurora.org>,
	"; David Airlie" <airlied@linux.ie>,
	Matthias, "Jitao Shi  <jitao.shi@mediatek.com>,
	; Thierry Reding" <treding@nvidia.com>,
	"; Ajay Kumar" <ajaykumar.rs@samsung.com>,
	"; Inki Dae" <inki.dae@samsung.com>,
	Rahul, "Sean Paul  <seanpaul@chromium.org>,
	; Vincent Palatin" <vpalatin@chromium.org>,
	"; Andy Yan" <andy.yan@rock-chips.com>,
	"; Philipp Zabel" <p.zabel@pengutronix.de>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
	Sascha, Yingjoe, Eddie Huang <eddie.huang@mediatek.com>,
	"; Cawa Cheng" <cawa.cheng@mediatek.com>
Subject: RE: [RFC 2/2] drm/bridge: Add I2C based driver for ps8640 bridge
Date: Tue, 20 Oct 2015 14:37:12 +0800	[thread overview]
Message-ID: <1445323032.19417.8.camel@mtksdaap41> (raw)

Hi, Mark:

> -----Original Message-----
> From: Mark Rutland [mailto:mark.rutland@arm.com]
> Sent: Friday, October 16, 2015 9:07 PM
> Subject: Re: [RFC 2/2] drm/bridge: Add I2C based driver for ps8640
bridge
> 
> > +	/* FIXME - use of_graph_get_port_by_id(np, 1) on newer kernels */
> > +	in_ep = of_graph_get_next_endpoint(np, NULL);
> 
> Huh?

ah,Sorry,forget remove it. We will remove /* FIXME - use
of_graph_get_port_by_id(np, 1) on newer kernels */.

> 
> > +	edidp = of_get_property(np, "edid", &size);
> 
> This property wasn't mentioned in the binding document.

edid property is the temp solution in develop. We will remove it next
patch.

> 
> Please describe it. If it's from a more generic binding, refer to that
from the
> binding document.

             reply	other threads:[~2015-10-20  6:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-20  6:37 CK Hu [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-10-20  7:14 [RFC 2/2] drm/bridge: Add I2C based driver for ps8640 bridge CK Hu
2015-10-16 12:15 [RFC 1/2] Dcumentation: bridge: Add documentation for ps8640 DT properties CK Hu
2015-10-16 12:15 ` [RFC 2/2] drm/bridge: Add I2C based driver for ps8640 bridge CK Hu
2015-10-16 13:06   ` Mark Rutland
2015-10-16 13:27     ` Rob Herring
     [not found]   ` <1444997709-57293-2-git-send-email-ck.hu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-10-16 13:52     ` kbuild test robot
2015-10-16 18:14     ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445323032.19417.8.camel@mtksdaap41 \
    --to=ck.hu@mediatek.com \
    --cc=airlied@linux.ie \
    --cc=ajaykumar.rs@samsung.com \
    --cc=andy.yan@rock-chips.com \
    --cc=cawa.cheng@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eddie.huang@mediatek.com \
    --cc=galak@codeaurora.org \
    --cc=inki.dae@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=p.zabel@pengutronix.de \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=srv_heupstream@mediatek.com \
    --cc=treding@nvidia.com \
    --cc=vpalatin@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).