From: CK Hu <ck.hu@mediatek.com>
To: Rob Herring <robh+dt@kernel.org>,
"; Mark Rutland" <mark.rutland@arm.com>
Cc: Pawel Moll <pawel.moll@arm.com>,
"; Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"; Kumar Gala" <galak@codeaurora.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"; Jitao Shi" <jitao.shi@mediatek.com>,
Thierry, Ajay, Inki, Rahul Sharma <rahul.sharma@samsung.com>,
"; Sean Paul" <seanpaul@chromium.org>,
Andy Yan <andy.yan@rock-chips.com>,
"; Philipp Zabel" <p.zabel@pengutronix.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
Sascha, Yingjoe, Eddie Huang <eddie.huang@mediatek.com>,
"; Cawa Cheng" <cawa.cheng@mediatek.com>
Subject: RE: [RFC 2/2] drm/bridge: Add I2C based driver for ps8640 bridge
Date: Tue, 20 Oct 2015 15:14:11 +0800 [thread overview]
Message-ID: <1445325251.19417.16.camel@mtksdaap41> (raw)
Hi, Rob:
> -----Original Message-----
> From: Rob Herring [mailto:robh+dt@kernel.org]
> Sent: Friday, October 16, 2015 9:27 PM
> Subject: Re: [RFC 2/2] drm/bridge: Add I2C based driver for ps8640
bridge
>
> On Fri, Oct 16, 2015 at 8:06 AM, Mark Rutland <mark.rutland@arm.com>
> wrote:
> >> + /* FIXME - use of_graph_get_port_by_id(np, 1) on newer
kernels */
> >> + in_ep = of_graph_get_next_endpoint(np, NULL);
> >
> > Huh?
> >
> >> + edidp = of_get_property(np, "edid", &size);
> >
> > This property wasn't mentioned in the binding document.
> >
> > Please describe it. If it's from a more generic binding, refer to
that
> > from the binding document.
>
> It should be generic, but currently documented in individual drivers.
> I also think this is not the right location in the DT for this
property. It should be
> part of the panel or connector node instead.
edid property is the temp solution in develop. We will remove it next
patch.
>
> Rob
next reply other threads:[~2015-10-20 7:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 7:14 CK Hu [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-10-20 6:37 [RFC 2/2] drm/bridge: Add I2C based driver for ps8640 bridge CK Hu
2015-10-16 12:15 [RFC 1/2] Dcumentation: bridge: Add documentation for ps8640 DT properties CK Hu
2015-10-16 12:15 ` [RFC 2/2] drm/bridge: Add I2C based driver for ps8640 bridge CK Hu
2015-10-16 13:06 ` Mark Rutland
2015-10-16 13:27 ` Rob Herring
[not found] ` <1444997709-57293-2-git-send-email-ck.hu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-10-16 13:52 ` kbuild test robot
2015-10-16 18:14 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445325251.19417.16.camel@mtksdaap41 \
--to=ck.hu@mediatek.com \
--cc=andy.yan@rock-chips.com \
--cc=cawa.cheng@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eddie.huang@mediatek.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jitao.shi@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=rahul.sharma@samsung.com \
--cc=robh+dt@kernel.org \
--cc=seanpaul@chromium.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).