From: "Andrew F. Davis" <afd@ti.com>
To: "Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Javier Martinez Canillas" <javier@dowhile0.org>
Cc: devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, "Andrew F. Davis" <afd@ti.com>
Subject: [PATCH v2] ARM: dts: am335x-boneblack: Use pinctrl constants and AM33XX_IOPAD macro
Date: Sat, 24 Oct 2015 12:05:13 -0500 [thread overview]
Message-ID: <1445706313-14761-1-git-send-email-afd@ti.com> (raw)
Using constants for pinctrl allows better readability and removes
redundancy with comments. AM33XX_IOPAD allows us to use part of the
pinctrl physical address as in the TRM instead of an offset.
Signed-off-by: Andrew F. Davis <afd@ti.com>
---
arch/arm/boot/dts/am335x-boneblack.dts | 44 +++++++++++++++++-----------------
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/arch/arm/boot/dts/am335x-boneblack.dts b/arch/arm/boot/dts/am335x-boneblack.dts
index eadbba3..346f529 100644
--- a/arch/arm/boot/dts/am335x-boneblack.dts
+++ b/arch/arm/boot/dts/am335x-boneblack.dts
@@ -36,32 +36,32 @@
&am33xx_pinmux {
nxp_hdmi_bonelt_pins: nxp_hdmi_bonelt_pins {
pinctrl-single,pins = <
- 0x1b0 0x03 /* xdma_event_intr0, OMAP_MUX_MODE3 | AM33XX_PIN_OUTPUT */
- 0xa0 0x08 /* lcd_data0.lcd_data0, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xa4 0x08 /* lcd_data1.lcd_data1, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xa8 0x08 /* lcd_data2.lcd_data2, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xac 0x08 /* lcd_data3.lcd_data3, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xb0 0x08 /* lcd_data4.lcd_data4, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xb4 0x08 /* lcd_data5.lcd_data5, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xb8 0x08 /* lcd_data6.lcd_data6, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xbc 0x08 /* lcd_data7.lcd_data7, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xc0 0x08 /* lcd_data8.lcd_data8, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xc4 0x08 /* lcd_data9.lcd_data9, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xc8 0x08 /* lcd_data10.lcd_data10, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xcc 0x08 /* lcd_data11.lcd_data11, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xd0 0x08 /* lcd_data12.lcd_data12, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xd4 0x08 /* lcd_data13.lcd_data13, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xd8 0x08 /* lcd_data14.lcd_data14, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xdc 0x08 /* lcd_data15.lcd_data15, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT | AM33XX_PULL_DISA */
- 0xe0 0x00 /* lcd_vsync.lcd_vsync, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT */
- 0xe4 0x00 /* lcd_hsync.lcd_hsync, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT */
- 0xe8 0x00 /* lcd_pclk.lcd_pclk, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT */
- 0xec 0x00 /* lcd_ac_bias_en.lcd_ac_bias_en, OMAP_MUX_MODE0 | AM33XX_PIN_OUTPUT */
+ AM33XX_IOPAD(0x9b0, (PIN_OUTPUT_PULLDOWN | MUX_MODE3)) /* xdma_event_intr0 */
+ AM33XX_IOPAD(0x8a0, (PIN_OUTPUT | MUX_MODE0)) /* lcd_data0.lcd_data0 */
+ AM33XX_IOPAD(0x8a4, (PIN_OUTPUT | MUX_MODE0)) /* lcd_data1.lcd_data1 */
+ AM33XX_IOPAD(0x8a8, (PIN_OUTPUT | MUX_MODE0)) /* lcd_data2.lcd_data2 */
+ AM33XX_IOPAD(0x8ac, (PIN_OUTPUT | MUX_MODE0)) /* lcd_data3.lcd_data3 */
+ AM33XX_IOPAD(0x8b0, (PIN_OUTPUT | MUX_MODE0)) /* lcd_data4.lcd_data4 */
+ AM33XX_IOPAD(0x8b4, (PIN_OUTPUT | MUX_MODE0)) /* lcd_data5.lcd_data5 */
+ AM33XX_IOPAD(0x8b8, (PIN_OUTPUT | MUX_MODE0)) /* lcd_data6.lcd_data6 */
+ AM33XX_IOPAD(0x8bc, (PIN_OUTPUT | MUX_MODE0)) /* lcd_data7.lcd_data7 */
+ AM33XX_IOPAD(0x8c0, (PIN_OUTPUT | MUX_MODE0)) /* lcd_data8.lcd_data8 */
+ AM33XX_IOPAD(0x8c4, (PIN_OUTPUT | MUX_MODE0)) /* lcd_data9.lcd_data9 */
+ AM33XX_IOPAD(0x8c8, (PIN_OUTPUT | MUX_MODE0)) /* lcd_data10.lcd_data10 */
+ AM33XX_IOPAD(0x8cc, (PIN_OUTPUT | MUX_MODE0)) /* lcd_data11.lcd_data11 */
+ AM33XX_IOPAD(0x8d0, (PIN_OUTPUT | MUX_MODE0)) /* lcd_data12.lcd_data12 */
+ AM33XX_IOPAD(0x8d4, (PIN_OUTPUT | MUX_MODE0)) /* lcd_data13.lcd_data13 */
+ AM33XX_IOPAD(0x8d8, (PIN_OUTPUT | MUX_MODE0)) /* lcd_data14.lcd_data14 */
+ AM33XX_IOPAD(0x8dc, (PIN_OUTPUT | MUX_MODE0)) /* lcd_data15.lcd_data15 */
+ AM33XX_IOPAD(0x8e0, (PIN_OUTPUT_PULLDOWN | MUX_MODE0)) /* lcd_vsync.lcd_vsync */
+ AM33XX_IOPAD(0x8e4, (PIN_OUTPUT_PULLDOWN | MUX_MODE0)) /* lcd_hsync.lcd_hsync */
+ AM33XX_IOPAD(0x8e8, (PIN_OUTPUT_PULLDOWN | MUX_MODE0)) /* lcd_pclk.lcd_pclk */
+ AM33XX_IOPAD(0x8ec, (PIN_OUTPUT_PULLDOWN | MUX_MODE0)) /* lcd_ac_bias_en.lcd_ac_bias_en */
>;
};
nxp_hdmi_bonelt_off_pins: nxp_hdmi_bonelt_off_pins {
pinctrl-single,pins = <
- 0x1b0 0x03 /* xdma_event_intr0, OMAP_MUX_MODE3 | AM33XX_PIN_OUTPUT */
+ AM33XX_IOPAD(0x9b0, (PIN_OUTPUT_PULLDOWN | MUX_MODE3)) /* xdma_event_intr0 */
>;
};
};
--
1.9.1
next reply other threads:[~2015-10-24 17:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-24 17:05 Andrew F. Davis [this message]
[not found] ` <1445706313-14761-1-git-send-email-afd-l0cyMroinI0@public.gmane.org>
2015-10-27 0:24 ` [PATCH v2] ARM: dts: am335x-boneblack: Use pinctrl constants and AM33XX_IOPAD macro Javier Martinez Canillas
2015-11-10 18:28 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445706313-14761-1-git-send-email-afd@ti.com \
--to=afd@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=javier@dowhile0.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).