From: Christophe Ricard <christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org
Cc: linux-nfc-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
christophe-h.ricard-qxv4g6HH51o@public.gmane.org,
christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v3 22/35] nfc: st-nci: Add error messages when an unexpected HCI event occurs
Date: Mon, 26 Oct 2015 07:50:02 +0100 [thread overview]
Message-ID: <1445842215-28403-23-git-send-email-christophe-h.ricard@st.com> (raw)
In-Reply-To: <1445842215-28403-1-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
Potentially an unexpected HCI event may occur because of a firmware bug.
It could be transparent for the user but at least log this.
Signed-off-by: Christophe Ricard <christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
---
drivers/nfc/st-nci/se.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/nfc/st-nci/se.c b/drivers/nfc/st-nci/se.c
index 7ec4dba..2812884 100644
--- a/drivers/nfc/st-nci/se.c
+++ b/drivers/nfc/st-nci/se.c
@@ -280,6 +280,8 @@ static void st_nci_hci_admin_event_received(struct nci_dev *ndev,
}
}
break;
+ default:
+ nfc_err(&ndev->nfc_dev->dev, "Unexpected event on admin gate\n");
}
}
@@ -303,6 +305,9 @@ static int st_nci_hci_apdu_reader_event_received(struct nci_dev *ndev,
mod_timer(&info->se_info.bwi_timer, jiffies +
msecs_to_jiffies(info->se_info.wt_timeout));
break;
+ default:
+ nfc_err(&ndev->nfc_dev->dev, "Unexpected event on apdu reader gate\n");
+ return 1;
}
kfree_skb(skb);
@@ -357,6 +362,7 @@ static int st_nci_hci_connectivity_event_received(struct nci_dev *ndev,
r = nfc_se_transaction(ndev->nfc_dev, host, transaction);
break;
default:
+ nfc_err(&ndev->nfc_dev->dev, "Unexpected event on connectivity gate\n");
return 1;
}
kfree_skb(skb);
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-10-26 6:50 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 6:49 [PATCH v3 00/35] Few fixes and st21nfca/st-nci vendor_cmds support Christophe Ricard
2015-10-26 6:49 ` [PATCH v3 04/35] nfc: st-nci: Fix incorrect spi buffer size Christophe Ricard
2015-10-26 6:49 ` [PATCH v3 05/35] nfc: nci: Fix incorrect data chaining when sending data Christophe Ricard
2015-10-26 6:49 ` [PATCH v3 06/35] nfc: nci: Fix improper management of HCI return code Christophe Ricard
2015-10-26 6:49 ` [PATCH v3 07/35] nfc: nci: extract pipe value using NCI_HCP_MSG_GET_PIPE Christophe Ricard
2015-10-26 6:49 ` [PATCH v3 11/35] nfc: st-nci: Remove ndev->hci_dev->init_data.gates initialization in load_session Christophe Ricard
2015-10-26 6:49 ` [PATCH v3 12/35] nfc: st21nfca: Remove hdev->init_data.gates " Christophe Ricard
2015-10-26 6:49 ` [PATCH v3 14/35] nfc: st21nfca: Open NFC_HCI_LINK_MGMT_PIPE Christophe Ricard
2015-10-26 6:49 ` [PATCH v3 15/35] nfc: st-nci: Keep st_nci_gates unchanged in load_session Christophe Ricard
2015-10-26 6:49 ` [PATCH v3 16/35] nfc: st21nfca: Keep st21nfca_gates " Christophe Ricard
2015-10-26 6:49 ` [PATCH v3 17/35] nfc: st-nci: initialize gate_count in st_nci_hci_network_init Christophe Ricard
2015-10-26 6:49 ` [PATCH v3 19/35] nfc: st-nci: Change st_nci_gates offset when looking for a pipe in the table Christophe Ricard
2015-10-26 6:50 ` [PATCH v3 26/35] nfc: st-nci: Fix host_list verification after secure element activation Christophe Ricard
2015-10-26 6:50 ` [PATCH v3 27/35] nfc: st21nfca: " Christophe Ricard
2015-10-26 6:50 ` [PATCH v3 30/35] nfc: st21nfca: Add few code style fixes Christophe Ricard
[not found] ` <1445842215-28403-1-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2015-10-26 6:49 ` [PATCH v3 01/35] nfc: st-nci: Align st-nci driver with other nfc driver Christophe Ricard
2015-10-26 6:49 ` [PATCH v3 02/35] nfc: st-nci: include st-nci.h instead of ndlc.h Christophe Ricard
2015-10-26 6:49 ` [PATCH v3 03/35] nfc: st21nfca: Align st21nfca driver with other nfc driver Christophe Ricard
2015-10-26 6:49 ` [PATCH v3 08/35] nfc: nci: add nci_hci_clear_all_pipes functions Christophe Ricard
2015-10-26 6:49 ` [PATCH v3 09/35] nfc: nci: Add a call to nci_hci_clear_all_pipes at HCI initial activation Christophe Ricard
2015-10-26 6:49 ` [PATCH v3 10/35] nfc: nci: add capability to create pipe on specific gate in nci_hci_connect_gate Christophe Ricard
2015-10-26 6:49 ` [PATCH v3 13/35] nfc: st-nci: Open NCI_HCI_LINK_MGMT_PIPE Christophe Ricard
2015-10-26 6:49 ` [PATCH v3 18/35] nfc: st-nci: Add support for NCI_HCI_IDENTITY_MGMT_GATE Christophe Ricard
2015-10-26 6:50 ` [PATCH v3 20/35] nfc: st21nfca: Change st21nfca_gates offset when looking for a pipe in the table Christophe Ricard
2015-10-26 6:50 ` [PATCH v3 21/35] nfc: st-nci: Add support for proprietary commands for factory tests Christophe Ricard
2015-10-26 6:50 ` Christophe Ricard [this message]
2015-10-26 6:50 ` [PATCH v3 23/35] nfc: netlink: Add missing NFC_ATTR comments Christophe Ricard
2015-10-26 6:50 ` [PATCH v3 24/35] nfc: st-nci: Add ese-present/uicc-present dts properties Christophe Ricard
2015-10-26 6:50 ` [PATCH v3 25/35] nfc: st-nci: Increase waiting time between 2 secure element activation Christophe Ricard
2015-10-26 6:50 ` [PATCH v3 28/35] nfc: netlink: Add mode parameter to deactivate_target functions Christophe Ricard
2015-10-26 6:50 ` [PATCH v3 29/35] nfc: st-nci: Add few code style fixes Christophe Ricard
2015-10-26 6:50 ` [PATCH v3 31/35] nfc: st21nfca: Add support for proprietary commands for factory tests Christophe Ricard
2015-10-26 6:50 ` [PATCH v3 32/35] nfc: st21nfca: Add error messages when an unexpected HCI event occurs Christophe Ricard
2015-10-26 6:50 ` [PATCH v3 33/35] nfc: st-nci: Make sure irq is not already active when powering the device Christophe Ricard
2015-10-26 6:50 ` [PATCH v3 35/35] nfc: st-nci: Replace st21nfcb by st_nci in makefile Christophe Ricard
2015-10-26 6:50 ` [PATCH v3 34/35] nfc: st-nci: remove duplicated skb dump Christophe Ricard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445842215-28403-23-git-send-email-christophe-h.ricard@st.com \
--to=christophe.ricard-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=christophe-h.ricard-qxv4g6HH51o@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nfc-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).