devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] ahci: qoriq: Rename LS2085A SoC support code to LS2080A
@ 2015-10-29  6:22 Tang Yuantian
  2015-10-29  6:22 ` [PATCH 2/3] ahci: qoriq: Disable NCQ on ls2080a SoC Tang Yuantian
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Tang Yuantian @ 2015-10-29  6:22 UTC (permalink / raw)
  To: tj
  Cc: devicetree, hdegoede, Tang Yuantian, linux-kernel, linux-ide,
	linux-arm-kernel

Freescale is renaming the LS2085A SoC to LS2080A.
This patch addresses the same.

Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
---
 Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt | 2 +-
 drivers/ata/ahci_qoriq.c                                 | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt b/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
index b614e3b..3aafe27 100644
--- a/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
+++ b/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
@@ -3,7 +3,7 @@ Binding for Freescale QorIQ AHCI SATA Controller
 Required properties:
   - reg: Physical base address and size of the controller's register area.
   - compatible: Compatibility string. Must be 'fsl,<chip>-ahci', where
-    chip could be ls1021a, ls2085a, ls1043a etc.
+    chip could be ls1021a, ls2080a, ls1043a etc.
   - clocks: Input clock specifier. Refer to common clock bindings.
   - interrupts: Interrupt specifier. Refer to interrupt binding.
 
diff --git a/drivers/ata/ahci_qoriq.c b/drivers/ata/ahci_qoriq.c
index 58c1a94..b9b691e 100644
--- a/drivers/ata/ahci_qoriq.c
+++ b/drivers/ata/ahci_qoriq.c
@@ -45,7 +45,7 @@
 enum ahci_qoriq_type {
 	AHCI_LS1021A,
 	AHCI_LS1043A,
-	AHCI_LS2085A,
+	AHCI_LS2080A,
 };
 
 struct ahci_qoriq_priv {
@@ -57,7 +57,7 @@ struct ahci_qoriq_priv {
 static const struct of_device_id ahci_qoriq_of_match[] = {
 	{ .compatible = "fsl,ls1021a-ahci", .data = (void *)AHCI_LS1021A},
 	{ .compatible = "fsl,ls1043a-ahci", .data = (void *)AHCI_LS1043A},
-	{ .compatible = "fsl,ls2085a-ahci", .data = (void *)AHCI_LS2085A},
+	{ .compatible = "fsl,ls2080a-ahci", .data = (void *)AHCI_LS2080A},
 	{},
 };
 MODULE_DEVICE_TABLE(of, ahci_qoriq_of_match);
@@ -159,7 +159,7 @@ static int ahci_qoriq_phy_init(struct ahci_host_priv *hpriv)
 		break;
 
 	case AHCI_LS1043A:
-	case AHCI_LS2085A:
+	case AHCI_LS2080A:
 		writel(AHCI_PORT_PHY_1_CFG, reg_base + PORT_PHY1);
 		break;
 	}
-- 
2.1.0.27.g96db324

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/3] ahci: qoriq: Disable NCQ on ls2080a SoC
  2015-10-29  6:22 [PATCH 1/3] ahci: qoriq: Rename LS2085A SoC support code to LS2080A Tang Yuantian
@ 2015-10-29  6:22 ` Tang Yuantian
  2015-10-29  6:22 ` [PATCH 3/3] devicetree: bindings: Fixed a few typos Tang Yuantian
  2015-10-31  0:53 ` [PATCH 1/3] ahci: qoriq: Rename LS2085A SoC support code to LS2080A Tejun Heo
  2 siblings, 0 replies; 4+ messages in thread
From: Tang Yuantian @ 2015-10-29  6:22 UTC (permalink / raw)
  To: tj
  Cc: hdegoede, devicetree, linux-kernel, linux-ide, linux-arm-kernel,
	Tang Yuantian

NCQ feature can't be used due to the erratum A-008473.
This patch disabled NCQ as a workaround.

Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
---
 drivers/ata/ahci_qoriq.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/ata/ahci_qoriq.c b/drivers/ata/ahci_qoriq.c
index b9b691e..686d804 100644
--- a/drivers/ata/ahci_qoriq.c
+++ b/drivers/ata/ahci_qoriq.c
@@ -131,7 +131,7 @@ static struct ata_port_operations ahci_qoriq_ops = {
 	.hardreset	= ahci_qoriq_hardreset,
 };
 
-static const struct ata_port_info ahci_qoriq_port_info = {
+static struct ata_port_info ahci_qoriq_port_info = {
 	.flags		= AHCI_FLAG_COMMON | ATA_FLAG_NCQ,
 	.pio_mask	= ATA_PIO4,
 	.udma_mask	= ATA_UDMA6,
@@ -208,6 +208,12 @@ static int ahci_qoriq_probe(struct platform_device *pdev)
 	if (rc)
 		goto disable_resources;
 
+	/* Workaround for ls2080a */
+	if (qoriq_priv->type == AHCI_LS2080A) {
+		hpriv->flags |= AHCI_HFLAG_NO_NCQ;
+		ahci_qoriq_port_info.flags &= ~(ATA_FLAG_NCQ);
+	}
+
 	rc = ahci_platform_init_host(pdev, hpriv, &ahci_qoriq_port_info,
 				     &ahci_qoriq_sht);
 	if (rc)
-- 
2.1.0.27.g96db324


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 3/3] devicetree: bindings: Fixed a few typos
  2015-10-29  6:22 [PATCH 1/3] ahci: qoriq: Rename LS2085A SoC support code to LS2080A Tang Yuantian
  2015-10-29  6:22 ` [PATCH 2/3] ahci: qoriq: Disable NCQ on ls2080a SoC Tang Yuantian
@ 2015-10-29  6:22 ` Tang Yuantian
  2015-10-31  0:53 ` [PATCH 1/3] ahci: qoriq: Rename LS2085A SoC support code to LS2080A Tejun Heo
  2 siblings, 0 replies; 4+ messages in thread
From: Tang Yuantian @ 2015-10-29  6:22 UTC (permalink / raw)
  To: tj
  Cc: hdegoede, devicetree, linux-kernel, linux-ide, linux-arm-kernel,
	Tang Yuantian

There is a few typos in Freescale QorIQ AHCI bindings, This
patch fixed them.

Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
---
 Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt b/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
index 3aafe27..032a760 100644
--- a/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
+++ b/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
@@ -8,8 +8,8 @@ Required properties:
   - interrupts: Interrupt specifier. Refer to interrupt binding.
 
 Optional properties:
-  - dma-coherent: Enable ACHI coherency DMA operation.
-  - reg-names: register area names when there are more then 1 regster area.
+  - dma-coherent: Enable AHCI coherent DMA operation.
+  - reg-names: register area names when there are more than 1 register area.
 
 Examples:
 	sata@3200000 {
-- 
2.1.0.27.g96db324

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/3] ahci: qoriq: Rename LS2085A SoC support code to LS2080A
  2015-10-29  6:22 [PATCH 1/3] ahci: qoriq: Rename LS2085A SoC support code to LS2080A Tang Yuantian
  2015-10-29  6:22 ` [PATCH 2/3] ahci: qoriq: Disable NCQ on ls2080a SoC Tang Yuantian
  2015-10-29  6:22 ` [PATCH 3/3] devicetree: bindings: Fixed a few typos Tang Yuantian
@ 2015-10-31  0:53 ` Tejun Heo
  2 siblings, 0 replies; 4+ messages in thread
From: Tejun Heo @ 2015-10-31  0:53 UTC (permalink / raw)
  To: Tang Yuantian
  Cc: hdegoede, devicetree, linux-kernel, linux-ide, linux-arm-kernel

On Thu, Oct 29, 2015 at 02:22:15PM +0800, Tang Yuantian wrote:
> Freescale is renaming the LS2085A SoC to LS2080A.
> This patch addresses the same.
> 
> Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>

Applied 1-3 to libata/for-4.4 with cosmetic updates.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-10-31  0:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-29  6:22 [PATCH 1/3] ahci: qoriq: Rename LS2085A SoC support code to LS2080A Tang Yuantian
2015-10-29  6:22 ` [PATCH 2/3] ahci: qoriq: Disable NCQ on ls2080a SoC Tang Yuantian
2015-10-29  6:22 ` [PATCH 3/3] devicetree: bindings: Fixed a few typos Tang Yuantian
2015-10-31  0:53 ` [PATCH 1/3] ahci: qoriq: Rename LS2085A SoC support code to LS2080A Tejun Heo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).