devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: sun4i: Enable audio codec on Olimex A20-SOM-EVB
@ 2015-10-31 12:55 Marcus Weseloh
       [not found] ` <1446296142-4152-1-git-send-email-mweseloh42-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Marcus Weseloh @ 2015-10-31 12:55 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Marcus Weseloh

Enable the on-chip audio codec on the Olimex A20-SOM-EVB

Signed-off-by: Marcus Weseloh <mweseloh42-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts b/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts
index b7fe102..03352cc 100644
--- a/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts
+++ b/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts
@@ -86,6 +86,10 @@
 	status = "okay";
 };
 
+&codec {
+        status = "okay";
+};
+
 &gmac {
 	pinctrl-names = "default";
 	pinctrl-0 = <&gmac_pins_rgmii_a>;
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: sun4i: Enable audio codec on Olimex A20-SOM-EVB
       [not found] ` <1446296142-4152-1-git-send-email-mweseloh42-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2015-11-01  9:39   ` Maxime Ripard
  2015-11-01 10:00     ` Marcus Weseloh
  0 siblings, 1 reply; 3+ messages in thread
From: Maxime Ripard @ 2015-11-01  9:39 UTC (permalink / raw)
  To: Marcus Weseloh
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]

Hi,

On Sat, Oct 31, 2015 at 01:55:42PM +0100, Marcus Weseloh wrote:
> Enable the on-chip audio codec on the Olimex A20-SOM-EVB
> 
> Signed-off-by: Marcus Weseloh <mweseloh42-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts b/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts
> index b7fe102..03352cc 100644
> --- a/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts
> @@ -86,6 +86,10 @@
>  	status = "okay";
>  };
>  
> +&codec {
> +        status = "okay";
> +};

The indentation in the DT in with tabs, and not spaces (and checkpatch
actually complains about that).

Make sure you run checkpatch before sending a new patch.

I've fixed it, and queued the patch for 4.5. Thanks!

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: sun4i: Enable audio codec on Olimex A20-SOM-EVB
  2015-11-01  9:39   ` Maxime Ripard
@ 2015-11-01 10:00     ` Marcus Weseloh
  0 siblings, 0 replies; 3+ messages in thread
From: Marcus Weseloh @ 2015-11-01 10:00 UTC (permalink / raw)
  To: linux-sunxi
  Cc: mweseloh42-Re5JQEeQqe8AvxtiuMwx3w,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r


[-- Attachment #1.1: Type: text/plain, Size: 724 bytes --]

On Sunday, 1 November 2015 10:39:20 UTC+1, Maxime Ripard wrote:
>
> The indentation in the DT in with tabs, and not spaces (and checkpatch 
> actually complains about that). 
>
> Make sure you run checkpatch before sending a new patch. 
>

Sorry for that, I will make sure to use checkpatch next time.
 

> I've fixed it, and queued the patch for 4.5. Thanks! 
>

Thanks for fixing it!

Cheers,

    Marcus

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #1.2: Type: text/html, Size: 1298 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-11-01 10:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-31 12:55 [PATCH] ARM: dts: sun4i: Enable audio codec on Olimex A20-SOM-EVB Marcus Weseloh
     [not found] ` <1446296142-4152-1-git-send-email-mweseloh42-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-11-01  9:39   ` Maxime Ripard
2015-11-01 10:00     ` Marcus Weseloh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).