From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Zabel Subject: Re: [PATCH v6 02/12] drm/mediatek: Add DRM Driver for Mediatek SoC MT8173. Date: Tue, 24 Nov 2015 11:11:36 +0100 Message-ID: <1448359896.3346.33.camel@pengutronix.de> References: <1447868060-11620-1-git-send-email-p.zabel@pengutronix.de> <1447868060-11620-3-git-send-email-p.zabel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomasz Figa Cc: Mark Rutland , devicetree@vger.kernel.org, Paul Bolle , Jitao Shi , Pawel Moll , Jie Qiu , Ian Campbell , Cawa Cheng , dri-devel , Rob Herring , linux-mediatek@lists.infradead.org, Kumar Gala , YT Shen , Sasha Hauer , Matthias Brugger List-Id: devicetree@vger.kernel.org SGkgVG9tYXN6LAoKQW0gRGllbnN0YWcsIGRlbiAyNC4xMS4yMDE1LCAxNzoyNyArMDkwMCBzY2hy aWViIFRvbWFzeiBGaWdhOgo+IEhpIFBoaWxpcHAsIENLLAo+IAo+IFBsZWFzZSBzZWUgbXkgY29t bWVudHMgaW5saW5lLgoKVGhhbmsgeW91IGZvciB5b3VyIGNvbW1lbnRzLgoKPiBPbiBUaHUsIE5v diAxOSwgMjAxNSBhdCAyOjM0IEFNLCBQaGlsaXBwIFphYmVsIDxwLnphYmVsQHBlbmd1dHJvbml4 LmRlPiB3cm90ZToKPiBbc25pcF0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbWVk aWF0ZWsvbXRrX2RybV9jcnRjLmMgYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9j cnRjLmMKPiA+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gPiBpbmRleCAwMDAwMDAwLi41MDhjOGYz Cj4gPiAtLS0gL2Rldi9udWxsCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRr X2RybV9jcnRjLmMKPiA+IEBAIC0wLDAgKzEsNTk2IEBAClsuLi5dCj4gPiArc3RydWN0IG10a19j cnRjX2RkcF9jb250ZXh0Owo+IAo+IElzIHRoaXMgZm9yd2FyZCBkZWNsYXJhdGlvbiByZWFsbHkg bmVjZXNzYXJ5PwoKTGVmdG92ZXIsIHdpbGwgcmVtb3ZlLgoKPiA+ICsvKgo+ID4gKyAqIE1lZGlh VGVrIHNwZWNpZmljIGNydGMgc3RydWN0dXJlLgo+ID4gKyAqCj4gPiArICogQGJhc2U6IGNydGMg b2JqZWN0Lgo+ID4gKyAqIEBwaXBlOiBhIGNydGMgaW5kZXggY3JlYXRlZCBhdCBsb2FkKCkgd2l0 aCBhIG5ldyBjcnRjIG9iamVjdCBjcmVhdGlvbgo+ID4gKyAqICAgICBhbmQgdGhlIGNydGMgb2Jq ZWN0IHdvdWxkIGJlIHNldCB0byBwcml2YXRlLT5jcnRjIGFycmF5Cj4gPiArICogICAgIHRvIGdl dCBhIGNydGMgb2JqZWN0IGNvcnJlc3BvbmRpbmcgdG8gdGhpcyBwaXBlIGZyb20gcHJpdmF0ZS0+ Y3J0Ywo+ID4gKyAqICAgICBhcnJheSB3aGVuIGlycSBpbnRlcnJ1cHQgb2NjdXJyZWQuIHRoZSBy ZWFzb24gb2YgdXNpbmcgdGhpcyBwaXBlIGlzIHRoYXQKPiA+ICsgKiAgICAgZHJtIGZyYW1ld29y ayBkb2Vzbid0IHN1cHBvcnQgbXVsdGlwbGUgaXJxIHlldC4KPiA+ICsgKiAgICAgd2UgY2FuIHJl ZmVyIHRvIHRoZSBjcnRjIHRvIGN1cnJlbnQgaGFyZHdhcmUgaW50ZXJydXB0IG9jY3VycmVkIHRo cm91Z2gKPiA+ICsgKiAgICAgdGhpcyBwaXBlIHZhbHVlLgo+IAo+IE9ubHkgZmlyc3QgdHdvIGZp ZWxkcyBkb2N1bWVudGVkPyBBbHNvIHRoaXMgaXNuJ3QgcHJvcGVyIGtlcm5lbGRvYwo+IHN5bnRh eCAoc2VlIERvY3VtZW50YXRpb24va2VybmVsLWRvYy1uYW5vLUhPV1RPLnR4dCkuCgpJJ2xsIGZp eCB0aGF0LgoKPiA+ICsgKi8KPiA+ICtzdHJ1Y3QgbXRrX2RybV9jcnRjIHsKPiA+ICsgICAgICAg c3RydWN0IGRybV9jcnRjICAgICAgICAgICAgICAgICBiYXNlOwo+ID4gKyAgICAgICB1bnNpZ25l ZCBpbnQgICAgICAgICAgICAgICAgICAgIHBpcGU7Cj4gPiArCj4gPiArICAgICAgIGJvb2wgICAg ICAgICAgICAgICAgICAgICAgICAgICAgZG9fZmx1c2g7Cj4gPiArCj4gPiArICAgICAgIHN0cnVj dCBtdGtfZHJtX3BsYW5lICAgICAgICAgICAgcGxhbmVzW09WTF9MQVlFUl9OUl07Cj4gPiArCj4g PiArICAgICAgIHZvaWQgX19pb21lbSAgICAgICAgICAgICAgICAgICAgKmNvbmZpZ19yZWdzOwo+ ID4gKyAgICAgICBzdHJ1Y3QgbXRrX2Rpc3BfbXV0ZXggICAgICAgICAgICptdXRleDsKPiA+ICsg ICAgICAgdTMyICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkZHBfY29tcF9ucjsKPiAKPiBJ IGFzc3VtZSB0aGlzIGlzIHNpemUgb2YgZGRwX2NvbXAgYXJyYXk/IFdoeSBub3QganVzdCB1bnNp Z25lZCBpbnQgdGhlbj8KCkFuZCB0aGF0LgoKPiA+ICsgICAgICAgc3RydWN0IG10a19kZHBfY29t cCAgICAgICAgICAgICAqKmRkcF9jb21wOwo+ID4gK307Cj4gW3NuaXBdCj4gPiArc3RhdGljIGJv b2wgbXRrX2RybV9jcnRjX21vZGVfZml4dXAoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ID4gKyAg ICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICptb2RlLAo+ID4gKyAg ICAgICAgICAgICAgIHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICphZGp1c3RlZF9tb2RlKQo+ID4g K3sKPiA+ICsgICAgICAgLyogZHJtIGZyYW1ld29yayBkb2Vzbid0IGNoZWNrIE5VTEwgKi8KPiAK PiBNYXliZSByZXBocmFzZSB0aGUgY29tbWVudCB0byAiTm90aGluZyB0byBkbyBoZXJlLCBidXQg dGhlIGNhbGxiYWNrIGlzCj4gbWFuZGF0b3J5LiI/CgpPay4KCj4gPiArICAgICAgIHJldHVybiB0 cnVlOwo+ID4gK30KPiBbc25pcF0KPiA+ICtzdGF0aWMgdm9pZCBtdGtfY3J0Y19kZHBfcG93ZXJf b24oc3RydWN0IG10a19kcm1fY3J0YyAqbXRrX2NydGMpCj4gPiArewo+ID4gKyAgICAgICBpbnQg cmV0Owo+ID4gKyAgICAgICBpbnQgaTsKPiA+ICsKPiA+ICsgICAgICAgRFJNX0lORk8oIm10a19j cnRjX2RkcF9wb3dlcl9vblxuIik7Cj4gCj4gRFJNX0RFQlVHX0RSSVZFUigpCgpZZXMsIGFuZCB0 aGUgc2FtZSBmb3IgdGhlIGZvbGxvd2luZyBpbnN0YW5jZXMgb2YgdGhpcyBpc3N1ZSB5b3UgcG9p bnQKb3V0IGJlbG93LgoKPiA+ICsgICAgICAgZm9yIChpID0gMDsgaSA8IG10a19jcnRjLT5kZHBf Y29tcF9ucjsgaSsrKSB7Cj4gPiArICAgICAgICAgICAgICAgcmV0ID0gY2xrX2VuYWJsZShtdGtf Y3J0Yy0+ZGRwX2NvbXBbaV0tPmNsayk7Cj4gPiArICAgICAgICAgICAgICAgaWYgKHJldCkKPiA+ ICsgICAgICAgICAgICAgICAgICAgICAgIERSTV9FUlJPUigiRmFpbGVkIHRvIGVuYWJsZSBjbG9j ayAlZDogJWRcbiIsIGksIHJldCk7Cj4gCj4gVGhpcyBpcyB1bnNhZmUsIGJlY2F1c2UgZXZlbiBp ZiB3ZSBmYWlsIGhlcmUsIG10a19jcnRjX2RkcF9wb3dlcl9vZmYoKQo+IHdpbGwgdHJ5IHRvIGRp c2FibGUgdGhlIGNsb2NrcyBhbnl3YXksIHdoaWNoIHdpbGwgbGVhZCB0byBuZWdhdGl2ZQo+IGVu YWJsZSBjb3VudHMgKGFuZCBhIFdBUk4oKSBpbiBiZXN0IGNhc2UpLiBDYW4gd2UgYWRkIHByb3Bl ciBlcnJvcgo+IGhhbmRsaW5nIHRvIHRoaXMgZnVuY3Rpb24gYW5kIG90aGVyIGZ1bmN0aW9ucyBp biB0aGUgY2FsbCBzdGFjaz8KClVsdGltYXRlbHkgdGhlc2UgYXJlIGNhbGxlZCBieSB0aGUgZW5h YmxlL2Rpc2FibGUgZHJtX2NydGNfaGVscGVyX2Z1bmNzLAp3aGljaCBhcmVuJ3QgYWxsb3dlZCB0 byBmYWlsLiBBbmQgY2xrX2VuYWJsZSBvZiBjb3JlIFNvQyBjbG9ja3Mgc2hvdWxkCm5ldmVyIGZh aWwgZWl0aGVyLiBJZiB3ZSBoaXQgdGhpcyBlcnJvciwgc29tZXRoaW5nIGVsc2UgaXMgdmVyeSB3 cm9uZwp3aXRoIHRoZSBzeXN0ZW0gYWxyZWFkeS4KSSdsbCBoYXZlIG10a19jcnRjX2RkcF9wb3dl cl9vbiBwcm9wYWdhdGUgdGhlIGVycm9yIGFuZAptdGtfY3J0Y19kZHBfaHdfaW5pdCBiZWxvdyBi YWlsIG91dCwgYW5kIEknbGwgYWxzbyByZS1hZGQgdGhlCm10a19jcnRjLT5lbmFibGVkIGJvb2wg YWdhaW4gdG8gbGV0IGNydGNfZGlzYWJsZSB3YXJuIGFuZCBiYWlsIG91dCBpbgpjYXNlIGNydGNf ZW5hYmxlIGZhaWxlZC4KClsuLi5dCj4gPiArc3RhdGljIHZvaWQgbXRrX2NydGNfZGRwX2h3X2lu aXQoc3RydWN0IG10a19kcm1fY3J0YyAqbXRrX2NydGMpCj4gPiArewo+ID4gKyAgICAgICBzdHJ1 Y3QgZHJtX2NydGMgKmNydGMgPSAmbXRrX2NydGMtPmJhc2U7Cj4gPiArICAgICAgIHVuc2lnbmVk IGludCB3aWR0aCwgaGVpZ2h0LCB2cmVmcmVzaDsKPiA+ICsgICAgICAgaW50IHJldDsKPiA+ICsg ICAgICAgaW50IGk7Cj4gPiArCj4gPiArICAgICAgIGlmIChjcnRjLT5zdGF0ZSkgewo+ID4gKyAg ICAgICAgICAgICAgIHdpZHRoID0gY3J0Yy0+c3RhdGUtPmFkanVzdGVkX21vZGUuaGRpc3BsYXk7 Cj4gPiArICAgICAgICAgICAgICAgaGVpZ2h0ID0gY3J0Yy0+c3RhdGUtPmFkanVzdGVkX21vZGUu dmRpc3BsYXk7Cj4gPiArICAgICAgICAgICAgICAgdnJlZnJlc2ggPSBjcnRjLT5zdGF0ZS0+YWRq dXN0ZWRfbW9kZS52cmVmcmVzaDsKPiA+ICsgICAgICAgfSBlbHNlIHsKPiA+ICsgICAgICAgICAg ICAgICBXQVJOX09OKHRydWUpOwo+ID4gKyAgICAgICAgICAgICAgIHdpZHRoID0gMTkyMDsKPiA+ ICsgICAgICAgICAgICAgICBoZWlnaHQgPSAxMDgwOwo+ID4gKyAgICAgICAgICAgICAgIHZyZWZy ZXNoID0gNjA7Cj4gCj4gV2hlbiBjYW4gY3J0Yy0+c3RhdGUgYmUgTlVMTD8gQWxzbyBzaG91bGRu J3Qgd2UganVzdCBmYWlsIGhlcmUgaW5zdGVhZAo+IG9mIGNhcnJ5aW5nIG9uPwo+ID4gKyAgICAg ICB9Cj4gCj4gbml0OiBUaGUgaWYgYWJvdmUgY2FuIGJlIHJlcGxhY2VkIHdpdGggdGhlIGZvbGxv d2luZy4KPiAKPiBpZiAoV0FSTl9PTighY3J0Yy0+c3RhdGUpKSB7Cj4gICAgICAvLyBkbyB0aGUg ZXJyb3IgaGFuZGxpbmcKPiB9IGVsc2Ugewo+ICAgICAvLyBkZXJlZmVyZW5jZSBjcnRjLT5zdGF0 ZQo+IH0KPiAKPiBUaGlzIGlzIGJldHRlciBiZWNhdXNlIHRoZSB3YXJuaW5nIGNvbmRpdGlvbiBz aG93cyB3aGF0J3Mgd3JvbmcuCgpPay4KClsuLi5dCj4gPiArCj4gPiArICAgICAgIC8qIGRpc3Bf bXRjbW9zICovCgpJJ2xsIGRyb3AgdGhpcyBjb21tZW50LgoKPiA+ICsgICAgICAgcmV0ID0gcG1f cnVudGltZV9nZXRfc3luYyhjcnRjLT5kZXYtPmRldik7Cj4gPiArICAgICAgIGlmIChyZXQgPCAw KQo+ID4gKyAgICAgICAgICAgICAgIERSTV9FUlJPUigiRmFpbGVkIHRvIGVuYWJsZSBwb3dlciBk b21haW46ICVkXG4iLCByZXQpOwo+IAo+IENhcnJ5aW5nIG9uIGhlcmUgYWZ0ZXIgcG0gcnVudGlt ZSBlcnJvciBpcyBhdCBsZWFzdCBpbmFwcHJvcHJpYXRlIGFuZAo+IGluIHByYWN0aWNlIGlzIGEg Z29vZCB3YXkgdG8gbG9jayB0aGUgc3lzdGVtIHVwLi4uCgpPaywgd2lsbCBiZSBmaXhlZCBhcyBw YXJ0IG9mIHRoZSBlcnJvciBoYW5kbGluZyBjbGVhbnVwLgoKWy4uLl0KPiA+ICsgICAgICAgbXRr X2NydGNfZGRwX3Bvd2VyX29mZihtdGtfY3J0Yyk7Cj4gPiArICAgICAgIGZvciAoaSA9IDA7IGkg PCBtdGtfY3J0Yy0+ZGRwX2NvbXBfbnI7IGkrKykKPiA+ICsgICAgICAgICAgICAgICBtdGtfZGlz cF9tdXRleF9yZW1vdmVfY29tcChtdGtfY3J0Yy0+bXV0ZXgsCj4gPiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgbXRrX2NydGMtPmRkcF9jb21wW2ldLT5pZCk7Cj4g PiArICAgICAgIG10a19kaXNwX211dGV4X2Rpc2FibGUobXRrX2NydGMtPm11dGV4KTsKPiA+ICsg ICAgICAgZm9yIChpID0gMDsgaSA8IG10a19jcnRjLT5kZHBfY29tcF9uciAtIDE7IGkrKykgewo+ ID4gKyAgICAgICAgICAgICAgIG10a19kZHBfcmVtb3ZlX2NvbXBfZnJvbV9wYXRoKG10a19jcnRj LT5jb25maWdfcmVncywKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBtdGtfY3J0Yy0+ZGRwX2NvbXBbaV0tPmlkLAo+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIG10a19jcnRjLT5kZHBfY29tcFtpICsgMV0tPmlk KTsKPiA+ICsgICAgICAgICAgICAgICBtdGtfZGlzcF9tdXRleF9yZW1vdmVfY29tcChtdGtfY3J0 Yy0+bXV0ZXgsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg bXRrX2NydGMtPmRkcF9jb21wW2ldLT5pZCk7Cj4gPiArICAgICAgIH0KPiA+ICsgICAgICAgbXRr X2Rpc3BfbXV0ZXhfcmVtb3ZlX2NvbXAobXRrX2NydGMtPm11dGV4LCBtdGtfY3J0Yy0+ZGRwX2Nv bXBbaV0tPmlkKTsKPiA+ICsgICAgICAgbXRrX2Rpc3BfbXV0ZXhfdW5wcmVwYXJlKG10a19jcnRj LT5tdXRleCk7Cj4gPiArICAgICAgIG10a19jcnRjLT5tdXRleCA9IE5VTEw7Cj4gCj4gbXRrX2Ny dGMtPm11dGV4IHdhcyBhY3F1aXJlZCBieSBtdGtfZGlzcF9tdXRleF9nZXQoKS4gU2hvdWxkbid0 IGl0IGJlCj4gcmVsZWFzZWQgd2l0aCBtdGtfZGlzcF9tdXRleF9wdXQoKT8gKEluIGZhY3QgSSBj YW4gc2VlCj4gbXRrX2Rpc3Bfb3ZsX3VuYmluZCgpIGFscmVhZHkgZG9pbmcgdGhhdCkuCgpBYnNv bHV0ZWx5IHllcywgdGhpcyB3YXMgZm91bmQgcmVhbGx5IHF1aWNrbHkuIEkgbWlzc2VkIGl0IGF0 IGZpcnN0IGp1c3QKYmVjYXVzZSBJIGZvcmdvdCB0byBwbHVnIGluL291dCB0aGUgSERNSSBjb25u ZWN0b3IgYSBzZWNvbmQgdGltZSB3aGVuCnRlc3RpbmcuIFRoZSBOVUxMIGFzc2lnbm1lbnQgbmVl ZHMgdG8gYmUgcmVtb3ZlZCBoZXJlLgoKPiA+ICsKPiA+ICsgICAgICAgLyogZGlzcF9tdGNtb3Mg Ki8KPiAKPiBUaGlzIGNvbW1lbnQgZG9lc24ndCBzZWVtIHRvIGJlIHZlcnkgbWVhbmluZ2Z1bC4K CkknbGwgZHJvcCBpdC4KCj4gPiArICAgICAgIHBtX3J1bnRpbWVfcHV0KGRybS0+ZGV2KTsKPiA+ ICt9Cj4gCj4gVG8gYmUgY29udGludWVkLgoKVGhhbmtzIQoKcmVnYXJkcwpQaGlsaXBwCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=