From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Zabel Subject: Re: [PATCH 1/2] Documentation: devicetree: add epson rx6110 binding Date: Tue, 24 Nov 2015 12:12:41 +0100 Message-ID: <1448363561.3346.57.camel@pengutronix.de> References: <1448361533-10728-1-git-send-email-s.trumtrar@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1448361533-10728-1-git-send-email-s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Steffen Trumtrar Cc: Alessandro Zummo , Alexandre Belloni , Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Pawel Moll , Ian Campbell , Rob Herring , kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, Kumar Gala List-Id: devicetree@vger.kernel.org Am Dienstag, den 24.11.2015, 11:38 +0100 schrieb Steffen Trumtrar: > Add the binding documentation for the Epson RX6110 RTC. > > Signed-off-by: Steffen Trumtrar > --- > I'm not sure what the current policy for such simple SPI bindings is. > Are they necessary? Like for i2c there is trivial-devices.txt? Although in this case it's not just a compatible. Here you have a certain spi configuration that is necessary for the rtc to work. > .../devicetree/bindings/rtc/epson,rtc-rx6110.txt | 25 ++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/epson,rtc-rx6110.txt > > diff --git a/Documentation/devicetree/bindings/rtc/epson,rtc-rx6110.txt b/Documentation/devicetree/bindings/rtc/epson,rtc-rx6110.txt > new file mode 100644 > index 000000000000..7ce7ae761657 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/epson,rtc-rx6110.txt > @@ -0,0 +1,25 @@ > +Epson RX6110 Real Time Clock > +============================ > + > +The Epson RX6110 can be used with SPI or I2C busses. The kind of > +bus depends on the SPISEL pin and can not be configured via software. > + > +SPI mode > +-------- > + > +Required properties: > +- compatible: should be: "epson,rtc-rx6110" Should this just be "epson,rx6110" ? > +- reg: chip select number > +- spi-cs-high: RX6110 needs chipselect high > +- spi-cpha: RX6110 works with SPI shifted clock phase > +- spi-cpol: RX6110 works with SPI inverse clock polarity > + > +Example: > + > + rtc: rtc@3 { > + compatible = "epson,rtc-rx6110" > + reg = <3> > + spi-cs-high; > + spi-cpba; s/b/h/ > + spi-cpol; > + }; regards Philipp -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html