From mboxrd@z Thu Jan 1 00:00:00 1970 From: bayi cheng Subject: Re: [PATCH v8 2/2] arm64: dts: mt8173: Add nor flash node Date: Thu, 26 Nov 2015 10:42:53 +0800 Message-ID: <1448505773.9118.19.camel@mhfsdcap03> References: <1447817403-16631-1-git-send-email-bayi.cheng@mediatek.com> <1447817403-16631-3-git-send-email-bayi.cheng@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Daniel Kurtz Cc: David Woodhouse , Brian Norris , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Matthias Brugger , Sascha Hauer , "open list:OPEN FIRMWARE AND..." , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, srv_heupstream , jteki-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org, ezequiel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, 2015-11-26 at 09:20 +0800, Daniel Kurtz wrote: > Hi Bayi, Matthias, > > Sorry for the late review, one comment below... > > On Wed, Nov 18, 2015 at 11:30 AM, Bayi Cheng wrote: > > Add Mediatek nor flash node > > > > Signed-off-by: Bayi Cheng > > Acked-by: Brian Norris > > --- > > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 18 +++++++++++++++++- > > 1 file changed, 17 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > index 4dd5f93..7988656 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > @@ -387,7 +387,23 @@ > > status = "disabled"; > > }; > > > > - i2c3: i2c@11010000 { > > + nor_flash: spi@1100d000 { > > + compatible = "mediatek,mt8173-nor"; > > + reg = <0 0x1100d000 0 0xe0>; > > + clocks = <&pericfg CLK_PERI_SPI>, > > + <&topckgen CLK_TOP_SPINFI_IFR_SEL>; > > + clock-names = "spi", "sf"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + status = "disabled"; > > + > > + flash@0 { > > + compatible = "jedec,spi-nor"; > > + reg = <0>; > > + }; > > I think this flash@0 node represents the flash device present on the > board and should therefore be moved to the board-specific .dts. > > -Dan > Hi Daniel, Thanks for your comments, and I will fixed it in the next patch. > > + }; > > + > > + i2c3: i2c3@11010000 { > > compatible = "mediatek,mt8173-i2c"; > > reg = <0 0x11010000 0 0x70>, > > <0 0x11000280 0 0x80>; > > -- > > 1.8.1.1.dirty > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html