From: Inki Dae <inki.dae@samsung.com>
To: dri-devel@lists.freedesktop.org
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
k.kozlowski@samsung.com, linux-samsung-soc@vger.kernel.org,
pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
javier@osg.samsung.com, robh+dt@kernel.org, galak@codeaurora.org,
kgene.kim@samsung.com
Subject: [PATCH v2 2/3] drm/exynos: dp: fix wrong return type
Date: Thu, 03 Dec 2015 18:30:09 +0900 [thread overview]
Message-ID: <1449135010-8111-3-git-send-email-inki.dae@samsung.com> (raw)
In-Reply-To: <1449135010-8111-1-git-send-email-inki.dae@samsung.com>
This patch fixes wrong return type when dt binding of bridge device
failed.
If a board has a bridge device then of_graph_get_remote_port_parent
function shouldn't be NULL. So this patch will return a proper error
type so that the deferred probe isn't triggered.
Changelog v2:
- return -EINVAL if getting a port node failed.
Signed-off-by: Inki Dae <inki.dae@samsung.com>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/gpu/drm/exynos/exynos_dp_core.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c
index 60260a0..aeee60a 100644
--- a/drivers/gpu/drm/exynos/exynos_dp_core.c
+++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
@@ -1437,8 +1437,10 @@ static int exynos_dp_probe(struct platform_device *pdev)
of_node_put(bridge_node);
if (!dp->ptn_bridge)
return -EPROBE_DEFER;
- } else
- return -EPROBE_DEFER;
+ } else {
+ DRM_ERROR("no port node for bridge device.\n");
+ return -EINVAL;
+ }
}
out:
--
1.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-12-03 9:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 9:30 [PATCH 0/3] drm/exynos: dp: consider port node outbound for panel Inki Dae
2015-12-03 9:30 ` [PATCH v3 1/3] drm/exynos: dp: add of_graph dt binding support " Inki Dae
2015-12-03 13:55 ` Javier Martinez Canillas
2015-12-04 9:00 ` Inki Dae
2015-12-04 12:38 ` Javier Martinez Canillas
2015-12-04 14:57 ` Inki Dae
2015-12-04 16:18 ` Javier Martinez Canillas
2015-12-03 9:30 ` Inki Dae [this message]
2015-12-03 9:30 ` [PATCH 3/3] dt-bindings: exynos-dp: update ports node binding " Inki Dae
2015-12-03 13:29 ` Javier Martinez Canillas
2015-12-04 9:07 ` Inki Dae
2015-12-03 23:38 ` Rob Herring
2015-12-04 9:08 ` Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449135010-8111-3-git-send-email-inki.dae@samsung.com \
--to=inki.dae@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).