From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C66BFC4167B for ; Thu, 22 Dec 2022 22:01:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229763AbiLVWBp (ORCPT ); Thu, 22 Dec 2022 17:01:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235595AbiLVWBo (ORCPT ); Thu, 22 Dec 2022 17:01:44 -0500 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B80527CF8 for ; Thu, 22 Dec 2022 14:01:43 -0800 (PST) Received: by mail-lf1-x12d.google.com with SMTP id f34so4626782lfv.10 for ; Thu, 22 Dec 2022 14:01:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hwyt8ZdI5ZWUHfUGRX4s0PkLUr1UuuhJWewTj+QujR0=; b=sdyRfPiBd704FQG4bNjO87wMafWV6TlycxRFOCRg6C1jFqskYPrheu40WnKLXd97VD 9awr9681ZZ40f3yEZ2IV7TOgT6N9WWG8ibxUc6eDGIm+JUjyZLX3o+sCaKvKuvXbGC/K FhxTq13RxetjjMC19nCQz2Cd1WynTrH/8q7rY/Q0ugj5DGuvoBsDN0X830KHShnuh/FQ SlGLo97+D1lqnHkOgPdteqpHcC/bRwOEBxgtL2oG9pTqonU5RBKciuJ/xsbJgR0BIKsl iWxKGuexHDXtiOQgKoz3mSY1ZLtgf0sbmw+VTgwLb4GN7btlbcv4CDGIcClg7UDOwjgS 8Jig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hwyt8ZdI5ZWUHfUGRX4s0PkLUr1UuuhJWewTj+QujR0=; b=0oX0e7gkw8bx+HLRPfEYsUonc7vOEkFueDzc5Wz0CiHJKMBdhvHGI3XDWKWVg9kBTc Ic7RRG/uIbZXMHxpdSfq7SsjJ2xXP8fFsteZxJTf1ZfqFjT8SbMQREwgnsFibrG7/6iy CYCFR61aVGstuvWzes7YK04RayilJZKdWNueVlyFCO5Pk21uhs+hupgs/pkQTyD15A3/ te4rt8hpyiE5rd9uRfdUsSUByJWEAYq9TV/s1PYtxrNB4PkaS1stbvEkAvjm2gi98bJw BA9GcDJVuwjPPnrS4GxS6PBX3Ah7I8fBT6gMK1qRjHtmadwB5v8WOag+hQVXYeRb7b6/ teuA== X-Gm-Message-State: AFqh2krAqUEMzclyF/X5h88iTjAFJPzsPv1XA3KnLkHcwrIOCBL8Nl2J g0uj0v/W5Lyjjy/o/jO3YGnvAw== X-Google-Smtp-Source: AMrXdXtCv726/Ll7RZS1LYdA1OYHa3A5hq1rDXIE2Lyae6+L1yQnAfH8gZRKJugpTYZo5pID48KFog== X-Received: by 2002:a05:6512:16a8:b0:4b5:a70f:8efc with SMTP id bu40-20020a05651216a800b004b5a70f8efcmr3436708lfb.64.1671746501410; Thu, 22 Dec 2022 14:01:41 -0800 (PST) Received: from [192.168.1.101] (abyl184.neoplus.adsl.tpnet.pl. [83.9.31.184]) by smtp.gmail.com with ESMTPSA id s20-20020a195e14000000b004b0b2212315sm224362lfb.121.2022.12.22.14.01.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Dec 2022 14:01:40 -0800 (PST) Message-ID: <144d7b69-fb67-60dd-2c40-c004fbbba288@linaro.org> Date: Thu, 22 Dec 2022 23:01:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2] arm64: dts: qcom: sm6350-lena: Flatten gpio-keys pinctrl state Content-Language: en-US To: Marijn Suijten , phone-devel@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Martin Botka , Jami Kettunen , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221222215906.324092-1-marijn.suijten@somainline.org> From: Konrad Dybcio In-Reply-To: <20221222215906.324092-1-marijn.suijten@somainline.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22.12.2022 22:59, Marijn Suijten wrote: > Pinctrl states typically collate multiple related pins. In the case of > gpio-keys there's no hardware-defined relation at all except all pins > representing a key; and especially on Sony's lena board there's only one > pin regardless. Flatten it similar to other boards [1]. > > As a drive-by fix, clean up the label string. > > [1]: https://lore.kernel.org/linux-arm-msm/11174eb6-0a9d-7df1-6f06-da4010f76453@linaro.org/ > > Fixes: 2b8bbe985659 ("arm64: dts: qcom: sm6350-lena: Include pm6350 and configure buttons") > Signed-off-by: Marijn Suijten > --- Reviewed-by: Konrad Dybcio Konrad > > Changes since v1: > > - Replace accidental semicolon in patch title with colon. > > v1: https://lore.kernel.org/linux-arm-msm/20221222212634.298135-1-marijn.suijten@somainline.org/T/#u > > .../qcom/sm6350-sony-xperia-lena-pdx213.dts | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts > index 94f77d376662..4916d0db5b47 100644 > --- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts > +++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts > @@ -35,10 +35,10 @@ framebuffer: framebuffer@a0000000 { > gpio-keys { > compatible = "gpio-keys"; > pinctrl-names = "default"; > - pinctrl-0 = <&gpio_keys_state>; > + pinctrl-0 = <&vol_down_n>; > > key-volume-down { > - label = "volume_down"; > + label = "Volume Down"; > linux,code = ; > gpios = <&pm6350_gpios 2 GPIO_ACTIVE_LOW>; > }; > @@ -305,14 +305,12 @@ touchscreen@48 { > }; > > &pm6350_gpios { > - gpio_keys_state: gpio-keys-state { > - key-volume-down-pins { > - pins = "gpio2"; > - function = PMIC_GPIO_FUNC_NORMAL; > - power-source = <0>; > - bias-disable; > - input-enable; > - }; > + vol_down_n: vol-down-n-state { > + pins = "gpio2"; > + function = PMIC_GPIO_FUNC_NORMAL; > + power-source = <0>; > + bias-disable; > + input-enable; > }; > }; >