From: Paul Kocialkowski <contact@paulk.fr>
To: linux-kernel@vger.kernel.org
Cc: "Mark Rutland" <mark.rutland@arm.com>,
"Milo Kim" <milo.kim@ti.com>,
"Russell King" <linux@arm.linux.org.uk>,
"Pawel Moll" <pawel.moll@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Tony Lindgren" <tony@atomide.com>,
"Mark Brown" <broonie@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Paul Kocialkowski" <contact@paulk.fr>,
devicetree@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Kumar Gala" <galak@codeaurora.org>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support
Date: Wed, 23 Dec 2015 11:58:37 +0100 [thread overview]
Message-ID: <1450868319-20513-5-git-send-email-contact@paulk.fr> (raw)
In-Reply-To: <1450868319-20513-1-git-send-email-contact@paulk.fr>
LP872x regulators are made active via the EN pin, which might be hooked to a
GPIO. This adds support for driving the GPIO high when the driver is in use.
Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
.../devicetree/bindings/regulator/lp872x.txt | 1 +
drivers/regulator/lp872x.c | 33 ++++++++++++++++++++--
include/linux/regulator/lp872x.h | 2 ++
3 files changed, 33 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/regulator/lp872x.txt b/Documentation/devicetree/bindings/regulator/lp872x.txt
index 7818318..0559c25 100644
--- a/Documentation/devicetree/bindings/regulator/lp872x.txt
+++ b/Documentation/devicetree/bindings/regulator/lp872x.txt
@@ -28,6 +28,7 @@ Optional properties:
- ti,dvs-gpio: GPIO specifier for external DVS pin control of LP872x devices.
- ti,dvs-vsel: DVS selector. 0 = SEL_V1, 1 = SEL_V2.
- ti,dvs-state: initial DVS pin state. 0 = DVS_LOW, 1 = DVS_HIGH.
+ - ti,enable-gpio: GPIO specifier for EN pin control of LP872x devices.
Sub nodes for regulator_init_data
LP8720 has maximum 6 nodes. (child name: ldo1 ~ 5 and buck)
diff --git a/drivers/regulator/lp872x.c b/drivers/regulator/lp872x.c
index 21c49d8..c8855f3 100644
--- a/drivers/regulator/lp872x.c
+++ b/drivers/regulator/lp872x.c
@@ -726,6 +726,27 @@ static struct regulator_desc lp8725_regulator_desc[] = {
},
};
+static int lp872x_init_enable(struct lp872x *lp)
+{
+ int ret, gpio;
+
+ if (!lp->pdata)
+ return -EINVAL;
+
+ gpio = lp->pdata->enable_gpio;
+ if (!gpio_is_valid(gpio))
+ return 0;
+
+ /* Always set enable GPIO high. */
+ ret = devm_gpio_request_one(lp->dev, gpio, GPIOF_OUT_INIT_HIGH, "LP872X EN");
+ if (ret) {
+ dev_err(lp->dev, "gpio request err: %d\n", ret);
+ return ret;
+ }
+
+ return 0;
+}
+
static int lp872x_init_dvs(struct lp872x *lp)
{
int ret, gpio;
@@ -763,14 +784,18 @@ static int lp872x_config(struct lp872x *lp)
int ret;
if (!pdata || !pdata->update_config)
- goto init_dvs;
+ goto init_dvs_enable;
ret = lp872x_write_byte(lp, LP872X_GENERAL_CFG, pdata->general_config);
if (ret)
return ret;
-init_dvs:
- return lp872x_init_dvs(lp);
+init_dvs_enable:
+ ret = lp872x_init_dvs(lp);
+ if (ret)
+ return ret;
+
+ return lp872x_init_enable(lp);
}
static struct regulator_init_data
@@ -875,6 +900,8 @@ static struct lp872x_platform_data
of_property_read_u8(np, "ti,dvs-state", &dvs_state);
pdata->dvs->init_state = dvs_state ? DVS_HIGH : DVS_LOW;
+ pdata->enable_gpio = of_get_named_gpio(np, "ti,enable-gpio", 0);
+
if (of_get_child_count(np) == 0)
goto out;
diff --git a/include/linux/regulator/lp872x.h b/include/linux/regulator/lp872x.h
index 132e05c..44316dd 100644
--- a/include/linux/regulator/lp872x.h
+++ b/include/linux/regulator/lp872x.h
@@ -79,12 +79,14 @@ struct lp872x_regulator_data {
* @update_config : if LP872X_GENERAL_CFG register is updated, set true
* @regulator_data : platform regulator id and init data
* @dvs : dvs data for buck voltage control
+ * @enable_gpio : gpio pin number for enable control
*/
struct lp872x_platform_data {
u8 general_config;
bool update_config;
struct lp872x_regulator_data regulator_data[LP872X_MAX_REGULATORS];
struct lp872x_dvs *dvs;
+ int enable_gpio;
};
#endif
--
1.9.1
next prev parent reply other threads:[~2015-12-23 10:58 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 10:58 [PATCH 0/6] LG Optimus Black (P970) codename sniper support and lp872x improvements Paul Kocialkowski
2015-12-23 10:58 ` [PATCH 1/6] regulator: lp872x: Add missing of_match in regulators descriptions Paul Kocialkowski
2015-12-28 1:04 ` Milo Kim
2015-12-23 10:58 ` [PATCH 2/6] regulator: lp872x: Get rid of duplicate reference to DVS GPIO Paul Kocialkowski
2015-12-28 1:05 ` Milo Kim
2015-12-23 10:58 ` [PATCH 3/6] regulator: lp872x: Remove warning about invalid " Paul Kocialkowski
2015-12-23 11:41 ` Mark Brown
2015-12-23 11:50 ` Paul Kocialkowski
2015-12-23 11:58 ` Mark Brown
2015-12-23 10:58 ` Paul Kocialkowski [this message]
[not found] ` <1450868319-20513-5-git-send-email-contact-W9ppeneeCTY@public.gmane.org>
2015-12-23 11:56 ` [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Mark Brown
2015-12-23 12:52 ` Paul Kocialkowski
[not found] ` <20151223115632.GS16023-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-12-24 18:12 ` Paul Kocialkowski
2015-12-24 19:35 ` Mark Brown
2015-12-24 20:05 ` Paul Kocialkowski
2015-12-28 0:56 ` Milo Kim
[not found] ` <568088B4.6090207-l0cyMroinI0@public.gmane.org>
2015-12-28 22:49 ` Paul Kocialkowski
2015-12-29 0:45 ` Milo Kim
2015-12-29 11:13 ` Paul Kocialkowski
2015-12-30 0:22 ` Milo Kim
2015-12-30 8:35 ` Paul Kocialkowski
2015-12-30 16:33 ` Mark Brown
2015-12-30 18:37 ` Paul Kocialkowski
2015-12-31 21:40 ` Mark Brown
[not found] ` <20151231214007.GC16023-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-12-31 21:59 ` Paul Kocialkowski
2015-12-31 22:14 ` Mark Brown
[not found] ` <20151231221407.GF16023-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-01-03 10:19 ` Paul Kocialkowski
2016-01-16 7:32 ` Paul Kocialkowski
2016-01-18 16:32 ` Mark Brown
2016-02-05 18:48 ` Paul Kocialkowski
2015-12-28 0:34 ` Milo Kim
2016-02-05 18:49 ` Paul Kocialkowski
2015-12-29 20:02 ` Rob Herring
2015-12-29 21:26 ` Paul Kocialkowski
2015-12-29 21:55 ` Rob Herring
2016-02-05 18:48 ` Paul Kocialkowski
2015-12-23 10:58 ` [PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper support, with basic features Paul Kocialkowski
[not found] ` <1450868319-20513-6-git-send-email-contact-W9ppeneeCTY@public.gmane.org>
2015-12-23 15:44 ` Tony Lindgren
2015-12-24 19:38 ` Paul Kocialkowski
2015-12-23 16:03 ` Javier Martinez Canillas
[not found] ` <CABxcv=moAUEPo8sq5KhuLZChrQtwjF1aBeNvV1i8HvUnwDXMZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-24 19:38 ` Paul Kocialkowski
2015-12-23 10:58 ` [PATCH 6/6] ARM: multi_v7_defconfig: Enable LP872x regulator support Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450868319-20513-5-git-send-email-contact@paulk.fr \
--to=contact@paulk.fr \
--cc=bcousson@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=milo.kim@ti.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).