* [PATCH] DT: i2c: Update vendor prefix for 24c00
@ 2015-12-23 19:18 Akshay Bhat
2015-12-27 14:57 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Akshay Bhat @ 2015-12-23 19:18 UTC (permalink / raw)
To: ktsai
Cc: wsa, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
trivial, linux-i2c, devicetree, linux-kernel, justin.waters,
Akshay Bhat
"at" is not a valid vendor prefix, correcting the same to "atmel"
Signed-off-by: Akshay Bhat <akshay.bhat@timesys.com>
---
Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
index c50cf13..c4a01c0 100644
--- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
+++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
@@ -20,11 +20,11 @@ adi,adt7476 +/-1C TDM Extended Temp Range I.C
adi,adt7490 +/-1C TDM Extended Temp Range I.C
adi,adxl345 Three-Axis Digital Accelerometer
adi,adxl346 Three-Axis Digital Accelerometer (backward-compatibility value "adi,adxl345" must be listed too)
-at,24c08 i2c serial eeprom (24cxx)
atmel,24c00 i2c serial eeprom (24cxx)
atmel,24c01 i2c serial eeprom (24cxx)
atmel,24c02 i2c serial eeprom (24cxx)
atmel,24c04 i2c serial eeprom (24cxx)
+atmel,24c08 i2c serial eeprom (24cxx)
atmel,24c16 i2c serial eeprom (24cxx)
atmel,24c32 i2c serial eeprom (24cxx)
atmel,24c64 i2c serial eeprom (24cxx)
--
2.6.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] DT: i2c: Update vendor prefix for 24c00
2015-12-23 19:18 [PATCH] DT: i2c: Update vendor prefix for 24c00 Akshay Bhat
@ 2015-12-27 14:57 ` Andy Shevchenko
2016-01-02 21:21 ` Wolfram Sang
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2015-12-27 14:57 UTC (permalink / raw)
To: Akshay Bhat
Cc: ktsai, Wolfram Sang, Rob Herring, Pawel Moll, Mark Rutland,
ijc+devicetree, Kumar Gala, Jiri Kosina, linux-i2c, devicetree,
linux-kernel@vger.kernel.org, justin.waters
On Wed, Dec 23, 2015 at 9:18 PM, Akshay Bhat <akshay.bhat@timesys.com> wrote:
> "at" is not a valid vendor prefix, correcting the same to "atmel"
>
I'm afraid you can't just do this change alone as it's used in some
DTS. Though you may deprecated it along with update of current users.
> Signed-off-by: Akshay Bhat <akshay.bhat@timesys.com>
> ---
> Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> index c50cf13..c4a01c0 100644
> --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> @@ -20,11 +20,11 @@ adi,adt7476 +/-1C TDM Extended Temp Range I.C
> adi,adt7490 +/-1C TDM Extended Temp Range I.C
> adi,adxl345 Three-Axis Digital Accelerometer
> adi,adxl346 Three-Axis Digital Accelerometer (backward-compatibility value "adi,adxl345" must be listed too)
> -at,24c08 i2c serial eeprom (24cxx)
> atmel,24c00 i2c serial eeprom (24cxx)
> atmel,24c01 i2c serial eeprom (24cxx)
> atmel,24c02 i2c serial eeprom (24cxx)
> atmel,24c04 i2c serial eeprom (24cxx)
> +atmel,24c08 i2c serial eeprom (24cxx)
> atmel,24c16 i2c serial eeprom (24cxx)
> atmel,24c32 i2c serial eeprom (24cxx)
> atmel,24c64 i2c serial eeprom (24cxx)
> --
> 2.6.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] DT: i2c: Update vendor prefix for 24c00
2015-12-27 14:57 ` Andy Shevchenko
@ 2016-01-02 21:21 ` Wolfram Sang
2016-01-04 18:22 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Wolfram Sang @ 2016-01-02 21:21 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Akshay Bhat, ktsai, Rob Herring, Pawel Moll, Mark Rutland,
ijc+devicetree, Kumar Gala, Jiri Kosina, linux-i2c, devicetree,
linux-kernel@vger.kernel.org, justin.waters
[-- Attachment #1: Type: text/plain, Size: 2247 bytes --]
On Sun, Dec 27, 2015 at 04:57:48PM +0200, Andy Shevchenko wrote:
> On Wed, Dec 23, 2015 at 9:18 PM, Akshay Bhat <akshay.bhat@timesys.com> wrote:
> > "at" is not a valid vendor prefix, correcting the same to "atmel"
> >
>
> I'm afraid you can't just do this change alone as it's used in some
> DTS. Though you may deprecated it along with update of current users.
Well, in Linux, I2C core currently strips the vendor anyhow. This will
probably be changed somewhen (tm), but for now, the impact for Linux
should be extremly close to 0.
>
> > Signed-off-by: Akshay Bhat <akshay.bhat@timesys.com>
> > ---
> > Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> > index c50cf13..c4a01c0 100644
> > --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> > +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> > @@ -20,11 +20,11 @@ adi,adt7476 +/-1C TDM Extended Temp Range I.C
> > adi,adt7490 +/-1C TDM Extended Temp Range I.C
> > adi,adxl345 Three-Axis Digital Accelerometer
> > adi,adxl346 Three-Axis Digital Accelerometer (backward-compatibility value "adi,adxl345" must be listed too)
> > -at,24c08 i2c serial eeprom (24cxx)
> > atmel,24c00 i2c serial eeprom (24cxx)
> > atmel,24c01 i2c serial eeprom (24cxx)
> > atmel,24c02 i2c serial eeprom (24cxx)
> > atmel,24c04 i2c serial eeprom (24cxx)
> > +atmel,24c08 i2c serial eeprom (24cxx)
> > atmel,24c16 i2c serial eeprom (24cxx)
> > atmel,24c32 i2c serial eeprom (24cxx)
> > atmel,24c64 i2c serial eeprom (24cxx)
> > --
> > 2.6.3
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
>
>
>
> --
> With Best Regards,
> Andy Shevchenko
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] DT: i2c: Update vendor prefix for 24c00
2016-01-02 21:21 ` Wolfram Sang
@ 2016-01-04 18:22 ` Andy Shevchenko
2016-01-06 8:55 ` Wolfram Sang
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2016-01-04 18:22 UTC (permalink / raw)
To: Wolfram Sang
Cc: Akshay Bhat, ktsai, Rob Herring, Pawel Moll, Mark Rutland,
ijc+devicetree, Kumar Gala, Jiri Kosina, linux-i2c, devicetree,
linux-kernel@vger.kernel.org, justin.waters
On Sat, Jan 2, 2016 at 11:21 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> On Sun, Dec 27, 2015 at 04:57:48PM +0200, Andy Shevchenko wrote:
>> On Wed, Dec 23, 2015 at 9:18 PM, Akshay Bhat <akshay.bhat@timesys.com> wrote:
>> > "at" is not a valid vendor prefix, correcting the same to "atmel"
>> >
>>
>> I'm afraid you can't just do this change alone as it's used in some
>> DTS. Though you may deprecated it along with update of current users.
>
> Well, in Linux, I2C core currently strips the vendor anyhow. This will
> probably be changed somewhen (tm), but for now, the impact for Linux
> should be extremly close to 0.
Okay, no objections to the original patch then.
>
>
>>
>> > Signed-off-by: Akshay Bhat <akshay.bhat@timesys.com>
>> > ---
>> > Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
>> > index c50cf13..c4a01c0 100644
>> > --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
>> > +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
>> > @@ -20,11 +20,11 @@ adi,adt7476 +/-1C TDM Extended Temp Range I.C
>> > adi,adt7490 +/-1C TDM Extended Temp Range I.C
>> > adi,adxl345 Three-Axis Digital Accelerometer
>> > adi,adxl346 Three-Axis Digital Accelerometer (backward-compatibility value "adi,adxl345" must be listed too)
>> > -at,24c08 i2c serial eeprom (24cxx)
>> > atmel,24c00 i2c serial eeprom (24cxx)
>> > atmel,24c01 i2c serial eeprom (24cxx)
>> > atmel,24c02 i2c serial eeprom (24cxx)
>> > atmel,24c04 i2c serial eeprom (24cxx)
>> > +atmel,24c08 i2c serial eeprom (24cxx)
>> > atmel,24c16 i2c serial eeprom (24cxx)
>> > atmel,24c32 i2c serial eeprom (24cxx)
>> > atmel,24c64 i2c serial eeprom (24cxx)
>> > --
>> > 2.6.3
>> >
>> > --
>> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> > the body of a message to majordomo@vger.kernel.org
>> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>> > Please read the FAQ at http://www.tux.org/lkml/
>>
>>
>>
>> --
>> With Best Regards,
>> Andy Shevchenko
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] DT: i2c: Update vendor prefix for 24c00
2016-01-04 18:22 ` Andy Shevchenko
@ 2016-01-06 8:55 ` Wolfram Sang
0 siblings, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2016-01-06 8:55 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Akshay Bhat, ktsai, Rob Herring, Pawel Moll, Mark Rutland,
ijc+devicetree, Kumar Gala, Jiri Kosina, linux-i2c, devicetree,
linux-kernel@vger.kernel.org, justin.waters
[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]
On Mon, Jan 04, 2016 at 08:22:33PM +0200, Andy Shevchenko wrote:
> On Sat, Jan 2, 2016 at 11:21 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> > On Sun, Dec 27, 2015 at 04:57:48PM +0200, Andy Shevchenko wrote:
> >> On Wed, Dec 23, 2015 at 9:18 PM, Akshay Bhat <akshay.bhat@timesys.com> wrote:
> >> > "at" is not a valid vendor prefix, correcting the same to "atmel"
> >> >
> >>
> >> I'm afraid you can't just do this change alone as it's used in some
> >> DTS. Though you may deprecated it along with update of current users.
> >
> > Well, in Linux, I2C core currently strips the vendor anyhow. This will
> > probably be changed somewhen (tm), but for now, the impact for Linux
> > should be extremly close to 0.
>
> Okay, no objections to the original patch then.
Heh, I just go reminded that eeproms already have a seperate binding
description (Documentation/devicetree/bindings/eeprom/eeprom.txt).
I will update the eeprom bindings and remove the entries from trivial
devices.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-01-06 8:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-23 19:18 [PATCH] DT: i2c: Update vendor prefix for 24c00 Akshay Bhat
2015-12-27 14:57 ` Andy Shevchenko
2016-01-02 21:21 ` Wolfram Sang
2016-01-04 18:22 ` Andy Shevchenko
2016-01-06 8:55 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).