From: Romain Izard <romain.izard.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Josh Wu <josh.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
Nicolas Ferre
<nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
Romain Izard
<romain.izard.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: [RFC PATCH 1/4] mtd: atmel_nand: Do not warn on bitflips
Date: Tue, 12 Jan 2016 15:33:40 +0100 [thread overview]
Message-ID: <1452609223-14790-2-git-send-email-romain.izard.pro@gmail.com> (raw)
In-Reply-To: <1452609223-14790-1-git-send-email-romain.izard.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
When using multi-bit ECC, it is normal for the NAND Flash driver to
correct bit errors during the life of the product. Those errors will
only be cleared once a threshold has been reached, and corrections can
occur regularly before this.
Use only dev_dbg and not dev_info to report the bitflips, to keep the
system log clean when everything works correctly.
Signed-off-by: Romain Izard <romain.izard.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
drivers/mtd/nand/atmel_nand.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index 46010bd895b1..9d71f9e6a8de 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -824,7 +824,7 @@ static void pmecc_correct_data(struct mtd_info *mtd, uint8_t *buf, uint8_t *ecc,
*(buf + byte_pos) ^= (1 << bit_pos);
pos = sector_num * host->pmecc_sector_size + byte_pos;
- dev_info(host->dev, "Bit flip in data area, byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n",
+ dev_dbg(host->dev, "Bit flip in data area, byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n",
pos, bit_pos, err_byte, *(buf + byte_pos));
} else {
/* Bit flip in OOB area */
@@ -834,7 +834,7 @@ static void pmecc_correct_data(struct mtd_info *mtd, uint8_t *buf, uint8_t *ecc,
ecc[tmp] ^= (1 << bit_pos);
pos = tmp + nand_chip->ecc.layout->eccpos[0];
- dev_info(host->dev, "Bit flip in OOB, oob_byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n",
+ dev_dbg(host->dev, "Bit flip in OOB, oob_byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n",
pos, bit_pos, err_byte, ecc[tmp]);
}
--
2.5.0
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-12 14:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 14:33 [RFC PATCH 0/4] mtd: atmel_nand: Add support for NAND Flash on SAMA5D2 Romain Izard
[not found] ` <1452609223-14790-1-git-send-email-romain.izard.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-12 14:33 ` Romain Izard [this message]
2016-01-13 5:12 ` [RFC PATCH 1/4] mtd: atmel_nand: Do not warn on bitflips Yang, Wenyou
2016-01-13 5:14 ` Yang, Wenyou
2016-01-12 14:33 ` [RFC PATCH 2/4] mtd: atmel_nand: Support variable RB_EDGE interrupts Romain Izard
[not found] ` <1452609223-14790-3-git-send-email-romain.izard.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-13 6:14 ` Yang, Wenyou
2016-01-17 3:58 ` Rob Herring
2016-01-12 14:33 ` [RFC PATCH 3/4] mtd: atmel_nand: Support 32-bit ECC strength Romain Izard
[not found] ` <1452609223-14790-4-git-send-email-romain.izard.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-13 6:12 ` Yang, Wenyou
2016-01-12 14:33 ` [RFC PATCH 4/4] ARM: at91/dt: sama5d2: add nand0 and nfc0 nodes Romain Izard
[not found] ` <1452609223-14790-5-git-send-email-romain.izard.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-13 6:06 ` Yang, Wenyou
2016-01-13 9:41 ` romain izard
[not found] ` <CAGkQfmN3Ko0Pbyued0AGMPskqVUWStxO44Nj=k8O-+iWYObXMg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-13 11:33 ` Yang, Wenyou
2016-01-13 12:39 ` Yang, Wenyou
2016-01-13 14:51 ` Nicolas Ferre
2016-01-12 15:45 ` [RFC PATCH 0/4] mtd: atmel_nand: Add support for NAND Flash on SAMA5D2 Nicolas Ferre
[not found] ` <56951F91.1090101-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2016-01-12 16:55 ` Romain Izard
[not found] ` <CAGkQfmOmgiKwziQ+HuJTN1Qk1aHEXBWYcE1LT+XT2d-Xv7kxNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-13 11:46 ` Nicolas Ferre
[not found] ` <56963918.7040809-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2016-01-13 12:56 ` Romain Izard
[not found] ` <CAGkQfmNDZmKDJYMuVizbb-+3nXX2DAqDCOf8qE0DNR-3Y2Etcg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-13 14:40 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452609223-14790-2-git-send-email-romain.izard.pro@gmail.com \
--to=romain.izard.pro-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=josh.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).