From mboxrd@z Thu Jan 1 00:00:00 1970 From: Loc Ho Subject: [PATCH v4 1/2] acpi: Fix proper return code for function acpi_gsi_to_irq Date: Wed, 20 Jan 2016 17:17:38 -0700 Message-ID: <1453335459-3617-2-git-send-email-lho@apm.com> References: <1453335459-3617-1-git-send-email-lho@apm.com> Return-path: In-Reply-To: <1453335459-3617-1-git-send-email-lho@apm.com> Sender: linux-acpi-owner@vger.kernel.org To: bp@alien8.de, dougthompson@xmission.com, mchehab@osg.samsung.com, tomasz.nowicki@linaro.org, fu.wei@linaro.org, rjw@rjwysocki.net, lenb@kernel.org Cc: linux-edac@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, patches@apm.com, Loc Ho , Tuan Phan List-Id: devicetree@vger.kernel.org The function acpi_gsi_to_irq must return 0 on success as the caller ghes_probe expects an 0 for success. This change also matches x86 implementation. Signed-off-by: Tuan Phan Signed-off-by: Loc Ho --- drivers/acpi/gsi.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/gsi.c b/drivers/acpi/gsi.c index ee9e0f2..7b109bd 100644 --- a/drivers/acpi/gsi.c +++ b/drivers/acpi/gsi.c @@ -24,7 +24,7 @@ static struct fwnode_handle *acpi_gsi_domain_id; * * irq location updated with irq value [>0 on success, 0 on failure] * - * Returns: linux IRQ number on success (>0) + * Returns: 0 on success * -EINVAL on failure */ int acpi_gsi_to_irq(u32 gsi, unsigned int *irq) @@ -37,7 +37,7 @@ int acpi_gsi_to_irq(u32 gsi, unsigned int *irq) * *irq == 0 means no mapping, that should * be reported as a failure */ - return (*irq > 0) ? *irq : -EINVAL; + return (*irq > 0) ? 0 : -EINVAL; } EXPORT_SYMBOL_GPL(acpi_gsi_to_irq); -- 1.7.1