From: Stefan Agner <stefan@agner.ch>
To: dmitry.torokhov@gmail.com, michael.hennerich@analog.com,
robh+dt@kernel.org
Cc: mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, realmz6@gmail.com, broonie@kernel.org,
jic23@kernel.org, linux-input@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Stefan Agner <stefan@agner.ch>
Subject: [PATCH 2/3] input: touchscreen: ad7879: fix default x/y axis assignment
Date: Mon, 25 Jan 2016 19:04:36 -0800 [thread overview]
Message-ID: <1453777477-29706-2-git-send-email-stefan@agner.ch> (raw)
In-Reply-To: <1453777477-29706-1-git-send-email-stefan@agner.ch>
The measurements read from the controller which are temporary stored
in conversion_data, are interpreted wrong. The first measurement X+
contains the Y position, and the second measurement Y+ the X position
(see also Table 11 Register Table in the data sheet).
The problem is already known and a swap option has been introduced:
commit 6680884a4420 ("Input: ad7879 - add option to correct xy axis")
However, with that the meaning of the new boolean is inverted since
the underlying values are already swapped. With this change, a true
in swap_xy actually swaps the two axis.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
Hi Michael,
It seems that swap_xy is not used in any board which is in mainline,
hence swap_xy is always false. Therefore, up until now all boards
actually used swapped axis. However, I doubt that the blackfin boards
really have those axis swapped, it is probably more likely that the
userspace calibration took care of it.
However, if they are really swapped, we should set the swap_xy flag
to 1 for those board...
Do you happen to now what is the case with those boards?
next prev parent reply other threads:[~2016-01-26 3:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 3:04 [PATCH 1/3] input: touchscreen: ad7879: move header to input subdirectory Stefan Agner
2016-01-26 3:04 ` Stefan Agner [this message]
2016-01-26 7:58 ` [PATCH 2/3] input: touchscreen: ad7879: fix default x/y axis assignment Michael Hennerich
[not found] ` <56A72734.9000303-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
2016-01-26 17:04 ` Stefan Agner
2016-01-27 23:40 ` Dmitry Torokhov
2016-01-26 3:04 ` [PATCH 3/3] input: touchscreen: ad7879: add device tree support Stefan Agner
2016-01-26 4:50 ` kbuild test robot
2016-01-26 8:14 ` Michael Hennerich
2016-01-26 17:10 ` Stefan Agner
[not found] ` <1453777477-29706-3-git-send-email-stefan-XLVq0VzYD2Y@public.gmane.org>
2016-01-26 3:28 ` kbuild test robot
2016-01-26 3:57 ` kbuild test robot
2016-01-27 23:38 ` Dmitry Torokhov
2016-01-29 3:00 ` Rob Herring
2016-01-27 23:35 ` [PATCH 1/3] input: touchscreen: ad7879: move header to input subdirectory Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453777477-29706-2-git-send-email-stefan@agner.ch \
--to=stefan@agner.ch \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jic23@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michael.hennerich@analog.com \
--cc=realmz6@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).