devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] scripts/dtc: Update to upstream commit b06e55c88b9b
@ 2016-01-26 17:05 Rob Herring
  2016-02-02  8:08 ` Frank Rowand
  0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2016-01-26 17:05 UTC (permalink / raw)
  To: devicetree, linux-kernel; +Cc: Frank Rowand, Grant Likely

Sync to upstream dtc commit b06e55c88b9b ("Prevent crash on modulo by
zero"). This adds the following commits from upstream:

b06e55c Prevent crash on modulo by zero
b433450 Fix some bugs in processing of line directives
d728ad5 Fix crash on nul character in string escape sequence
1ab2205 Gracefully handle bad octal literals
1937095 Prevent crash on division by zero
d0b3ab0 libfdt: Fix undefined behaviour in fdt_offset_ptr()
d4c7c25 libfdt: check for potential overrun in _fdt_splice()
f58799b libfdt: Add some missing symbols to version.lds
af9f26d Remove duplicated -Werror in dtc Makefile
604e61e fdt: Add functions to retrieve strings
8702bd1 fdt: Add a function to get the index of a string
2218387 fdt: Add a function to count strings
554fde2 libfdt: fix comment block of fdt_get_property_namelen()
e5e6df7 fdtdump: Fix bug printing bytestrings with negative values
067829e Remove redundant fdtdump test code
897a429 Move fdt_path_offset alias tests to right tests section
2d1417c Add simple .travis.yml
f6dbc6c guess output file format
5e78dff guess input file format based on file content or file name
8b927bf tests: convert `echo -n` to `printf`
64c46b0 Fix crash with poorly defined #size-cells

Cc: Frank Rowand <frowand.list@gmail.com>
Cc: Grant Likely <grant.likely@linaro.org>
Signed-off-by: Rob Herring <robh@kernel.org>
---
 scripts/dtc/checks.c                 |   2 +-
 scripts/dtc/dtc-lexer.l              |  39 +++++++++-----
 scripts/dtc/dtc-lexer.lex.c_shipped  | 101 +++++++++++++++++++----------------
 scripts/dtc/dtc-parser.tab.c_shipped |  84 +++++++++++++++++------------
 scripts/dtc/dtc-parser.y             |  20 ++++++-
 scripts/dtc/dtc.c                    |  62 ++++++++++++++++++++-
 scripts/dtc/libfdt/fdt.c             |  13 ++---
 scripts/dtc/libfdt/fdt_ro.c          | 100 ++++++++++++++++++++++++++++++++++
 scripts/dtc/libfdt/fdt_rw.c          |   2 +
 scripts/dtc/libfdt/libfdt.h          |  73 +++++++++++++++++++++++--
 scripts/dtc/util.c                   |   3 +-
 scripts/dtc/version_gen.h            |   2 +-
 12 files changed, 390 insertions(+), 111 deletions(-)

Generated from script, so just sending the diffstat and log for review.

Rob

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] scripts/dtc: Update to upstream commit b06e55c88b9b
  2016-01-26 17:05 [PATCH] scripts/dtc: Update to upstream commit b06e55c88b9b Rob Herring
@ 2016-02-02  8:08 ` Frank Rowand
  0 siblings, 0 replies; 2+ messages in thread
From: Frank Rowand @ 2016-02-02  8:08 UTC (permalink / raw)
  To: Rob Herring; +Cc: devicetree, linux-kernel, Grant Likely

On 1/26/2016 9:05 AM, Rob Herring wrote:
> Sync to upstream dtc commit b06e55c88b9b ("Prevent crash on modulo by
> zero"). This adds the following commits from upstream:
> 
> b06e55c Prevent crash on modulo by zero
> b433450 Fix some bugs in processing of line directives
> d728ad5 Fix crash on nul character in string escape sequence
> 1ab2205 Gracefully handle bad octal literals
> 1937095 Prevent crash on division by zero
> d0b3ab0 libfdt: Fix undefined behaviour in fdt_offset_ptr()
> d4c7c25 libfdt: check for potential overrun in _fdt_splice()
> f58799b libfdt: Add some missing symbols to version.lds
> af9f26d Remove duplicated -Werror in dtc Makefile
> 604e61e fdt: Add functions to retrieve strings
> 8702bd1 fdt: Add a function to get the index of a string
> 2218387 fdt: Add a function to count strings
> 554fde2 libfdt: fix comment block of fdt_get_property_namelen()
> e5e6df7 fdtdump: Fix bug printing bytestrings with negative values
> 067829e Remove redundant fdtdump test code
> 897a429 Move fdt_path_offset alias tests to right tests section
> 2d1417c Add simple .travis.yml
> f6dbc6c guess output file format
> 5e78dff guess input file format based on file content or file name
> 8b927bf tests: convert `echo -n` to `printf`
> 64c46b0 Fix crash with poorly defined #size-cells
> 
> Cc: Frank Rowand <frowand.list@gmail.com>
> Cc: Grant Likely <grant.likely@linaro.org>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  scripts/dtc/checks.c                 |   2 +-
>  scripts/dtc/dtc-lexer.l              |  39 +++++++++-----
>  scripts/dtc/dtc-lexer.lex.c_shipped  | 101 +++++++++++++++++++----------------
>  scripts/dtc/dtc-parser.tab.c_shipped |  84 +++++++++++++++++------------
>  scripts/dtc/dtc-parser.y             |  20 ++++++-
>  scripts/dtc/dtc.c                    |  62 ++++++++++++++++++++-
>  scripts/dtc/libfdt/fdt.c             |  13 ++---
>  scripts/dtc/libfdt/fdt_ro.c          | 100 ++++++++++++++++++++++++++++++++++
>  scripts/dtc/libfdt/fdt_rw.c          |   2 +
>  scripts/dtc/libfdt/libfdt.h          |  73 +++++++++++++++++++++++--
>  scripts/dtc/util.c                   |   3 +-
>  scripts/dtc/version_gen.h            |   2 +-
>  12 files changed, 390 insertions(+), 111 deletions(-)
> 
> Generated from script, so just sending the diffstat and log for review.
> 
> Rob

Looks good to me.

I did not use your tree (based on 4.5-rc1) to test.  I instead based on
4.4 and did ./scripts/dtc/update-dtc-source.sh with the current dtc git
tree and verified the commits in the dtc tree matched the list above.

I compiled all of the .dts files in the Linux source tree.  I diffed the
resulting .dtb files against the .dtb files created before updating dtc.
There were no differences.

Tested-by: Frank Rowand <frank.rowand@sonymobile.com>

I visually inspected all of the commits you listed in the dtc tree.

Reviewed-by: Frank Rowand <frank.rowand@sonymobile.com>

-Frank

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-02-02  8:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-26 17:05 [PATCH] scripts/dtc: Update to upstream commit b06e55c88b9b Rob Herring
2016-02-02  8:08 ` Frank Rowand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).