* [PATCH V4 1/2] powerpc/fsl: Add PCI node in device tree of bsc9132qds
@ 2015-11-05 3:15 Zhiqiang Hou
[not found] ` <1446693360-1578-1-git-send-email-Zhiqiang.Hou-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
0 siblings, 1 reply; 9+ messages in thread
From: Zhiqiang Hou @ 2015-11-05 3:15 UTC (permalink / raw)
To: linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ,
scottwood-KZfg59tc24xl57MIdRCFDg,
galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r,
benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r,
paulus-eUNUBHrolfbYtjvyW6yDsg, mpe-Gsx/Oe8HsFggBc27wqDAHg,
devicetree-u79uwXL29TY76Z2rM5mHXA, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
harninder.rai-KZfg59tc24xl57MIdRCFDg
Cc: Minghuan.Lian-KZfg59tc24xl57MIdRCFDg,
Mingkai.Hu-KZfg59tc24xl57MIdRCFDg, Hou Zhiqiang
From: Harninder Rai <harninder.rai-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Signed-off-by: Harninder Rai <harninder.rai-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Signed-off-by: Minghuan Lian <Minghuan.Lian-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Signed-off-by: Hou Zhiqiang <B48286-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
V4: V3:
- Remove gerrit stuff.
V2:
- Remove property clock-frequency.
arch/powerpc/boot/dts/bsc9132qds.dts | 15 ++++++++++++++
arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi | 28 +++++++++++++++++++++++++++
arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi | 1 +
3 files changed, 44 insertions(+)
diff --git a/arch/powerpc/boot/dts/bsc9132qds.dts b/arch/powerpc/boot/dts/bsc9132qds.dts
index 6cab106..940d719 100644
--- a/arch/powerpc/boot/dts/bsc9132qds.dts
+++ b/arch/powerpc/boot/dts/bsc9132qds.dts
@@ -29,6 +29,21 @@
soc: soc@ff700000 {
ranges = <0x0 0x0 0xff700000 0x100000>;
};
+
+ pci0: pcie@ff70a000 {
+ reg = <0 0xff70a000 0 0x1000>;
+ ranges = <0x2000000 0x0 0x90000000 0 0x90000000 0x0 0x20000000
+ 0x1000000 0x0 0x00000000 0 0xc0010000 0x0 0x10000>;
+ pcie@0 {
+ ranges = <0x2000000 0x0 0x90000000
+ 0x2000000 0x0 0x90000000
+ 0x0 0x20000000
+
+ 0x1000000 0x0 0x0
+ 0x1000000 0x0 0x0
+ 0x0 0x100000>;
+ };
+ };
};
/include/ "bsc9132qds.dtsi"
diff --git a/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi b/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
index c723071..b5f0715 100644
--- a/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
@@ -40,6 +40,34 @@
interrupts = <16 2 0 0 20 2 0 0>;
};
+/* controller at 0xa000 */
+&pci0 {
+ compatible = "fsl,bsc9132-pcie", "fsl,qoriq-pcie-v2.2";
+ device_type = "pci";
+ #size-cells = <2>;
+ #address-cells = <3>;
+ bus-range = <0 255>;
+ interrupts = <16 2 0 0>;
+
+ pcie@0 {
+ reg = <0 0 0 0 0>;
+ #interrupt-cells = <1>;
+ #size-cells = <2>;
+ #address-cells = <3>;
+ device_type = "pci";
+ interrupts = <16 2 0 0>;
+ interrupt-map-mask = <0xf800 0 0 7>;
+
+ interrupt-map = <
+ /* IDSEL 0x0 */
+ 0000 0x0 0x0 0x1 &mpic 0x0 0x2 0x0 0x0
+ 0000 0x0 0x0 0x2 &mpic 0x1 0x2 0x0 0x0
+ 0000 0x0 0x0 0x3 &mpic 0x2 0x2 0x0 0x0
+ 0000 0x0 0x0 0x4 &mpic 0x3 0x2 0x0 0x0
+ >;
+ };
+};
+
&soc {
#address-cells = <1>;
#size-cells = <1>;
diff --git a/arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi b/arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi
index 301a9db..90f7949 100644
--- a/arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi
+++ b/arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi
@@ -45,6 +45,7 @@
serial0 = &serial0;
ethernet0 = &enet0;
ethernet1 = &enet1;
+ pci0 = &pci0;
};
cpus {
--
2.1.0.27.g96db324
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH V4 2/2] powerpc/85xx: Add PCIe controller support for bsc9132qds
[not found] ` <1446693360-1578-1-git-send-email-Zhiqiang.Hou-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
@ 2015-11-05 3:16 ` Zhiqiang Hou
2015-11-17 2:31 ` Hou Zhiqiang
2015-12-22 9:28 ` [PATCH V4 1/2] powerpc/fsl: Add PCI node in device tree of bsc9132qds Zhiqiang Hou
1 sibling, 1 reply; 9+ messages in thread
From: Zhiqiang Hou @ 2015-11-05 3:16 UTC (permalink / raw)
To: linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ,
scottwood-KZfg59tc24xl57MIdRCFDg,
galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r,
benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r,
paulus-eUNUBHrolfbYtjvyW6yDsg, mpe-Gsx/Oe8HsFggBc27wqDAHg,
devicetree-u79uwXL29TY76Z2rM5mHXA, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
harninder.rai-KZfg59tc24xl57MIdRCFDg
Cc: Minghuan.Lian-KZfg59tc24xl57MIdRCFDg,
Mingkai.Hu-KZfg59tc24xl57MIdRCFDg, Hou Zhiqiang
From: Harninder Rai <harninder.rai-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
1. Use machine_arch_initcall to hook mpc85xx_common_publish_devices
This can ensure before pcibios_init() is called, pci controllers have
been probed and added to the hose_list.
2. Add a workaround for errata A-005434
For the BSC9132, PEX_PEXIWARn[TRGT] for all windows defaults to 0xF,
which is mapped to CCSRBAR. However, for other products, 0xF is
mapped to the local memory. Therefore, for the BSC9132, any default
PCI Express access to the local memory (DDR) will now access the
CCSRBAR. This patch changes the mapping of targets of inbound windows
PEX_PEXIWARn[TRGT] to the Local address space – 0x0 (from 0xF).
Signed-off-by: Harninder Rai <harninder.rai-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Signed-off-by: Minghuan Lian <Minghuan.Lian-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Signed-off-by: Hou Zhiqiang <B48286-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
V4: V3:
- Remove gerrit stuff.
arch/powerpc/platforms/85xx/bsc913x_qds.c | 8 +++++++-
arch/powerpc/sysdev/fsl_pci.c | 13 +++++++++++++
2 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/85xx/bsc913x_qds.c b/arch/powerpc/platforms/85xx/bsc913x_qds.c
index f0927e5..dcfafd6 100644
--- a/arch/powerpc/platforms/85xx/bsc913x_qds.c
+++ b/arch/powerpc/platforms/85xx/bsc913x_qds.c
@@ -17,6 +17,7 @@
#include <linux/pci.h>
#include <asm/mpic.h>
#include <sysdev/fsl_soc.h>
+#include <sysdev/fsl_pci.h>
#include <asm/udbg.h>
#include "mpc85xx.h"
@@ -46,10 +47,12 @@ static void __init bsc913x_qds_setup_arch(void)
mpc85xx_smp_init();
#endif
+ fsl_pci_assign_primary();
+
pr_info("bsc913x board from Freescale Semiconductor\n");
}
-machine_device_initcall(bsc9132_qds, mpc85xx_common_publish_devices);
+machine_arch_initcall(bsc9132_qds, mpc85xx_common_publish_devices);
/*
* Called very early, device-tree isn't unflattened
@@ -67,6 +70,9 @@ define_machine(bsc9132_qds) {
.probe = bsc9132_qds_probe,
.setup_arch = bsc913x_qds_setup_arch,
.init_IRQ = bsc913x_qds_pic_init,
+#ifdef CONFIG_PCI
+ .pcibios_fixup_bus = fsl_pcibios_fixup_bus,
+#endif
.get_irq = mpic_get_irq,
.restart = fsl_rstcr_restart,
.calibrate_decr = generic_calibrate_decr,
diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c
index ebc1f412..b8607f6 100644
--- a/arch/powerpc/sysdev/fsl_pci.c
+++ b/arch/powerpc/sysdev/fsl_pci.c
@@ -193,6 +193,19 @@ static void setup_pci_atmu(struct pci_controller *hose)
const u64 *reg;
int len;
+ if (of_device_is_compatible(hose->dn, "fsl,bsc9132-pcie")) {
+ /*
+ * BSC9132 Rev1.0 has an issue where all the PEX inbound
+ * windows have implemented the default target value as 0xf
+ * for CCSR space.In all Freescale legacy devices the target
+ * of 0xf is reserved for local memory space. 9132 Rev1.0
+ * now has local mempry space mapped to target 0x0 instead of
+ * 0xf. Hence adding a workaround to remove the target 0xf
+ * defined for memory space from Inbound window attributes.
+ */
+ piwar &= ~PIWAR_TGI_LOCAL;
+ }
+
if (early_find_capability(hose, 0, 0, PCI_CAP_ID_EXP)) {
if (in_be32(&pci->block_rev1) >= PCIE_IP_REV_2_2) {
win_idx = 2;
--
2.1.0.27.g96db324
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 9+ messages in thread
* RE: [PATCH V4 2/2] powerpc/85xx: Add PCIe controller support for bsc9132qds
2015-11-05 3:16 ` [PATCH V4 2/2] powerpc/85xx: Add PCIe controller support for bsc9132qds Zhiqiang Hou
@ 2015-11-17 2:31 ` Hou Zhiqiang
[not found] ` <CY1PR0301MB07806A3A31D76967125054C28B1D0-YrwGdl+PljnwWZenWrSUgZwN6zqB+hSMnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
0 siblings, 1 reply; 9+ messages in thread
From: Hou Zhiqiang @ 2015-11-17 2:31 UTC (permalink / raw)
To: Zhiqiang Hou, linuxppc-dev@lists.ozlabs.org, Scott Wood,
galak@kernel.crashing.org, benh@kernel.crashing.org,
paulus@samba.org, mpe@ellerman.id.au, devicetree@vger.kernel.org,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, Harninder Rai
Cc: Lian M.H., Hu Vincent
Hi,
Any response, please comment.
> -----Original Message-----
> From: Zhiqiang Hou [mailto:Zhiqiang.Hou@freescale.com]
> Sent: 2015年11月5日 11:16
> To: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421;
> galak@kernel.crashing.org; benh@kernel.crashing.org; paulus@samba.org;
> mpe@ellerman.id.au; devicetree@vger.kernel.org; robh+dt@kernel.org;
> pawel.moll@arm.com; mark.rutland@arm.com; ijc+devicetree@hellion.org.uk;
> Rai Harninder-B01044
> Cc: Lian Minghuan-B31939; Hu Mingkai-B21284; Hou Zhiqiang-B48286
> Subject: [PATCH V4 2/2] powerpc/85xx: Add PCIe controller support for
> bsc9132qds
>
> From: Harninder Rai <harninder.rai@freescale.com>
>
> 1. Use machine_arch_initcall to hook mpc85xx_common_publish_devices This
> can ensure before pcibios_init() is called, pci controllers have been
> probed and added to the hose_list.
> 2. Add a workaround for errata A-005434
> For the BSC9132, PEX_PEXIWARn[TRGT] for all windows defaults to 0xF,
> which is mapped to CCSRBAR. However, for other products, 0xF is mapped to
> the local memory. Therefore, for the BSC9132, any default PCI Express
> access to the local memory (DDR) will now access the CCSRBAR. This patch
> changes the mapping of targets of inbound windows PEX_PEXIWARn[TRGT] to
> the Local address space – 0x0 (from 0xF).
>
> Signed-off-by: Harninder Rai <harninder.rai@freescale.com>
> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
> Signed-off-by: Hou Zhiqiang <B48286@freescale.com>
> ---
> V4: V3:
> - Remove gerrit stuff.
>
> arch/powerpc/platforms/85xx/bsc913x_qds.c | 8 +++++++-
> arch/powerpc/sysdev/fsl_pci.c | 13 +++++++++++++
> 2 files changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/85xx/bsc913x_qds.c
> b/arch/powerpc/platforms/85xx/bsc913x_qds.c
> index f0927e5..dcfafd6 100644
> --- a/arch/powerpc/platforms/85xx/bsc913x_qds.c
> +++ b/arch/powerpc/platforms/85xx/bsc913x_qds.c
> @@ -17,6 +17,7 @@
> #include <linux/pci.h>
> #include <asm/mpic.h>
> #include <sysdev/fsl_soc.h>
> +#include <sysdev/fsl_pci.h>
> #include <asm/udbg.h>
>
> #include "mpc85xx.h"
> @@ -46,10 +47,12 @@ static void __init bsc913x_qds_setup_arch(void)
> mpc85xx_smp_init();
> #endif
>
> + fsl_pci_assign_primary();
> +
> pr_info("bsc913x board from Freescale Semiconductor\n"); }
>
> -machine_device_initcall(bsc9132_qds, mpc85xx_common_publish_devices);
> +machine_arch_initcall(bsc9132_qds, mpc85xx_common_publish_devices);
>
> /*
> * Called very early, device-tree isn't unflattened @@ -67,6 +70,9 @@
> define_machine(bsc9132_qds) {
> .probe = bsc9132_qds_probe,
> .setup_arch = bsc913x_qds_setup_arch,
> .init_IRQ = bsc913x_qds_pic_init,
> +#ifdef CONFIG_PCI
> + .pcibios_fixup_bus = fsl_pcibios_fixup_bus,
> +#endif
> .get_irq = mpic_get_irq,
> .restart = fsl_rstcr_restart,
> .calibrate_decr = generic_calibrate_decr,
> diff --git a/arch/powerpc/sysdev/fsl_pci.c
> b/arch/powerpc/sysdev/fsl_pci.c index ebc1f412..b8607f6 100644
> --- a/arch/powerpc/sysdev/fsl_pci.c
> +++ b/arch/powerpc/sysdev/fsl_pci.c
> @@ -193,6 +193,19 @@ static void setup_pci_atmu(struct pci_controller
> *hose)
> const u64 *reg;
> int len;
>
> + if (of_device_is_compatible(hose->dn, "fsl,bsc9132-pcie")) {
> + /*
> + * BSC9132 Rev1.0 has an issue where all the PEX inbound
> + * windows have implemented the default target value as 0xf
> + * for CCSR space.In all Freescale legacy devices the target
> + * of 0xf is reserved for local memory space. 9132 Rev1.0
> + * now has local mempry space mapped to target 0x0 instead of
> + * 0xf. Hence adding a workaround to remove the target 0xf
> + * defined for memory space from Inbound window attributes.
> + */
> + piwar &= ~PIWAR_TGI_LOCAL;
> + }
> +
> if (early_find_capability(hose, 0, 0, PCI_CAP_ID_EXP)) {
> if (in_be32(&pci->block_rev1) >= PCIE_IP_REV_2_2) {
> win_idx = 2;
> --
> 2.1.0.27.g96db324
Thanks,
Zhiqiang
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V4 2/2] powerpc/85xx: Add PCIe controller support for bsc9132qds
[not found] ` <CY1PR0301MB07806A3A31D76967125054C28B1D0-YrwGdl+PljnwWZenWrSUgZwN6zqB+hSMnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
@ 2015-11-20 3:02 ` Scott Wood
2015-12-22 9:21 ` Zhiqiang Hou
0 siblings, 1 reply; 9+ messages in thread
From: Scott Wood @ 2015-11-20 3:02 UTC (permalink / raw)
To: Hou Zhiqiang-B48286, Zhiqiang Hou,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org,
benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org,
paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org,
mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
Rai Harninder-B01044
Cc: Lian Minghuan-B31939, Hu Mingkai-B21284
On Mon, 2015-11-16 at 20:31 -0600, Hou Zhiqiang-B48286 wrote:
> Hi,
>
> Any response, please comment.
They look OK.
-Scott
>
> > -----Original Message-----
> > From: Zhiqiang Hou [mailto:Zhiqiang.Hou-KZfg59tc24xl57MIdRCFDg@public.gmane.org]
> > Sent: 2015年11月5日 11:16
> > To: linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; Wood Scott-B07421;
> > galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org; benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org; paulus@samba.org;
> > mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org; devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org;
> > pawel.moll-5wv7dgnIgG8@public.gmane.org; mark.rutland-5wv7dgnIgG8@public.gmane.org; ijc+devicetree-KcIKpvwj1kXF2uMehF1BdA@public.gmane.orgg.uk;
> > Rai Harninder-B01044
> > Cc: Lian Minghuan-B31939; Hu Mingkai-B21284; Hou Zhiqiang-B48286
> > Subject: [PATCH V4 2/2] powerpc/85xx: Add PCIe controller support for
> > bsc9132qds
> >
> > From: Harninder Rai <harninder.rai-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> >
> > 1. Use machine_arch_initcall to hook mpc85xx_common_publish_devices This
> > can ensure before pcibios_init() is called, pci controllers have been
> > probed and added to the hose_list.
> > 2. Add a workaround for errata A-005434
> > For the BSC9132, PEX_PEXIWARn[TRGT] for all windows defaults to 0xF,
> > which is mapped to CCSRBAR. However, for other products, 0xF is mapped to
> > the local memory. Therefore, for the BSC9132, any default PCI Express
> > access to the local memory (DDR) will now access the CCSRBAR. This patch
> > changes the mapping of targets of inbound windows PEX_PEXIWARn[TRGT] to
> > the Local address space – 0x0 (from 0xF).
> >
> > Signed-off-by: Harninder Rai <harninder.rai-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > Signed-off-by: Minghuan Lian <Minghuan.Lian-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > Signed-off-by: Hou Zhiqiang <B48286-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > ---
> > V4: V3:
> > - Remove gerrit stuff.
> >
> > arch/powerpc/platforms/85xx/bsc913x_qds.c | 8 +++++++-
> > arch/powerpc/sysdev/fsl_pci.c | 13 +++++++++++++
> > 2 files changed, 20 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/powerpc/platforms/85xx/bsc913x_qds.c
> > b/arch/powerpc/platforms/85xx/bsc913x_qds.c
> > index f0927e5..dcfafd6 100644
> > --- a/arch/powerpc/platforms/85xx/bsc913x_qds.c
> > +++ b/arch/powerpc/platforms/85xx/bsc913x_qds.c
> > @@ -17,6 +17,7 @@
> > #include <linux/pci.h>
> > #include <asm/mpic.h>
> > #include <sysdev/fsl_soc.h>
> > +#include <sysdev/fsl_pci.h>
> > #include <asm/udbg.h>
> >
> > #include "mpc85xx.h"
> > @@ -46,10 +47,12 @@ static void __init bsc913x_qds_setup_arch(void)
> > mpc85xx_smp_init();
> > #endif
> >
> > + fsl_pci_assign_primary();
> > +
> > pr_info("bsc913x board from Freescale Semiconductor\n"); }
> >
> > -machine_device_initcall(bsc9132_qds, mpc85xx_common_publish_devices);
> > +machine_arch_initcall(bsc9132_qds, mpc85xx_common_publish_devices);
> >
> > /*
> > * Called very early, device-tree isn't unflattened @@ -67,6 +70,9 @@
> > define_machine(bsc9132_qds) {
> > .probe = bsc9132_qds_probe,
> > .setup_arch = bsc913x_qds_setup_arch,
> > .init_IRQ = bsc913x_qds_pic_init,
> > +#ifdef CONFIG_PCI
> > + .pcibios_fixup_bus = fsl_pcibios_fixup_bus,
> > +#endif
> > .get_irq = mpic_get_irq,
> > .restart = fsl_rstcr_restart,
> > .calibrate_decr = generic_calibrate_decr,
> > diff --git a/arch/powerpc/sysdev/fsl_pci.c
> > b/arch/powerpc/sysdev/fsl_pci.c index ebc1f412..b8607f6 100644
> > --- a/arch/powerpc/sysdev/fsl_pci.c
> > +++ b/arch/powerpc/sysdev/fsl_pci.c
> > @@ -193,6 +193,19 @@ static void setup_pci_atmu(struct pci_controller
> > *hose)
> > const u64 *reg;
> > int len;
> >
> > + if (of_device_is_compatible(hose->dn, "fsl,bsc9132-pcie")) {
> > + /*
> > + * BSC9132 Rev1.0 has an issue where all the PEX inbound
> > + * windows have implemented the default target value as
> > 0xf
> > + * for CCSR space.In all Freescale legacy devices the
> > target
> > + * of 0xf is reserved for local memory space. 9132 Rev1.0
> > + * now has local mempry space mapped to target 0x0
> > instead of
> > + * 0xf. Hence adding a workaround to remove the target
> > 0xf
> > + * defined for memory space from Inbound window
> > attributes.
> > + */
> > + piwar &= ~PIWAR_TGI_LOCAL;
> > + }
> > +
> > if (early_find_capability(hose, 0, 0, PCI_CAP_ID_EXP)) {
> > if (in_be32(&pci->block_rev1) >= PCIE_IP_REV_2_2) {
> > win_idx = 2;
> > --
> > 2.1.0.27.g96db324
>
> Thanks,
> Zhiqiang
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH V4 2/2] powerpc/85xx: Add PCIe controller support for bsc9132qds
2015-11-20 3:02 ` Scott Wood
@ 2015-12-22 9:21 ` Zhiqiang Hou
0 siblings, 0 replies; 9+ messages in thread
From: Zhiqiang Hou @ 2015-12-22 9:21 UTC (permalink / raw)
To: Scott Wood, Zhiqiang Hou, Zhiqiang Hou,
linuxppc-dev@lists.ozlabs.org, galak@kernel.crashing.org,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
devicetree@vger.kernel.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, Harninder Rai
Cc: Minghuan Lian, Mingkai Hu
Hi Scott,
Could you please help to apply this patch?
Thanks,
Zhiqiang
> -----Original Message-----
> From: Scott Wood
> Sent: 2015年11月20日 11:02
> To: Zhiqiang Hou; Zhiqiang Hou; linuxppc-dev@lists.ozlabs.org;
> galak@kernel.crashing.org; benh@kernel.crashing.org; paulus@samba.org;
> mpe@ellerman.id.au; devicetree@vger.kernel.org; robh+dt@kernel.org;
> pawel.moll@arm.com; mark.rutland@arm.com; ijc+devicetree@hellion.org.uk;
> Harninder Rai
> Cc: Minghuan Lian; Mingkai Hu
> Subject: Re: [PATCH V4 2/2] powerpc/85xx: Add PCIe controller support for
> bsc9132qds
>
> On Mon, 2015-11-16 at 20:31 -0600, Hou Zhiqiang-B48286 wrote:
> > Hi,
> >
> > Any response, please comment.
>
> They look OK.
>
> -Scott
>
> >
> > > -----Original Message-----
> > > From: Zhiqiang Hou [mailto:Zhiqiang.Hou@freescale.com]
> > > Sent: 2015年11月5日 11:16
> > > To: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421;
> > > galak@kernel.crashing.org; benh@kernel.crashing.org;
> > > paulus@samba.org; mpe@ellerman.id.au; devicetree@vger.kernel.org;
> > > robh+dt@kernel.org; pawel.moll@arm.com; mark.rutland@arm.com;
> > > ijc+devicetree@hellion.org.uk; Rai Harninder-B01044
> > > Cc: Lian Minghuan-B31939; Hu Mingkai-B21284; Hou Zhiqiang-B48286
> > > Subject: [PATCH V4 2/2] powerpc/85xx: Add PCIe controller support
> > > for bsc9132qds
> > >
> > > From: Harninder Rai <harninder.rai@freescale.com>
> > >
> > > 1. Use machine_arch_initcall to hook mpc85xx_common_publish_devices
> > > This can ensure before pcibios_init() is called, pci controllers
> > > have been probed and added to the hose_list.
> > > 2. Add a workaround for errata A-005434 For the BSC9132,
> > > PEX_PEXIWARn[TRGT] for all windows defaults to 0xF, which is mapped
> > > to CCSRBAR. However, for other products, 0xF is mapped to the local
> > > memory. Therefore, for the BSC9132, any default PCI Express access
> > > to the local memory (DDR) will now access the CCSRBAR. This patch
> > > changes the mapping of targets of inbound windows PEX_PEXIWARn[TRGT]
> > > to the Local address space – 0x0 (from 0xF).
> > >
> > > Signed-off-by: Harninder Rai <harninder.rai@freescale.com>
> > > Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
> > > Signed-off-by: Hou Zhiqiang <B48286@freescale.com>
> > > ---
> > > V4: V3:
> > > - Remove gerrit stuff.
> > >
> > > arch/powerpc/platforms/85xx/bsc913x_qds.c | 8 +++++++-
> > > arch/powerpc/sysdev/fsl_pci.c | 13 +++++++++++++
> > > 2 files changed, 20 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/arch/powerpc/platforms/85xx/bsc913x_qds.c
> > > b/arch/powerpc/platforms/85xx/bsc913x_qds.c
> > > index f0927e5..dcfafd6 100644
> > > --- a/arch/powerpc/platforms/85xx/bsc913x_qds.c
> > > +++ b/arch/powerpc/platforms/85xx/bsc913x_qds.c
> > > @@ -17,6 +17,7 @@
> > > #include <linux/pci.h>
> > > #include <asm/mpic.h>
> > > #include <sysdev/fsl_soc.h>
> > > +#include <sysdev/fsl_pci.h>
> > > #include <asm/udbg.h>
> > >
> > > #include "mpc85xx.h"
> > > @@ -46,10 +47,12 @@ static void __init bsc913x_qds_setup_arch(void)
> > > mpc85xx_smp_init();
> > > #endif
> > >
> > > + fsl_pci_assign_primary();
> > > +
> > > pr_info("bsc913x board from Freescale Semiconductor\n"); }
> > >
> > > -machine_device_initcall(bsc9132_qds,
> > > mpc85xx_common_publish_devices);
> > > +machine_arch_initcall(bsc9132_qds, mpc85xx_common_publish_devices);
> > >
> > > /*
> > > * Called very early, device-tree isn't unflattened @@ -67,6 +70,9
> > > @@
> > > define_machine(bsc9132_qds) {
> > > .probe = bsc9132_qds_probe,
> > > .setup_arch = bsc913x_qds_setup_arch,
> > > .init_IRQ = bsc913x_qds_pic_init,
> > > +#ifdef CONFIG_PCI
> > > + .pcibios_fixup_bus = fsl_pcibios_fixup_bus,
> > > +#endif
> > > .get_irq = mpic_get_irq,
> > > .restart = fsl_rstcr_restart,
> > > .calibrate_decr = generic_calibrate_decr,
> > > diff --git a/arch/powerpc/sysdev/fsl_pci.c
> > > b/arch/powerpc/sysdev/fsl_pci.c index ebc1f412..b8607f6 100644
> > > --- a/arch/powerpc/sysdev/fsl_pci.c
> > > +++ b/arch/powerpc/sysdev/fsl_pci.c
> > > @@ -193,6 +193,19 @@ static void setup_pci_atmu(struct
> > > pci_controller
> > > *hose)
> > > const u64 *reg;
> > > int len;
> > >
> > > + if (of_device_is_compatible(hose->dn, "fsl,bsc9132-pcie")) {
> > > + /*
> > > + * BSC9132 Rev1.0 has an issue where all the PEX inbound
> > > + * windows have implemented the default target value as
> > > 0xf
> > > + * for CCSR space.In all Freescale legacy devices the
> > > target
> > > + * of 0xf is reserved for local memory space. 9132 Rev1.0
> > > + * now has local mempry space mapped to target 0x0
> > > instead of
> > > + * 0xf. Hence adding a workaround to remove the target
> > > 0xf
> > > + * defined for memory space from Inbound window
> > > attributes.
> > > + */
> > > + piwar &= ~PIWAR_TGI_LOCAL;
> > > + }
> > > +
> > > if (early_find_capability(hose, 0, 0, PCI_CAP_ID_EXP)) {
> > > if (in_be32(&pci->block_rev1) >= PCIE_IP_REV_2_2) {
> > > win_idx = 2;
> > > --
> > > 2.1.0.27.g96db324
> >
> > Thanks,
> > Zhiqiang
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH V4 1/2] powerpc/fsl: Add PCI node in device tree of bsc9132qds
[not found] ` <1446693360-1578-1-git-send-email-Zhiqiang.Hou-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-11-05 3:16 ` [PATCH V4 2/2] powerpc/85xx: Add PCIe controller support for bsc9132qds Zhiqiang Hou
@ 2015-12-22 9:28 ` Zhiqiang Hou
2016-01-27 6:47 ` Zhiqiang Hou
1 sibling, 1 reply; 9+ messages in thread
From: Zhiqiang Hou @ 2015-12-22 9:28 UTC (permalink / raw)
To: Zhiqiang Hou,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Scott Wood,
galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org,
benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org,
paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org,
mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
Harninder Rai
Cc: Minghuan Lian, Mingkai Hu, Zhiqiang Hou
Hi Rob,
Could you please take this patch into account?
Thanks,
Zhiqiang
> -----Original Message-----
> From: Zhiqiang Hou [mailto:Zhiqiang.Hou@freescale.com]
> Sent: 2015年11月5日 11:16
> To: linuxppc-dev@lists.ozlabs.org; Scott Wood; galak@kernel.crashing.org;
> benh@kernel.crashing.org; paulus@samba.org; mpe@ellerman.id.au;
> devicetree@vger.kernel.org; robh+dt@kernel.org; pawel.moll@arm.com;
> mark.rutland@arm.com; ijc+devicetree@hellion.org.uk; Harninder Rai
> Cc: Minghuan Lian; Mingkai Hu; Zhiqiang Hou
> Subject: [PATCH V4 1/2] powerpc/fsl: Add PCI node in device tree of
> bsc9132qds
>
> From: Harninder Rai <harninder.rai@freescale.com>
>
> Signed-off-by: Harninder Rai <harninder.rai@freescale.com>
> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
> Signed-off-by: Hou Zhiqiang <B48286@freescale.com>
> ---
> V4: V3:
> - Remove gerrit stuff.
> V2:
> - Remove property clock-frequency.
>
> arch/powerpc/boot/dts/bsc9132qds.dts | 15 ++++++++++++++
> arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi | 28
> +++++++++++++++++++++++++++ arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi
> | 1 +
> 3 files changed, 44 insertions(+)
>
> diff --git a/arch/powerpc/boot/dts/bsc9132qds.dts
> b/arch/powerpc/boot/dts/bsc9132qds.dts
> index 6cab106..940d719 100644
> --- a/arch/powerpc/boot/dts/bsc9132qds.dts
> +++ b/arch/powerpc/boot/dts/bsc9132qds.dts
> @@ -29,6 +29,21 @@
> soc: soc@ff700000 {
> ranges = <0x0 0x0 0xff700000 0x100000>;
> };
> +
> + pci0: pcie@ff70a000 {
> + reg = <0 0xff70a000 0 0x1000>;
> + ranges = <0x2000000 0x0 0x90000000 0 0x90000000 0x0
> 0x20000000
> + 0x1000000 0x0 0x00000000 0 0xc0010000 0x0 0x10000>;
> + pcie@0 {
> + ranges = <0x2000000 0x0 0x90000000
> + 0x2000000 0x0 0x90000000
> + 0x0 0x20000000
> +
> + 0x1000000 0x0 0x0
> + 0x1000000 0x0 0x0
> + 0x0 0x100000>;
> + };
> + };
> };
>
> /include/ "bsc9132qds.dtsi"
> diff --git a/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
> b/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
> index c723071..b5f0715 100644
> --- a/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
> @@ -40,6 +40,34 @@
> interrupts = <16 2 0 0 20 2 0 0>;
> };
>
> +/* controller at 0xa000 */
> +&pci0 {
> + compatible = "fsl,bsc9132-pcie", "fsl,qoriq-pcie-v2.2";
> + device_type = "pci";
> + #size-cells = <2>;
> + #address-cells = <3>;
> + bus-range = <0 255>;
> + interrupts = <16 2 0 0>;
> +
> + pcie@0 {
> + reg = <0 0 0 0 0>;
> + #interrupt-cells = <1>;
> + #size-cells = <2>;
> + #address-cells = <3>;
> + device_type = "pci";
> + interrupts = <16 2 0 0>;
> + interrupt-map-mask = <0xf800 0 0 7>;
> +
> + interrupt-map = <
> + /* IDSEL 0x0 */
> + 0000 0x0 0x0 0x1 &mpic 0x0 0x2 0x0 0x0
> + 0000 0x0 0x0 0x2 &mpic 0x1 0x2 0x0 0x0
> + 0000 0x0 0x0 0x3 &mpic 0x2 0x2 0x0 0x0
> + 0000 0x0 0x0 0x4 &mpic 0x3 0x2 0x0 0x0
> + >;
> + };
> +};
> +
> &soc {
> #address-cells = <1>;
> #size-cells = <1>;
> diff --git a/arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi
> b/arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi
> index 301a9db..90f7949 100644
> --- a/arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi
> @@ -45,6 +45,7 @@
> serial0 = &serial0;
> ethernet0 = &enet0;
> ethernet1 = &enet1;
> + pci0 = &pci0;
> };
>
> cpus {
> --
> 2.1.0.27.g96db324
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH V4 1/2] powerpc/fsl: Add PCI node in device tree of bsc9132qds
2015-12-22 9:28 ` [PATCH V4 1/2] powerpc/fsl: Add PCI node in device tree of bsc9132qds Zhiqiang Hou
@ 2016-01-27 6:47 ` Zhiqiang Hou
[not found] ` <HE1PR04MB09060D4FCE88CD7B3F1CBF9084D90-6LN7OEpIatWBkn9woE/rDM9NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
0 siblings, 1 reply; 9+ messages in thread
From: Zhiqiang Hou @ 2016-01-27 6:47 UTC (permalink / raw)
To: Zhiqiang Hou, Zhiqiang Hou, linuxppc-dev@lists.ozlabs.org,
Scott Wood, galak@kernel.crashing.org, benh@kernel.crashing.org,
paulus@samba.org, mpe@ellerman.id.au, devicetree@vger.kernel.org,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, Harninder Rai, robh@kernel.org
Cc: Lian M.H., Hu Vincent, Hou Zhiqiang
Hi Herring and Kumar and Ian,
Can you help to apply this patch?
Thanks,
Zhiqiang
> -----Original Message-----
> From: Zhiqiang Hou [mailto:zhiqiang.hou@nxp.com]
> Sent: 2015年12月22日 17:28
> To: Zhiqiang Hou <Zhiqiang.Hou@freescale.com>; linuxppc-dev@lists.ozlabs.org;
> Scott Wood <scottwood@freescale.com>; galak@kernel.crashing.org;
> benh@kernel.crashing.org; paulus@samba.org; mpe@ellerman.id.au;
> devicetree@vger.kernel.org; robh+dt@kernel.org; pawel.moll@arm.com;
> mark.rutland@arm.com; ijc+devicetree@hellion.org.uk; Harninder Rai
> <harninder.rai@freescale.com>
> Cc: Lian M.H. <Minghuan.Lian@freescale.com>; Hu Vincent
> <Mingkai.Hu@freescale.com>; Hou Zhiqiang <B48286@freescale.com>
> Subject: RE: [PATCH V4 1/2] powerpc/fsl: Add PCI node in device tree of
> bsc9132qds
>
> Hi Rob,
>
> Could you please take this patch into account?
>
> Thanks,
> Zhiqiang
>
> > -----Original Message-----
> > From: Zhiqiang Hou [mailto:Zhiqiang.Hou@freescale.com]
> > Sent: 2015年11月5日 11:16
> > To: linuxppc-dev@lists.ozlabs.org; Scott Wood;
> > galak@kernel.crashing.org; benh@kernel.crashing.org; paulus@samba.org;
> > mpe@ellerman.id.au; devicetree@vger.kernel.org; robh+dt@kernel.org;
> > pawel.moll@arm.com; mark.rutland@arm.com;
> > ijc+devicetree@hellion.org.uk; Harninder Rai
> > Cc: Minghuan Lian; Mingkai Hu; Zhiqiang Hou
> > Subject: [PATCH V4 1/2] powerpc/fsl: Add PCI node in device tree of
> > bsc9132qds
> >
> > From: Harninder Rai <harninder.rai@freescale.com>
> >
> > Signed-off-by: Harninder Rai <harninder.rai@freescale.com>
> > Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
> > Signed-off-by: Hou Zhiqiang <B48286@freescale.com>
> > ---
> > V4: V3:
> > - Remove gerrit stuff.
> > V2:
> > - Remove property clock-frequency.
> >
> > arch/powerpc/boot/dts/bsc9132qds.dts | 15 ++++++++++++++
> > arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi | 28
> > +++++++++++++++++++++++++++
> > +++++++++++++++++++++++++++ arch/powerpc/boot/dts/fsl/bsc9132si-pre.dt
> > +++++++++++++++++++++++++++ si
> > | 1 +
> > 3 files changed, 44 insertions(+)
> >
> > diff --git a/arch/powerpc/boot/dts/bsc9132qds.dts
> > b/arch/powerpc/boot/dts/bsc9132qds.dts
> > index 6cab106..940d719 100644
> > --- a/arch/powerpc/boot/dts/bsc9132qds.dts
> > +++ b/arch/powerpc/boot/dts/bsc9132qds.dts
> > @@ -29,6 +29,21 @@
> > soc: soc@ff700000 {
> > ranges = <0x0 0x0 0xff700000 0x100000>; };
> > +
> > +pci0: pcie@ff70a000 {
> > +reg = <0 0xff70a000 0 0x1000>;
> > +ranges = <0x2000000 0x0 0x90000000 0 0x90000000 0x0
> > 0x20000000
> > + 0x1000000 0x0 0x00000000 0 0xc0010000 0x0 0x10000>;
> > +pcie@0 {
> > +ranges = <0x2000000 0x0 0x90000000
> > + 0x2000000 0x0 0x90000000
> > + 0x0 0x20000000
> > +
> > + 0x1000000 0x0 0x0
> > + 0x1000000 0x0 0x0
> > + 0x0 0x100000>;
> > +};
> > +};
> > };
> >
> > /include/ "bsc9132qds.dtsi"
> > diff --git a/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
> > b/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
> > index c723071..b5f0715 100644
> > --- a/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
> > +++ b/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
> > @@ -40,6 +40,34 @@
> > interrupts = <16 2 0 0 20 2 0 0>;
> > };
> >
> > +/* controller at 0xa000 */
> > +&pci0 {
> > +compatible = "fsl,bsc9132-pcie", "fsl,qoriq-pcie-v2.2"; device_type =
> > +"pci"; #size-cells = <2>; #address-cells = <3>; bus-range = <0 255>;
> > +interrupts = <16 2 0 0>;
> > +
> > +pcie@0 {
> > +reg = <0 0 0 0 0>;
> > +#interrupt-cells = <1>;
> > +#size-cells = <2>;
> > +#address-cells = <3>;
> > +device_type = "pci";
> > +interrupts = <16 2 0 0>;
> > +interrupt-map-mask = <0xf800 0 0 7>;
> > +
> > +interrupt-map = <
> > +/* IDSEL 0x0 */
> > +0000 0x0 0x0 0x1 &mpic 0x0 0x2 0x0 0x0
> > +0000 0x0 0x0 0x2 &mpic 0x1 0x2 0x0 0x0
> > +0000 0x0 0x0 0x3 &mpic 0x2 0x2 0x0 0x0
> > +0000 0x0 0x0 0x4 &mpic 0x3 0x2 0x0 0x0
> > +>;
> > +};
> > +};
> > +
> > &soc {
> > #address-cells = <1>;
> > #size-cells = <1>;
> > diff --git a/arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi
> > b/arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi
> > index 301a9db..90f7949 100644
> > --- a/arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi
> > +++ b/arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi
> > @@ -45,6 +45,7 @@
> > serial0 = &serial0;
> > ethernet0 = &enet0;
> > ethernet1 = &enet1;
> > +pci0 = &pci0;
> > };
> >
> > cpus {
> > --
> > 2.1.0.27.g96db324
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V4 1/2] powerpc/fsl: Add PCI node in device tree of bsc9132qds
[not found] ` <HE1PR04MB09060D4FCE88CD7B3F1CBF9084D90-6LN7OEpIatWBkn9woE/rDM9NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
@ 2016-01-27 14:23 ` Scott Wood
2016-01-29 11:26 ` Zhiqiang Hou
0 siblings, 1 reply; 9+ messages in thread
From: Scott Wood @ 2016-01-27 14:23 UTC (permalink / raw)
To: Zhiqiang Hou, Zhiqiang Hou,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org,
benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org,
paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org,
mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
Harninder Rai, robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: Lian M.H., Hu Vincent, Hou Zhiqiang
On Wed, 2016-01-27 at 06:47 +0000, Zhiqiang Hou wrote:
> Hi Herring and Kumar and Ian,
>
> Can you help to apply this patch?
>
> Thanks,
> Zhiqiang
Can you check whether a patch has already been applied before pinging people
about it?
-Scott
>
> > -----Original Message-----
> > From: Zhiqiang Hou [mailto:zhiqiang.hou-3arQi8VN3Tc@public.gmane.org]
> > Sent: 2015年12月22日 17:28
> > To: Zhiqiang Hou <Zhiqiang.Hou-KZfg59tc24xl57MIdRCFDg@public.gmane.org>;
> > linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org;
> > Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org>; galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org;
> > benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org; paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org; mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org;
> > devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; pawel.moll-5wv7dgnIgG8@public.gmane.org;
> > mark.rutland-5wv7dgnIgG8@public.gmane.org; ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org; Harninder Rai
> > <harninder.rai-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > Cc: Lian M.H. <Minghuan.Lian-KZfg59tc24xl57MIdRCFDg@public.gmane.org>; Hu Vincent
> > <Mingkai.Hu-KZfg59tc24xl57MIdRCFDg@public.gmane.org>; Hou Zhiqiang <B48286-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > Subject: RE: [PATCH V4 1/2] powerpc/fsl: Add PCI node in device tree of
> > bsc9132qds
> >
> > Hi Rob,
> >
> > Could you please take this patch into account?
> >
> > Thanks,
> > Zhiqiang
> >
> > > -----Original Message-----
> > > From: Zhiqiang Hou [mailto:Zhiqiang.Hou-KZfg59tc24xl57MIdRCFDg@public.gmane.org]
> > > Sent: 2015年11月5日 11:16
> > > To: linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; Scott Wood;
> > > galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org; benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org; paulus@samba.org;
> > > mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org; devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; robh+dt-DgEjT+Ai2yhQFI55V6+gNQ@public.gmane.orgg;
> > > pawel.moll-5wv7dgnIgG8@public.gmane.org; mark.rutland-5wv7dgnIgG8@public.gmane.org;
> > > ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org; Harninder Rai
> > > Cc: Minghuan Lian; Mingkai Hu; Zhiqiang Hou
> > > Subject: [PATCH V4 1/2] powerpc/fsl: Add PCI node in device tree of
> > > bsc9132qds
> > >
> > > From: Harninder Rai <harninder.rai-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > >
> > > Signed-off-by: Harninder Rai <harninder.rai-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > > Signed-off-by: Minghuan Lian <Minghuan.Lian-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > > Signed-off-by: Hou Zhiqiang <B48286-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > > ---
> > > V4: V3:
> > > - Remove gerrit stuff.
> > > V2:
> > > - Remove property clock-frequency.
> > >
> > > arch/powerpc/boot/dts/bsc9132qds.dts | 15 ++++++++++++++
> > > arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi | 28
> > > +++++++++++++++++++++++++++
> > > +++++++++++++++++++++++++++ arch/powerpc/boot/dts/fsl/bsc9132si-pre.dt
> > > +++++++++++++++++++++++++++ si
> > > > 1 +
> > > 3 files changed, 44 insertions(+)
> > >
> > > diff --git a/arch/powerpc/boot/dts/bsc9132qds.dts
> > > b/arch/powerpc/boot/dts/bsc9132qds.dts
> > > index 6cab106..940d719 100644
> > > --- a/arch/powerpc/boot/dts/bsc9132qds.dts
> > > +++ b/arch/powerpc/boot/dts/bsc9132qds.dts
> > > @@ -29,6 +29,21 @@
> > > soc: soc@ff700000 {
> > > ranges = <0x0 0x0 0xff700000 0x100000>; };
> > > +
> > > +pci0: pcie@ff70a000 {
> > > +reg = <0 0xff70a000 0 0x1000>;
> > > +ranges = <0x2000000 0x0 0x90000000 0 0x90000000 0x0
> > > 0x20000000
> > > + 0x1000000 0x0 0x00000000 0 0xc0010000 0x0 0x10000>;
> > > +pcie@0 {
> > > +ranges = <0x2000000 0x0 0x90000000
> > > + 0x2000000 0x0 0x90000000
> > > + 0x0 0x20000000
> > > +
> > > + 0x1000000 0x0 0x0
> > > + 0x1000000 0x0 0x0
> > > + 0x0 0x100000>;
> > > +};
> > > +};
> > > };
> > >
> > > /include/ "bsc9132qds.dtsi"
> > > diff --git a/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
> > > b/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
> > > index c723071..b5f0715 100644
> > > --- a/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
> > > +++ b/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
> > > @@ -40,6 +40,34 @@
> > > interrupts = <16 2 0 0 20 2 0 0>;
> > > };
> > >
> > > +/* controller at 0xa000 */
> > > +&pci0 {
> > > +compatible = "fsl,bsc9132-pcie", "fsl,qoriq-pcie-v2.2"; device_type =
> > > +"pci"; #size-cells = <2>; #address-cells = <3>; bus-range = <0 255>;
> > > +interrupts = <16 2 0 0>;
> > > +
> > > +pcie@0 {
> > > +reg = <0 0 0 0 0>;
> > > +#interrupt-cells = <1>;
> > > +#size-cells = <2>;
> > > +#address-cells = <3>;
> > > +device_type = "pci";
> > > +interrupts = <16 2 0 0>;
> > > +interrupt-map-mask = <0xf800 0 0 7>;
> > > +
> > > +interrupt-map = <
> > > +/* IDSEL 0x0 */
> > > +0000 0x0 0x0 0x1 &mpic 0x0 0x2 0x0 0x0
> > > +0000 0x0 0x0 0x2 &mpic 0x1 0x2 0x0 0x0
> > > +0000 0x0 0x0 0x3 &mpic 0x2 0x2 0x0 0x0
> > > +0000 0x0 0x0 0x4 &mpic 0x3 0x2 0x0 0x0
> > > +>;
> > > +};
> > > +};
> > > +
> > > &soc {
> > > #address-cells = <1>;
> > > #size-cells = <1>;
> > > diff --git a/arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi
> > > b/arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi
> > > index 301a9db..90f7949 100644
> > > --- a/arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi
> > > +++ b/arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi
> > > @@ -45,6 +45,7 @@
> > > serial0 = &serial0;
> > > ethernet0 = &enet0;
> > > ethernet1 = &enet1;
> > > +pci0 = &pci0;
> > > };
> > >
> > > cpus {
> > > --
> > > 2.1.0.27.g96db324
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH V4 1/2] powerpc/fsl: Add PCI node in device tree of bsc9132qds
2016-01-27 14:23 ` Scott Wood
@ 2016-01-29 11:26 ` Zhiqiang Hou
0 siblings, 0 replies; 9+ messages in thread
From: Zhiqiang Hou @ 2016-01-29 11:26 UTC (permalink / raw)
To: Scott Wood, Zhiqiang Hou, linuxppc-dev@lists.ozlabs.org,
galak@kernel.crashing.org, benh@kernel.crashing.org,
paulus@samba.org, mpe@ellerman.id.au, devicetree@vger.kernel.org,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, Harninder Rai, robh@kernel.org
Cc: Lian M.H., Hu Vincent, Hou Zhiqiang
> -----Original Message-----
> From: Scott Wood [mailto:oss@buserror.net]
> Sent: 2016年1月27日 22:24
> To: Zhiqiang Hou <zhiqiang.hou@nxp.com>; Zhiqiang Hou
> <Zhiqiang.Hou@freescale.com>; linuxppc-dev@lists.ozlabs.org;
> galak@kernel.crashing.org; benh@kernel.crashing.org; paulus@samba.org;
> mpe@ellerman.id.au; devicetree@vger.kernel.org; robh+dt@kernel.org;
> pawel.moll@arm.com; mark.rutland@arm.com; ijc+devicetree@hellion.org.uk;
> Harninder Rai <harninder.rai@freescale.com>; robh@kernel.org
> Cc: Lian M.H. <Minghuan.Lian@freescale.com>; Hu Vincent
> <Mingkai.Hu@freescale.com>; Hou Zhiqiang <B48286@freescale.com>
> Subject: Re: [PATCH V4 1/2] powerpc/fsl: Add PCI node in device tree of
> bsc9132qds
>
> On Wed, 2016-01-27 at 06:47 +0000, Zhiqiang Hou wrote:
> > Hi Herring and Kumar and Ian,
> >
> > Can you help to apply this patch?
> >
> > Thanks,
> > Zhiqiang
>
> Can you check whether a patch has already been applied before pinging people
> about it?
>
Sorry, I only checked the state of this patchset on web.
Thanks,
Zhiqiang
>
> >
> > > -----Original Message-----
> > > From: Zhiqiang Hou [mailto:zhiqiang.hou@nxp.com]
> > > Sent: 2015年12月22日 17:28
> > > To: Zhiqiang Hou <Zhiqiang.Hou@freescale.com>;
> > > linuxppc-dev@lists.ozlabs.org; Scott Wood <scottwood@freescale.com>;
> > > galak@kernel.crashing.org; benh@kernel.crashing.org;
> > > paulus@samba.org; mpe@ellerman.id.au; devicetree@vger.kernel.org;
> > > robh+dt@kernel.org; pawel.moll@arm.com; mark.rutland@arm.com;
> > > ijc+devicetree@hellion.org.uk; Harninder Rai
> > > <harninder.rai@freescale.com>
> > > Cc: Lian M.H. <Minghuan.Lian@freescale.com>; Hu Vincent
> > > <Mingkai.Hu@freescale.com>; Hou Zhiqiang <B48286@freescale.com>
> > > Subject: RE: [PATCH V4 1/2] powerpc/fsl: Add PCI node in device tree
> > > of bsc9132qds
> > >
> > > Hi Rob,
> > >
> > > Could you please take this patch into account?
> > >
> > > Thanks,
> > > Zhiqiang
> > >
> > > > -----Original Message-----
> > > > From: Zhiqiang Hou [mailto:Zhiqiang.Hou@freescale.com]
> > > > Sent: 2015年11月5日 11:16
> > > > To: linuxppc-dev@lists.ozlabs.org; Scott Wood;
> > > > galak@kernel.crashing.org; benh@kernel.crashing.org;
> > > > paulus@samba.org; mpe@ellerman.id.au; devicetree@vger.kernel.org;
> > > > robh+dt@kernel.org; pawel.moll@arm.com; mark.rutland@arm.com;
> > > > ijc+devicetree@hellion.org.uk; Harninder Rai
> > > > Cc: Minghuan Lian; Mingkai Hu; Zhiqiang Hou
> > > > Subject: [PATCH V4 1/2] powerpc/fsl: Add PCI node in device tree
> > > > of bsc9132qds
> > > >
> > > > From: Harninder Rai <harninder.rai@freescale.com>
> > > >
> > > > Signed-off-by: Harninder Rai <harninder.rai@freescale.com>
> > > > Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
> > > > Signed-off-by: Hou Zhiqiang <B48286@freescale.com>
> > > > ---
> > > > V4: V3:
> > > > - Remove gerrit stuff.
> > > > V2:
> > > > - Remove property clock-frequency.
> > > >
> > > > arch/powerpc/boot/dts/bsc9132qds.dts | 15 ++++++++++++++
> > > > arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi | 28
> > > > +++++++++++++++++++++++++++
> > > > +++++++++++++++++++++++++++ arch/powerpc/boot/dts/fsl/bsc9132si-pr
> > > > +++++++++++++++++++++++++++ e.dt
> > > > +++++++++++++++++++++++++++ si
> > > > > 1 +
> > > > 3 files changed, 44 insertions(+)
> > > >
> > > > diff --git a/arch/powerpc/boot/dts/bsc9132qds.dts
> > > > b/arch/powerpc/boot/dts/bsc9132qds.dts
> > > > index 6cab106..940d719 100644
> > > > --- a/arch/powerpc/boot/dts/bsc9132qds.dts
> > > > +++ b/arch/powerpc/boot/dts/bsc9132qds.dts
> > > > @@ -29,6 +29,21 @@
> > > > soc: soc@ff700000 {
> > > > ranges = <0x0 0x0 0xff700000 0x100000>; };
> > > > +
> > > > +pci0: pcie@ff70a000 {
> > > > +reg = <0 0xff70a000 0 0x1000>;
> > > > +ranges = <0x2000000 0x0 0x90000000 0 0x90000000 0x0
> > > > 0x20000000
> > > > + 0x1000000 0x0 0x00000000 0 0xc0010000 0x0 0x10000>;
> > > > +pcie@0 {
> > > > +ranges = <0x2000000 0x0 0x90000000
> > > > + 0x2000000 0x0 0x90000000
> > > > + 0x0 0x20000000
> > > > +
> > > > + 0x1000000 0x0 0x0
> > > > + 0x1000000 0x0 0x0
> > > > + 0x0 0x100000>;
> > > > +};
> > > > +};
> > > > };
> > > >
> > > > /include/ "bsc9132qds.dtsi"
> > > > diff --git a/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
> > > > b/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
> > > > index c723071..b5f0715 100644
> > > > --- a/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
> > > > +++ b/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
> > > > @@ -40,6 +40,34 @@
> > > > interrupts = <16 2 0 0 20 2 0 0>; };
> > > >
> > > > +/* controller at 0xa000 */
> > > > +&pci0 {
> > > > +compatible = "fsl,bsc9132-pcie", "fsl,qoriq-pcie-v2.2";
> > > > +device_type = "pci"; #size-cells = <2>; #address-cells = <3>;
> > > > +bus-range = <0 255>; interrupts = <16 2 0 0>;
> > > > +
> > > > +pcie@0 {
> > > > +reg = <0 0 0 0 0>;
> > > > +#interrupt-cells = <1>;
> > > > +#size-cells = <2>;
> > > > +#address-cells = <3>;
> > > > +device_type = "pci";
> > > > +interrupts = <16 2 0 0>;
> > > > +interrupt-map-mask = <0xf800 0 0 7>;
> > > > +
> > > > +interrupt-map = <
> > > > +/* IDSEL 0x0 */
> > > > +0000 0x0 0x0 0x1 &mpic 0x0 0x2 0x0 0x0
> > > > +0000 0x0 0x0 0x2 &mpic 0x1 0x2 0x0 0x0
> > > > +0000 0x0 0x0 0x3 &mpic 0x2 0x2 0x0 0x0
> > > > +0000 0x0 0x0 0x4 &mpic 0x3 0x2 0x0 0x0
> > > > +>;
> > > > +};
> > > > +};
> > > > +
> > > > &soc {
> > > > #address-cells = <1>;
> > > > #size-cells = <1>;
> > > > diff --git a/arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi
> > > > b/arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi
> > > > index 301a9db..90f7949 100644
> > > > --- a/arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi
> > > > +++ b/arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi
> > > > @@ -45,6 +45,7 @@
> > > > serial0 = &serial0;
> > > > ethernet0 = &enet0;
> > > > ethernet1 = &enet1;
> > > > +pci0 = &pci0;
> > > > };
> > > >
> > > > cpus {
> > > > --
> > > > 2.1.0.27.g96db324
> >
> > _______________________________________________
> > Linuxppc-dev mailing list
> > Linuxppc-dev@lists.ozlabs.org
> > https://lists.ozlabs.org/listinfo/linuxppc-dev
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-01-29 11:26 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-05 3:15 [PATCH V4 1/2] powerpc/fsl: Add PCI node in device tree of bsc9132qds Zhiqiang Hou
[not found] ` <1446693360-1578-1-git-send-email-Zhiqiang.Hou-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-11-05 3:16 ` [PATCH V4 2/2] powerpc/85xx: Add PCIe controller support for bsc9132qds Zhiqiang Hou
2015-11-17 2:31 ` Hou Zhiqiang
[not found] ` <CY1PR0301MB07806A3A31D76967125054C28B1D0-YrwGdl+PljnwWZenWrSUgZwN6zqB+hSMnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2015-11-20 3:02 ` Scott Wood
2015-12-22 9:21 ` Zhiqiang Hou
2015-12-22 9:28 ` [PATCH V4 1/2] powerpc/fsl: Add PCI node in device tree of bsc9132qds Zhiqiang Hou
2016-01-27 6:47 ` Zhiqiang Hou
[not found] ` <HE1PR04MB09060D4FCE88CD7B3F1CBF9084D90-6LN7OEpIatWBkn9woE/rDM9NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-01-27 14:23 ` Scott Wood
2016-01-29 11:26 ` Zhiqiang Hou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).