devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: cros-ec-keyboard: Add LOCK key to keyboard matrix
@ 2016-01-30  2:38 Daniel Kurtz
  2016-02-01 17:16 ` Heiko Stübner
       [not found] ` <1454121504-12683-1-git-send-email-djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
  0 siblings, 2 replies; 6+ messages in thread
From: Daniel Kurtz @ 2016-01-30  2:38 UTC (permalink / raw)
  Cc: Mark Rutland,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	YH Huang, Russell King, Pawel Moll, Ian Campbell, James Chao,
	dianders-F7+t8E8rja9g9hUCZPvPmw, open list, Rob Herring,
	moderated list:ARM/Mediatek SoC support, Kumar Gala,
	Matthias Brugger, moderated list:ARM PORT

From: James Chao <james_chao-4gYQFoH7KfQ@public.gmane.org>

The LOCK key is at KSO9/KSI3 for Chromebook Flip and other devices
that use the Chrome OS EC keyboard matrix.

Signed-off-by: James Chao <james_chao-4gYQFoH7KfQ@public.gmane.org>
Signed-off-by: Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Signed-off-by: YH Huang <yh.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
 arch/arm/boot/dts/cros-ec-keyboard.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/cros-ec-keyboard.dtsi b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
index 4e42f30c..c045105 100644
--- a/arch/arm/boot/dts/cros-ec-keyboard.dtsi
+++ b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
@@ -55,6 +55,7 @@
 			MATRIX_KEY(0x03, 0x04, KEY_F5)
 			MATRIX_KEY(0x03, 0x06, KEY_6)
 			MATRIX_KEY(0x03, 0x08, KEY_MINUS)
+			MATRIX_KEY(0x03, 0x09, KEY_F13)
 			MATRIX_KEY(0x03, 0x0b, KEY_BACKSLASH)
 			MATRIX_KEY(0x03, 0x0c, KEY_MUHENKAN)
 
-- 
2.7.0.rc3.207.g0ac5344

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: dts: cros-ec-keyboard: Add LOCK key to keyboard matrix
  2016-01-30  2:38 [PATCH] ARM: dts: cros-ec-keyboard: Add LOCK key to keyboard matrix Daniel Kurtz
@ 2016-02-01 17:16 ` Heiko Stübner
  2016-02-01 23:59   ` Daniel Kurtz
  2016-02-02  0:52   ` Olof Johansson
       [not found] ` <1454121504-12683-1-git-send-email-djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
  1 sibling, 2 replies; 6+ messages in thread
From: Heiko Stübner @ 2016-02-01 17:16 UTC (permalink / raw)
  To: linux-arm-kernel, Daniel Kurtz, Olof Johansson
  Cc: Mark Rutland,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	YH Huang, Russell King, Pawel Moll, Ian Campbell, James Chao,
	dianders, open list, Rob Herring,
	moderated list:ARM/Mediatek SoC support, Kumar Gala,
	Matthias Brugger

Hi Daniel,

Am Samstag, 30. Januar 2016, 10:38:24 schrieb Daniel Kurtz:
> From: James Chao <james_chao@asus.com>
> 
> The LOCK key is at KSO9/KSI3 for Chromebook Flip and other devices
> that use the Chrome OS EC keyboard matrix.
> 
> Signed-off-by: James Chao <james_chao@asus.com>
> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
> Signed-off-by: YH Huang <yh.huang@mediatek.com>

that should probably be a 
	Reviewed-by: YH Huang <yh.huang@mediatek.com>
As I don't see any actual patch handling step by him/her.

Also, you might've included Olof as the keeper of all things ChromeOS when 
sending.

@Olof: this seems to be pretty Veyron-specific for the moment, so I'm inclined 
to pick that up. Please holler if you disagree and want to pick it up yourself 
;-)


Thanks
Heiko

> ---
>  arch/arm/boot/dts/cros-ec-keyboard.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/cros-ec-keyboard.dtsi
> b/arch/arm/boot/dts/cros-ec-keyboard.dtsi index 4e42f30c..c045105 100644
> --- a/arch/arm/boot/dts/cros-ec-keyboard.dtsi
> +++ b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
> @@ -55,6 +55,7 @@
>  			MATRIX_KEY(0x03, 0x04, KEY_F5)
>  			MATRIX_KEY(0x03, 0x06, KEY_6)
>  			MATRIX_KEY(0x03, 0x08, KEY_MINUS)
> +			MATRIX_KEY(0x03, 0x09, KEY_F13)
>  			MATRIX_KEY(0x03, 0x0b, KEY_BACKSLASH)
>  			MATRIX_KEY(0x03, 0x0c, KEY_MUHENKAN)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: dts: cros-ec-keyboard: Add LOCK key to keyboard matrix
       [not found] ` <1454121504-12683-1-git-send-email-djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
@ 2016-02-01 17:19   ` Doug Anderson
  2016-02-11 12:53   ` Heiko Stuebner
  1 sibling, 0 replies; 6+ messages in thread
From: Doug Anderson @ 2016-02-01 17:19 UTC (permalink / raw)
  To: Daniel Kurtz
  Cc: James Chao, YH Huang, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, Russell King, Matthias Brugger,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	moderated list:ARM PORT, open list,
	moderated list:ARM/Mediatek SoC support, Heiko Stübner,
	Olof Johansson

Dan,

On Fri, Jan 29, 2016 at 6:38 PM, Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> wrote:
> From: James Chao <james_chao-4gYQFoH7KfQ@public.gmane.org>
>
> The LOCK key is at KSO9/KSI3 for Chromebook Flip and other devices
> that use the Chrome OS EC keyboard matrix.
>
> Signed-off-by: James Chao <james_chao-4gYQFoH7KfQ@public.gmane.org>
> Signed-off-by: Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Signed-off-by: YH Huang <yh.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> ---
>  arch/arm/boot/dts/cros-ec-keyboard.dtsi | 1 +
>  1 file changed, 1 insertion(+)

Feel free to add:

Reviewed-by: Douglas Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: dts: cros-ec-keyboard: Add LOCK key to keyboard matrix
  2016-02-01 17:16 ` Heiko Stübner
@ 2016-02-01 23:59   ` Daniel Kurtz
  2016-02-02  0:52   ` Olof Johansson
  1 sibling, 0 replies; 6+ messages in thread
From: Daniel Kurtz @ 2016-02-01 23:59 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: Matthias Brugger, Russell King, Rob Herring, Ian Campbell,
	Pawel Moll, Kumar Gala, moderated list:ARM/Mediatek SoC support,
	open list:OPEN FIRMWARE AND..., YH Huang, Mark Rutland,
	James Chao, Doug Anderson, Olof Johansson, open list,
	linux-arm-kernel

[-- Attachment #1: Type: text/plain, Size: 1887 bytes --]

On Feb 2, 2016 01:17, "Heiko Stübner" <heiko@sntech.de> wrote:
>
> Hi Daniel,
>
> Am Samstag, 30. Januar 2016, 10:38:24 schrieb Daniel Kurtz:
> > From: James Chao <james_chao@asus.com>
> >
> > The LOCK key is at KSO9/KSI3 for Chromebook Flip and other devices
> > that use the Chrome OS EC keyboard matrix.
> >
> > Signed-off-by: James Chao <james_chao@asus.com>
> > Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
> > Signed-off-by: YH Huang <yh.huang@mediatek.com>
>
> that should probably be a
>         Reviewed-by: YH Huang <yh.huang@mediatek.com>
> As I don't see any actual patch handling step by him/her.

YH independently uploaded an identical patch to a different ChromeOS kernel
version (v3.18) with his SOB to support a different device.
I wasn't sure how to deal with it, so I merged the SOB lists when posting
upstream.

> Also, you might've included Olof as the keeper of all things ChromeOS when
> sending.
>
> @Olof: this seems to be pretty Veyron-specific for the moment, so I'm
inclined
> to pick that up. Please holler if you disagree and want to pick it up
yourself
> ;-)
>
>
> Thanks
> Heiko
>
> > ---
> >  arch/arm/boot/dts/cros-ec-keyboard.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/boot/dts/cros-ec-keyboard.dtsi
> > b/arch/arm/boot/dts/cros-ec-keyboard.dtsi index 4e42f30c..c045105 100644
> > --- a/arch/arm/boot/dts/cros-ec-keyboard.dtsi
> > +++ b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
> > @@ -55,6 +55,7 @@
> >                       MATRIX_KEY(0x03, 0x04, KEY_F5)
> >                       MATRIX_KEY(0x03, 0x06, KEY_6)
> >                       MATRIX_KEY(0x03, 0x08, KEY_MINUS)
> > +                     MATRIX_KEY(0x03, 0x09, KEY_F13)
> >                       MATRIX_KEY(0x03, 0x0b, KEY_BACKSLASH)
> >                       MATRIX_KEY(0x03, 0x0c, KEY_MUHENKAN)
>

[-- Attachment #2: Type: text/html, Size: 2698 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: dts: cros-ec-keyboard: Add LOCK key to keyboard matrix
  2016-02-01 17:16 ` Heiko Stübner
  2016-02-01 23:59   ` Daniel Kurtz
@ 2016-02-02  0:52   ` Olof Johansson
  1 sibling, 0 replies; 6+ messages in thread
From: Olof Johansson @ 2016-02-02  0:52 UTC (permalink / raw)
  To: Heiko Stübner
  Cc: linux-arm-kernel@lists.infradead.org, Daniel Kurtz, Mark Rutland,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	YH Huang, Russell King, Pawel Moll, Ian Campbell, James Chao,
	Doug Anderson, open list, Rob Herring,
	moderated list:ARM/Mediatek SoC support, Kumar Gala,
	Matthias Brugger

On Mon, Feb 1, 2016 at 9:16 AM, Heiko Stübner <heiko@sntech.de> wrote:
> Hi Daniel,
>
> Am Samstag, 30. Januar 2016, 10:38:24 schrieb Daniel Kurtz:
>> From: James Chao <james_chao@asus.com>
>>
>> The LOCK key is at KSO9/KSI3 for Chromebook Flip and other devices
>> that use the Chrome OS EC keyboard matrix.
>>
>> Signed-off-by: James Chao <james_chao@asus.com>
>> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
>> Signed-off-by: YH Huang <yh.huang@mediatek.com>
>
> that should probably be a
>         Reviewed-by: YH Huang <yh.huang@mediatek.com>
> As I don't see any actual patch handling step by him/her.
>
> Also, you might've included Olof as the keeper of all things ChromeOS when
> sending.
>
> @Olof: this seems to be pretty Veyron-specific for the moment, so I'm inclined
> to pick that up. Please holler if you disagree and want to pick it up yourself
> ;-)

Go ahead, we can take it as a fix for 4.5 at this time if you want.


-Olof

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: dts: cros-ec-keyboard: Add LOCK key to keyboard matrix
       [not found] ` <1454121504-12683-1-git-send-email-djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
  2016-02-01 17:19   ` Doug Anderson
@ 2016-02-11 12:53   ` Heiko Stuebner
  1 sibling, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2016-02-11 12:53 UTC (permalink / raw)
  To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
  Cc: Daniel Kurtz, Mark Rutland,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	YH Huang, Russell King, Pawel Moll, Ian Campbell, James Chao,
	dianders-F7+t8E8rja9g9hUCZPvPmw, open list, Rob Herring,
	moderated list:ARM/Mediatek SoC support, Kumar Gala,
	Matthias Brugger

Am Samstag, 30. Januar 2016, 10:38:24 schrieb Daniel Kurtz:
> From: James Chao <james_chao-4gYQFoH7KfQ@public.gmane.org>
> 
> The LOCK key is at KSO9/KSI3 for Chromebook Flip and other devices
> that use the Chrome OS EC keyboard matrix.
> 
> Signed-off-by: James Chao <james_chao-4gYQFoH7KfQ@public.gmane.org>
> Signed-off-by: Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Signed-off-by: YH Huang <yh.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>

applied to my dts32 branch for 4.6
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-02-11 12:53 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-30  2:38 [PATCH] ARM: dts: cros-ec-keyboard: Add LOCK key to keyboard matrix Daniel Kurtz
2016-02-01 17:16 ` Heiko Stübner
2016-02-01 23:59   ` Daniel Kurtz
2016-02-02  0:52   ` Olof Johansson
     [not found] ` <1454121504-12683-1-git-send-email-djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-02-01 17:19   ` Doug Anderson
2016-02-11 12:53   ` Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).