* [PATCH 1/2] dt/bindings: Add bindings for the PIC32 SPI peripheral @ 2016-02-01 22:44 Joshua Henderson 2016-02-02 11:11 ` Sergei Shtylyov 0 siblings, 1 reply; 5+ messages in thread From: Joshua Henderson @ 2016-02-01 22:44 UTC (permalink / raw) To: linux-kernel-u79uwXL29TY76Z2rM5mHXA Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA, Purna Chandra Mandal, Joshua Henderson, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, devicetree-u79uwXL29TY76Z2rM5mHXA From: Purna Chandra Mandal <purna.mandal-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org> Document the devicetree bindings for the SPI peripheral found on Microchip PIC32 class devices. Signed-off-by: Purna Chandra Mandal <purna.mandal-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org> Signed-off-by: Joshua Henderson <joshua.henderson-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org> --- .../bindings/spi/microchip,spi-pic32.txt | 44 ++++++++++++++++++++ 1 file changed, 44 insertions(+) create mode 100644 Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt diff --git a/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt b/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt new file mode 100644 index 0000000..a555618 --- /dev/null +++ b/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt @@ -0,0 +1,44 @@ +* Microchip PIC32 SPI device + +Required properties: +- compatible: Should be "microchip,pic32mzda-spi". +- reg: Address and length of the register set for the device +- interrupts: Should contain all three spi interrupts in sequence + of <fault-irq>, <receive-irq>, <transmit-irq>. +- interrupt-names: Should be "fault","rx","tx" in order. +- clocks: phandles of baud generation clocks. Maximum two possible clocks + can be provided (&PBCLK2, &REFCLKO1). + See: Documentation/devicetree/bindings/clock/clock-bindings.txt +- clock-names: Should be "mck0","mck1". + See: Documentation/devicetree/bindings/resource-names.txt +- pinctrl-names: A pinctrl state names "default" must be defined. +- pinctrl-0: Phandle referencing pin configuration of the SPI peripheral. + See: Documentation/devicetree/bindings/pinctrl/pinctrl-binding.txt + +Optional properties: +- cs-gpios: List of GPIO chip selects. See ../spi/spi-bus.txt + See: Documentation/devicetree/bindings/spi/spi-bus.txt +- dmas: Two or more DMA channel specifiers following the convention outlined + in Documentation/devicetree/bindings/dma/dma.txt +- dma-names: Names for the dma channels. There must be at least one channel + named "spi-tx" for transmit and named "spi-rx" for receive. + +Example: + + spi1:spi@0x1f821000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "microchip,pic32mzda-spi"; + reg = <0x1f821000 0x200>; + interrupts = <109 IRQ_TYPE_LEVEL_HIGH>, + <110 IRQ_TYPE_LEVEL_HIGH>, + <111 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "fault", "rx", "tx"; + clocks = <&PBCLK2>, <&REFCLKO1>; + clock-names = "mck0", "mck1"; + dmas = <&dma 134>, + <&dma 135>; + dma-names = "spi-rx", "spi-tx"; + cs-gpios = <&gpio3 0 GPIO_ACTIVE_LOW>, + <&gpio3 14 GPIO_ACTIVE_LOW>; + }; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt/bindings: Add bindings for the PIC32 SPI peripheral 2016-02-01 22:44 [PATCH 1/2] dt/bindings: Add bindings for the PIC32 SPI peripheral Joshua Henderson @ 2016-02-02 11:11 ` Sergei Shtylyov [not found] ` <56B08EEB.3050808-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Sergei Shtylyov @ 2016-02-02 11:11 UTC (permalink / raw) To: Joshua Henderson, linux-kernel Cc: linux-mips, Purna Chandra Mandal, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, devicetree Hello. On 2/2/2016 1:44 AM, Joshua Henderson wrote: > From: Purna Chandra Mandal <purna.mandal@microchip.com> > > Document the devicetree bindings for the SPI peripheral found > on Microchip PIC32 class devices. > > Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com> > Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com> > --- > .../bindings/spi/microchip,spi-pic32.txt | 44 ++++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt > > diff --git a/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt b/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt > new file mode 100644 > index 0000000..a555618 > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt > @@ -0,0 +1,44 @@ > +* Microchip PIC32 SPI device > + > +Required properties: > +- compatible: Should be "microchip,pic32mzda-spi". > +- reg: Address and length of the register set for the device > +- interrupts: Should contain all three spi interrupts in sequence > + of <fault-irq>, <receive-irq>, <transmit-irq>. > +- interrupt-names: Should be "fault","rx","tx" in order. Please insert spaces after commas. > +- clocks: phandles of baud generation clocks. Maximum two possible clocks Baud in the SPI context? > + can be provided (&PBCLK2, &REFCLKO1). Please align. > + See: Documentation/devicetree/bindings/clock/clock-bindings.txt > +- clock-names: Should be "mck0","mck1". Please insert space after comma. [...] > +Example: > + > + spi1:spi@0x1f821000 { Please insert spaces after colon. [...] MBR, Sergei ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <56B08EEB.3050808-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>]
* Re: [PATCH 1/2] dt/bindings: Add bindings for the PIC32 SPI peripheral [not found] ` <56B08EEB.3050808-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> @ 2016-02-05 5:08 ` Purna Chandra Mandal [not found] ` <56B42E4C.8040201-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Purna Chandra Mandal @ 2016-02-05 5:08 UTC (permalink / raw) To: Sergei Shtylyov, Joshua Henderson, linux-kernel-u79uwXL29TY76Z2rM5mHXA Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, devicetree-u79uwXL29TY76Z2rM5mHXA On 02/02/2016 04:41 PM, Sergei Shtylyov wrote: > Hello. > On 2/2/2016 1:44 AM, Joshua Henderson wrote: >> From: Purna Chandra Mandal <purna.mandal-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org> >> Document the devicetree bindings for the SPI peripheral found >> on Microchip PIC32 class devices. >> Signed-off-by: Purna Chandra Mandal <purna.mandal-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org> >> Signed-off-by: Joshua Henderson <joshua.henderson-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org> >> --- >> .../bindings/spi/microchip,spi-pic32.txt | 44 ++++++++++++++++++++ >> 1 file changed, 44 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt >> diff --git a/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt b/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt >> new file mode 100644 >> index 0000000..a555618 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt >> @@ -0,0 +1,44 @@ >> +* Microchip PIC32 SPI device >> + >> +Required properties: >> +- compatible: Should be "microchip,pic32mzda-spi". >> +- reg: Address and length of the register set for the device >> +- interrupts: Should contain all three spi interrupts in sequence >> + of <fault-irq>, <receive-irq>, <transmit-irq>. >> +- interrupt-names: Should be "fault","rx","tx" in order. >> > Please insert spaces after commas. ack. >> +- clocks: phandles of baud generation clocks. Maximum two possible clocks >> > Baud in the SPI context? Yes, clock for generating spi clock (SCK). Will update the comment. >> + can be provided (&PBCLK2, &REFCLKO1). >> > Please align. ack. >> + See: Documentation/devicetree/bindings/clock/clock-bindings.txt >> +- clock-names: Should be "mck0","mck1". >> > Please insert space after comma. ack. > [...] >> +Example: >> + >> + spi1:spi@0x1f821000 { > Please insert spaces after colon. ack > [...] > MBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <56B42E4C.8040201-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>]
* Re: [PATCH 1/2] dt/bindings: Add bindings for the PIC32 SPI peripheral [not found] ` <56B42E4C.8040201-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org> @ 2016-02-05 13:32 ` Sergei Shtylyov [not found] ` <56B4A457.7050807-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Sergei Shtylyov @ 2016-02-05 13:32 UTC (permalink / raw) To: Purna Chandra Mandal, Joshua Henderson, linux-kernel-u79uwXL29TY76Z2rM5mHXA Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, devicetree-u79uwXL29TY76Z2rM5mHXA Hello. On 2/5/2016 8:08 AM, Purna Chandra Mandal wrote: >>> From: Purna Chandra Mandal <purna.mandal-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org> >>> Document the devicetree bindings for the SPI peripheral found >>> on Microchip PIC32 class devices. >>> Signed-off-by: Purna Chandra Mandal <purna.mandal-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org> >>> Signed-off-by: Joshua Henderson <joshua.henderson-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org> >>> --- >>> .../bindings/spi/microchip,spi-pic32.txt | 44 ++++++++++++++++++++ >>> 1 file changed, 44 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt >>> diff --git a/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt b/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt >>> new file mode 100644 >>> index 0000000..a555618 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt >>> @@ -0,0 +1,44 @@ >>> +* Microchip PIC32 SPI device [...] >>> +Example: >>> + >>> + spi1:spi@0x1f821000 { >> Please insert spaces after colon. > ack And please drop "0x" from the <unit-address> part of the name. MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <56B4A457.7050807-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>]
* Re: [PATCH 1/2] dt/bindings: Add bindings for the PIC32 SPI peripheral [not found] ` <56B4A457.7050807-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> @ 2016-02-08 5:06 ` Purna Chandra Mandal 0 siblings, 0 replies; 5+ messages in thread From: Purna Chandra Mandal @ 2016-02-08 5:06 UTC (permalink / raw) To: Sergei Shtylyov Cc: Joshua Henderson, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-mips-6z/3iImG2C8G8FEW9MqTrA, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, devicetree-u79uwXL29TY76Z2rM5mHXA On 02/05/2016 07:02 PM, Sergei Shtylyov wrote: > Hello. > On 2/5/2016 8:08 AM, Purna Chandra Mandal wrote: >>>> From: Purna Chandra Mandal <purna.mandal-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org> >>>> Document the devicetree bindings for the SPI peripheral found >>>> on Microchip PIC32 class devices. >>>> Signed-off-by: Purna Chandra Mandal <purna.mandal-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org> >>>> Signed-off-by: Joshua Henderson <joshua.henderson-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org> >>>> --- >>>> .../bindings/spi/microchip,spi-pic32.txt | 44 ++++++++++++++++++++ >>>> 1 file changed, 44 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt >>>> diff --git >>>> a/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt >>>> b/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt >>>> new file mode 100644 >>>> index 0000000..a555618 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt >>>> @@ -0,0 +1,44 @@ >>>> +* Microchip PIC32 SPI device > [...] >>>> +Example: >>>> + >>>> + spi1:spi@0x1f821000 { >>> Please insert spaces after colon. >> ack >> > And please drop "0x" from the <unit-address> part of the name. ack. > MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-02-08 5:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-01 22:44 [PATCH 1/2] dt/bindings: Add bindings for the PIC32 SPI peripheral Joshua Henderson
2016-02-02 11:11 ` Sergei Shtylyov
[not found] ` <56B08EEB.3050808-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-02-05 5:08 ` Purna Chandra Mandal
[not found] ` <56B42E4C.8040201-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>
2016-02-05 13:32 ` Sergei Shtylyov
[not found] ` <56B4A457.7050807-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-02-08 5:06 ` Purna Chandra Mandal
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).