* [PATCH 2/2] dt-bindings: clock: add lpc32xx clock frequency output
@ 2016-02-09 18:47 slemieux.tyco
2016-02-10 0:06 ` Vladimir Zapolskiy
0 siblings, 1 reply; 3+ messages in thread
From: slemieux.tyco @ 2016-02-09 18:47 UTC (permalink / raw)
To: robh+dt, sboyd, mturquette; +Cc: stigge, vz, devicetree, linux-clk
From: Sylvain Lemieux <slemieux@tycoint.com>
This patch add an optional parameter to setup the
xtal clock frequency output.
Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
---
Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt b/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt
index 20cbca3..ce51759 100644
--- a/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt
+++ b/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt
@@ -10,6 +10,9 @@ Required properties:
- clock-names: list of external oscillator clock names, must contain
"xtal_32k" and may have optional "xtal"
+Optional properties:
+- xtal,clock-output-frequency: define the "xtal" clock frequency output in Hz
+
Examples:
/* System Control Block */
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] dt-bindings: clock: add lpc32xx clock frequency output
2016-02-09 18:47 [PATCH 2/2] dt-bindings: clock: add lpc32xx clock frequency output slemieux.tyco
@ 2016-02-10 0:06 ` Vladimir Zapolskiy
2016-02-10 17:21 ` Sylvain Lemieux
0 siblings, 1 reply; 3+ messages in thread
From: Vladimir Zapolskiy @ 2016-02-10 0:06 UTC (permalink / raw)
To: slemieux.tyco, robh+dt, sboyd, mturquette; +Cc: stigge, devicetree, linux-clk
Hi Sylvain,
On 09.02.2016 20:47, slemieux.tyco@gmail.com wrote:
> From: Sylvain Lemieux <slemieux@tycoint.com>
>
> This patch add an optional parameter to setup the
> xtal clock frequency output.
>
> Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
> ---
> Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt b/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt
> index 20cbca3..ce51759 100644
> --- a/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt
> +++ b/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt
> @@ -10,6 +10,9 @@ Required properties:
> - clock-names: list of external oscillator clock names, must contain
> "xtal_32k" and may have optional "xtal"
>
> +Optional properties:
> +- xtal,clock-output-frequency: define the "xtal" clock frequency output in Hz
> +
this one looks wrong in sense that from patch 1/2 the property configures
a PLL output clock rate, which is not an oscillator (xtal) clock rate.
I believe switching to "assigned-clock-rates" should make this change
obsolete.
> Examples:
>
> /* System Control Block */
>
--
With best wishes,
Vladimir
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] dt-bindings: clock: add lpc32xx clock frequency output
2016-02-10 0:06 ` Vladimir Zapolskiy
@ 2016-02-10 17:21 ` Sylvain Lemieux
0 siblings, 0 replies; 3+ messages in thread
From: Sylvain Lemieux @ 2016-02-10 17:21 UTC (permalink / raw)
To: Vladimir Zapolskiy
Cc: robh+dt, sboyd, mturquette, stigge, devicetree, linux-clk
On Wed, 2016-02-10 at 02:06 +0200, Vladimir Zapolskiy wrote:
> Hi Sylvain,
>
> On 09.02.2016 20:47, slemieux.tyco@gmail.com wrote:
> > From: Sylvain Lemieux <slemieux@tycoint.com>
> >
> > This patch add an optional parameter to setup the
> > xtal clock frequency output.
> >
> > Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
> > ---
> > Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt b/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt
> > index 20cbca3..ce51759 100644
> > --- a/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt
> > +++ b/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt
> > @@ -10,6 +10,9 @@ Required properties:
> > - clock-names: list of external oscillator clock names, must contain
> > "xtal_32k" and may have optional "xtal"
> >
> > +Optional properties:
> > +- xtal,clock-output-frequency: define the "xtal" clock frequency output in Hz
> > +
>
> this one looks wrong in sense that from patch 1/2 the property configures
> a PLL output clock rate, which is not an oscillator (xtal) clock rate.
>
> I believe switching to "assigned-clock-rates" should make this change
> obsolete.
>
Agreed, this change is not needed;
Sylvain
> > Examples:
> >
> > /* System Control Block */
> >
>
> --
> With best wishes,
> Vladimir
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-10 17:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-09 18:47 [PATCH 2/2] dt-bindings: clock: add lpc32xx clock frequency output slemieux.tyco
2016-02-10 0:06 ` Vladimir Zapolskiy
2016-02-10 17:21 ` Sylvain Lemieux
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).